| 8151c34b1055a20bfd4d5e60bcc2363dafe822c0 |
|
23-Oct-2015 |
Alex Vakulenko <avakulenko@google.com> |
shill: Use Any::IsTypeCompatible<T>() instead of type_info
Comparing type_info is unreliable on some implementations, so we
should use Any::IsTypeCompatible<T>() instead.
BUG: 25132472
Change-Id: I9f95b5d8aa42c1b8b6a57e589ea1b27db206842b
/system/connectivity/shill/fake_store.cc
|
| 03e6719bae1e0903d94853b896673a033196bcf5 |
|
13-Oct-2015 |
Alex Vakulenko <avakulenko@google.com> |
shill: Rename "chromeos" -> "brillo" in include paths and namespaces
libchromeos is transitioning to libbrillo and chromeos namespaces
and include directory is changing to brillo.
Bug: 24872993
TEST=built for aosp and brillo, all unit tests pass on dragonboard
Change-Id: I804311e49ee780ca96e05f6a581e8c95709d4e1d
/system/connectivity/shill/fake_store.cc
|
| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/fake_store.cc
|
| b8f04f56133060fada6a65f0494c05b78eee6b88 |
|
27-Aug-2015 |
mukesh agrawal <quiche@chromium.org> |
shill: StoreInterface: remove set_path()
set_path() is no longer used in a substantive way,
so remove it. Update calling code accordingly.
Also: remove empty-path checks in FakeStore,
since FakeStore no longer needs a path_ member
at all.
BUG=chromium:517570
TEST="USE='asan clang' FEATURES=test emerge-samus shill"
Change-Id: I0bea86264c037cdb758146bd937f237529c38333
Reviewed-on: https://chromium-review.googlesource.com/295926
Commit-Ready: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/fake_store.cc
|
| fbac24bfb0b630316414c265872738410578a07c |
|
24-Aug-2015 |
mukesh agrawal <quiche@chromium.org> |
shill: add FakeStore
Some unit tests (e.g. ProfileTests) need to use a
StoreInterface implementation. For tests which verify
the interaction between the class-under-test and the
StoreInterface, we've used MockStore.
For tests which don't care about the interaction, we've
used KeyFileStore. Unfortunately, that will not be
viable on some new platforms.
We could resolve this problem by moving such tests to
JsonStore. But that makes the code hard to understand.
In a quick glance, it would be confusing to see a test
use both KeyFileStore and JsonStore.
Instead, add a FakeStore. This fake provides the
functionality needed by the class under test (namely:
in-memory storage and retrieval). The fake, however,
omits serialization and persistence.
BUG=chromium:23387120
TEST=compile
Change-Id: I7852870fc957d5c123f317e8c2e2c4ae69aa33a7
Reviewed-on: https://chromium-review.googlesource.com/295259
Trybot-Ready: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/fake_store.cc
|