| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/mock_eap_credentials.h
|
| fc5236388674c3ae04255d98f5a3e93b789be185 |
|
14-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: cleanup proxy interfaces for supplicant
Remove dbus-c++ dependencies from supplicant proxy interfaces and the
classes that uses supplicant proxy interfaces. Mainly the usage of
dbus-c++ specific types: DBus::Path (replaced by std::string) and
map<string, DBus::Variant> (replaced by KeyValueStore) types.
Also update the proxy interface APIs to return boolean status instead
of passing on the DBus exception errors. Ideally, we would like to
return an error object back to the caller as well, but that would require
a method to convert dbus errors to shill errors (additional errors to
cover all possible DBus errors). And currently, those errors are used
for logging purpose only (with an exception in RemoveNetwork), where it
is already done inside the proxy APIs.
BUG=chromium:570966
TEST=USE="asan clang" FEATURES=test emerge-$BOARD shill
TEST=Run wifi_matfunc tests
Change-Id: I227b5adc2306873480414db7d4e625bc1cc4f21b
Reviewed-on: https://chromium-review.googlesource.com/285632
Trybot-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/mock_eap_credentials.h
|
| 1e006c610db980bca337121134d2ba54497b7a59 |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Top-level mocks: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: I730ed5115e62319c2745dd6cef642e228b0fb66e
Reviewed-on: https://chromium-review.googlesource.com/278036
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/mock_eap_credentials.h
|
| 5ea763b83299b5fad76a87183fb39a74c2d3c61d |
|
13-Aug-2014 |
Ben Chan <benchan@chromium.org> |
shill: Add C++11 override specifier to destructors of derived classes.
BUG=None
TEST=`USE=wimax FEATURES=test emerge-$BOARD platform2`
Change-Id: I88d4e29165869b26924cccb94ac940dc8961c312
Reviewed-on: https://chromium-review.googlesource.com/212267
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/mock_eap_credentials.h
|
| c350e68360d08626cff8c4020c743b61d7da5a2b |
|
20-Jun-2014 |
Paul Stewart <pstew@chromium.org> |
shill: Further deprecate CaCertNSS
Chrome has been updated to no longer set the CaCertNSS property
for OpenVPN, L2TP/IPSec and 802.1x connections. It also has code
to migrate such properties over to the equivalent CaCertPEM
property. This CL rips out the underpinnings in shill that used
to convert NSS properties by reading the user NSS database. It
still supports the various NSS service properties for read (to
allow Chrome to detect and migrate away from the NSS property)
and write (so Chrome can clear the vestigial property) in all the
places where that was previously supported.
CQ-DEPEND=CL:205152
BUG=chromium:385401
TEST=Unit tests
Change-Id: Id3df385148acb8e9c4240bbaa980e4118aa6b088
Reviewed-on: https://chromium-review.googlesource.com/204763
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/mock_eap_credentials.h
|
| 8a5322984f2d81bcbfd8d44c59747a11bd9b904b |
|
17-Jun-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
shill: Fix most of warnings from cpplint
Fix most cpplinter's warnings. On a few occasisions, the warnings
produced were false-positives, so added explicit // NOLINT comment
overrides.
There were a few instances of disallowed non-const reference usage
(reported as runtime/reference error by cpplint) for
"DBus::Error &error" which should potentially be changed
to pointers to comply with C++ coding style but I will let Shill
owners do that since there is quite a few of those and the
change isn't brain-dead simple...
BUG=None
TEST=platform2 still compiles and all unit tests pass.
Change-Id: Ic2e31896aa13d20eeb1a85dee74f3db8cccfde2e
Reviewed-on: https://chromium-review.googlesource.com/204164
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/connectivity/shill/mock_eap_credentials.h
|
| 11c224b7054a3f0dc5a34c2903e13f74376db27e |
|
23-Oct-2013 |
Paul Stewart <pstew@chromium.org> |
shill: WiFi: Provide wpa_supplicant a PIN if asked for
There are conditions under which wpa_supplicant will clear the
"pin" property of its configuration, even if this was previously
supplied by shill. Under these circumstances it wil request it
again as the EAP negotiation starts. This change provides the
means for the WiFi object to detect when this parameter is being
requested and to supply this value to wpa_supplicant if the
WiFiService has this information on hand.
BUG=chromium:310296
TEST=Unit tests + new autotest:
https://chromium-review.googlesource.com/174170
This autotest still fails the following but shows in the supplicant logs:
CTRL_IFACE: response handle field=PIN
EAPOL: received control response (user input) notification - retrying pending EAP Request
indicating that the PIN has been successfully provided to wpa_supplicant
Change-Id: I91bc3ddd01a335f93d20cca4d47ca497bd631ebe
Reviewed-on: https://chromium-review.googlesource.com/174180
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/mock_eap_credentials.h
|
| bebf1b8bce52b88c2cc2d93200b9405f9c19cf21 |
|
24-Apr-2013 |
mukesh agrawal <quiche@chromium.org> |
shill: make setting a property to its current value a no-op
Before this change, setting the EAP authentication properties
on a WiFiService would cause the connection to be dropped.
The connection would drop even if the new values were the same
as the old.
With this change, the connection is only dropped if the new
values differ from the old.
Overview of changes:
- AccessorInterface: have property setters return a bool (rather
than void). Setters should return true to indicate the value was
changed, and false otherwise.
- PropertyAccessor and derived classes:
- Implement the new AccessorInterface.
- Add tests that we implement the new AccessorInterface.
- Custom property setters (various classes):
- Update existing custom setters to return true if the value was
changed, and false otherwise.
- Add tests that custom setters implement the desired behavior.
- DBusAdaptor
- Change SetProperty to propagate the return value of
PropertyStore's setters, rather than Error::IsSuccess().
- In combination with other changes, this means
DBusAdaptor::SetProperty now returns false if the new value is
the same as the old.
- This also suppresses some spurious change notifications from
IPConfig, Manager, and Profile objects.
- Add tests that DBusAdaptor::SetProperty implements the desired
behavior.
- PropertyStore
- Add a change callback. This optional argument to the ctor is
invoked if a setter or clearer modified its property. This
is so that classes don't have to depend on their RPC adaptors
to inform them of a change. (See changes in Service.)
- Have setters pass through the return value of the Accessor,
rather than returning Error::IsSuccess(). In
combination with other changes, this means that setters
now returns false if the new value is the same as the old.
- Add tests that PropertyStore invokes the change callback
appropriately.
- ClearPropertyNonexistent, SetPropertyNonexistent: no callback
- ClearProperty: callback
- SetProperty: callback if and only if property changed
- Service
- Register OnPropertyChanged with PropertyStore, instead of relying
on a callback from ServiceDBusAdaptor. Two reasons for the change:
1) The RPC adaptors should be as trivial as possible, and
2) We can't test code in the RPC adaptors.
3) If we can't test code in the RPC adaptors, go to 1.
- ServiceDBusAdaptor: remove OnPropertyChange callback in SetProperty.
See Service for the rationale.
- Update existing SetProperty tests (various classes)
We now use values that differ from the current value of the property.
This ensures that the setter returns true.
- WiFiServiceTest: add a case to test that EAP authentication property
changes caused cached credentials to be cleared appropriately. This is
redundant given some of the other tests. But given that this was the
original problem in the bug, it seems worth testing specifically.
- HACKING: add some guidelines for what to do when adding properties.
While there:
- Change some HelpRegister... functions to HelpRegisterConst...
- Update some tests to check error.is_set() before reading
error.name(). This avoids a stray pointer dereference.
- Add SetStringmapsProperty to PropertyStore. This is needed because
PropertyStoreTypedTest now tests setters.
- Remove duplicate kAutoConnectProperty test case in ServiceTest.SetProperty
- Remove unused local in WiFiServiceTest.SetPassphraseRemovedCachedCredentials
- Remove unused method Device::HelpRegisterDerivedStrings
- Remove KeyValueStore from the set of types exercised by
PropertyStoreTypedTest. We only use KeyValueStore for const
properties, and PropertyStoreTypedTest tests setting and
clearing.
- Add PropertyChanges test to EthernetEapServiceTest.
BUG=chromium:233681
TEST=new unit tests
Change-Id: I9bdd89fbe6f19101dfcd5f126f2ba9c81533ff97
Reviewed-on: https://gerrit.chromium.org/gerrit/49733
Commit-Queue: mukesh agrawal <quiche@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/mock_eap_credentials.h
|
| c43cbbe5b33a7afe1b1250bef87fb8e9223cb764 |
|
11-Apr-2013 |
Paul Stewart <pstew@chromium.org> |
shill: EapCredentials: Promote to a class
Promote the EapCredentials structure to a sovereign class with
a small set of getters and setters where necessary. Otherwise,
move most of the member manipulation (creating arguments for
wpa_supplicant and wimax_manager, Load() and Save()) interior
to the class. This involves a straightforwarnd but lengthy
refactor of just about everything that uses EapCredentials.
The EapCredentials object is ref-counted to allow it to be
shared between some services. For this reason, move the
"remote_certification" property out of EapCredentials into
Service since this property is strictly per-service.
BUG=chromium:227434
TEST=Unit tests, wired 802.1x and wifi EAP-TLS autotests
Change-Id: I167e71e1d9c934bc328a0e1d73f638e1ff50d238
Reviewed-on: https://gerrit.chromium.org/gerrit/47973
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/mock_eap_credentials.h
|