| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/service_under_test.cc
|
| 1a212a6b98b22ad1d69652bb26a9e94138635476 |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Top-level files n-v: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: I8bd6f66ea185ca3a2687986f6f2fd99be957dffe
Reviewed-on: https://chromium-review.googlesource.com/278070
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/service_under_test.cc
|
| bb833563aff5a55777e206d0b640c7cbff5f7417 |
|
22-Jan-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Service: Accept variant dict in Configure
Service::Configure is called indirectly through the Service D-Bus
adaptor "SetProperties" method as well as the Manager D-Bus adaptor
"ConfigureService" methods. They both use ArgsToKeyValueStore to
convert D-Bus string/variant dicts into a KeyValueStore object.
In order for the StaticIPConfig property to be configured using
either of these methods, we must allow an element of the
KeyValueValueStore (the properties bundle) to contain another
KeyValueStore (Static IP properties).
This CL adds a "key_value_store_properties_" to KeyValueStore. It
allows DBusAdaptor to unbundle such a data member, and enables this
to be used in Service::Configure and Service::DoPropertiesMatch().
BUG=chromium:450833
TEST=Unit tests
Change-Id: I7bd698fc685f56902fea3c3c8a2bbdf324e2b5ce
Reviewed-on: https://chromium-review.googlesource.com/242491
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
/system/connectivity/shill/service_under_test.cc
|
| 1cf7eb8dcb037d45b23ed85b777c227b7ab39069 |
|
04-Dec-2013 |
Paul Stewart <pstew@chromium.org> |
shill: PropertyAccessor: Create a const ReadOnly accessor
Provide a means to create an Accessor child class which can be
constructed with a const method. This is useful for read-only
properties which won't modify the called object's state. Make
use of this new feature by transforming the HelpRegisterConst*
in the Service object to take const methods and to register
read only accessors. The bulk of this CL is the change to all
the subclasses to constify methods which were only non-const
due to this issue.
BUG=chromium:325603
TEST=Unit test
Change-Id: I79c6211e9e0907869c2885937dff58c1faf2ca4a
Reviewed-on: https://chromium-review.googlesource.com/178698
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/service_under_test.cc
|
| 99dc9f3cd85bc40e0eaf97849a261f155e7c13f7 |
|
27-Jun-2013 |
Paul Stewart <pstew@chromium.org> |
shill: Service: Support string arrays in Configure
Support conversion of string array parameters in
DBusAdaptor::ArgsToKeyValueStore(), so that in addition to SetProperty,
Manager functions like ConfigureService, GetService, etc, are passed
string array arguments. In Service::Configure() and
Service::DoPropertiesMatch(), add string array properties to the
properties set / matched.
BUG=chromium:249363
TEST=Unit test. As of https://gerrit.chromium.org/gerrit/59123,
network_VPNConnect now tests this code path (by setting CACertPEM
in the OpenVPN tests).
Change-Id: Ide3545e47c8c05b36c7ef3a41d83fbde7263404d
Reviewed-on: https://gerrit.chromium.org/gerrit/60221
Commit-Queue: Paul Stewart <pstew@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/service_under_test.cc
|
| 58f0b6dbd71f52c3abdac91aed44024a35bc4898 |
|
12-Jun-2012 |
Darin Petkov <petkov@chromium.org> |
shill: Log boot statistics for service state changes.
BUG=chromium-os:30169
TEST=unit tests, booted device, /tmp/disk-network-ready is populated
Change-Id: I8f0de3d3f9da2f73ca10977d46262fbbbbd56584
Reviewed-on: https://gerrit.chromium.org/gerrit/25084
Tested-by: Darin Petkov <petkov@chromium.org>
Reviewed-by: Thieu Le <thieule@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Ready: Darin Petkov <petkov@chromium.org>
/system/connectivity/shill/service_under_test.cc
|
| acdc11f4961994f894f978713d1a22f2eb23687d |
|
30-Mar-2012 |
Jason Glasgow <jglasgow@chromium.org> |
shill: Change service.device property to be a DBus::Path
Change service.device property to be a DBus::Path because it is a path
not a string. Flimflam exports the property as a path. Exporting it
as a string causes cashew to die.
Change the unit tests to use valid DBus paths which can contain
elements separated by /. Each element can contain only
[A-z][a-z][0-9]_ and cannot end in a trailing /.
BUG=chromium-os:28734
TEST=run shill unit tests, run shill on DUT. Run cashew.
Change-Id: I65fb843fb93f76d95eea6da334ad326ccb9fbd6f
Reviewed-on: https://gerrit.chromium.org/gerrit/19366
Commit-Ready: Jason Glasgow <jglasgow@chromium.org>
Reviewed-by: Jason Glasgow <jglasgow@chromium.org>
Tested-by: Jason Glasgow <jglasgow@chromium.org>
/system/connectivity/shill/service_under_test.cc
|
| adb6848a27f0eb449527fa3aa0440002f2be6800 |
|
18-Jan-2012 |
mukesh agrawal <quiche@chromium.org> |
shill: don't auto-connect to a disconnected service
This addresses part of the problem with the 003AsciiKeyWEP40
failure. That test establishes a connection, disconnects,
reconfigures the (WEP) password on an AP, and then tries
to reconnect.
Before this patch, the test failed as follows:
1. shill immediately tries to reconnect after the disconnect.
This reconnect uses the old password (because the test
hasn't had a chance to supply a new password).
2. The test code provides the correct password, and then
initiates an explicit connect. However, the explicit
connect is ignored, because a connection is already in
progress (to the same service).
3. The automatic reconnect fails, because it is using the
wrong password.
BUG=chromium-os:25153,chromium-os:25157
TEST=unit tests, WiFiRoaming, WiFiSecMat.*WEP*, WiFiManager
Testing notes:
- WiFiRoaming had some failures, but no regressions
- WiFiSecMat.*WEP* passed except 003CheckWEP_8021x
(previously, that failed in addition to 000StaticKeyWEP40,
001StaticKeyWEP104, 005SharedKeyWEP40, and 006SharedKeyWEP104.)
- WiFiManager passed
(previously, 003AsciiKeyWEP40 and 004AsciiKeyWEP104 failed.)
Change-Id: I2dd6312006865c914d4193ce3f7d7c5443b84deb
Reviewed-on: https://gerrit.chromium.org/gerrit/14408
Commit-Ready: mukesh agrawal <quiche@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/service_under_test.cc
|
| 3426c8fc7a3943f2d8fcb2ec78f0593088b42bed |
|
12-Jan-2012 |
Thieu Le <thieule@chromium.org> |
shill: Move Metrics from singleton to Shill daemon
While implementing chromium-os:24810, it was discovered that Metrics is
cleaner if it is passed around like ControlInterface, Dispatcher,
Manager, etc. This approach also makes Metrics more testable.
BUG=chromium-os:24810
TEST=Unit tests, network_WiFiManager suite
Change-Id: I556a1bd11f21f0b93ecfeaae8855dfb99ed5e5f9
Reviewed-on: https://gerrit.chromium.org/gerrit/14099
Commit-Ready: Thieu Le <thieule@chromium.org>
Reviewed-by: Thieu Le <thieule@chromium.org>
Tested-by: Thieu Le <thieule@chromium.org>
/system/connectivity/shill/service_under_test.cc
|
| 0ed0f2e84c366a90bca4a824b0adf18e9f243369 |
|
05-Dec-2011 |
mukesh agrawal <quiche@chromium.org> |
shill: implement Service.Disconnect (for WiFiService only)
BUG=chromium-os:23774,chromium-os:23662
TEST=new unit tests, some autotests
autotests run:
- PASS network_WiFiSecMat.031CheckHidden_WPA
- PASS network_WiFiSecMat.032CheckHidden_RSN
Change-Id: I0c2dc8c9888caca793f0dfe5a55c0df2a4b10c79
Reviewed-on: https://gerrit.chromium.org/gerrit/12498
Commit-Ready: mukesh agrawal <quiche@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/service_under_test.cc
|
| 435de2cd55a95836381b53acbce8cbbad98ec04d |
|
18-Nov-2011 |
Gaurav Shah <gauravsh@chromium.org> |
Implement {Available|Connected|Enabled}Technolgies and DefaultTechnology
This is Part 1 of a series of changes required for the Manager to generate
the right set of DBus events allowing shill to properly tell Chrome about
connectivity.
Some other side-effects in the change (needed to implement the above):
- Emit these manager properties over DBus everytime we re-sort the Service
vector.
- Add a technology data member to Device, this allows easy enumeration of
technologies.
- Add interface for getting a handle to the selected service on a device.
- Map connected state to online instead of ready state. This is needed for
so that Chrome doesn't wait for the portal detection code to switch the
state from ready->online.
- Default set the ethernet service as connectable.
BUG=chromium-os:14887
TEST=1) manual test to verify shill properly configures the ethernet
device and Chrome correctly detects that.
2) new unit tests
Change-Id: Ib10f2f0836f8d4aacaad1491f58ed9b3b5d37e7d
Reviewed-on: https://gerrit.chromium.org/gerrit/12019
Tested-by: Gaurav Shah <gauravsh@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/service_under_test.cc
|
| 1b7a616197af7ff753dbe7614a8e207b1e10ac1a |
|
09-Nov-2011 |
Gaurav Shah <gauravsh@chromium.org> |
shill: Implement write-only properties
Certain properties (e.g. WIFI Passphrase) are write only and must
not be returned when Service.GetProperties() is called over D-Bus.
This CL implements WriteOnlyProperties, a write-only analog of the
read-only ConstProperties.
Also add a ReadablePropertyConstIterator which only returns the
readable properties. Switch over DBus adaptor and PropertyStore
to use that.
BUG=chromium-os:21196
TEST=Added 2 new unittests.
Change-Id: I52815cc395650e0b49e1acac8d4954deeebcee5d
Reviewed-on: https://gerrit.chromium.org/gerrit/11402
Commit-Ready: Gaurav Shah <gauravsh@chromium.org>
Reviewed-by: Gaurav Shah <gauravsh@chromium.org>
Tested-by: Gaurav Shah <gauravsh@chromium.org>
/system/connectivity/shill/service_under_test.cc
|
| 6515aabcd1fbbb9ff2090c9675c17eeef64e7474 |
|
13-Oct-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Make profiles backed with StoreInterfaces
Rely on persistence of data in StoreInterface to maintain
Service/Device/IPConfig info for entities that are not
currently active, instead of maintaining lists in Profile
objects themselves.
BUG=chromium-os:17253
TEST=unit, run on device
Change-Id: I206f44ddf16c584354f8fcadb57032f047f33d0a
Reviewed-on: http://gerrit.chromium.org/gerrit/10024
Commit-Ready: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/service_under_test.cc
|