Cross Reference: /system/connectivity/shill/shill

History log of /system/connectivity/shill/shill_main.cc
Revision	Date	Author	Comments (<<< Hide modified files) (Show modified files >>>)
59b397b6ac7fa39edf26d8e0ff2ecac6ac8ebc5b	20-Jan-2016	Samuel Tan <samueltan@google.com>	shill: rename ChromeosDaemon to DaemonTask Rename ChromeosDaemon to DaemonTask since this class contains all the logic for daemon-related tasks (e.g. start/stop, init/shutdown). This will also prevent this class from being confused with ShillDaemon. BUG: 26653263 Change-Id: I9713203cb1f933163d7067a7ae982622bf5b17af TEST: shill compiles and unit tests pass on Android. TEST: shill compiles and unit tests pass on Chrome OS. /system/connectivity/shill/shill_main.cc
3a62e235646ec19bee71e8dbee5208282dcd13b5	20-Jan-2016	Alex Vakulenko <avakulenko@google.com>	shill: Update libchrome APIs to r369476 The new libchrome has been ported from Chromium and some APIs have changed. Make necessary changes at call sites. Change-Id: Ib4c4b5438a2e249777c9c1b6509f085ad5d00049 /system/connectivity/shill/shill_main.cc
60ea15d40a3ad77536e01f2bb780181aa9c3c084	20-Jan-2016	Samuel Tan <samueltan@google.com>	shill: refactor ChromeosDaemon Refactor ChromeosDaemon so that it no longer inherits from brillo::Daemon. This is necessary to allow its unit tests to run without the extra base::ExitManager inherited from brillo::Daemon. Do this by introducing a new ShillDaemon class, which inherits the logic in ChromeosDaemon, and overrides brillo::Daemon methods. BUG: 26653263 Change-Id: Ia256bc540d261fb183aae0100946afdcdea80fb3 TEST: shill compiles and unit tests pass on Android. TEST: shill compiles and unit tests pass on Chrome OS. /system/connectivity/shill/shill_main.cc
c1d447354db29b83262c7db0857baa84e05e0c2a	15-Jan-2016	Christopher Grant <cjgrant@google.com>	shill: add a whitelist invocation option To compliment the blacklisting approach, add a whitelist option. If specified, shill will manage only device specified by the whitelist. Allow only one of blacklist, whitelist or passive mode to be specified. Bug: 26424002 TEST=Manual testing, new unit tests. Change-Id: I9149543b56f6bcb464a1ba09da56abcdd9a34b2e /system/connectivity/shill/shill_main.cc
7370e4f0e15e9d08a37a90eb9b28d41885a5d977	08-Jan-2016	Samuel Tan <samueltan@google.com>	shill: do not use in Callback80211Metrics if WiFi is disabled Fix ChromeosDaemonUnittest so that Callback80211Metrics is not used when WiFi is disabled. While there, include <base/bind.h> in shill_main.cc to support the use of base::Bind in main(). BUG: None Change-Id: I9db2115e9f6bd1339b1e2b3fa91827bca2234a76 TEST: shill compiles successfully in Android both when WiFi is enabled. TEST: shill compiles successfully in Android both when WiFi is disabled. /system/connectivity/shill/shill_main.cc
646c7e891789ea8abadd9e88bdd625d8bea2536d	29-Dec-2015	Samuel Tan <samueltan@google.com>	shill: stop using ChromeosDBusDaemon Replace the use of ChromeosDBusDaemon with ChromeosDaemon, and move D-Bus initialization code into ChromeosDBusControl. This will allow us to easily plug in another RPC interface (Binder) into shill by adding another ControlInterface implementation that handles that RPC mechanism's initialization. BUG: 26359493 Change-Id: I0ffe1e080601d7c4544fa6c73bad0f34b4a984ed TEST: shill compiles on Android and unit tests pass. TEST: shill compiles on ChromeOS and unit tests pass. TEST: weave provisioning succeeds on Brillo dragonboard build. /system/connectivity/shill/shill_main.cc
03e6719bae1e0903d94853b896673a033196bcf5	13-Oct-2015	Alex Vakulenko <avakulenko@google.com>	shill: Rename "chromeos" -> "brillo" in include paths and namespaces libchromeos is transitioning to libbrillo and chromeos namespaces and include directory is changing to brillo. Bug: 24872993 TEST=built for aosp and brillo, all unit tests pass on dragonboard Change-Id: I804311e49ee780ca96e05f6a581e8c95709d4e1d /system/connectivity/shill/shill_main.cc
ddce70da26f410225a977bc7d9f651f279a5a5b4	30-Sep-2015	Peter Qiu <zqiu@google.com>	Do not run logger on Android Logger utility doesn't exist on Android, so do not run it on Android. Bug: 24451556 TEST=Manual test on dragonboard TEST=Start shill and verify logger process is running for shill Change-Id: I937e33555bea32d2b738fac8892dcb202d9a3ee4 /system/connectivity/shill/shill_main.cc
508ae9d92fd6d91fa7b13e116780ed4be2c8693e	29-Sep-2015	Peter Qiu <zqiu@google.com>	Do not daemonize (fork) the daemon process When starting the daemon using an init system, the environment setup is already being handled by the init system, so there is no need to daemonize the daemon process create such setup. By daemonizing the daemon process, it spawns off a new process to run the daemon and terminates the current process. This causes a problem with the init system, where it thinks that the daemon failed to start. We were able to work around it on Chrome OS's upstart script by adding the forking expectation in the init scritp ("expect fork"), but there is not such workaround on Android's init system. Fix it by removing the daemonize call (daemon()) and remove the the forking expectation on Chrome OS's init script. Bug: 24412675 TEST=start/stop shill on Chrome OS device Change-Id: Ib584e52f13946b2d18692e85ff55f86d22022505 /system/connectivity/shill/shill_main.cc
81ee711ea9ab5398be994b4eb3a2634c10f0448d	19-Sep-2015	mukesh agrawal <quiche@google.com>	shill: shill_main: remove unnecessary include of glib We don't use any symbols from glib-unix.h any more. So remove the include. Bug: None BUG=chromium:533591 TEST=compile Change-Id: I54a06753fa5bd4e02dc7693db2da15f3eee5ed93 /system/connectivity/shill/shill_main.cc
bd335110439d524bd5c09867419b30e4a06cdc62	13-Sep-2015	Peter Qiu <zqiu@google.com>	Remove usage of chromeos_dbus USE flag shill is now default to use Chrome OS D-Bus for RPC on Chrome OS, so remove the usage of chromeos_dbus USE flag from the shill.gyp file. While there, remove the dependency for dbus-c++ from libshill. Also change the define for RPC type from DISABLE_CHROMEOS_DBUS to ENABLE_CHROMEOS_DBUS, which will make it easier for enabling a different RPC on another platform (just need to define ENABLE_XXX). Bug: 24028839 TEST=USE="asan clang wimax pppoe" FEATURES=test emerge-$BOARD shill Change-Id: Ib2b513de41e08992ca16543758c96658fae9178c /system/connectivity/shill/shill_main.cc
c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5	03-Sep-2015	Peter Qiu <zqiu@google.com>	License shill to Apache2 This patch automatically replaced the license on all text files from Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as a reference. The license header was added to .gyp and .gypi, the NOTICE was added with a copy of the Apache2 license and MODULE_LICENSE_* file was added. BUG=23587594 TEST=grep 'Chromium OS Authors' doesn't find anything. Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596 /system/connectivity/shill/shill_main.cc
dde57ef146d3868130cd8597e805b42395440c9a	14-Aug-2015	Peter Qiu <zqiu@chromium.org>	shill: switch over to ChromeosDBusDaemon This removes the dependency for glib's io handler and message loop. All the signal handling and message loop setup is handled by chromeos::Daemon. And all the DBus related setup is handled by chromeos::DBusServiceDaemon. Daemon/Manager resources initailization are deferred until the bus is intialized. BUG=chromium:517680 TEST=USE="chromeos_dbus asan clang -cellular" FEATURES=test emerge-$BOARD shill TEST=wifi_matfunc test Change-Id: I88928c5c1290403053d6a5cec392e3d459f5a7af Reviewed-on: https://chromium-review.googlesource.com/293557 Commit-Ready: Zeping Qiu <zqiu@chromium.org> Tested-by: Zeping Qiu <zqiu@chromium.org> Reviewed-by: Zeping Qiu <zqiu@chromium.org> /system/connectivity/shill/shill_main.cc
1a212a6b98b22ad1d69652bb26a9e94138635476	16-Jun-2015	Paul Stewart <pstew@chromium.org>	shill: Top-level files n-v: Switch pointer/ref spacing Switch to Chrome style spacing. BUG=chromium:501026 TEST=Unit tests Change-Id: I8bd6f66ea185ca3a2687986f6f2fd99be957dffe Reviewed-on: https://chromium-review.googlesource.com/278070 Reviewed-by: Rebecca Silberstein <silberst@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/shill_main.cc
1ce231c71932200e4d02c71567f8e93788120781	13-Jun-2015	Paul Stewart <pstew@chromium.org>	shill: Manager: Refactor command line setup In anticipation of a new and different implementation of shill::Daemon, this CL re-factors the interaction between the main() function and shill::Daemon by passing a new Daemon::Settings structure. This way the process of parsing command line parameters is separated from the task of delivering this configuration the Daemon object. While here, the "default_technology_order" field of was unified with the other parameters passed to the Manager from the Daemon. However this change is somewhat dwarfed by the technical debt that needed to be paid off in order to allow this new change to be tested. The new Daemon::ApplySettings method makes no new calls to the Manager object but none of these methods were previously mocked in the MockManager object. More troublingly the side-effects of these Manager methods were depended on in MockManager, so a few tests (notably DeviceTest) needed to be re-architected to deal with mock functionality instead of assuming the Mock object did what a real Manager would do. Lastly, both the Device::PrependDNSServers and Manager::FilterPrependDNSServersByFamily methods seemed a bit hard to understand and difficult to test. Minor changes to these APIs allowed the test changes above to work a lot smoother, and also to separate the unit tests to work on individually testing the functionality in each object. BUG=chromium:500991 TEST=Unit tests Change-Id: I04c33c841024c102ff9658e5857236ab2e5bf32f Reviewed-on: https://chromium-review.googlesource.com/278022 Reviewed-by: Garret Kelly <gdk@chromium.org> Reviewed-by: Rebecca Silberstein <silberst@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/shill_main.cc
d48fa0c5531e2102d4f537e81b9f92afc2d60955	10-Jun-2015	Peter Qiu <zqiu@chromium.org>	shill: command line support for DHCPv6 Add command line option "--dhcpv6-enabled-devices" to enable DHCPv6 for specific devices. The obtained DHCPv6 configuration is for informational purpose only, will not be used to setup connection nor update system configuration by shill. Note: since shill does not use DHCPv6 configuration to setup any connection, other IP configuration (DHCPv4 or IPv6 over RDNSS) is required in order for the device to setup a connection for a given network service. BUG=chromium:492764 TEST=USE="dhcpv6 asan clang" emerge-$BOARD shill TEST=USE="asan clang" emerge-$BOARD shill TEST=Verify with new DHCPv6 client auotest Manual Test: 1. Build/install IPv6 enabled dhcpcd and DHCPv6 enabled shill 2. Setup a virtual ethernet pair using: "ip link add name veth_master type veth peer name slave" 2. Setup a DHCPv6 server on veth_master interface "/usr/sbin/dhcpd -6 -cf /tmp/dhcp6.conf veth_master" 3. Start shill with DHCPv6 enabled for "slave" interface 4. Verify DHCPv6 configuration via "/usr/local/lib/flimflam/test/list-ipconfigs slave" Change-Id: Ic152400f61e5bb4cb02f237b97da971ed24da27f Reviewed-on: https://chromium-review.googlesource.com/276713 Reviewed-by: Paul Stewart <pstew@chromium.org> Tested-by: Zeping Qiu <zqiu@chromium.org> Commit-Queue: Zeping Qiu <zqiu@chromium.org> /system/connectivity/shill/shill_main.cc
08add488849f90600a5657a6f54f4dbc34701b8f	20-Apr-2015	Matthew Wein <mattwein@chromium.org>	shill: Allow hostname setting via DHCP Allow shill to optionally allow a Device to (a) request the hostname parameter and (b) accept this hostname from a dhcp config and apply it locally. BUG=chromium:475699 TEST=None CQ-DEPEND=CL:266519 Change-Id: I56140831768255b04c6f5c558feec4a9119f349b Reviewed-on: https://chromium-review.googlesource.com/266647 Reviewed-by: Matthew Wein <mattwein@chromium.org> Tested-by: Matthew Wein <mattwein@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/shill_main.cc
af19870a5717a0a9f05c4fd957d4a05f48b8b090	09-Apr-2015	Alex Deymo <deymo@chromium.org>	Use PLOG instead of LOG with strerror() This patch replaces "LOG() << ... << strerror(errno)" by "PLOG() << ..." when possible, which provides equivalent functionality. BUG=None TEST=cbuildbot amd64-generic-full Change-Id: I760689818a3647efa980c96305a0bc8cf0bb4ac0 Reviewed-on: https://chromium-review.googlesource.com/264834 Reviewed-by: Alex Vakulenko <avakulenko@chromium.org> Commit-Queue: Alex Deymo <deymo@chromium.org> Trybot-Ready: Alex Deymo <deymo@chromium.org> Tested-by: Alex Deymo <deymo@chromium.org> /system/connectivity/shill/shill_main.cc
127f2565a985650963d6109fc3a32c3da6a17d32	02-Apr-2015	Alex Vakulenko <avakulenko@chromium.org>	platform2: Explicitly use base:: namespace with CommandLine The current revision of libchrome is removing CommandLine class from global namespace and only retain the one in base::. Sweep the code to use the correct namespace in anticpation of libchrome revision roll. BUG=None TEST=./build_packages Change-Id: Ib7ca448dac1204c1e36ab053e775a5a5214997ac Reviewed-on: https://chromium-review.googlesource.com/263785 Trybot-Ready: Alex Vakulenko <avakulenko@chromium.org> Tested-by: Alex Vakulenko <avakulenko@chromium.org> Reviewed-by: Alex Deymo <deymo@chromium.org> Commit-Queue: Alex Vakulenko <avakulenko@chromium.org> /system/connectivity/shill/shill_main.cc
782cdcea789d76a7ad7802cf9410b14a2399c0a9	01-Apr-2015	Garret Kelly <gdk@chromium.org>	shill: add minimum-mtu command-line parameter Add the --minimum-mtu option to shill to allow clients to override small MTU values set by DHCP servers. Any MTU value smaller than the provided one is dropped. BUG=chrome-os-partner:36886 TEST=FEATURES=test emerge-amd64-generic shill, ASAN profile Change-Id: I8e79a18f335705887568e04050712d565d53c4f0 Reviewed-on: https://chromium-review.googlesource.com/263522 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Garret Kelly <gdk@chromium.org> Tested-by: Garret Kelly <gdk@chromium.org> /system/connectivity/shill/shill_main.cc
c5f89d131e5b03f448b73fd02d16cab30e438521	18-Feb-2015	Garret Kelly <gdk@chromium.org>	shill: add new --prepend-dns-servers flag The --prepend-dns-servers flag causes every Device to prepend resolvers of the same address family as their local address to their list of resolvers before setting it. It is guaranteed that the same resolver will not appear more than once in the output list. BUG=chrome-os-partner:36696 TEST=amd64-generic unit tests and ASAN profile unit tests CQ-DEPEND=CL:250873 Change-Id: I052f6bb8bd222880e1b18097c72a96f11cd50559 Reviewed-on: https://chromium-review.googlesource.com/250877 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Garret Kelly <gdk@chromium.org> Tested-by: Garret Kelly <gdk@chromium.org> /system/connectivity/shill/shill_main.cc
5a2097c0f4db1704dd5b7b0b874b669bb21c42ad	11-Feb-2015	Jason Simmons <jsimmons@google.com>	shill: Add a command line option that controls the default technology order This can be used to configure a preference for a particular network on a given device. For example, a device may want to use the mobile network for all traffic even if an open wifi network is available. BUG=chromium:453607 TEST=Added the flag via /etc/init/shill.override and confirmed that dbus GetServiceOrder returned the new order Change-Id: Ifac0baa4feeaae4a780d4d74f2bd195b4e4dd31d Reviewed-on: https://chromium-review.googlesource.com/248610 Reviewed-by: Paul Stewart <pstew@chromium.org> Tested-by: Jason Simmons <jsimmons@chromium.org> Commit-Queue: Jason Simmons <jsimmons@chromium.org> /system/connectivity/shill/shill_main.cc
83d625655edbc7c35fc436b8b8fe744886d0aae1	10-Feb-2015	Paul Stewart <pstew@chromium.org>	shill: DeviceInfo: Optionally ignore unknown Ethernet Before CL:224422, any unknown network devices (ones that did not report a driver symlink) were treated as "Unknown" and were not managed by shill. However some broken Ethernet drivers do not report this. This change allows a command-line option to revert this workaround so virtual network interfaces and other such non-reported devices can be ignored by the manager again. Additionally, explicitly ignore all devices that appear with a "veth" prefix. BUG=chromium:457043,chromium:456104,chromium:451714 TEST=Unit tests Change-Id: I513c7014c2159d7fea608eed85c0e33b02a893ba Reviewed-on: https://chromium-review.googlesource.com/247904 Reviewed-by: Zeping Qiu <zqiu@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/shill_main.cc
1d499ed2d5eede24f55c7f6b8aaba06136ef4f22	31-Jan-2015	Peter Qiu <zqiu@chromium.org>	shill: add passive mode support Add a command line option to enable passive-mode. When this option is enabled, shill will not manage any devices by default. Remote application can specify the devices for shill to manage through org.chromium.flimflam.Manager::ReleaseInterface/ClaimInterface APIs. All devices claims will go through the default device claimer, with claimer name of empty string (""). While there, update the ReleaseInterface API to also take claimer name as an argument, so that the claimer name will be check before releasing a device. This is to avoid devices being released by other unknown claimers. BUG=chromium:454007 TEST=USE="asan clang" FEATURES=test emerge-$BOARD shill apmanager Manual Test: 1. Start shill with passive mode enabled, verify "/usr/local/lib/flimflam/list-device" does not return any device. 2. Use dbus-send command to release "eth0" device from default claimer, and verify "/usr/local/lib/flimflam/list-device" does return eth0 device. 3. Use dbus-send command to claim "eth0" device from default claimer, and verify "/usr/local/lib/flimflam/list-device" does not return any device. 4. Regression test with apmanager. Change-Id: I2b79a13e8aea0d07e9d7923ba3c26adb19237e1a Reviewed-on: https://chromium-review.googlesource.com/245123 Reviewed-by: Zeping Qiu <zqiu@chromium.org> Commit-Queue: Zeping Qiu <zqiu@chromium.org> Trybot-Ready: Zeping Qiu <zqiu@chromium.org> Tested-by: Zeping Qiu <zqiu@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/shill_main.cc
8dc5e7b99920ab79d2bee7f99fec9fa5765fda68	12-Dec-2014	Paul Stewart <pstew@chromium.org>	shill: DBus: Fix issues with the exit path Fix a short list of issues that prevented shill from exiting cleanly: - In daemon mode stderr is redirected to a child process running "logger". When the shill process receives a signal, the logger process is also killed. Catch and ignore SIGPIPE errors that occur as a result of this defunct process. - Both DHCPControl and ProxyFactory created separate DBus::Connection instances. Either dbus-c++ or the dbus library has a double free problem when the second instance is freed. Instead, create a new singleton SharedDBusConneciton so both these modules can share the DBus connection. - Ownership of dbus_control shill_main is passed to the ShillDaemon instance. As such is an error to create an at-exit handler to explicitly delete it as this would constitute a double-free. - The DHCP provider singleton held a reference to a DBus proxy which was only removed in the LazyInstance at-exit-handler. Release this instance explicitly in Daemon::Stop() so it is freed while the DBus connection is still active. - Explicitly destroy manager_ in Daemon::Stop() so that its adaptor is freed while the DBus connection is still active. BUG=chromium:441413 TEST=Unit tests + "stop shill" and ensure "PIPE" message does not appear in logs. Change-Id: I0239ccc24fee05ef9b2c953ef04fa64acd817349 Reviewed-on: https://chromium-review.googlesource.com/234902 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/shill_main.cc
c9c31d8497c3f053c2160408cc386010fc125fad	22-Oct-2014	Rebecca Silberstein <silberst@chromium.org>	shill: add object id to scoped log messages Add object identifier (DBus::Path) string to scoped logging messages. If the logging message is called from a static method, SLOG will be called with nullptr and the log will use (anon) for the object id. Objects without identifying information will use the (class_name) as their logged identifier. BUG=chromium:403996 TEST=ran unit tests and manually inspected net.log Change-Id: Idf23911a303f5edc4b82917bf1e2cea3f8e44e60 Reviewed-on: https://chromium-review.googlesource.com/224812 Tested-by: Rebecca Silberstein <silberst@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Rebecca Silberstein <silberst@chromium.org> /system/connectivity/shill/shill_main.cc
40a014862d79843026e06ef0cc0e3bc1463fe518	31-Oct-2014	Peter Qiu <zqiu@chromium.org>	shill: remove glib dependency from libshill-net Pull glib's IO handlers out from libshill-net to eliminate its dependency on glib. This is desired since the applications that uses this library might not want this extra dependency. This is achieved by adding an IOHandlerFactoryContainer for setting/accessing IOHandlerFactory. By default. the container will create an IOHandlerFactory that create IOHandlers base on the libbase's FileDescriptorWatcher. The caller can implement its own IOHandlerFactory and IOHandlers to overwrite this default behavior. For example, shill's glib IOHandlers. BUG=chromium:427982 TEST=unittests, run wifi_matfunc for shill regression test Change-Id: I92b853309d520f499b9bb2736211cdd3bb3c268f Reviewed-on: https://chromium-review.googlesource.com/226833 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Tested-by: Peter Qiu <zqiu@chromium.org> /system/connectivity/shill/shill_main.cc
cc225ef3b77b5e098cc12c661a947e1737480777	30-Sep-2014	Ben Chan <benchan@chromium.org>	shill: Replace NULL with nullptr. BUG=None TEST=`USE=wimax FEATURES=test emerge-$BOARD shill` Change-Id: I30ab47ff32dcadad09ae7a2baf4d4123a6ef0d8e Reviewed-on: https://chromium-review.googlesource.com/220657 Reviewed-by: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> /system/connectivity/shill/shill_main.cc
f002cdb1c378e78026a5a3d10415cc1ebb64f6fe	18-Sep-2014	Prathmesh Prabhu <pprabhu@chromium.org>	shill: Add command line switch to control log level in shill_unittest. This CL adds command line switches to shill_unittest similar to the shill daemon to control the logging verbosity from different shill objects. BUG=chromium:415368 TEST=manual. - Run shill and shill_unittest with different log levels. - For shill_unittest, make sure --gtest_filter and --log-level switches can be used together. - Run shill and shill_unittest with --help and check help message has logging related messages. Change-Id: I0793d098fd9b0ea2aaab81cc57ff4abeee40033c Reviewed-on: https://chromium-review.googlesource.com/218757 Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org> /system/connectivity/shill/shill_main.cc
ca324740fb53093c4bd4ffa73cd4b9ebe09a01be	29-Aug-2014	Paul Stewart <pstew@chromium.org>	shill: ShillDaemonTest: Fix ASAN issues ShillDaemon had a raw pointer to the ControlInterface. Change this to a scoped_ptr so it is freed when the Daemon instance destructs. BUG=chromium:408818 TEST=P2_TEST_FILTER="shill::ShillDaemonTest.*" FEATURES=test \ USE="clang asan" emerge-falco platform2 Change-Id: Ia8e4ed773cacb6a5906c2188a6b6bc3e7c20716a Reviewed-on: https://chromium-review.googlesource.com/215669 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/shill_main.cc
e4c6aff3afa8eec213691e6ab1941d6dd6463ce0	30-Jul-2014	Utkarsh Sanghi <usanghi@chromium.org>	shill, libchromeos, lorgnette: move minijail to libchromeos Move the c++ wrapper of minijail out of lorgnette and into libchromeos BUG=None TEST=emerge-lumpy libchromeos && USE="shill lorgnette" emerge-lumpy platform2 --test Change-Id: Idc796ffb042b1ed6b5a4d322d501eab5bff7fc55 Reviewed-on: https://chromium-review.googlesource.com/210553 Reviewed-by: Utkarsh Sanghi <usanghi@chromium.org> Commit-Queue: Utkarsh Sanghi <usanghi@chromium.org> Tested-by: Utkarsh Sanghi <usanghi@chromium.org> Reviewed-by: Alex Deymo <deymo@chromium.org> /system/connectivity/shill/shill_main.cc
83bd64b869bef72ec734b96eb9cf291b9a9ac2c4	30-Jul-2014	Utkarsh Sanghi <usanghi@chromium.org>	shill, libchromeos: Move the minijail c++ bindings This CL moves the c++ binding for minijail from shill into libchromeos BUG=None TEST=emerge-lumpy libchromeos && FEATURES=test emerge-lumpy platform2 CQ-DEPEND=CL:210408 Change-Id: Ia087ffbf4f54e08fff450f0e2b7984e9eb3448e3 Reviewed-on: https://chromium-review.googlesource.com/210379 Tested-by: Utkarsh Sanghi <usanghi@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Bertrand Simonnet <bsimonnet@chromium.org> Commit-Queue: Utkarsh Sanghi <usanghi@chromium.org> Reviewed-by: Alex Deymo <deymo@chromium.org> /system/connectivity/shill/shill_main.cc
6db7b24348e69639e19cd6c408388b10d6ee54fe	03-May-2014	Paul Stewart <pstew@chromium.org>	shill: Remove trivial use of iterators Move trivial iterations through containers from using an iterator to using range-based for loops. In instances where it makes sense also use "auto" for iterators in non-trivial for loops as well. BUG=None TEST=Unit tests Change-Id: I840d90fb62dc96d45f63144462b9a53b28c25ee9 Reviewed-on: https://chromium-review.googlesource.com/198051 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/shill_main.cc
a0ddf46e466bd4ba3d20952f0a6988c680c1af14	06-Feb-2014	Ben Chan <benchan@chromium.org>	shill: Update to build against libchrome-242728. BUG=chromium:341521 CQ-DEPEND=CL:193660 TEST=Tested the following: 1. `FEATURES=test USE='cellular wimax' emerge-$BOARD platform2` 2. Run the following tests: - network_3GSmokeTest - network_VPNConnect.* - network_WiMaxSmoke - wifi_matfunc Change-Id: Ic1553c182ab7a833a68c45f012f646b8930cb095 Reviewed-on: https://chromium-review.googlesource.com/193606 Reviewed-by: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> /system/connectivity/shill/shill_main.cc
bb5d4a664b6dfaef5f83fe5f2dd95f01b8764b06	07-Jun-2013	Wade Guthrie <wdg@chromium.org>	shill: Removes unused and anachronistic invocation flags. Removes use-flimflam-dirs but keeps shill::Config (and its associated files) and because it simplifies testing and, as a byproduct, simplifies making the storage directories easy to modify on a switch, later. Also removes \|config-dir\| and \|default-config-dir\| because they were unused. BUG=chromium:217747 TEST=unittest and a quick smoke test: * bring-up machine with new shill * make sure it connects * go to a couple websites Change-Id: Id79f35ab33cba79371dc440da2d3f4866700c6ec Reviewed-on: https://gerrit.chromium.org/gerrit/57952 Reviewed-by: Darin Petkov <petkov@chromium.org> Commit-Queue: Wade Guthrie <wdg@chromium.org> Reviewed-by: Wade Guthrie <wdg@chromium.org> Tested-by: Wade Guthrie <wdg@chromium.org> /system/connectivity/shill/shill_main.cc
e6c44440f5cf102c14581c961028a7830cc6448f	19-Apr-2013	Paul Stewart <pstew@chromium.org>	shill: Remove "--push" argument parsing Now that init no longer uses this argument in vain, remove the "--push" argument from shill's command-line parsing. CQ-DEPEND=CL:48604 BUG=chromium:231858 TEST=Unit tests Change-Id: I3838057b2127f271a23ec40d27b248a91a840bcf Reviewed-on: https://gerrit.chromium.org/gerrit/48607 Reviewed-by: Christopher Wiley <wiley@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/shill_main.cc
0e1cdeae24dd678a5fe27c840802582c0ca45ec0	28-Feb-2013	Albert Chaulk <achaulk@chromium.org>	shill: Implement Service.Remove & delete DHCP leases Implement the Service.Remove dbus API and modify the unload sequence to remove the DHCP lease file. Add unit tests to DHCPProvider & WiFiService to check lease file deletion. Currently only WiFi does the DHCP lease delete from DBus - WiMax/Cell/VPN do their own things for IP configuration and Ethernet can't be removed as per the API spec. Also make sure FilePath is qualified as base::FilePath throughout the project. BUG=chromium-os:32756 TEST=added unittests to test the call path on Unload() to delete the lease file Change-Id: Ic6eee17b9d81cd0be8d09c683d85d6a4d19278c9 Reviewed-on: https://gerrit.chromium.org/gerrit/44339 Tested-by: Albert Chaulk <achaulk@chromium.org> Reviewed-by: mukesh agrawal <quiche@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> /system/connectivity/shill/shill_main.cc
63864b6e7bda0e417d18093892ca1692ae926fe6	08-Nov-2012	Paul Stewart <pstew@chromium.org>	shill: manager: Suppress autoconnect while stopped The manager may continue to run for a short while after Manager::Stop() is called, as shutdown tasks are executed. Prevent the the AutoConnect task from running as this could be triggered as Services are disconnected. From there things can only get worse as the associated services for these devices could be in a partially removed state and cause untold mahyem. While here, print a message at the point where shill receives a signal and is shutting down. BUG=chromium-os:36149 TEST=Unit tests, kill shill with SIGTERM and make sure it shuts down correctly Change-Id: Ifb7ae1ba4114bc696958498c15b1bf082d2d0e70 Reviewed-on: https://gerrit.chromium.org/gerrit/37581 Reviewed-by: Christopher Wiley <wiley@chromium.org> Reviewed-by: mukesh agrawal <quiche@chromium.org> Commit-Ready: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org> /system/connectivity/shill/shill_main.cc
8c1706f09b15e6140b89b9a49cd599d8050380d5	31-Aug-2012	Jorge Lucangeli Obes <jorgelo@chromium.org>	Use Minijail to launch 'logger' as a regular user. BUG=chromium-os:33983 TEST=emerge shill, reboot, check that logger is running as user 'syslog'. TEST=manual, as described in https://gerrit.chromium.org/gerrit/#/c/23912/ TEST=smoke suite. Change-Id: I54068a223daeee65ff480a720b73965aaf3e64ce Reviewed-on: https://gerrit.chromium.org/gerrit/31964 Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Darin Petkov <petkov@chromium.org> Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org> /system/connectivity/shill/shill_main.cc
6e8c54b2f87df76281f43558c24f101c30622d32	16-Aug-2012	Christopher Wiley <wiley@chromium.org>	shill: Catch CHECK log messages through LOG_STREAM Remove the log handler installed by MemoryLog and catch CHECK-esque log messages by redefining the LOG_STREAM macro instead. BUG=chromium-os:31145 TEST=Unit tests Change-Id: I2462a1a0718b5c6f0b5a1a5d4a46ec23268434b5 Reviewed-on: https://gerrit.chromium.org/gerrit/30478 Tested-by: Christopher Wiley <wiley@chromium.org> Reviewed-by: Gary Morain <gmorain@chromium.org> Commit-Ready: Christopher Wiley <wiley@chromium.org> /system/connectivity/shill/shill_main.cc