| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/shims/c_ppp.cc
|
| 758dee3579a092825bf481a7610b4c7c4df99b8e |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: shims: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: I35ddebb0b9f357255a53ae62baf79e2dc661a187
Reviewed-on: https://chromium-review.googlesource.com/278077
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/shims/c_ppp.cc
|
| effb385f12068df2da38deb1e758f984f3792100 |
|
30-Jul-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
shill: fix linter issues in sub-directories
Fixed various issues reported by cpplint.py when run on
src/platform2/shill.
BUG=None
TEST=FEATURES=test emerge-link platform2
cpplint.py `find shill/* | grep "\.cc\|\.h"`
Change-Id: Ie16c9bb1f4079db0e8f9dc338937946249dbb919
Reviewed-on: https://chromium-review.googlesource.com/210504
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/connectivity/shill/shims/c_ppp.cc
|
| fc362910150ab2abeb5556d4c02adc35cf2f7aa9 |
|
07-Aug-2013 |
mukesh agrawal <quiche@chromium.org> |
shill: dongles: report PPP authentication failures correctly
Previously, any time we received a disconnect notification from
pppd, we would attempt to set our error state to indicate that
PPP authentication failed. (See below for more on "attempt to".)
This CL tightens up our disconnect handling, to identify which
disconnects are likely to be authentication failures, versus
those that are other failures. Other failures include things like
being unable to acquire an acceptable IP configuration.
We say a disconnect is an authentication failure if PPP was in
the middle of authenticating when the disconnect occurred. Otherwise,
we report kFailureUnknown.
In addition to tightening up the error reporting, this CL fixes a
case where errors would fail to be reported.
Specifically, we used to call SetServiceState, which modifies the
state of selected_service(). However, if we had not yet started
configuring IP, then there would be no selected service, and no
error would be reported.
Fix this, by falling back to |service_| in this case. Note that I
suspect that the failed error reporting is a long-standing issue,
and not specific to PPP dongles.
While there:
- Lower the priority of some log statements (from INFO to VERBOSE2).
- Uncomment a line in CelluarTest.Notify, which I'd meant to uncomment
before it originally landed.
- Improve readability of log statement in TaskProxy::Notify.
BUG=chromium:267682
TEST=(new) unit tests, manual
TEST=network_3GSmokeTest.pseudomodem
TEST=network_3GModemControl.pseudomodem
Manual testing
--------------
1. get a dongle that requires a specific PPP username/password
2. use set_cellular_ppp (in crosh), to configure an incorrect
username/password combination
3. try connecting to the cellular network
4. observe a toast-style notification with an error message
indicating a bad username or password
Change-Id: I60fa7fa9ad8901f5a19eea23b6eb44a6100a02db
Reviewed-on: https://gerrit.chromium.org/gerrit/64863
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/shims/c_ppp.cc
|
| d1bd02eeff55c908723396306ec6511ce22c3f41 |
|
25-May-2013 |
mukesh agrawal <quiche@chromium.org> |
shill: clean up PPP object management
Previously, we were creating (and deleting) a PPP object on every
call into functions of c_ppp.cc. Now, we use a LazyInstance, and
retain the PPP object until PPPOnExit.
Note that I've moved the AtExitManager from ppp.cc to c_ppp.cc,
because the AtExitManager must now clean up the PPP object as well.
BUG=chromium:242752
TEST=unit tests, manual
Manual test
-----------
- connect to CrOS_WPA2_Buffalo2_AG300H_2.4GHz
- /usr/local/lib/flimflam/test/connect-vpn l2tpipsec-psk \
Cisco-ASA-173 172.22.22.173 \
Cisco-ASA-173 chromeos_psk \
CrOS_Password <password>
- check that ppp0 has an IP address
- egrep "l2tpipsec_vpn.+pppd: local" /var/log/net.log
(should match)
Change-Id: I7171566d30f6defb8da0f445469ee809bab3fec4
Reviewed-on: https://gerrit.chromium.org/gerrit/56664
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Darin Petkov <petkov@chromium.org>
Commit-Queue: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/shims/c_ppp.cc
|
| e6ca32073238c7880a65559746c47f1adaf32061 |
|
19-Oct-2012 |
Darin Petkov <petkov@chromium.org> |
shill: l2tp/ipsec: Implement a new pppd plugin for L2TP/IPSec support.
The plugin is currently unused. This patch will be followed by an
ebuild change that installs the plugin and then by another shill
change that switches shill over to the new plugin.
BUG=chromium-os:29423
TEST=Unit tests. Tested on device by establishing L2TP/IPSec
connection and inspecting logs.
Change-Id: I6ce28b1a7e34d148c21fcc3870142bcdbbae7051
Reviewed-on: https://gerrit.chromium.org/gerrit/36052
Reviewed-by: Darin Petkov <petkov@chromium.org>
Tested-by: Darin Petkov <petkov@chromium.org>
Commit-Ready: Darin Petkov <petkov@chromium.org>
/system/connectivity/shill/shims/c_ppp.cc
|