| 289a5a5e18bb1a676b3dfce111af4c2c00c7776e |
|
21-Sep-2015 |
Samuel Tan <samueltan@google.com> |
shill: use different service_constants.h path for Android builds
Use the service_constants.h file from the external/cros/system_api/dbus
instead of chromeos/dbus/service_constants.h, since this header file
is installed into different directories when building shill for Android
and Chrome OS.
BUG: 22956441
Change-Id: I7e6ea46b4893588d2862792cf43aa83fdf7c30b4
TEST: shill still compiles using emerge.
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| 3b30ca58d13cf66b75ba0729b222ddc42ae68b33 |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Top-level unit tests: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: I86c072b89281e0de18928b47860b99d779af061a
Reviewed-on: https://chromium-review.googlesource.com/278037
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| 024a6c80bc8474d828af6d961ea7fe0d67d69587 |
|
23-Jan-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Connection: Apply connection MTU
Honor the "mtu" field in IPConfig::Properties by applying this
MTU to the interface. Apply a default MTU to interfaces that
do not specify one, and a minimum MTU if the supplied MTU will
not work for the connected IP configuration.
BUG=chromium:450759
TEST=Unit tests, Upcoming test network_DhcpMTU (CL:243315)
Change-Id: Ie7abf937b8475d43e5a77bf9f27ec58a5433fc2a
Reviewed-on: https://chromium-review.googlesource.com/243370
Reviewed-by: Prabhu Kaliamoorthi <kaliamoorthi@chromium.org>
Reviewed-by: Zeping Qiu <zqiu@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| cc225ef3b77b5e098cc12c661a947e1737480777 |
|
30-Sep-2014 |
Ben Chan <benchan@chromium.org> |
shill: Replace NULL with nullptr.
BUG=None
TEST=`USE=wimax FEATURES=test emerge-$BOARD shill`
Change-Id: I30ab47ff32dcadad09ae7a2baf4d4123a6ef0d8e
Reviewed-on: https://chromium-review.googlesource.com/220657
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| 08bf508aa612c4f73aa4692a81cf0c551c56f23b |
|
09-Sep-2014 |
Peter Qiu <zqiu@chromium.org> |
shill: Add Service property "SavedIPConfig" and "StaticIPConfig"
Both "SavedIPConfig" and "StaticIPConfig" contains a dictionary of
IP parameters. NameServers field within the dictionary is an array
of string instead of comma separated string.
This will make the saved IP and static IP properties more consistent
with the IPConfig object properties. The legacy properties
("SavedIP.*" and "StaticIP.*") can be removed once the Chrome switch
over to use these new dictionary.
Note, the names and formats of the static IP configuration saved
in the storage are not changing. This is to avoid any backward
compatibility issues.
BUG=chromium:411289
TEST=unit tests, manual test
Manual Test:
1. Connect a chrome device to "GoogleGuest", run "./list-services"
from command prompt, verify "SavedIPConfig" field for service
"GoogleGuest" contain the dictionary of IP Parameters.
2. Manually configure "GoogleGuest" with IP address and Name Servers,
run "./list-services" from command prompt, and verify "StaticIPConfig"
field for service "GoogleGuest" contain the dictionary of IP parameters
with manual configured values.
CQ-DEPEND=CL:217115
Change-Id: I6741c80d3889f15319736d34d3ca466e36874983
Reviewed-on: https://chromium-review.googlesource.com/217135
Reviewed-by: Peter Qiu <zqiu@chromium.org>
Commit-Queue: Peter Qiu <zqiu@chromium.org>
Tested-by: Peter Qiu <zqiu@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| cc67c52a2c00f90e877971d552208dd99825d84e |
|
03-Sep-2014 |
Ben Chan <benchan@chromium.org> |
shill: Include base/macros.h instead of base/basictypes.h
shill no longer uses the integer types from base/basictypes.h. It should
simply include base/macros.h for the DISALLOW_COPY_AND_ASSIGN macro
instead.
BUG=None
TEST=`USE='cellular wimax' FEATURES=test emerge-$BOARD platform2`
Change-Id: I9b350c1bd9eff88e2c87de2ef8d607e90049e102
Reviewed-on: https://chromium-review.googlesource.com/216055
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| be0849f4474f6e97496550187bc4256bf0a91d2b |
|
16-Aug-2014 |
Ben Chan <benchan@chromium.org> |
shill: Drop static specifier on constants in anonymous namespace.
BUG=None
TEST=`FEATURES=test emerge-$BOARD platform2`
Change-Id: Ic1e97a75efa16061e371573c6bf89f7d40b7efd5
Reviewed-on: https://chromium-review.googlesource.com/212800
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| 7fab89734d88724a288e96a9996b15548c5294c7 |
|
11-Aug-2014 |
Ben Chan <benchan@chromium.org> |
shill: Use integer types from stdint.h
This CL replaces the deprecated int* and uint* types from
'base/basictypes.h' with the int*_t and uint*_t types from 'stdint.h'.
BUG=chromium:401356
TEST=`USE='cellular gdmwimax wimax' FEATURES=test emerge-$BOARD platform2`
Change-Id: I3d4c195881203dd2a47dbb5af150b6c90b9c206e
Reviewed-on: https://chromium-review.googlesource.com/211770
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| 8a5322984f2d81bcbfd8d44c59747a11bd9b904b |
|
17-Jun-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
shill: Fix most of warnings from cpplint
Fix most cpplinter's warnings. On a few occasisions, the warnings
produced were false-positives, so added explicit // NOLINT comment
overrides.
There were a few instances of disallowed non-const reference usage
(reported as runtime/reference error by cpplint) for
"DBus::Error &error" which should potentially be changed
to pointers to comply with C++ coding style but I will let Shill
owners do that since there is quite a few of those and the
change isn't brain-dead simple...
BUG=None
TEST=platform2 still compiles and all unit tests pass.
Change-Id: Ic2e31896aa13d20eeb1a85dee74f3db8cccfde2e
Reviewed-on: https://chromium-review.googlesource.com/204164
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| a0ddf46e466bd4ba3d20952f0a6988c680c1af14 |
|
06-Feb-2014 |
Ben Chan <benchan@chromium.org> |
shill: Update to build against libchrome-242728.
BUG=chromium:341521
CQ-DEPEND=CL:193660
TEST=Tested the following:
1. `FEATURES=test USE='cellular wimax' emerge-$BOARD platform2`
2. Run the following tests:
- network_3GSmokeTest
- network_VPNConnect.*
- network_WiMaxSmoke
- wifi_matfunc
Change-Id: Ic1553c182ab7a833a68c45f012f646b8930cb095
Reviewed-on: https://chromium-review.googlesource.com/193606
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| 8223653e57318b02c40d018b47ea32f062734abd |
|
11-Dec-2013 |
Paul Stewart <pstew@chromium.org> |
shill: Device: Refresh Static IP configuration
This CL provides a means for Devices to update static IPConfig
properties in situations where no DHCP server exists. Previously
IPConfig properties were updated for static IP only when the
IPConfig was initially created, or when the DHCP server returned
a result. This change allows IPConfigs to be updated whenever
Chrome updates the static IP configuration paramters.
Chrome signals a static IP configuration update by calling the
"Refresh" method on the IPConfig, which will now trigger a
callback in the Device to update the IPConfig.
Methods are added in the IPConfig and StaticIPParameters to
restore the saved (pre-static-IP) configuration before applying
the new static configuration.
BUG=chromium:318290
TEST=Unittest, new autotest network_DhcpFailureWithStaticIP (CL:179783)
Change-Id: I055f27655db7ed137552e9ae8bfa93ba18b88c3d
Reviewed-on: https://chromium-review.googlesource.com/179785
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| e6e8e499adf14d9408a7e07f54b58d71ab3a9502 |
|
17-Jan-2013 |
Paul Stewart <pstew@chromium.org> |
shill: Remove PropertyStoreInspector
Remove PropertyStoreInspector, and move its methods internal to
PropertyStore. Service will soon need to inspect individual
properties, so it is time to move the inspection code out of
unit-test only code.
BUG=chromium-os:34525
TEST=Unit tests
Change-Id: I48fb7e459d2fca631a231700ee3050161b1df79b
Reviewed-on: https://gerrit.chromium.org/gerrit/41540
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| def189ec3772bdc440b1c45c2b673122d3e2789e |
|
03-Aug-2012 |
Paul Stewart <pstew@chromium.org> |
shill: Static IP: Save DHCP-supplied IP parameters
Before Static IP parameters are applied to an IPConfig, save
all DHCP-supplied parameters to corresponding "SavedIP.*"
values in the service. This way the UI can display:
* The current IP address confgured on the interface by
showing the IPConfig value.
* The current user-supplied static IP parameter by showing
the "StaticIP.*" parameter.
* The DHCP-supplied IP parameter by first checking for a
"SavedIP.*" parameter, failing that, using the IPConfig
parameter.
BUG=chromium-os:33223
TEST=New unit test + manual (set StaticIP.Address parameter,
reconnect, and confirm that both SavedIP.Address and StaticIP.Address
parameters are set on the service)
Change-Id: I6410b003bbdc63097a193cfb09881c862dcef5bd
Reviewed-on: https://gerrit.chromium.org/gerrit/29130
Commit-Ready: Paul Stewart <pstew@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| 4682aa877598abf04e7ae0f13aa4166cac90be9d |
|
31-May-2012 |
Darin Petkov <petkov@chromium.org> |
shill: Avoid double gets of property store values when iterating.
Cleanup and simplify the property iterator classes by removing the
unused PropertyConstIterator class and caching the property
value. This way we avoid deriving property values twice when iterating
through properties. Also, remove some incorrect and unused logic in
the PropertyStoreInspector related to handling errors coming from the
property store iterators.
BUG=chromium-os:30373
TEST=unit tests
Change-Id: Ie6ba2696f070e1ed43997f17273f48360f85055b
Reviewed-on: https://gerrit.chromium.org/gerrit/24201
Tested-by: Darin Petkov <petkov@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Ready: Darin Petkov <petkov@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|
| 1062d9deedace1cf4b3b374c5d40c53047fd6778 |
|
27-Apr-2012 |
Paul Stewart <pstew@chromium.org> |
shill: Allow service override of DHCP-derived IP parameters
Create new class StaticIPParameters which encapsulates all of the
property handling for RPC and storage, as well as applying parameters
to an IPConfig::Properties element. When a DHCP request succeeds
these parameters are used to selectively override values gained from
DHCP with those specified on the service.
BUG=chromium-os:23930
TEST=New unit tests -- manual testing is pending
Change-Id: I3b784f897ec6ffe0c78f2efe615d07d8f8924add
Reviewed-on: https://gerrit.chromium.org/gerrit/21448
Commit-Ready: Paul Stewart <pstew@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/static_ip_parameters_unittest.cc
|