| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/testing.h
|
| fa3043cd7dfabf084ee2daa177d197cf67fd3cd6 |
|
17-Jul-2015 |
Samuel Tan <samueltan@chromium.org> |
shill: refactor ErrorType matcher to shill/testing.h
Refactor the ErrorType matcher, which is used in several
shill unit tests, to shill/testing.h. Also, rename the matcher
to ErrorTypeIs to be consistent with other matchers in the
same file.
BUG=None.
TEST=Compile shill and run unit tests.
Change-Id: Iffe5096f3cad1ae3c91d46f6ad5257590c38c090
Reviewed-on: https://chromium-review.googlesource.com/286540
Tested-by: Samuel Tan <samueltan@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Samuel Tan <samueltan@chromium.org>
/system/connectivity/shill/testing.h
|
| d31fb5812df751f0bfac41e2c0489e1a8a18cfd7 |
|
15-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: refactor KeyValueStore internal data structures
Use a single chromeos::VariantDictionary to store all key value
pairs instead of having one map per data type.
Also overload the == and != operators for equality comparison
when KeyValueStore is wrapped inside a chromeos::Any object, which
is needed for nested KeyValueStore.
BUG=chromium:510238
TEST=USE="asan clang" FEATURES=test emerge-$BOARD shill
Change-Id: I8b014d602b9d67538a86d0f5e0fdd1fb07556533
Reviewed-on: https://chromium-review.googlesource.com/285930
Reviewed-by: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/testing.h
|
| 1a212a6b98b22ad1d69652bb26a9e94138635476 |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Top-level files n-v: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: I8bd6f66ea185ca3a2687986f6f2fd99be957dffe
Reviewed-on: https://chromium-review.googlesource.com/278070
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/testing.h
|
| cd47732488cd101eaf0d3558dde5a7d4e4fc260b |
|
17-Oct-2014 |
Ben Chan <benchan@chromium.org> |
shill: Replace scoped_ptr with std::unique_ptr.
BUG=None
TEST=`USE='wimax' FEATURES=test emerge-$BOARD shill`
TEST=`USE='wimax clang asan' FEATURES=test emerge-$BOARD shill`
Change-Id: Id9737d9a9c75ecb6abb466b5559ff06dcf0751cd
Reviewed-on: https://chromium-review.googlesource.com/224138
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/testing.h
|
| 303f65324659b1bbe5ad0b8d2664d8892169eae8 |
|
30-Aug-2014 |
Prathmesh Prabhu <pprabhu@chromium.org> |
shill: cellular: mock proxy objects fail DBus calls synchronously by default.
This CL introduces a new mock action to pick out the (shill::Error *) argument
passed to mock DBus proxy objects, and set it to a particular error type.
This mock action is used to set default behaviour of all cellular related mock
proxies to fail DBus method calls synchronously. This is the only sensible
default behaviour because a successful DBus calls requires a continuation in the
form of a callback to report result.
Before this CL, the error argument was left untouched by default, i.e., the
error returned was Error::kSuccess. This behaviour has now changed to return
Error::kOperatorFailed.
BUG=chromium:409386
TEST=Run shill unittests.
CQ-DEPEND=CL:215791
Change-Id: I9f00f9fa4b70936ed1ff697a8e8524f389882433
Reviewed-on: https://chromium-review.googlesource.com/215790
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
/system/connectivity/shill/testing.h
|
| f286034f95c44f177148f6df15407632da8e55fb |
|
09-May-2014 |
Paul Stewart <pstew@chromium.org> |
shill: Service Unittest: Use IsRefPtrTo()
Move the IsRefPtrTo() macro from manager_unittest over to
testing.h. Use it in service_unittest for reference pointer
comparisons in expectations that are sometimes picky about
passing service subclass refptrs.
BUG=None
TEST=Unit tests
Change-Id: I9fe67cc2c872763062fb9a2d5ce80c549628297d
Reviewed-on: https://chromium-review.googlesource.com/199146
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/testing.h
|
| d4f26486b237fae831d4b682481de785fc99c66e |
|
26-Apr-2014 |
Paul Stewart <pstew@chromium.org> |
shill: Device: Report IPv6 address
Have the Device query DeviceInfo for the primary IPv6 address
every time DeviceInfo notifies it of a change. Use the output
of this to add another IPConfig object to the list reported if
this address exists.
While here, emit a property change event from the "IPConfigs"
property if either the IPv4 or IPv6 ipconfigs change.
BUG=chromium:365883
TEST=Unit tests, upcoming change to network_Ipv6SimpleNegotiation
(CL:197394). Manual: list-ipconfigs while connected to a network
that supplies IPv6 global prefixes.
Change-Id: I28771acd3e990a9bea7f5988cc382a5cd9e91f1f
Reviewed-on: https://chromium-review.googlesource.com/197304
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/testing.h
|
| be277dd19182e3de5422fd5ea5094053e88a396f |
|
06-Feb-2014 |
Ben Chan <benchan@chromium.org> |
shill: Consolidate error matchers.
This CL consolidates error matchers in various unit tests into testing.h
to avoid code duplication.
BUG=None
TEST=Build and unit tests.
Change-Id: If941e845bfc44ef550e0f892fe71ea1a60195876
Reviewed-on: https://chromium-review.googlesource.com/185087
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/testing.h
|
| a55469db27a5b7c46af9fb1cfb727f2989059925 |
|
28-Jan-2014 |
Ben Chan <benchan@chromium.org> |
shill: Replace TestProxyFactory variants with MockProxyFactory.
This CL reduces the number of TestProxyFactory variants in unit tests as
follows:
- Add a ReturnAndReleasePointee Google Mock action, which can be used
with EXPECT_CALL on MockProxyFactory, to mimic how TestProxyFactory
handles the scoped_ptr of mock proxies.
- Use MockProxyFactor with EXPECT_CALL to mimic
TestProxyFactory::Create*Proxy methods.
- Check arguments passed to MockProxyFactory::Create*Proxy() via
EXPECT_CALL.
BUG=chromium:338623
TEST=`FEATURES=test emerge-{x86,amd64,arm}-generic shill`
Change-Id: Ieb0689f76feb105a2d1efaf1e7c52b4bc15fb8d7
Reviewed-on: https://chromium-review.googlesource.com/184033
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/testing.h
|