| 78fcf66c1747ed6cc067e764ac3e39e12d6b103b |
|
20-Jan-2016 |
Steve Fung <stevefung@google.com> |
crash_reporter: Fix unit tests to use ScopedTempDir
Some of the unit tests manually create their own temp
directories from a relative path. This creates a temp folder
in the folder that the test is run from. This is a problem
when using test_droid or a non-interactive ADB shell command,
since the root directory is not writable. Instead use a
ScopedTempDir to handle temporary folders.
Bug: 26671657
Change-Id: Iaf71d345565dcb4393e80426784a864f7f8b5929
Test: Unit tests pass when running brillo_WhitelistedGtests
/system/core/crash_reporter/crash_collector_test.cc
|
| 8ed101bab5d01b1ab0c648586c1d5259404b79c4 |
|
03-Dec-2015 |
Steve Fung <stevefung@google.com> |
crash_reporter: Fix unit tests
- Removed obsolete unit tests.
- Fix remaining unit tests for Android.
Change-Id: I1665447d375178d2bcf941fec3585c8f96cd2bac
/system/core/crash_reporter/crash_collector_test.cc
|
| 74dc62460b8cdd5bfeac47bfe8e759fc04b55ef8 |
|
13-Oct-2015 |
Alex Vakulenko <avakulenko@google.com> |
system/core: Rename "chromeos" -> "brillo" in include paths and namespaces
libchromeos is transitioning to libbrillo and chromeos namespaces
and include directory is changing to brillo.
Bug: 24872993
Change-Id: I797613a38c7444a113f12e38366a424388477276
/system/core/crash_reporter/crash_collector_test.cc
|
| 6c34c2576eb241f134431b2cc847a6c7d70ef012 |
|
20-Aug-2015 |
Steve Fung <stevefung@google.com> |
crash_reporter: Relicense as Apache 2.
MODULE_LICENSE_BSD and NOTICE were removed as the license is no longer
different from the rest of system/core.
Bug: 23368756
Change-Id: I31e48eb7c3d153c7c5ec4f694c61474dedac2eeb
/system/core/crash_reporter/crash_collector_test.cc
|
| ab2ac7d11442975f700bbde5702a96d020d82254 |
|
15-Aug-2015 |
Steve Fung <stevefung@google.com> |
crash_reporter: Enable core dumps
Fix various path/directory locations to their Android equivalents
to enable collection of core dumps and generation of mini dumps
to work correctly. Also add the init script to initialize
crash_reporter.
Bug: 22874832
Change-Id: Iffb1529e5259c5da5ba7f6977b2787e738f68a78
/system/core/crash_reporter/crash_collector_test.cc
|
| c8b741428caeb01f7aca3c4c199e5f6894d335f8 |
|
06-Aug-2015 |
Steve Fung <stevefung@google.com> |
crash_reporter: Remove Chrome collector, CrOS build files, DBus
Removed the ChromeOS specific code so that the code compiles. The code
removed is not needed when running on Android, and includes:
* Chrome collector
* ChromeOS build's gyp file
* ChromeOS-specific DBus calls
* ChromeOS-specific collector path logic
* Chrome bypass logic in user collector
Bug: 22672752
Change-Id: I3c7d87c971a181d8f73293519318e3602d142927
/system/core/crash_reporter/crash_collector_test.cc
|
| 129bea543b7572bfdf09c6a7b3cebbe3b57ce723 |
|
23-Jul-2015 |
Steve Fung <stevefung@google.com> |
crash_reporter: Fix header include paths
Fix the header include paths to be relative to the crash_reporter
base folder.
Bug: 22873331
Change-Id: Icdd0495a79cd7679f38c54a84e189bfb3c9d7f1c
/system/core/crash_reporter/crash_collector_test.cc
|
| 6e13952269ad729594f2670b889bd806e9b0f3b3 |
|
05-Feb-2015 |
Steve Fung <stevefung@chromium.org> |
crash: Remove glib from crash_reporter
As part of the minimization effort, refactor crash_reporter code to
not depend directly on glib.
BUG=brillo:87, brillo:88, chromium:435314
TEST=`FEATURES=test emerge-panther libchromeos debugd crash-reporter`
TEST=Enabled crash reports; Browsed to chrome://crash; crash files \
generated; `FORCE_OFFICIAL=1 SECONDS_SEND_SPREAD=1 crash_sender` \
/var/log/messages shows crash id, report shows all expected files
TEST=`cbuildbot --remote -p chromiumos/platform2 amd64-generic-full`
CQ-DEPEND=I00331e0bf29195b41cd84d4495ab47738a5a41de
CQ-DEPEND=I9df752d8995773adb56fab34dd97626f3ddf1765
Change-Id: I48b366198a7f89ca55259603cf8470e4d59321bf
Reviewed-on: https://chromium-review.googlesource.com/246441
Reviewed-by: Dan Erat <derat@chromium.org>
Tested-by: Steve Fung <stevefung@chromium.org>
Commit-Queue: Steve Fung <stevefung@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| 731da3379bd7ead7222b1a7add45e307bec7c865 |
|
28-Jan-2015 |
Daniel Erat <derat@chromium.org> |
crash-reporter: Use chromeos::KeyValueStore.
Make the crash reporter use libchromeos's KeyValueStore
class to read its log-collection config file and
/etc/lsb-release instead of its own parsing code.
Also update the log-collection config file to split long
commands across multiple lines and to use '=' instead of ':'
to separate executable names from commands.
BUG=chromium:452520
TEST=updated tests; also triggered powerd and chrome crashes
and checked that logs were attached
Change-Id: I4e2447712869608f32a4ae38f5d5cb9c6046af14
Reviewed-on: https://chromium-review.googlesource.com/244121
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| d257ea1cbeb0d61fe73a2aef8f3f8feca5402a3c |
|
28-Jan-2015 |
Daniel Erat <derat@chromium.org> |
crash-reporter: Clean up testing code.
Link all of the crash reporter's tests into a single
crash_reporter_test executable instead of building separate
binaries that lead to a bunch of duplication.
BUG=none
TEST=tests pass
CQ-DEPEND=I7f6623dd0ae36395efac89bdcfae54926ea6c918
Change-Id: I18e2d929d6545e7d05e88232bdaec089ae620544
Reviewed-on: https://chromium-review.googlesource.com/243940
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Trybot-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| ab6cc90503ca2db976a3cb9c9382a9da85c4b5a2 |
|
05-Sep-2014 |
Ben Chan <benchan@chromium.org> |
Update code to include base/files/file_util.h
file_util.h was moved from base to base/files
(https://codereview.chromium.org/468253002). This CL updates platform2
code to include base/files/file_util.h instead of base/file_util.h.
BUG=chromium:411001
TEST=Trybot run on paladin, release, and chromiumos-sdk builders.
Change-Id: I488925b54615e131e508a460dc1a27f88168f936
Reviewed-on: https://chromium-review.googlesource.com/216851
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| 7e77690375bc8a896a8de318d69d515e67c7aefe |
|
18-Jun-2014 |
Ben Chan <benchan@chromium.org> |
crash-reporter: Fix coding style and cpplint issues.
BUG=chromium:385849
TEST=`FEATURES=test emerge-$BOARD platform2`
TEST=`cpplint.py --filter=--build/header_guard,-build/include_order *.h *.cc`
Change-Id: I3c24dd9487df50cdb22fc1c7739c9e95e452afae
Reviewed-on: https://chromium-review.googlesource.com/204487
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| f30c641225e55055641ffe3fd679a96e44f34af6 |
|
23-May-2014 |
Ben Chan <benchan@chromium.org> |
crash-reporter: Update to build against libchrome-271506.
BUG=chromium:375032
TEST=`FEATURES=test emerge-$BOARD platform2`
Change-Id: I3984dee513690711e277e5fa8939ca5f7910d180
Reviewed-on: https://chromium-review.googlesource.com/201184
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| 9b1f300139689eb9c7b7a35e91a4fbc1eab93b4e |
|
24-Apr-2014 |
Lei Zhang <thestig@chromium.org> |
crash-reporter: Write out a magic string for Chrome crashes.
Also do some much needed code cleanup.
BUG=chromium:363660
TEST=emerge platform2
Change-Id: Ica9abfd854e2c77d970851805989c86a6a45fdee
Reviewed-on: https://chromium-review.googlesource.com/196764
Commit-Queue: Lei Zhang <thestig@chromium.org>
Tested-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| a557c1187ff19d422db2a9c951ecd8f7243e79bd |
|
06-Feb-2014 |
Mike Frysinger <vapier@chromium.org> |
update to libbase-242728
BUG=chromium:331128
TEST=`FEATURES=test emerge-x86-alex platform2` works
TEST=`cbuildbot chromiumos-sdk` works
CQ-DEPEND=CL:185131
Change-Id: Ia03a6ea7aaf6b4ee5d9c512ebf7080c0c28920f1
Reviewed-on: https://chromium-review.googlesource.com/185150
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| 83ce73eac51b219dc1d112683149c486722e65c5 |
|
24-Jan-2014 |
Mike Frysinger <vapier@chromium.org> |
remove unused gflags includes
These files don't use gflags, so drop the includes.
BUG=chromium:337753
TEST=`FEATURES=test emerge-x86-alex crash-reporter` passes
Change-Id: I0a57e45cd16cd37b1361858e3313d59dced4eb5e
Reviewed-on: https://chromium-review.googlesource.com/183644
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| 62b0c42baf898e06ca19660dbc902c58f6a57267 |
|
22-Oct-2013 |
Ben Chan <benchan@chromium.org> |
crash-reporter: Remove unused constants reported by clang.
BUG=chromium:309859
TEST=`FEATURES=test USE=clang emerge-lumpy crash-reporter`
Change-Id: Ie6f78ad420322f44ce0c108cb23de299981f60a4
Reviewed-on: https://chromium-review.googlesource.com/173937
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| 37843a9f8a46cd5afa57505bdb6d75aa1a75c9d2 |
|
11-Jun-2013 |
Mike Frysinger <vapier@chromium.org> |
crash_collector: add /crash to the user crash path
The recent multiprofile work forgot to append /crash to the user-specific
crash path. It was in the fallback path, but not the dynamic one.
BUG=chromium:248629
TEST=`cros_run_unit_tests --board=x86-alex -p crash-reporter` works
TEST=`cbuildbot x86-generic-full` works
Change-Id: If87848526b0e78f3f76fd412b0f46e37b7022bd6
Reviewed-on: https://gerrit.chromium.org/gerrit/58232
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| f19b518532cb2ab8fc1ed77381809f24a30ac4ca |
|
18-May-2013 |
Mike Frysinger <vapier@chromium.org> |
add support for multiprofile
Update crash_sender to scan /home/chronos/u-*/crash/ paths since it's
a shell script and there's no easy way to get the right info via shell
commands. We want to scan all paths in case of different ordering.
For crash_collector, update it to use SessionManager's dbus call to
query the active profiles. We select the first one and use that to
process crashes. This should be fine.
We also need to handle the edge case where no user is logged in (yet a
crash occurs with a program running as chronos uid; e.g. the login).
In the past, we just wrote to /home/chronos/user/crash/ even when there
wasn't a user home dir mounted there. With this change, we formalize
(and document) things a bit more by moving to /home/chronos/crash/. We
want this behavior rather than re-using the system path as our tests
specifically verify system vs user crashes.
BUG=chromium:221778
TEST=`cros_run_unit_tests --board=x86-alex -p crash-reporter` passes
TEST=logging_UserCrash autotest passes in a vm
CQ-DEPEND=CL:56112
CQ-DEPEND=CL:57067
Change-Id: If9f2ffd0740533537718b2a5e7d215200f5a41d6
Reviewed-on: https://gerrit.chromium.org/gerrit/55600
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| 9f90acaa4d420530d7b4ddd37112518df68e373a |
|
20-Feb-2013 |
Simon Que <sque@chromium.org> |
Replace FilePath declaration with file_path.h include
Fixes a clang error. Also use "base::FilePath" since FilePath has been
moved to the base namespace.
BUG=chromium-os:39046
TEST=The following command passes:
USE="chrome_internal" CFLAGS="-clang -print-cmdline"
CXXFLAGS="-clang -print-cmdline" emerge-x86-alex crash-reporter
Change-Id: I7da82093c5685b5b556cba971b1e1b14ac0f59c4
Signed-off-by: Simon Que <sque@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/43577
Reviewed-by: Ben Chan <benchan@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| 57b261cf04f45d67b02f6bea8ad2c37734da86e0 |
|
11-Apr-2012 |
Mike Frysinger <vapier@chromium.org> |
update to newer libbase
BUG=chromium-os:25872
TEST=`emerge-x86-alex crash-reporter` works
TEST=`cros_run_unit_tests --board=x86-alex -p crash-reporter` passed
Change-Id: Iff428b1364f96533d2d2290272823c2c84c48933
Reviewed-on: https://gerrit.chromium.org/gerrit/20008
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
/system/core/crash_reporter/crash_collector_test.cc
|
| a324932e066ccb7ed9d62db9c409ee2c10052554 |
|
03-Mar-2011 |
Ken Mixter <kmixter@google.com> |
crash-reporter: Use standard logging and new libchromeos Process code
Change-Id: Ie085d61d4d79c0df38e51debaa044d701a860c89
BUG=none
TEST=unit tests / UserCrash / CrashSender
Review URL: http://codereview.chromium.org/6517001
/system/core/crash_reporter/crash_collector_test.cc
|
| 1b8fe015585c0b966d5240b8e22eba1af8c69e88 |
|
25-Jan-2011 |
Ken Mixter <kmixter@chromium.org> |
crash-reporter: Add diagnostics to help diagnose failures in the wild
We add logging messages that are generated during invocation of core2md, but we also enable sending arbitrary system info based on the configuration file. In this case we add the list of running processes, meminfo, and dmesg.
Change-Id: Ifdf29b89dd60d56349fa39095d2aa07f6b5e2de2
BUG=chromium-os:6299,chromium-os:9345
TEST=UserCrash, unit tests
Review URL: http://codereview.chromium.org/6297004
/system/core/crash_reporter/crash_collector_test.cc
|
| c49dbd4775986f32b2f09659595f9f28ef7f6b44 |
|
15-Dec-2010 |
Ken Mixter <kmixter@chromium.org> |
crash-reporter: Capture and send recent update_engine logs when it crashes
We also disallow more than 4 nested crashes. This way we know if core2md crashes for instance, but not if crash_reporter crashes while handling the core2md crash that came from crash_reporter. Note that the kernel does not know about parent/child process relationships, it just counts concurrent handling, so it is possible that some of many crashing processes will be discarded.
See crash report id 473c22ed428d33a9 for an example report with update_engine logs.
Change-Id: I9ff9f03a94dc87d2d42840511c2e5e42ee37cea8
BUG=9176
TEST=UserCrash,CrashSender,unit tests
Review URL: http://codereview.chromium.org/5814001
/system/core/crash_reporter/crash_collector_test.cc
|
| 9b346474538a255bc7144ae358bb0ee129163d58 |
|
07-Nov-2010 |
Ken Mixter <kmixter@chromium.org> |
crash-reporter: Avoid writing through symlinks.
BUG=7987
TEST=bvts
Change-Id: I875adeb5073936e790beb93f6a223a1642131cbd
Review URL: http://codereview.chromium.org/4603001
/system/core/crash_reporter/crash_collector_test.cc
|
| 207694d3f491ef602a859c30cc1379584f2d61cf |
|
29-Oct-2010 |
Ken Mixter <kmixter@chromium.org> |
crash-reporter: write conversion failure diagnostics into fake dmp files
Change-Id: I9f1ca92def3e1d0fa43b3bef0f2a72d367953926
BUG=6299,7782
TEST=bvts
Review URL: http://codereview.chromium.org/4088003
/system/core/crash_reporter/crash_collector_test.cc
|
| afcf80821c57a189b53b7a66f76d13855d63821e |
|
26-Oct-2010 |
Ken Mixter <kmixter@chromium.org> |
crash-reporter: Generate kernel crash signatures for server-side grouping of similar crashes
BUG=5868
TEST=KernelCrash, UserCrash, CrashSender, unittests, and manual inspection of sent report.
Change-Id: I31991895c9ac719ac1832d588ae3360500ef0c26
Review URL: http://codereview.chromium.org/4018008
/system/core/crash_reporter/crash_collector_test.cc
|
| ee849c5ef4c416cb0321483fa10c92f8aada3179 |
|
01-Oct-2010 |
Ken Mixter <kmixter@chromium.org> |
Add meta files to crash directory, enabling OS version at crash time.
Adding meta files also:
1) ensures atomically added crash reports
2) allows us to remove orphaned crash report payload files
(such as core files)
3) gives us better control over the number of reports in
crash directory
While we're here, also made these minor changes
1) send board (x86-generic, x86-mario, etc) to crash server
2) send hwclass to crash server
3) Only record crash reports when metrics are enabled.
4) No longer allow crash reporting to staging server.
BUG=6100,5805,5624,6865
TEST=unit tests plus UserCrash,CrashSender,KernelCrash autotests
Change-Id: Ieea9bdc8e0680b379c65b91cc56ca0611dd0f31c
Review URL: http://codereview.chromium.org/3436029
/system/core/crash_reporter/crash_collector_test.cc
|
| 04ec10fc93b08057657503559ecf511661b55c9f |
|
27-Aug-2010 |
Ken Mixter <kmixter@google.com> |
Limit the number of crash reports to enqueue at once
BUG=5357
Change-Id: Ib21086cdd34c938def885d625a165ba2fa0879a4
Review URL: http://codereview.chromium.org/3209003
/system/core/crash_reporter/crash_collector_test.cc
|
| 0340316050044e0995b98fea87ed41ea77abb28b |
|
19-Aug-2010 |
Ken Mixter <kmixter@google.com> |
Collect and send kernel crash diagnostics
BUG=1512,1914
Review URL: http://codereview.chromium.org/3179006
/system/core/crash_reporter/crash_collector_test.cc
|