History log of /system/core/crash_reporter/user_collector.h
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
773fd3c42883b17b5918c71aead5690e16438248 10-Oct-2015 Steve Fung <stevefung@google.com> crash_reporter: Use the actual GID of the crashing process

Rather than assuming the UID and GID of crashing processes is
the same, report and use the actual GID that the process was
running as.

Bug: 24678424
Change-Id: I3cfc415be2feb2863a4f4b850bfd4a3267217a44
/system/core/crash_reporter/user_collector.h
6c34c2576eb241f134431b2cc847a6c7d70ef012 20-Aug-2015 Steve Fung <stevefung@google.com> crash_reporter: Relicense as Apache 2.

MODULE_LICENSE_BSD and NOTICE were removed as the license is no longer
different from the rest of system/core.

Bug: 23368756
Change-Id: I31e48eb7c3d153c7c5ec4f694c61474dedac2eeb
/system/core/crash_reporter/user_collector.h
ab2ac7d11442975f700bbde5702a96d020d82254 15-Aug-2015 Steve Fung <stevefung@google.com> crash_reporter: Enable core dumps

Fix various path/directory locations to their Android equivalents
to enable collection of core dumps and generation of mini dumps
to work correctly. Also add the init script to initialize
crash_reporter.

Bug: 22874832
Change-Id: Iffb1529e5259c5da5ba7f6977b2787e738f68a78
/system/core/crash_reporter/user_collector.h
c8b741428caeb01f7aca3c4c199e5f6894d335f8 06-Aug-2015 Steve Fung <stevefung@google.com> crash_reporter: Remove Chrome collector, CrOS build files, DBus

Removed the ChromeOS specific code so that the code compiles. The code
removed is not needed when running on Android, and includes:
* Chrome collector
* ChromeOS build's gyp file
* ChromeOS-specific DBus calls
* ChromeOS-specific collector path logic
* Chrome bypass logic in user collector

Bug: 22672752
Change-Id: I3c7d87c971a181d8f73293519318e3602d142927
/system/core/crash_reporter/user_collector.h
129bea543b7572bfdf09c6a7b3cebbe3b57ce723 23-Jul-2015 Steve Fung <stevefung@google.com> crash_reporter: Fix header include paths

Fix the header include paths to be relative to the crash_reporter
base folder.

Bug: 22873331
Change-Id: Icdd0495a79cd7679f38c54a84e189bfb3c9d7f1c
/system/core/crash_reporter/user_collector.h
d6169a2a4f775da37ffa8b8ba4d767efd0377343 12-Aug-2014 Steve Fung <stevefung@chromium.org> crash-reporter: remove gflags dependency

We are switching to using chromeos/flag_helper.h instead to standardize the
code everywhere.

BUG=chromium:402631
TEST=`FEATURES=test emerge-panther crash-reporter`
TEST=`test_that -b panther <ip> e:logging_.*`

Change-Id: I62b911a54f89d853235d0540460cbea119f66e9e
Reviewed-on: https://chromium-review.googlesource.com/212140
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Steve Fung <stevefung@chromium.org>
Commit-Queue: Steve Fung <stevefung@chromium.org>
/system/core/crash_reporter/user_collector.h
895fa5d99f4187d67eee807cf7812d1af9853b49 03-Sep-2014 Ben Chan <benchan@chromium.org> crash-reporter: Include base/macros.h instead of base/basictypes.h

crash-reporter no longer uses the integer types from base/basictypes.h.
It should simply include base/macros.h for the DISALLOW_COPY_AND_ASSIGN
macro instead. This CL also marks several classes
DISALLOW_COPY_AND_ASSIGN.

BUG=None
TEST=`FEATURES=test emerge-$BOARD crash-reporter`

Change-Id: I02c90916fdda63c4d4134ed87b13382ed2fbab26
Reviewed-on: https://chromium-review.googlesource.com/216009
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
/system/core/crash_reporter/user_collector.h
efec0b3625f447995d2ed79b946d2929039313c9 12-Aug-2014 Ben Chan <benchan@chromium.org> crash-reporter: Use C++11 override specifier.

Also remove some unnecessary 'void' arguments.

BUG=None
TEST=`FEATURES=test emerge-$BOARD crash-reporter`

Change-Id: I0039aec93aae14cb238f284fda756b631f9c1587
Reviewed-on: https://chromium-review.googlesource.com/211959
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
/system/core/crash_reporter/user_collector.h
7e77690375bc8a896a8de318d69d515e67c7aefe 18-Jun-2014 Ben Chan <benchan@chromium.org> crash-reporter: Fix coding style and cpplint issues.

BUG=chromium:385849
TEST=`FEATURES=test emerge-$BOARD platform2`
TEST=`cpplint.py --filter=--build/header_guard,-build/include_order *.h *.cc`

Change-Id: I3c24dd9487df50cdb22fc1c7739c9e95e452afae
Reviewed-on: https://chromium-review.googlesource.com/204487
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/core/crash_reporter/user_collector.h
a557c1187ff19d422db2a9c951ecd8f7243e79bd 06-Feb-2014 Mike Frysinger <vapier@chromium.org> update to libbase-242728

BUG=chromium:331128
TEST=`FEATURES=test emerge-x86-alex platform2` works
TEST=`cbuildbot chromiumos-sdk` works
CQ-DEPEND=CL:185131

Change-Id: Ia03a6ea7aaf6b4ee5d9c512ebf7080c0c28920f1
Reviewed-on: https://chromium-review.googlesource.com/185150
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
/system/core/crash_reporter/user_collector.h
426fcc0bd579a87102ea50fb570dbf9834fa2962 03-May-2013 Albert Chaulk <achaulk@chromium.org> Handle Chrome crashes

Chrome will be modified to pass crashes to crash_reporter via a specially
formatted file, a TLV-style designed to be easily parsed, instead of
multipart/form-data. Extra attributes are added into the .meta file.

BUG=chromium:187808
TEST=new unit tests created

Change-Id: I0d65d118e0e348329d14bb4004c8f7bad5a44a97
Reviewed-on: https://gerrit.chromium.org/gerrit/49972
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Tested-by: Albert Chaulk <achaulk@chromium.org>
/system/core/crash_reporter/user_collector.h
9f90acaa4d420530d7b4ddd37112518df68e373a 20-Feb-2013 Simon Que <sque@chromium.org> Replace FilePath declaration with file_path.h include

Fixes a clang error. Also use "base::FilePath" since FilePath has been
moved to the base namespace.

BUG=chromium-os:39046
TEST=The following command passes:
USE="chrome_internal" CFLAGS="-clang -print-cmdline"
CXXFLAGS="-clang -print-cmdline" emerge-x86-alex crash-reporter

Change-Id: I7da82093c5685b5b556cba971b1e1b14ac0f59c4
Signed-off-by: Simon Que <sque@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/43577
Reviewed-by: Ben Chan <benchan@chromium.org>
/system/core/crash_reporter/user_collector.h
1c57e9e330bc4c6a44955fd649ee9a4badb9e1dc 26-Sep-2012 Michael Krebs <mkrebs@chromium.org> crash-reporter: Remove some dependency on /proc

Make the existence of a crashing process's /proc/<PID>/ directory optional
for all of crash_reporter, except for core2md. In particular, have the
kernel pass the UID of the crashing process to crash_reporter in case the
"status" file is unavailable.

BUG=chromium-os:34385
TEST=Ran unittests and autotests
CQ-DEPEND=I6048d3eb84f8188bee6a755eaa010510f5d2459b

Change-Id: I62df52cab44cf1febc7ed3e55b75bcffa0daf524
Reviewed-on: https://gerrit.chromium.org/gerrit/34078
Commit-Queue: David James <davidjames@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
Tested-by: David James <davidjames@chromium.org>
/system/core/crash_reporter/user_collector.h
6e709a11031c80c96f47da50b3231074334f462c 29-Feb-2012 Ben Chan <benchan@chromium.org> Improve error diagnostics in UserCollector.

This CL makes the following changes to improve error diagnostics in
UserCollector:
1. Add an error type to describe why the crash reporter fails to
collects a user crash, which is reported to the crash server along
with the "crash_reporter-user-collection" error signature.
2. Perform some preliminary validations of the core file before
converting it to a minidump file using core2md.
3. Identify the case when a 32-bit core file is produced on a 64-bit
platform as core2md currently cannot handle 32-bit core files on
a 64-bit platform.

BUG=chromium-os:7871
TEST=Tested the following:
1. emerge-{x86,amd64,arm}-generic crash-reporter
2. FEATURES="test" emerge-{x86,amd64,arm}-generic crash-reporter
3. Run the following autotest tests on x86-mario and stumpy64:
- logging_CrashSender
- logging_UserCrash

Change-Id: Ib50b4cc81a91f7cd75f9440005200d4027ce1f6f
Reviewed-on: https://gerrit.chromium.org/gerrit/17166
Reviewed-by: Michael Krebs <mkrebs@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Ready: Ben Chan <benchan@chromium.org>
/system/core/crash_reporter/user_collector.h
f13bb58358b879258c5c0eb48c6e09895d394ef1 06-Jan-2012 Ben Chan <benchan@chromium.org> crash-reporter: Validate proc files and log the state of crashed process.

This CL makes the following changes to UserCollector:
1. Check if the maps file is empty after copying proc files to the
temporary container directory, which prevents the core-to-minidump
conversion failure due to unusable maps file.
2. Obtain and log the state of the crashed process, which helps
determine if the crashed process is in the zombie state.
3. Refactor the status file processing code.

BUG=chromium-os:24820
TEST=Tested the following:
1. Build crash-reporter and run unit tests.
2. Run the following autotest tests on a Cr48:
- logging_CrashSender
- logging_UserCrash
3. Check that the process state of a crashed process is logged in
/var/log/messages.

Change-Id: Iebaf9c36c18185c703c18e7028ee4673dd9ebc93
Reviewed-on: https://gerrit.chromium.org/gerrit/13826
Reviewed-by: Ken Mixter <kmixter@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Ready: Ben Chan <benchan@chromium.org>
/system/core/crash_reporter/user_collector.h
4fe30db1405498dd21162436eda081486f400fa8 05-Aug-2011 Michael Krebs <mkrebs@chromium.org> crash-reporter: Dump crashes outside of cryptohome during autotests.

If the file "/mnt/stateful_partition/etc/collect_chrome_crashes" exists on
the target, dump crashes to /var/spool/crash/ instead of
/home/chronos/user/crash/. This is so they are easily available even after
logout.

BUG=chromium-os:18637
TEST=Ran unit and remote tests.

Change-Id: I340bbb0c1772123192c8bb87872bcda53fae5524
Reviewed-on: http://gerrit.chromium.org/gerrit/5419
Reviewed-by: Ken Mixter <kmixter@chromium.org>
Tested-by: Michael Krebs <mkrebs@chromium.org>
/system/core/crash_reporter/user_collector.h
538ecbf7d5f4011440c45b27e84902f5953b1f82 27-Jul-2011 Michael Krebs <mkrebs@chromium.org> Don't ignore chrome crashes when autotesting.

If the file "/mnt/stateful_partition/etc/collect_chrome_crashes" exists on
the target, allow chrome crashes to be reported by crash reporter. The
intention is that the autotest system will create this file. This is a
relatively temporary fix to help track down chrome problems, until the
crashes can be handled by crash reporter in the field as well.

BUG=chromium-os:17987, chromium-os:17898
TEST=Ran unit tests.

Change-Id: I68a584a0b861669117d8e97f5687b4c8fc876011
Reviewed-on: http://gerrit.chromium.org/gerrit/4861
Reviewed-by: Ken Mixter <kmixter@chromium.org>
Tested-by: Ken Mixter <kmixter@chromium.org>
/system/core/crash_reporter/user_collector.h
5d3a1a2c3543db21913f67cf240bad6c137063c9 16-Mar-2011 Ken Mixter <kmixter@google.com> crash-reporter: keep ignoring chrome crashes even on dev builds

Change-Id: Idd8859958e626dc782e511f35fca5d45a2977f53

BUG=chromium-os:12911
TEST=unit tests and UserCrash

Review URL: http://codereview.chromium.org/6673002
/system/core/crash_reporter/user_collector.h
a324932e066ccb7ed9d62db9c409ee2c10052554 03-Mar-2011 Ken Mixter <kmixter@google.com> crash-reporter: Use standard logging and new libchromeos Process code

Change-Id: Ie085d61d4d79c0df38e51debaa044d701a860c89

BUG=none
TEST=unit tests / UserCrash / CrashSender

Review URL: http://codereview.chromium.org/6517001
/system/core/crash_reporter/user_collector.h
d49d362f61c7e702d557e563055b1c541ead5b67 10-Feb-2011 Ken Mixter <kmixter@google.com> crash-reporter: when exe symlink read fails send diags and still ignore chrome crashes

Change-Id: I0f43d5f61936ebb6420c357e58df45761facd4d0

BUG=6299
TEST=unit tests and UserCrash/CrashSender

Review URL: http://codereview.chromium.org/6480009
/system/core/crash_reporter/user_collector.h
1b8fe015585c0b966d5240b8e22eba1af8c69e88 25-Jan-2011 Ken Mixter <kmixter@chromium.org> crash-reporter: Add diagnostics to help diagnose failures in the wild

We add logging messages that are generated during invocation of core2md, but we also enable sending arbitrary system info based on the configuration file. In this case we add the list of running processes, meminfo, and dmesg.

Change-Id: Ifdf29b89dd60d56349fa39095d2aa07f6b5e2de2

BUG=chromium-os:6299,chromium-os:9345
TEST=UserCrash, unit tests

Review URL: http://codereview.chromium.org/6297004
/system/core/crash_reporter/user_collector.h
c49dbd4775986f32b2f09659595f9f28ef7f6b44 15-Dec-2010 Ken Mixter <kmixter@chromium.org> crash-reporter: Capture and send recent update_engine logs when it crashes

We also disallow more than 4 nested crashes. This way we know if core2md crashes for instance, but not if crash_reporter crashes while handling the core2md crash that came from crash_reporter. Note that the kernel does not know about parent/child process relationships, it just counts concurrent handling, so it is possible that some of many crashing processes will be discarded.

See crash report id 473c22ed428d33a9 for an example report with update_engine logs.

Change-Id: I9ff9f03a94dc87d2d42840511c2e5e42ee37cea8

BUG=9176
TEST=UserCrash,CrashSender,unit tests

Review URL: http://codereview.chromium.org/5814001
/system/core/crash_reporter/user_collector.h
9b346474538a255bc7144ae358bb0ee129163d58 07-Nov-2010 Ken Mixter <kmixter@chromium.org> crash-reporter: Avoid writing through symlinks.

BUG=7987
TEST=bvts

Change-Id: I875adeb5073936e790beb93f6a223a1642131cbd

Review URL: http://codereview.chromium.org/4603001
/system/core/crash_reporter/user_collector.h
207694d3f491ef602a859c30cc1379584f2d61cf 29-Oct-2010 Ken Mixter <kmixter@chromium.org> crash-reporter: write conversion failure diagnostics into fake dmp files

Change-Id: I9f1ca92def3e1d0fa43b3bef0f2a72d367953926

BUG=6299,7782
TEST=bvts

Review URL: http://codereview.chromium.org/4088003
/system/core/crash_reporter/user_collector.h
2953c3a87a7b201bbf08555129f0640ede1d0cdb 18-Oct-2010 Ken Mixter <kmixter@google.com> crash-reporter: Avoid using system to invoke core2md

Change-Id: I1fc0b4dd6e4e84cb999ba61fedd43fc74a8fa1ba

BUG=6941
TEST=bvts

Review URL: http://codereview.chromium.org/3755011
/system/core/crash_reporter/user_collector.h
0340316050044e0995b98fea87ed41ea77abb28b 19-Aug-2010 Ken Mixter <kmixter@google.com> Collect and send kernel crash diagnostics

BUG=1512,1914

Review URL: http://codereview.chromium.org/3179006
/system/core/crash_reporter/user_collector.h
777484c41cc63e2f97f41a443d1d55f7e6037a5e 24-Jul-2010 Ken Mixter <kmixter@google.com> Start invoking core2md to implement full system crash reporting

BUG=4741

Review URL: http://codereview.chromium.org/3040013
/system/core/crash_reporter/user_collector.h
522c061f831325e73e3d46ee2161238ad6fa8b22 18-Jun-2010 Chris Sosa <sosa@chromium.org> Change include paths to reflect new directory.

TEST=Tested with new ebuild.

Review URL: http://codereview.chromium.org/2819009
/system/core/crash_reporter/user_collector.h
e4a86037f405415c460ace194fbf16cfd93d4c6f 17-Jun-2010 Chris Sosa <sosa@chromium.org> Initial commit of crash reporter repo
/system/core/crash_reporter/user_collector.h