| aa7948f4cba3db04dd42586f5d06711f443e0c56 |
|
18-Feb-2016 |
Eino-Ville Talvala <etalvala@google.com> |
Camera: Set warnings as errors, and fix a few of them
Bug: 27149500
Change-Id: Iddccb3bb7f0ca229d4c42f68d0c80fa91c3c4665
/system/media/camera/src/camera_metadata.c
|
| 9e28b9f7b2f62d2c1870218f951f7345a13bed2f |
|
15-Jun-2014 |
David Schalig <dschalig@nvidia.com> |
camera: allow 0-sized metadata entries
0-sized metadata entries were rejected in
update_camera_metadata_entry() when the data pointer
was NULL, but accepted when it was not NULL.
This prevents return of empty array-type camera properties,
which is a valid case for some dynamic properties, e.g.
number of detected face rectangles.
Change-Id: I4e69d889fb416fd256a81e877f3a5aa43c253796
Signed-off-by: David Schalig <dschalig@nvidia.com>
/system/media/camera/src/camera_metadata.c
|
| 21532655a531cf1168f10b8b974e2cef3061dd91 |
|
30-May-2014 |
Narayan Kamath <narayan@google.com> |
LP64 fixes for camera_metadata.
camera_metadata packets are transferred across process
boundaries with Parcel::readBlob / Parcel::writeBlob calls
so we should make sure they have a consistent layout across
32 and 64 bit processes. In this change :
- Replace size_t members with uint32_t members.
- Remove the "void*" user pointer which is no longer required
Change-Id: Ia0eada5d8358be21d725c05d6105705186b3d9c8
/system/media/camera/src/camera_metadata.c
|
| d1c3357af4bebf3d867761d826351ce7669fefc7 |
|
22-May-2014 |
Elliott Hughes <enh@google.com> |
resolved conflicts for merge of eb5d1723 to master
Change-Id: I4452c3b32dc3144da696e63417cd6e7d69805ffb
|
| 8e86c9c609a65563aa1b2f17423e69eabc6268c3 |
|
22-May-2014 |
Elliott Hughes <enh@google.com> |
Move from fdprintf to POSIX dprintf.
Bug: 11156955
Change-Id: I6e15d8229a14688909976ec28b15b92fe507896d
/system/media/camera/src/camera_metadata.c
|
| 6802721f101d43853264c5c3c13f2f4641861ff9 |
|
15-Apr-2014 |
Ruben Brunk <rubenbrunk@google.com> |
Update precision in dump.
Change-Id: I7508a9abad59e995163bf7fe8b4878a78711278c
/system/media/camera/src/camera_metadata.c
|
| a365d5ab28400c3a468710ac0d1ec74982897ad9 |
|
14-Mar-2014 |
Mark Salyzyn <salyzyn@google.com> |
am ebb95847: am b7f55262: Merge "libcamera_metadata: 64-bit compile issues"
* commit 'ebb958476492e5c382176a6ac048435f8954e995':
libcamera_metadata: 64-bit compile issues
|
| 9c51a070d0379637a3bddcee89d16273352a6564 |
|
13-Nov-2013 |
Alex Ray <aray@google.com> |
libcamera_metadata: assert correct state on exit
(cherry picked from commit 151389f386c45ff23ca5e2df4c3aaeb1fde3c496)
Change-Id: I2d9138f61665baa6695ac086184246334038236d
/system/media/camera/src/camera_metadata.c
|
| 773e5c8c23de85c100211911b0a5b2cb9733c58e |
|
13-Mar-2014 |
Mark Salyzyn <salyzyn@google.com> |
libcamera_metadata: 64-bit compile issues
- logger messages use %zu for size_t
- print format for int32_t and int64_t types.
Change-Id: I3117b074b473f591fd69426a9cd53e8d5d1de52b
/system/media/camera/src/camera_metadata.c
|
| 9c13e191ea2d9622d00621d6acb009a9a759dc92 |
|
15-Feb-2014 |
Ruben Brunk <rubenbrunk@google.com> |
camera3: Pass vendor tags through binder.
Bug: 12134423
Change-Id: Icef3fe9e67160767bdb8244ac49c85b68b497123
/system/media/camera/src/camera_metadata.c
|
| 1450f7f45376976100d63d3b7f8a39c4dfd47553 |
|
05-Dec-2013 |
Zhijun He <zhijunhe@google.com> |
camera_metadata: add API to query metadata alignment
Bug: 12010193
Change-Id: I7d190a183fa89d96cc3cbd59228df3f2a2347c2e
/system/media/camera/src/camera_metadata.c
|
| 246a1adacce4854b91adc9635887453ba4f58e51 |
|
26-Nov-2013 |
Zhijun He <zhijunhe@google.com> |
camera_metadata: fix metadata clone bug
clone_camera_metadata fails at validation during camera start, then crashes
camera.
Bug: 11879762
Change-Id: I9437c6724dd290aec162ae8b68be898b2f9a5b9e
/system/media/camera/src/camera_metadata.c
|
| 151389f386c45ff23ca5e2df4c3aaeb1fde3c496 |
|
13-Nov-2013 |
Alex Ray <aray@google.com> |
libcamera_metadata: assert correct state on exit
Change-Id: I2d9138f61665baa6695ac086184246334038236d
/system/media/camera/src/camera_metadata.c
|
| 71fe0f87dd5339a93ab2f376ca50568d45de617c |
|
21-Oct-2013 |
Alex Ray <aray@google.com> |
libcamera_metadata: Minor fixes
Add method to get read-only metadata entry by index.
Update some function descriptions to show return values.
Change-Id: Ib79ec1aab8f44f4ee7122fd56064514b2d6f78b4
/system/media/camera/src/camera_metadata.c
|
| 3064d31f5401b1727bf4c94b55d230615918ea9b |
|
15-Jul-2013 |
Zhijun He <zhijunhe@google.com> |
Camera: Metadata: clear metadata buffer entry before values are assigned
To avoid inconsistent state of metadata buffer entry when the entry count is 0.
Bug: 9529161
Change-Id: Ic3fa4b39457142b8bec61d0625d04672b51890b7
/system/media/camera/src/camera_metadata.c
|
| d1cecc16420d1e210b0643530e552e3427b2bab2 |
|
01-May-2013 |
Igor Murashkin <iam@google.com> |
camera_metadata: add validation function to ensure structural sanity
This is particularly useful when accepting copied metadata from another process,
since it could put whatever it want into the binder parcel.
Bug: 8713951
Change-Id: I72b25b2bf96230eb995bb32e3bbd68de16e122cd
/system/media/camera/src/camera_metadata.c
|
| 375cfd3889aa72160273af802370c8f47f5c64d1 |
|
03-Dec-2012 |
Igor Murashkin <iam@google.com> |
Camera2: Dump enum data types as strings, not integers
Change-Id: Ia225662d4ee0aad81b22b96355d7f39c4aa70d42
/system/media/camera/src/camera_metadata.c
|
| 555aac882ed63e70019c78ccc58032a5be0f58ec |
|
15-Nov-2012 |
Igor Murashkin <iam@google.com> |
Camera2: Fix metadata alignment for double and int64 types
* camera_metadata_rational_t was only aligning to 4 bytes, we need to align to 8
* add an automated unit test to verify alignment for each type of data
Bug: 7498597
Change-Id: Ib5554d412e09b95d21933b6015db68d01a072f90
/system/media/camera/src/camera_metadata.c
|
| b10d56ad43a91924d3666127963e5fdce725389c |
|
13-Nov-2012 |
Eino-Ville Talvala <etalvala@google.com> |
Camera: Actually make camera_metadata memcopyable
- Use internal offsets instead of pointers for the entry and data
arrays.
- Add test to verify memcpy works and doesn't alias data.
- Remove support for forward-compatible reserved space handling, given
that it's unlikely to be useful
Bug: 7546079
Change-Id: I439aa27fed8d243b7a04155daf5e58fa1c4c730e
/system/media/camera/src/camera_metadata.c
|
| 3154036acd2cc809388d08ff856198a8512f05f0 |
|
08-Nov-2012 |
Eino-Ville Talvala <etalvala@google.com> |
Camera: Fix metadata data alignment, other minor bugs.
- When a metadata entry needs to overflow into the data buffer, make
sure the starting offset is aligned to the maximum needed by all the
metadata types.
- Bounds check the data buffer size when adding a new entry
- Add new test for the bounds check
- Print out doubles correctly.
Bug: 7498597
Change-Id: Ic8645a998c096f5b803839ee8076b97862127021
/system/media/camera/src/camera_metadata.c
|
| 94879bd88f7ac3f2f678221497b8ad50c0bb3314 |
|
02-Oct-2012 |
Eino-Ville Talvala <etalvala@google.com> |
Camera: Add scene mode override and quirks fields.
To provide scene mode override information while preview is disabled,
need more static metadata from the HAL.
In addition, add a quirks section to allow for temporary workarounds
for incomplete HAL behavior. Any quirks added will be deprecated as
soon as possible.
Bug: 7159577
Bug: 7172543
Change-Id: Icadb6baa4132bf20ad82b2c549ac2b9a0c6618de
/system/media/camera/src/camera_metadata.c
|
| 2f4aca6526bbbaa9069f2683cdc60c0453a22055 |
|
24-Aug-2012 |
Eino-Ville Talvala <etalvala@google.com> |
Camera: Add methods for read-only access to metadata.
- Define a read-only version of camera_metadata_entry_t
- Support finding with read-only output
- Add const to clone method input camera_metadata_t.
Bug: 6243944
Change-Id: I1bf37a4c8c8935711e803d7477393fe2c01f8216
/system/media/camera/src/camera_metadata.c
|
| 2cae02cd02ea0b5d04268621616d386c9d5261c6 |
|
26-Aug-2012 |
Eino-Ville Talvala <etalvala@google.com> |
Revert "Camera: Add methods for read-only access to metadata."
Needs a third change that's not yet done with review.
This reverts commit ad0c0c836d0276079bf8fe1bfb0bef25d4bce601
Change-Id: Id4325fe93b43a447eded5ae50e8f7faa70fd9140
/system/media/camera/src/camera_metadata.c
|
| ad0c0c836d0276079bf8fe1bfb0bef25d4bce601 |
|
24-Aug-2012 |
Eino-Ville Talvala <etalvala@google.com> |
Camera: Add methods for read-only access to metadata.
- Define a read-only version of camera_metadata_entry_t
- Support finding with read-only output
- Add const to clone method input camera_metadata_t.
Bug: 6243944
Change-Id: Icd581e48f5fafaa6da22ca25e872bf3ede192222
/system/media/camera/src/camera_metadata.c
|
| 1d27e5b8a575620bb64406289c7c229662de92ca |
|
30-Jul-2012 |
Eino-Ville Talvala <etalvala@google.com> |
Camera: Add indented metadata dump
Bug: 6243944
Change-Id: Ib769ae2d40b9c4bfa456c812fd7ee2e426fd86df
/system/media/camera/src/camera_metadata.c
|
| fd2588282491637c61ba828eeb69c9486d8aaeab |
|
07-Jun-2012 |
Eino-Ville Talvala <etalvala@google.com> |
Camera: Add clone buffer, make type names public
Clone metadata buffer allows for straightforward duplication of
existing buffers; type names are useful for debugging code.
Bug: 6243944
Change-Id: Ibf70f4e3bcf49d6c772bba18a577e2673f2b9213
/system/media/camera/src/camera_metadata.c
|
| 98d02fd0be8cd09479262959a542dd2620bf6074 |
|
21-May-2012 |
Eino-Ville Talvala <etalvala@google.com> |
Camera: Add opaque user pointer to camera metadata buffer
This is useful for associating a metadata buffer handed off to a third
party with its parent object, when the buffer is returned.
Change-Id: I7e19708bb3adf4da26fc6101e78c276477276608
/system/media/camera/src/camera_metadata.c
|
| f5fb8a5516876c5a48cc44b4f1c99504e0b9f245 |
|
10-May-2012 |
Eino-Ville Talvala <etalvala@google.com> |
Improvements to camera metadata handling.
- Cleaner interface to get/find
- Adds delete entry, an expensive O(n) operation
- Adds update entry, which is O(n) sometimes
- Minor bugfixes:
- Keep sorted state when appending empty buffers
- Misspelling of camera_metadata_type_size in header
- Missing entry in type name array
Bug: 6243944
Change-Id: I316507d6adcc22aff6e7c464c6c484f31ef1510d
/system/media/camera/src/camera_metadata.c
|
| 623ff65afea34612498dcf33887ffaf8b194c281 |
|
12-Apr-2012 |
Eino-Ville Talvala <etalvala@google.com> |
Make camera metadata tag definitions more robust to mismatches.
Use array assignment-by-index syntax to make sure we match the desired
index to the entry, so it's easier to keep the metadata header and the
info structures in sync.
Change-Id: I06d1ea3d52c651b447cc167cd551e907c8e001ab
/system/media/camera/src/camera_metadata.c
|
| 94c1901a96c268f55012809f8261f2ec89c16dea |
|
05-Apr-2012 |
Eino-Ville Talvala <etalvala@google.com> |
Improvements to the camera metadata structure
- Add vendor_tag_query_ops_t as argument to methods inside it.
- Add version and flags fields
- Add sorted flag; additions and appends are not sorted, and thus
reset the flag.
- Add sort method, which sets the sorted flag.
- Add find-by-tag method, which uses a linear search on a non-sorted
buffer, and a binary search on a sorted buffer.
- Change dump method to take in a fd, like the HAL-level dump methods
do.
- Minor revisions to tag definitions, including a few enums for
enumerated-value tags.
Change-Id: I5f37e326519bda032cb3362da4ab3bf50eb98b4e
/system/media/camera/src/camera_metadata.c
|
| d8afb4d1a4245b2a9d722cbb358a4d6febed89cf |
|
10-Feb-2012 |
Eino-Ville Talvala <etalvala@google.com> |
Add a camera metadata structure and utility methods
Change-Id: I320cc33f31ebd8ce183572a447df8fae691eec0d
/system/media/camera/src/camera_metadata.c
|