961c25aba9898ac2e1629c745914e4c2f2a68301 |
|
12-Apr-2016 |
Sen Jiang <senj@google.com> |
Don't set data_offset and data_length if data blob is empty. ZERO operation was failing because we were setting these fields in delta payload. Bug: 27858697 Bug: 27156473 Test: apply a minor v4 payload. (cherry picked from commit 4108c32f268c9d50b7aab7599733bd04526bacdf) Change-Id: I7490491c7a3a25a52f7b06bbe670be058e5d655f
/system/update_engine/payload_generator/delta_diff_utils.cc
|
be77e9ed80be653fadd76dfda6ef325160678b27 |
|
06-Apr-2016 |
Alex Deymo <deymo@google.com> |
delta_generator: Use REPLACE_XZ in deltas when allowed. This patch moves the generation of the best allowed full operation to a new function which now includes ZERO, REPLACE, REPLACE_BZ and REPLACE_XZ when allowed. This function is used to produce a full operation whenever it is needed in the "full" payload generator and the AB "delta" payload generator. Bug: 24578399 TEST=brillo_update_payload generated REPLACE_XZ operations for a delta payload that was using REPLACE_BZ operations and merged them. TEST=brillo_update_payload generated a full payload with REPLACE, REPLACE_BZ and REPLACE_XZ operations. TEST=Updated unittests. (cherry picked from commit 726aeca1c665910593761a1990ee50f22d98f53f) Change-Id: I50684d5fa429f7110e5535ee4a7f29ac50b5a402
/system/update_engine/payload_generator/delta_diff_utils.cc
|
38818fbf1f2f937051b5bcc01ff74539a3c9b27d |
|
23-Mar-2016 |
Alex Deymo <deymo@google.com> |
Introduce PayloadVersion struct for version information. This new little struct encapsulates the version information (major and minor version numbers) and the zlib fingerprint information. Now, instead of querying throughout if the version number is certain value, we ask the PayloadVersion struct whether certain operation is allowed in that version or not. This moves the logic of what's supported and what's not to a single place and eliminates the need to pass several booleans to the helper functions. Bug: 24578399 TEST=Unittest still pass. (cherry picked from commit a4073ef63482fd08c3678982f7d153360b088094) Change-Id: I756d0c2cc217d23df1822f961bb7d82f64974fa9
/system/update_engine/payload_generator/delta_diff_utils.cc
|
f96cc198264161749d60169cb0b8d5d0015303d1 |
|
10-Feb-2016 |
Sen Jiang <senj@google.com> |
Include IMGDIFF operation in minor version 4 or up. Try imgdiff if both source and target contains gzip. Test: unit test & generated a payload with boot.img Bug: 26675118 (cherry picked from commit 55c4f9ba7f5c59e3345f2c1869464433ffa8dc2b) Change-Id: I65a9f61efdc286bd48eff6ddd99826b6bf8af25f
/system/update_engine/payload_generator/delta_diff_utils.cc
|
39910dcd1d68987ccee7c3031dc269233a8490bb |
|
10-Nov-2015 |
Alex Deymo <deymo@google.com> |
Split payload application code into a subdirectory. This patch splits from the main libupdate_engine code the part that is strictly used to download and apply a payload into a new static library, moving the code to subdirectories. The new library is divided in two subdirectories: common/ and payload_consumer/, and should not depend on other update_engine files outside those two subdirectories. The main difference between those two is that the common/ tools are more generic and not tied to the payload consumer process, but otherwise they are both compiled together. There are still dependencies from the new libpayload_consumer library into the main directory files and DBus generated files. Those will be addressed in follow up CLs. Bug: 25197634 Test: FEATURES=test emerge-link update_engine; `mm` on Brillo. Change-Id: Id8d0204ea573627e6e26ca9ea17b9592ca95bc23
/system/update_engine/payload_generator/delta_diff_utils.cc
|
abdc0115548985d8ca3f3f2aeb1283741ce409a6 |
|
22-Oct-2015 |
Alex Deymo <deymo@google.com> |
Fix building delta_generator. Previous CL had a few include renames missing. Bug: None Test: sudo emerge update_engine Change-Id: Ifcdf5f11d52561cf3f976f18c0d66b95dd3c0d66
/system/update_engine/payload_generator/delta_diff_utils.cc
|
3f39d5cc753905874d8d93bef94f857b8808f19e |
|
13-Oct-2015 |
Alex Vakulenko <avakulenko@google.com> |
update_engine: Rename "chromeos" -> "brillo" in include paths and namespaces libchromeos is transitioning to libbrillo and chromeos namespaces and include directory is changing to brillo. Bug: 24872993 Change-Id: I770659a95be380a50fe3b2ba9f91d65818f40945
/system/update_engine/payload_generator/delta_diff_utils.cc
|
aea4c1cea20dda7ae7e85fc8924a2d784f70d806 |
|
20-Aug-2015 |
Alex Deymo <deymo@google.com> |
Re-license update_engine to Apache2 This patch automatically replaced the license on all text files from Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as a reference. The license header was added to .gyp and .gypi files, the NOTICE was replaced with a copy of the Apache2 license and MODULE_LICENSE_* file was updated. BUG=b/23084294 TEST=grep 'Chromium OS Authors' doesn't find anything. Change-Id: Ie5083750755f5180a8a785b24fe67dbf9195cd10
/system/update_engine/payload_generator/delta_diff_utils.cc
|
a12ee11c78ac6d7c2605921a4006b6a7416e0c35 |
|
13-Aug-2015 |
Alex Deymo <deymo@chromium.org> |
update_engine: Move InstallOperation to the top level. The InstallOperation message in the protobuf is a nested message inside the DeltaArchiveManifest message, making all references to operation types be very long names like DeltaArchiveManifest_InstallOperation_Type_REPLACE_BZ while most other messages are not nested in the DeltaArchiveManifest message. To improve readability and to prepare for future update metadata changes, this patch moves the InstallOperation message to the top level and replaces all references to operation types with the new shorter version like InstallOperation::REPLACE_BZ. This change only impacts the scope of the generated classes and the serialized format of the protobuf. This exact same question was addressed by protobuf maintainers here: https://groups.google.com/forum/#!topic/protobuf/azWAPa6hP4A Finally coding style and indentation was automatically updated due to the shorter names. BUG=b:23179128 TEST=Unittest still pass. Change-Id: I55add54265934cd1fd3e9cb786c5d3f784902d17 Reviewed-on: https://chromium-review.googlesource.com/293504 Trybot-Ready: Alex Deymo <deymo@chromium.org> Tested-by: Alex Deymo <deymo@chromium.org> Reviewed-by: Alex Deymo <deymo@chromium.org> Commit-Queue: Alex Deymo <deymo@chromium.org>
/system/update_engine/payload_generator/delta_diff_utils.cc
|
8cc502dacbccdab96824d42287f230ce04004784 |
|
10-Aug-2015 |
Sen Jiang <senj@chromium.org> |
update_engine: Change OperationsGenerator to use BlobFileWriter BUG=chromium:517280 TEST=Unit test for BlobFileWriter Change-Id: Ib49925676331acee97ff6b4cec38a81ca8b157a1 Reviewed-on: https://chromium-review.googlesource.com/291441 Tested-by: Sen Jiang <senj@chromium.org> Reviewed-by: Alex Deymo <deymo@chromium.org> Commit-Queue: Sen Jiang <senj@chromium.org>
/system/update_engine/payload_generator/delta_diff_utils.cc
|
2d3b2d635e50c6886e285afb86c3187d9e0bd360 |
|
18-Jul-2015 |
Alex Deymo <deymo@chromium.org> |
update_engine: Implement soft/hard chunk size limits. The current approach uses a single chunk_size value, that defaults to -1 (or "whole files") for delta payloads. The "whole files" default is the preferred value since BSDIFF and SOURCE_BSDIFF operations (the most common operations in real delta payloads) will benefit from having access to the whole file in the old and new partition, in particular in cases like the chrome binary (~120 MiB in size). On the other hand, very big chunks have a big memory footprint in most cases. Current implementations of BSDIFF, REPLACE_BZ and REPLACE will require as much private memory as the destination chunk_size or more. Because of this and due to the lack of old data, a small chunk_size (1 MiB) is used for full payloads. To break this tension between having a big chunk_size for operations that will benefit from it versus having a small chunk_size for cases where it doesn't change anything, this patch introduces two chunk size values: a hard and soft limit. The hard_chunk_size has the same meaning as the old chunk_size: no operation should have a destination bigger than the provided hard limit. The soft_chunk_size is the preferred chunk size for an operation when a bigger chunk will not benefit significantly the final payload size. Having a small chunk size for operations like REPLACE_BZ, REPLACE, SOURCE_COPY and MOVE is important to keep the memory footprint low when it the extra memory is not required. The new soft_chunk_size limit is used when merging operations (previously hard-coded to 1 MiB) and when generating new operations for zeroed and moved blocks. BUG=chromium:485397 TEST=Run cros_generate_update_payload for full and delta payloads. Inspected the chunk size in the resulting payloads. Change-Id: I370048a81913ad23a151cfef6690627b7fff7277 Reviewed-on: https://chromium-review.googlesource.com/286568 Reviewed-by: Gilad Arnold <garnold@chromium.org> Tested-by: Alex Deymo <deymo@chromium.org> Trybot-Ready: Alex Deymo <deymo@chromium.org> Commit-Queue: Alex Deymo <deymo@chromium.org>
/system/update_engine/payload_generator/delta_diff_utils.cc
|
896fdbaa1cc9a422ac36ef455d02c3cef1f27816 |
|
17-Jul-2015 |
Alex Deymo <deymo@chromium.org> |
update_engine: Prevent the InplaceGenerator to add MOVEs to block 0. While we normally don't generate MOVE operations to/from the block 0, the cycle breaker logic can use the block 0 as scratch space, creating MOVE operations to and from the block 0. This patch prevents it from picking the block 0 as scratch space and logs a message when that would happend. BUG=chromium:480751,chromium:500423 TEST=Added unittest. Change-Id: I91f1b3c426a9d06aae5b685e2e901c7e448d8677 Reviewed-on: https://chromium-review.googlesource.com/286623 Reviewed-by: Gilad Arnold <garnold@chromium.org> Tested-by: Alex Deymo <deymo@chromium.org> Commit-Queue: Alex Deymo <deymo@chromium.org>
/system/update_engine/payload_generator/delta_diff_utils.cc
|
3b2c7d0e6d859e6fc75c82b3417f87cf5968a49d |
|
17-Jul-2015 |
Alex Deymo <deymo@chromium.org> |
update_engine: Sort full operations by destination. The inplace generator moves all the full operations to the end of the list. This patch sorts those operations by the destination. This patch also cleans up the Vertex class by using the new AnnotatedOperation class instead of the operation and file_name separated. BUG=None TEST=Unittest still pass. minor_version=1 full operations appear in order according to "cros payload". Change-Id: Ia0c15939086cec52dc855cbc3afa913f8cbebf6b Reviewed-on: https://chromium-review.googlesource.com/286213 Tested-by: Alex Deymo <deymo@chromium.org> Reviewed-by: Gilad Arnold <garnold@chromium.org> Commit-Queue: Alex Deymo <deymo@chromium.org>
/system/update_engine/payload_generator/delta_diff_utils.cc
|
f0061358b5f741baeeb9177b838b289d2ce318f3 |
|
01-Jul-2015 |
Alex Deymo <deymo@chromium.org> |
update_engine: Handle moved and zero blocks in payload generation. Delta generation uses only the file name to detect when files changed. Therefore, renaming a file doesn't get detected and the new name is assumed to be a new file. On the other hand, free-space blocks are often just zeros so they can be easilly encoded independently from the rest. This patch detects blocks that moved and blocks with zeros and handles those blocks beforehand regardless of where are they in the filesystem (file data, metadata, free space, etc). For blocks that moved, SOURCE_COPY or MOVE operations are created as needed. For blocks with zeros we use REPLACE_BZ operations. Blocks processed in this way will be excluded from other files, metadata or free space processing done. This solves perfomance issues when trying to process with bsdiff files with very long runs of zeros. CQ-DEPEND=CL:283643 BUG=chromium:504445 TEST=Unittest added. Run delta_generator between cid canary 7195 and 7201 and it doesn't take forever to finish. Change-Id: I892fe7456608e83a2946133da335eb4fbd19a645 Reviewed-on: https://chromium-review.googlesource.com/283172 Commit-Queue: Alex Deymo <deymo@chromium.org> Trybot-Ready: Alex Deymo <deymo@chromium.org> Tested-by: Alex Deymo <deymo@chromium.org> Reviewed-by: Alex Deymo <deymo@chromium.org> Reviewed-by: Gilad Arnold <garnold@chromium.org>
/system/update_engine/payload_generator/delta_diff_utils.cc
|
b42b98db059a12c44110588fc0b3d5f82d32a2f8 |
|
07-Jul-2015 |
Alex Deymo <deymo@chromium.org> |
update_engine: Load minor_version from the FilesystemInterface. In the normal use case, cros_generate_update_payload doesn't pass the requested minor_version to delta_generator which means we need to detect it from the old image. To detect it, we where looking at the update_engine.conf file in the mounted source directory. This patch uses the recently added FilesystemInterface::LoadSettings() method to read the update_engine.conf settings from the source rootfs partition. In order to make this information available when autodetecting the minor_version and to help future FilesystemInterface mocking for testing, we move the FilesystemInterface instance from inside the OperationsGenerator class to the PartitionConfig, so the filesystems are opened before calling GenerateUpdatePayloadFile. This patch then deprecates the --old_dir flag removing the requirement to run delta_generator and cros_generate_update_payload as root when generating deltas. BUG=chromium:305832 TEST=Ran cros_generate_update_payload to generate deltas from old (link FSI) and new (ToT link) images. Change-Id: I915679d62aae2d1a2acee68cc8c1ec691cc363ad Reviewed-on: https://chromium-review.googlesource.com/283643 Trybot-Ready: Alex Deymo <deymo@chromium.org> Tested-by: Alex Deymo <deymo@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: Alex Deymo <deymo@chromium.org>
/system/update_engine/payload_generator/delta_diff_utils.cc
|
14158570d3995008dc93a628004118b87a6bca01 |
|
13-Jun-2015 |
Alex Deymo <deymo@chromium.org> |
update_engine: Split delta_diff_generator file. The DeltaDiffGenerator class includes both an OperationsGenerator using the A-to-B operations and a set of common methods used also by the inplace generator. The delta_diff_generator.{h,cc} files also include a single function to generate the payload (GenerateUpdatePayloadFile) that centralizes the logic of generating the operations and writing the payload. This patch splits these three parts in different files. The common delta diff function are moved to the delta_diff_utils.{h,cc} files. The operations generator class that uses A-to-B operations is now in a new ab_generator.{h,cc} pair of files that implement the ABGenerator() class. Finally, the payload file writing methods are now in a single PayloadFile class. This allow us to create payload files without the need to generate images and their deltas. This will be used in a follow up CL to remove the image generation logic from the unittests. BUG=chromium:351589 TEST=Ran unittests. Regenerate a payload with and without this patch; got the same results. Change-Id: I6816d2c805ba8c0c5c9423c720131a100a15ebaa Reviewed-on: https://chromium-review.googlesource.com/280838 Reviewed-by: Alex Deymo <deymo@chromium.org> Commit-Queue: Alex Deymo <deymo@chromium.org> Trybot-Ready: Alex Deymo <deymo@chromium.org> Tested-by: Alex Deymo <deymo@chromium.org>
/system/update_engine/payload_generator/delta_diff_utils.cc
|