c0781c4988c2ad6bd3b56be567f966ae3124661c |
|
05-Oct-2015 |
Shelley Chen <shchen@chromium.org> |
FAFT: Adding new test firmware_ECLidShutdown This tests the functionality of the GBB_FLAG_DISABLE_LID_SHUTDOWN flag. BUG=chromium:446525 BRANCH=none TEST=tested on veyron_jerry and samus Change-Id: I06f8f654513212bdf129c981f9dab9f12c9c54d1 Signed-off-by: Shelley Chen <shchen@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/304190 Reviewed-by: Wai-Hong Tam <waihong@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
3e92b8e9041fa7bb44dc9285e2c415eb611697a9 |
|
07-May-2015 |
Tom Wai-Hong Tam <waihong@google.com> |
faft: Remove do_reboot_action and use the single-entry reboot method This change further unifies more calls, which use do_reboot_action, to adapt the new mode_aware_reboot method. BUG=chrome-os-partner:16231 TEST=Ran all affected FAFT tests on Jerry. Change-Id: I74120fe091cc06a910c1e31f09fdf748a2bb028d Reviewed-on: https://chromium-review.googlesource.com/270013 Trybot-Ready: Tom Tam <waihong@google.com> Tested-by: Tom Tam <waihong@google.com> Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org> Commit-Queue: Tom Tam <waihong@google.com>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
0cc9a4fe28f221cfc73bb35c30fa79338c4b43f1 |
|
01-May-2015 |
Tom Wai-Hong Tam <waihong@google.com> |
faft: Refactor setup_mode and restore_mode The change moves and splits the original logic on setup_dev_mode and restore_dev_mode to FAFTCheckers and ModeSwitcher. It is also enhanced to support setting up all firmware modes, including recovery. They are now methods in ModeSwitcher as they are highly related to mode switching. BUG=chrome-os-partner:39744 TEST=Switched DUT to normal mode and ran firmware_DevMode. Then switched DUT to dev mode and run firmware_DevMode. Checked DUT restored to the original mode state. Change-Id: I16314d18b785da59473df3ef5e02f7fe8f2693b0 Reviewed-on: https://chromium-review.googlesource.com/268858 Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org> Commit-Queue: Tom Tam <waihong@google.com> Tested-by: Tom Tam <waihong@google.com>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
04e454165b7ff23cd15226fac4f7ccafb11b9b28 |
|
16-May-2014 |
Yusuf Mohsinally <mohsinally@google.com> |
Converting firmware_ECPowerG3 to use new FirmwareTest class. The new FirmwareTest class does not require the traditional dict of objects that FAFTSequence required. 1. Converted the test to use the new flat function call style. BUG=chromium:371185 TEST=Manually ran this test at desk against peppy Change-Id: Ic4fe792c7976d2c897ae8aa9b715b574b0081d70 Reviewed-on: https://chromium-review.googlesource.com/200115 Reviewed-by: Vic Yang <victoryang@chromium.org> Commit-Queue: Yusuf Mohsinally <mohsinally@chromium.org> Tested-by: Yusuf Mohsinally <mohsinally@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
3a1caed0147bf48dac53525ce1e96851788fc28a |
|
23-Jan-2014 |
Vic (Chun-Ju) Yang <victoryang@chromium.org> |
Fix expected response in firmware_ECPowerG3 The EC console message has changed. We need to match it in the test. BUG=chrome-os-partner:25211 TEST=Pass the test on Rambi Change-Id: I71448ae78f2b16d1574f4e050862bfbde7dfe5ca Signed-off-by: Vic (Chun-Ju) Yang <victoryang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/183628 Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
1f115ae9ee3c043e9577e7ce9872dc99323fdcb3 |
|
07-Nov-2013 |
Yusuf Mohsinally <mohsinally@chromium.org> |
Correctly using initialize() rather than setup() for FAFT tests. FAFT tests have been using setup() (which is run once at autotest init), when it should have instead used initialize() for running code before each test case is run. BUG=chromium:267175 TEST=Ran tests manually against Pit device to ensure that these changes did not introduce problems. Change-Id: If0e76e12b9f40249154d7b95a1375b2787a56304 Reviewed-on: https://chromium-review.googlesource.com/176024 Reviewed-by: Wai-Hong Tam <waihong@chromium.org> Commit-Queue: Yusuf Mohsinally <mohsinally@chromium.org> Tested-by: Yusuf Mohsinally <mohsinally@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
22aa8411ceb4e08a83ebc535c96601be919e2e96 |
|
05-Oct-2013 |
Yusuf Mohsinally <mohsinally@chromium.org> |
Fix firmware_ECPowerG3 test. With new haswell systems, we cannot detect the intermediate S5 state before they go into G3. So removing that check which consistently failed on haswell systems. Note that this test change impacts older platforms as well, and is not limitted to only to haswell systems. So any assumption that we verify that older systems go into S5 before G3 will not be true. Also renamed "timeout" to "retries" which reflect the actual use. BUG=chrome-os-partner:22021 TEST=Manual tests at desk with peppy device Change-Id: I0ff181dc9ca266d5889152a06a620c01908660a5 Reviewed-on: https://chromium-review.googlesource.com/172021 Tested-by: Yusuf Mohsinally <mohsinally@chromium.org> Reviewed-by: Bill Richardson <wfrichar@chromium.org> Commit-Queue: Yusuf Mohsinally <mohsinally@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
73c28f3abd6ec8de4dc5a8e6afca1d5e83eb59c7 |
|
03-Aug-2013 |
Yusuf Mohsinally <mohsinally@google.com> |
Reorginazing FAFT (server side) files. Initial reorganization step while moves FAFT (autotest/server) files over to packages. Naming and other cleanup will be performed in additional CLs. BUG=None TEST=built and ran faft tests at desk against Link Change-Id: I83712620c0e6816ec08b9afdf8c227a800734ea6 Reviewed-on: https://gerrit.chromium.org/gerrit/64408 Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org> Tested-by: Yusuf Mohsinally <mohsinally@chromium.org> Commit-Queue: Yusuf Mohsinally <mohsinally@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
d4340315f76fcae9a5e9430d0446705f4f8fa7b7 |
|
17-Jul-2013 |
Tom Wai-Hong Tam <waihong@chromium.org> |
FAFT: Rename the module faftsequence to faft_classes For preparing the future refactoring that splitting FAFTSequence into multiple meaningful small classes, changes the original module name faftsequence to faft_classes. BUG=chrome-os-partner:21118 TEST=Manual Ran the affected test cases, firmware_FAFTSetup, on Spring and passed. Change-Id: I662cfc8d37a54711d7c52ff5322ed28a9a759ffe Reviewed-on: https://gerrit.chromium.org/gerrit/62642 Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org> Commit-Queue: Tom Wai-Hong Tam <waihong@chromium.org> Tested-by: Tom Wai-Hong Tam <waihong@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
a051510c53dbbd01f768a2546098ec73ba325221 |
|
07-May-2013 |
Vic Yang <victoryang@chromium.org> |
Suppress EC console for FAFT EC tests For EC tests, suppress EC console output so that they don't interfere with our tests. BUG=None TEST=Run firmware_ECBattery on Spring Change-Id: Iff312951d056d3f8a3d54b26896f83100209a4ad Signed-off-by: Vic Yang <victoryang@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/50245 Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
1c903d62b3381af452cda2415ebd83a523a8f05a |
|
07-May-2013 |
Vic Yang <victoryang@chromium.org> |
Use TestNAError for not applicable FAFT tests When a not applicable test is run, raise TestNAError so the user sees something like: TEST_NA: Nothing needs to be tested on this device BUG=chrome-os-partner:19170 TEST=Run firmware_ECThermal on Spring and see TEST_NA. Change-Id: Ib4a12f2224324ca0ad887a20ec565cc1e60d55d1 Signed-off-by: Vic Yang <victoryang@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/50233 Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org> Commit-Queue: David James <davidjames@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
4d743049231ce20b9a2a8694b2e01fad78a12f3a |
|
02-May-2013 |
Vic Yang <victoryang@chromium.org> |
Add more log message about skipped FAFT tests The current warning message doesn't say that skipped tests are normal. Let's add more descriptive messages so that people don't get confused. BUG=chrome-os-partner:19170 TEST=None Change-Id: Iad186d5dbde7d9458b1dac599376ac32b3951b13 Signed-off-by: Vic Yang <victoryang@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/49945 Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
5c8f8670ff46c6b3523fb2ea49a520186240b603 |
|
18-Jan-2013 |
Vadim Bendebury <vbendeb@chromium.org> |
Fix EC UART interactions When FAFT is running on a setup where the servo board is controlled by a Beaglebone board, many EC tests fail because the expected output from the EC console is not received in the allotted time. Actually, there is no need to limit the time when the test is waiting for the response: if the expected response comes, the wait stops right there, so the timeout does not matter. If the response does not show up, a few extra seconds will not make things much worse. This change deprecates the timeout parameter, all uses of send_command_get_output() will run with the same previously set timeout. By default the timeout is set to 3s in the servod package (https://gerrit.chromium.org/gerrit/41568). If some tests need a longer timeout, or there is a point in specifying a short timeout, it still could be done using the `ec_uart_timeout' control. BUG=chromium-os:22475 TEST=manual . successfully ran the following tests in two setups, with local and remote servos: firmware_ECAdc firmware_ECBattery firmware_ECBootTime firmware_ECCharging firmware_ECKeyboard firmware_ECPeci firmware_ECPowerG3 firmware_ECSharedMem firmware_ECThermal firmware_ECUsbPorts firmware_ECWakeSource firmware_ECWatchdog firmware_ECWriteProtect firmware_FAFTSetup Change-Id: I0da2f9a0924574846a6c7650e996576a7d2b76aa Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/41618 Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
d43aa9b4568e0b1283d6ff535b87446b14a6e3b9 |
|
16-Nov-2012 |
Chun-ting Chang <ctchang@chromium.org> |
Classify methods in FAFTClient There are too many methods in FAFTClient, so this CL is to classify them into several groups: ec, bios, kernel. Methods which can be put into one of the target group should be renamed with format _[group name]_[method name]. For example, dump_firmware should be modified to bios_dump. To call methods in FAFTClient, use [group name].[method name]. BUG=chromium-os:36429 TEST=run firmware update tests Change-Id: I7ead01246121b454c0a9f29e10bd026a77925e4f Reviewed-on: https://gerrit.chromium.org/gerrit/38186 Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org> Commit-Ready: Chun-Ting Chang <ctchang@chromium.org> Tested-by: Chun-Ting Chang <ctchang@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
b09a04183cf7017eb4b30ad28f5f81f1204c36b3 |
|
06-Nov-2012 |
Vic Yang <victoryang@chromium.org> |
faft: Fix lint warning and error This includes removing unnecessary 'pass' and unused argumenets. BUG=chrome-os-partner:35902 TEST=Check tests still work. Change-Id: Ifb9ac8348e7e26e2ea1a10b9c7e509f817e117b9 Signed-off-by: Vic Yang <victoryang@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/37424 Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
47d42ba469b82b51e45f755240eacad404b6122d |
|
31-Oct-2012 |
Vic Yang <victoryang@chromium.org> |
faft: Fix lint warning This includes: - String format arguments as logging function paramters - Unused loop counter - Long line - Unused import - Disable W0702 when we want to catch any exception BUG=chromium-os:35902 TEST=Run faft suite and passed. Change-Id: I8442fefc5d0687dfe18c3563b5befbff750ba3a7 Signed-off-by: Vic Yang <victoryang@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/36998
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
6019a1a0c375bee346b183921d3edf5f098d3f68 |
|
12-Oct-2012 |
Tom Wai-Hong Tam <waihong@chromium.org> |
faft: Refactor Chrome EC related methods into a class So far the Chrome EC related methods are quite distributed across tests. We should have a single place to control all the Chrome EC functions. This CL does the first step to refactor the UART command methods into the ChromeEC class. BUG=chromium-os:35254 TEST=run_remote_tests.sh --board link --remote dut suite:faft_ec Change-Id: If148170bcf6801a2a33f666b8a5a7fadc47f3243 Reviewed-on: https://gerrit.chromium.org/gerrit/35403 Reviewed-by: Vic Yang <victoryang@chromium.org> Reviewed-by: Mike Truty <truty@chromium.org> Commit-Ready: Tom Wai-Hong Tam <waihong@chromium.org> Tested-by: Tom Wai-Hong Tam <waihong@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
41859a60694f31a5f7dc8d76585f93a3a7265ff5 |
|
03-Oct-2012 |
Tom Wai-Hong Tam <waihong@chromium.org> |
faft: Change the return type of send_uart_command_get_ouput to a literal struct We are going to move the method send_uart_command_get_output to servod. FAFT will call it via a RPC, which only accepts literal structures. The original return type re.MatchObject is not a literal structure. This change is to change the return type of send_uart_command_get_ouput to a list of tuples, each of which contains the entire matched string and all the subgroups of the match. This change also restricts the argument regex_list to be an explicit list. BUG=chromium-os:34787 TEST=run_remote_tests.sh --remote $DUT suite:faft_ec Change-Id: Ic247fd65109d7ad4b716611b3cc6728665b1309c Reviewed-on: https://gerrit.chromium.org/gerrit/34609 Reviewed-by: Todd Broch <tbroch@chromium.org> Commit-Ready: Tom Wai-Hong Tam <waihong@chromium.org> Tested-by: Tom Wai-Hong Tam <waihong@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
72bdc35b3d3fd35842b04f582bfaa4e5fb83bb16 |
|
18-Sep-2012 |
Tom Wai-Hong Tam <waihong@chromium.org> |
faft: Call the setup methods of their superclasses on EC FAFT Should call the setup methods of their superclasses first. Otherwise, some variables may not be initialized. BUG=chrome-os-partner:14158,chrome-os-partner:14161,chrome-os-partner:14162 TEST=run_remote_tests.sh --remote=$IP suite:faft_ec Change-Id: Ie93f3a6bba42a1f4bcaffd6020e2c23ef7214964 Reviewed-on: https://gerrit.chromium.org/gerrit/33480 Commit-Ready: Tom Wai-Hong Tam <waihong@chromium.org> Tested-by: Tom Wai-Hong Tam <waihong@chromium.org> Reviewed-by: Mike Truty <truty@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
f3a35c4634ab88f12bee2d1bbd46c2c9a9806b62 |
|
14-Sep-2012 |
Vic Yang <victoryang@chromium.org> |
faft: run EC peripheral tests in normal mode EC peripheral tests don't care about dev mode. Let's only run them in normal mode. BUG=chromium-os:34392 TEST=Passed the tests. Change-Id: If68a153be5ae3dbe2bfac21012c3ab9573c5fa4d Signed-off-by: Vic Yang <victoryang@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/33296 Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
4d72cb65b05f9a535405c0dc90d6e24c75837c9c |
|
24-Jul-2012 |
Vic Yang <victoryang@chromium.org> |
FAFT: Issue warning when running incompatible EC tests Some EC tests require certain functinoality of EC which might not exists on all devices. In this case, we should issue warning and let the test pass so as not to raise false alarm. BUG=chrome-os-partner:11629 TEST=Check tests are gated by EC attributes. Change-Id: Ie518271e2a21094b1f8876c9520d95678a7474e5 Reviewed-on: https://gerrit.chromium.org/gerrit/28355 Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org> Tested-by: Vic Yang <victoryang@chromium.org> Commit-Ready: Vic Yang <victoryang@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
b02671c2616a9672a4b4c73c53325f9145a17f6f |
|
19-Jun-2012 |
Vic Yang <victoryang@chromium.org> |
firmware_ECPowerG3: Use powerinfo to improve reliability We need to read power state from EC console. However, EC console produces a lot of messages and sometimes power state info is not recognized. Since we have a 'powerinfo' command to get power state, let's use it to perform retry on retrieving power state info. BUG=chrome-os-partner:10256 TEST=Test passed. Change-Id: I173cdbe3a919a49a005fd4b63b52360ff94caadf Reviewed-on: https://gerrit.chromium.org/gerrit/25601 Commit-Ready: Vic Yang <victoryang@chromium.org> Reviewed-by: Vic Yang <victoryang@chromium.org> Tested-by: Vic Yang <victoryang@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|
01f74296a71f92767c7b92cf03095b0ee046e2b0 |
|
15-Jun-2012 |
Vic Yang <victoryang@chromium.org> |
Add a test of EC dropping X86 power into G3 after S5 This test checks if EC correctly drop X86 into G3 after S5 for 10 seconds. BUG=chrome-os-partner:10256 TEST=Test passed. Change-Id: I1b0669219af1420c4fe7a6b4174f9337122d8740 Reviewed-on: https://gerrit.chromium.org/gerrit/25388 Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org> Tested-by: Vic Yang <victoryang@chromium.org> Commit-Ready: Vic Yang <victoryang@chromium.org>
/external/autotest/server/site_tests/firmware_ECPowerG3/firmware_ECPowerG3.py
|