| 1bf1e9e0ddef515aaa41a70aa34821ff5564a71d |
|
18-Dec-2014 |
sameb <sameb@google.com> |
Add the source of the binding when mapbinder/multibinder fail because of a null
binding.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=82465720
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| bed1413751f54dc6804dcb2a4c28300081788603 |
|
04-Nov-2014 |
flan <flan@google.com> |
Adds a binding for Collection<javax.inject.Provider<E>> to Multibinder.
Before, only a Collection<com.google.inject.Provider<E>> was bound; now
both are bound.
Note that this required changes to SpiUtils because MapBinder uses a
Multibinder to bind Set<Entry<K, Provider<V>>. There is a bit of
strangeness here because it means that there is now a binding for
Collection<javax.inject.Provider<Map.Entry<K, Provider<V>>>.
Tested:
All existing and modified tests pass.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=79191051
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 9c8b61815fa15ee3457b9c816afe24a6fdaf7014 |
|
04-Nov-2014 |
flan <flan@google.com> |
Simplifies Multibinder by moving Key generation to RealMultibinder's
constructor.
Tested:
All existing tests pass.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=79159620
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 4faa20e3081448792933834aedfe972add806292 |
|
11-Aug-2014 |
Sam Berlin <sameb@google.com> |
Updating Multibinder to support injection of Collection<Provider<T>> alongside the usual Set<T>.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=72818888
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| c34e0185fcf508a890c6cd13bdafeb505c3e9e8a |
|
06-Aug-2014 |
Sam Berlin <sameb@google.com> |
Implement binding deduplication for multibinder & mapbinder in a different way.
Instead of relying on Guice binding deduplication (and hacking up RealElement
to break the annotation contract to do so, causing weirdness in WeakKeySet &
forcing us to care about "rehashing keys"), we instead deduplicate within
Multibinder. The downside of this is that toInstance or toProvider(instance)
bindings that are deduplicated will remain in the object graph but effectively
be unreachable. However, that's a downside I'm willing to live with to remove
this hack.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=72570932
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| c00df28be8bfa45b2bdc8b4d3c101c20a9cbdc12 |
|
01-Jul-2014 |
Sam Berlin <sameb@google.com> |
Automated code cleanups by internal tool.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=69390543
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 14e2703cd15b0ac745a0df80d25800692d8c727e |
|
03-May-2014 |
Sam Berlin <sameb@google.com> |
Implement hashCode and equals on type returned by Providers.of(...). There doesn't seem to be any reason *not* to provide these methods, and it means downstream code that does
bind(X.class).toProvider(Providers.of(null))
does not result in erroneous duplicate binding errors if Modules.override is used.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=65067530
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| c013facb2aa0af03206fd1af2d8314f6a414ec98 |
|
08-Apr-2014 |
Sam Berlin <sameb@google.com> |
*** Reason for rollback ***
Causes an internal test to become flaky.
*** Original change description ***
Enhance WeakKeySet to auto evict keys and avoid calling toString on Keys.
This should fix https://code.google.com/p/google-guice/issues/detail?id=756.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=64181193
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| bab9b6082ff7c3aefac2dc8c7de0468fe60fe8f6 |
|
02-Apr-2014 |
Christian Edward Gruber <cgruber@google.com> |
Enhance WeakKeySet to auto evict keys and avoid calling toString on Keys.
This should fix https://code.google.com/p/google-guice/issues/detail?id=756.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=64083354
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| af24f632f90fc91daeb30172b874405c131592c8 |
|
02-Apr-2014 |
Christian Edward Gruber <cgruber@google.com> |
Adds a new OptionalBinder. OptionalBinder allows frameworks to setup bindings for items that user code may or may not bind. It also allows frameworks to set default values that users can override.
The API is:
OptionalBinder.newOptionalBinder(Binder, Class|TypeLiteral|Key) -> OptionalBinder
optionalBinder.setDefault -> LinkedBindingBuilder
optionalBinder.setBinding -> LinkedBindingBuilder
By way of example, this will do:
newOptionalBinder(..) -> @Inject Thing -> exception: neither setDefault nor setBinding called
newOptionalBinder(..) -> @Inject Optional<Thing> -> isPresent() == false
newOptionalBinder(..).setDefault().to("a") -> @Inject Thing -> "a"
newOptionalBinder(..).setDefault().to("a") -> @Inject Optional<Thing> --> get() == "a"
newOptionalBinder(..).setDefault().to("a") + newOptionalBinder(..).setBinding().to("b") -> @Inject Thing -> "b"
newOptionalBinder(..).setDefault().to("a") + newOptionalBinder(..).setBinding().to("b") -> @Inject Optional<Thing> -> get() == "b"
newOptionalBinder(..).setBinding().to("b") -> @Inject Thing -> "b"
newOptionalBinder(..).setBinding().to("b") -> @Inject Optional<Thing> -> get() == "b"
newOptionalBinder(..).setDefault().to("a") + newOptionalBinder(..).setDefault().to("b") -> configuration exception
newOptionalBinder(..).setBinding().to("a") + newOptionalBinder(..).setBinding().to("b") -> configuration exception
(This also adds the jsr305 jar for build time, because doclava wanted it. Frustrating.)
(This also fixes users that implemented MultibindingsTargetVisitor, because I can't use default methods yet.)
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=63873859
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 96e81ba55441fd11c189d903ee2bd1806a23bd70 |
|
18-Sep-2013 |
Christian Edward Gruber <cgruber@google.com> |
An alternative way to support ShareableModule, Modules.override and Multibinder: use annotations that compare equal iff the binding strategy matches, so Guice will dedupe for us.
This CL includes a noteworthy adaptation of an earlier attempt which caused timeouts in some client tests, forcing a rollback ([]). Because Key caches its hashCode, we were inadvertently inserting every binding for a given multibound set into the same hashmap bucket, causing at best O(n^2) behaviour (and possibly worse, depending on how HashMap is implemented). To fix this, this CL adds changes to core Guice to recompute the Key's hashCode at injector construction time. (In fact, at the end of every Elements.getElements call, so any SPI-based code gets the same benefits.)
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=51233981
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 6c69bcf53d4122b0f05f44783c0d8a61afd83911 |
|
18-Sep-2013 |
Christian Edward Gruber <cgruber@google.com> |
An alternative way to support ShareableModule, Modules.override and Multibinder: use annotations that compare equal iff the binding strategy matches, so Guice will dedupe for us.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=50556753
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 3d3a9fa2eba286d8408ea933a28a0dcce6d7f7d1 |
|
09-Aug-2013 |
Christian Edward Gruber <cgruber@google.com> |
Give more information when duplicate elements are found in a multibound set.
Second attempt at [], which was rolled back in [], because it broke serializability. Turns out we were using Collections.immutableSet, not ImmutableSet.copyOf. Grrr.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=50346773
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 51829aa27bf05c2c84b6ca90225c61c55c675056 |
|
09-Aug-2013 |
Christian Edward Gruber <cgruber@google.com> |
Automated g4 rollback of changelist 50265868.
*** Reason for rollback ***
Multibound set is no longer Serializable, whoops.
*** Original change description ***
Give more information when duplicate elements are found in a multibound set.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=50268399
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 28c75b267faec7cdc710747bed9ac5f6a3c0c50b |
|
09-Aug-2013 |
Christian Edward Gruber <cgruber@google.com> |
Give more information when duplicate elements are found in a multibound set.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=50265868
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 21a19670ce07439d616a7a38a9907560eaa6a25d |
|
21-Jan-2012 |
Sam Berlin <sameb@google.com> |
Fix issue 670, keep values from MapBinder & Multibinder distinct.
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 45ef01760942b9575a6094effeb4eb034db9a113 |
|
14-Jan-2012 |
Sam Berlin <sameb@google.com> |
Cleanup a few things:
1) Remove invalid annotation.
2) Update to Guava 11.0.1, from r9.
3) Remove some unused files.
4) Forcibly keep Throwables, since servlet uses it but core doesn't (so jarjar
was wiping it).
5) Disable failing Multibinder test.
R=jessewilson
DELTA=193 (10 added, 174 deleted, 9 changed)
Revision created by MOE tool push_codebase.
MOE_MIGRATION=4087
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| e390a0f7070733c9aa7e16f40e56e5a229dfcd97 |
|
09-Sep-2011 |
guice.mirrorbot@gmail.com <guice.mirrorbot@gmail.com@d779f126-a31b-0410-b53b-1d3aecad763e> |
Failing test for a multibinder bug reported here:
http://groups.google.com/group/google-guice/browse_thread/thread/934e30b7ed0da98f/b90383ad4cd1228c
Revision created by MOE tool push_codebase.
MOE_MIGRATION=3231
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1583 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| ee443bce9731bb8da1eb60202f68de4c4c298698 |
|
09-Sep-2011 |
guice.mirrorbot@gmail.com <guice.mirrorbot@gmail.com@d779f126-a31b-0410-b53b-1d3aecad763e> |
Fix issue 644. Print a better error message when requestStaticInjection is called on an interface, fix it so that static injection errors show the source of the static injection.
Revision created by MOE tool push_codebase.
MOE_MIGRATION=3070
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1578 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 6585c73bd39373a7ec3613f0bd77e376b118db5f |
|
09-Aug-2011 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
Failing test for a multibinder bug reported here:
http://groups.google.com/group/google-guice/browse_thread/thread/934e30b7ed0da98f/b90383ad4cd1228c
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1577 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| b7a02b02d81c830d148355c90bc309bcd66fb592 |
|
08-Jul-2011 |
sberlin <sberlin@d779f126-a31b-0410-b53b-1d3aecad763e> |
* Remove unused imports
* Sort imports
* Convert tabs to spaces
* Fix the ant no_aop build
Revision created by MOE tool push_codebase.
MOE_MIGRATION=2532
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1572 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| d9c913acca55023ef5d76a32c3d4a51ee6b420cb |
|
26-Jun-2011 |
sberlin <sberlin@d779f126-a31b-0410-b53b-1d3aecad763e> |
switch Guice from manually repackaging Guava to depending on Guava. it's still jarjar'd right now, which is causing a ~400k increase in guice-snapshot.jar. next step is to switch to ProGuard to remove the unnecessary code and cut it back down (even further?!). this will let people build from Guice source and depend directly on Guava code without having to worry about hiding internal/util.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1558 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 8b64d455b982d5841480a0247c15d68de0759c91 |
|
13-Dec-2010 |
sberlin <sberlin@d779f126-a31b-0410-b53b-1d3aecad763e> |
Remove InjectorBuilder in favor of methods in Binder.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1457 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 75fcf6f3a7ae2000b8ed85038dfd33bedd0503fa |
|
20-Sep-2010 |
sberlin <sberlin@d779f126-a31b-0410-b53b-1d3aecad763e> |
issue 539 - extension SPI for Multibinder/MapBinder.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1253 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 9a227bef3b82a045323ef2cf38ec60b2e42cf0fe |
|
03-Jul-2010 |
limpbizkit@gmail.com <limpbizkit@gmail.com@d779f126-a31b-0410-b53b-1d3aecad763e> |
Move internal utility code to separate package.
These files have moved from c.g.i.internal to c.g.i.internal.util. Visibility has been increased when necessary.
AbstractIterator.java
AbstractMapEntry.java
AsynchronousComputationException.java
Classes.java
Collections2.java
ComputationException.java
CustomConcurrentHashMap.java
ExpirationTimer.java
FinalizablePhantomReference.java
FinalizableReference.java
FinalizableReferenceQueue.java
FinalizableSoftReference.java
FinalizableWeakReference.java
Finalizer.java
Function.java
Hashing.java
ImmutableCollection.java
ImmutableEntry.java
ImmutableList.java
ImmutableMap.java
ImmutableSet.java
Iterables.java
Iterators.java
Join.java
LineNumbers.java
Lists.java
MapMaker.java
Maps.java
NullOutputException.java
ObjectArrays.java
Objects.java
Preconditions.java
Sets.java
SourceProvider.java
StackTraceElements.java
Stopwatch.java
Strings.java
ToStringBuilder.java
UnmodifiableIterator.java
The rest of this change is just imports changes. Thanks to Max Bowsher for the idea.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1185 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 680c8b527ea94df6161aa9a61f00563338221e64 |
|
11-Jun-2010 |
sberlin <sberlin@d779f126-a31b-0410-b53b-1d3aecad763e> |
fixes issue 490 -- sets using marker annotations don't work properly all the time.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1173 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 34d2f00eee00ba170c3dffa72154399b830a67a6 |
|
02-May-2010 |
sberlin <sberlin@d779f126-a31b-0410-b53b-1d3aecad763e> |
add two more failing tests for Map/Multibinder -- permitDuplicates should be allowable through Module.overrides calls.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1157 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 8bc8387f63053ac03b609277093a06019c7b18b3 |
|
26-Apr-2010 |
sberlin <sberlin@d779f126-a31b-0410-b53b-1d3aecad763e> |
issue 297 -- allow Multibinder's dependencies to be retrieved in Stage.TOOL. also added a failing test for MapBinder & Modules.override (analog to existing failing test in MultibinderTest).
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1154 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| d8750fdcd8a32d0e6caaa2919414a479acbd1bb6 |
|
11-Aug-2009 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
some test fixes for ScopeChecker and Multibinder
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1059 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 398017ae4ed96750fa54dc9ce59dc2f974dcf541 |
|
23-Jun-2009 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
New API: Multibinder.permitDuplicates() and MapBinder.permitDuplicates()
When a map binder is configured to permit duplicate keys, the value chosen is arbitrary! This may be frustrating; but otherwise it would be necessary to actually call Provider.get() on the duplicated values to compare 'em; I think the cure would be worse than the disease
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1034 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 63a9605ee0b3190071c38ce7ada836cbbb9d2864 |
|
30-Mar-2009 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
Test cases that prove we have reliable iteration order for Multibinder and MapBinder
git-svn-id: https://google-guice.googlecode.com/svn/trunk@918 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 53664a7f17492bd0c3c4728df61679147907dd18 |
|
21-Feb-2009 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
Regrettably replacing jarjar'd Google Collections with minimal copies of the parts that we use.
The main benefit is a (significant) reduction in size of the Guice+AOP .jar - from 1004KB to 641KB. The drawback is that it's now a lot harder to use new Google Collections features, or to keep up-to-date with Google Collections bugfixes and optimizations.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@859 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| ddb3862415e078080293abba05f1a24a921c007c |
|
29-Dec-2008 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
Supporting HasDependencies for Multibinder, MapBinder and AssistedInject v1.
AssistedInject v2 support isn't here yet, it's difficult. Since we use a child injector in that package, we need a strategy for how the bindings from that injector should work. I don't think getting this perfect is urgent.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@747 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 72d11dd102eeebf081aa5363469d28b25f9b1384 |
|
02-Nov-2008 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
Taking advantage of the error message changes in some extensions.
AssistedInject, PrivateModules and Multibindings now have nice messages that are integrated into the main CreationException.
Also tweaking the errors in Binder and Errors. If a module throws a ConfigurationException, that message will be embedded in the main CreationException message.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@655 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| a6e0e787c546a1d5e82861b5c851ca09e3bbfd06 |
|
03-Sep-2008 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
Moving error sources so they're now reported in the same place for configuration errors and runtime errors. This means that instead of seeing this:
1) Error at com.google.Foo.class(Foo.java:123)
No constructor for Foo was found
We see this:
1) No constructor for Foo was found
at com.google.Foo.class(Foo.java:123)
And what's really nice is we can now have a long chain of sources for errors. For example, suppose we follow bindings and discover something that won't work via a transitive dependency. That'll look like this:
1) No constructor for Foo was found
at com.google.Foo.class(Foo.java:123)
for parameter 0 at com.google.Bar.inject(Bar.java:345)
for field at com.google.Baz.baz(Baz.java:567)
I'll still need to go over the errors code with a few more passes to tighten things up. But I believe this is a small leap forward in the usability in our already-fantastic errors.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@615 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 9532e6267f55105992301add5accfb5c62fdeed8 |
|
18-Jun-2008 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
Eliminated static from SourceProviders. The new mechanism to specify the source of a binding is like this:
Binder myBinder = binder.withSource(source);
git-svn-id: https://google-guice.googlecode.com/svn/trunk@525 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 49f67c0f62bc1748dd32e1d86616085231e974e7 |
|
10-Jun-2008 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
Fixing owner types so they're no longer missing in ThrowingProviderBinder. Also adding the necessary precondition checks so that we always include 'em when necessary.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@514 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| eab76471fbc2118a3c07d103d4b5548e153ed9e7 |
|
26-May-2008 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
A bunch of polish fixes for 2.0:
-All built-in Matchers are now Serializable. I needed to convert all anonymous inner classes to named nested classes.
-Objects.hashCode()
-Introducing a Types utility class with Serializable ParameterizedType and GenericArrayType implementations. Their hashCodes are consistent with Sun's JDK, although I'm not sure if that means they'll work on other Java SDKs.
- TypeLiteral Serialization fixups. Sun's Type implementations aren't Serializable, so I do some writeReplace hackery to make it just work.
- Adding some missing calls to fail() in try/catch tests
- Introducing the Asserts utility class. I'd like to keep this as lean as possible. Currently it's just the stuff we really need.
- A new TypeLiteral test that shows a problem where two keys that are functionally the same aren't equal
git-svn-id: https://google-guice.googlecode.com/svn/trunk@489 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| d6967b937274e0e1dab28a196d7aab647c5cc6a4 |
|
16-May-2008 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
More testcases for multibindings, including some fairly specific tests for toString() on the Binder API
git-svn-id: https://google-guice.googlecode.com/svn/trunk@483 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 83b510c924832d38df1a3030e69863098432fffb |
|
01-May-2008 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
Fixes from David P Baker's review.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@458 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 7c533acbed7ce9c051e847a290dd2060915e91aa |
|
01-May-2008 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
There was a pretty horrible bug in Multibinder where collections were checked for annotation but not element type.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@457 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|
| 5019270849439d3aa58bc086a4514d7471716a35 |
|
01-May-2008 |
limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> |
New multibindings extension.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@452 d779f126-a31b-0410-b53b-1d3aecad763e
/external/guice/extensions/multibindings/test/com/google/inject/multibindings/MultibinderTest.java
|