| ab9b2d1516cad017c6e0236c468934582530c965 |
|
14-Oct-2015 |
deadbeef <deadbeef@webrtc.org> |
Reland of Moving MediaStreamSignaling logic into PeerConnection. (patchset #1 id:1 of https://codereview.webrtc.org/1403633005/ )
Reason for reland:
The original CL actually didn't break browser_tests; it was
just a coincidence that it started failing.
Original issue's description:
> Revert of Moving MediaStreamSignaling logic into PeerConnection. (patchset #10 id:180001 of https://codereview.webrtc.org/1393563002/ )
>
> Reason for revert:
> Broke browser_tests on Mac. Still need to investigate the cause.
>
> Original issue's description:
> > Moving MediaStreamSignaling logic into PeerConnection.
> >
> > This needs to happen because in the future, m-lines will be offered
> > based on the set of RtpSenders/RtpReceivers, rather than the set of
> > tracks that MediaStreamSignaling knows about.
> >
> > Besides that, MediaStreamSignaling was a "glue class" without
> > a clearly defined role, so it going away is good for other
> > reasons as well.
> >
> > Committed: https://crrev.com/97c392935411398b506861601c82e31d95c591f0
> > Cr-Commit-Position: refs/heads/master@{#10268}
>
> TBR=pthatcher@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/fc648b6d934e936f4d9a32c813364b331536ec3b
> Cr-Commit-Position: refs/heads/master@{#10269}
TBR=pthatcher@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1404473005
Cr-Commit-Position: refs/heads/master@{#10277}
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| fc648b6d934e936f4d9a32c813364b331536ec3b |
|
14-Oct-2015 |
deadbeef <deadbeef@webrtc.org> |
Revert of Moving MediaStreamSignaling logic into PeerConnection. (patchset #10 id:180001 of https://codereview.webrtc.org/1393563002/ )
Reason for revert:
Broke browser_tests on Mac. Still need to investigate the cause.
Original issue's description:
> Moving MediaStreamSignaling logic into PeerConnection.
>
> This needs to happen because in the future, m-lines will be offered
> based on the set of RtpSenders/RtpReceivers, rather than the set of
> tracks that MediaStreamSignaling knows about.
>
> Besides that, MediaStreamSignaling was a "glue class" without
> a clearly defined role, so it going away is good for other
> reasons as well.
>
> Committed: https://crrev.com/97c392935411398b506861601c82e31d95c591f0
> Cr-Commit-Position: refs/heads/master@{#10268}
TBR=pthatcher@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1403633005
Cr-Commit-Position: refs/heads/master@{#10269}
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 97c392935411398b506861601c82e31d95c591f0 |
|
13-Oct-2015 |
deadbeef <deadbeef@webrtc.org> |
Moving MediaStreamSignaling logic into PeerConnection.
This needs to happen because in the future, m-lines will be offered
based on the set of RtpSenders/RtpReceivers, rather than the set of
tracks that MediaStreamSignaling knows about.
Besides that, MediaStreamSignaling was a "glue class" without
a clearly defined role, so it going away is good for other
reasons as well.
Review URL: https://codereview.webrtc.org/1393563002
Cr-Commit-Position: refs/heads/master@{#10268}
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 0c4e06b4c6107a1b94f764e279e4fb4161e905b0 |
|
07-Oct-2015 |
Peter Boström <pbos@webrtc.org> |
Use suffixed {uint,int}{8,16,32,64}_t types.
Removes the use of uint8, etc. in favor of uint8_t.
BUG=webrtc:5024
R=henrik.lundin@webrtc.org, henrikg@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1362503003 .
Cr-Commit-Position: refs/heads/master@{#10196}
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 0edd50ccb34cc2dc4746137fdce1f5cf66808274 |
|
01-Jul-2015 |
bemasc <bemasc@webrtc.org> |
Support for onbufferedamountlow
Original review at https://webrtc-codereview.appspot.com/54679004/
BUG=https://code.google.com/p/chromium/issues/detail?id=496700
Review URL: https://codereview.webrtc.org/1207613006
Cr-Commit-Position: refs/heads/master@{#9527}
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 5c6c6e026bbcc83ad546d00b41ab739dcc856c1b |
|
29-May-2015 |
Lally Singh <lally@google.com> |
Implements TODOs for webrtc::datachannel state management when the SCTP association is congested. Adds missing state variables for each step in the transitions between DataChannelInterface::DataStates (kConnecting, kOpen, etc.), and uses them.
BUG=https://code.google.com/p/chromium/issues/detail?id=474650
R=jiayl@webrtc.org, pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44299004
Cr-Commit-Position: refs/heads/master@{#9331}
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| eebcab5ce99d3e8641dd92a569916b0d24e29fca |
|
24-Mar-2015 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
rtc::Buffer: Rename length to size, for conformance with the STL
And add a constructor for creating an uninitialized Buffer of a
specified size.
(I intend to follow up with more Buffer changes, but since it's rather
widely used, the rename is quite noisy and works better as a separate
CL.)
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48579004
Cr-Commit-Position: refs/heads/master@{#8841}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8841 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| cceb166a3fd2724c679da7d093149b0511e8d99b |
|
22-Jan-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Fix a use-after-free when sending queued messages is aborted for blocked channel.
BUG=4187
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39519004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8119 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 5f93d0a140515e3b8cdd1b9a4c6f5871144e5dee |
|
20-Jan-2015 |
jlmiller@webrtc.org <jlmiller@webrtc.org> |
Update libjingle license statements at top of talk files for consistency
BUG=2133
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8105 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 9b5467e88d6f1b3cadb2f9d04941a2b4dec77188 |
|
05-Dec-2014 |
bemasc@webrtc.org <bemasc@webrtc.org> |
Fix assertion failure when closing data channel, and add a unit test.
BUG=4066
R=jiayl@webrtc.org, juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31109004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7816 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 6ca6190be2bdb6dc50a77e393e747cf8f55ea2c0 |
|
12-Nov-2014 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Fix a SCTP message reordering issue in datachannel.cc.
Previously DataChannel::SendQueuedDataMessages continues the loop of sending queued messages if the channel is blocked, which will cause message reordering if the channel becomes unblocked during the loop, i.e. messages attempted after the unblocking will be sent earlier than the older messages attempted before the unblocking.
BUG=3979
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25149004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7690 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| d4e598d57aed714a599444a7eab5e8fdde52a950 |
|
29-Jul-2014 |
buildbot@webrtc.org <buildbot@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
(Auto)update libjingle 72097588-> 72159069
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6799 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 3edbaaf33744e5b24e6946d4b84174e8db2d161e |
|
19-Jul-2014 |
jiayl@webrtc.org <jiayl@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Ignore empty data in DataChannel::Send to match FF's behavior.
BUG=crbug/395205
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16949004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6742 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| b43c99de297e2686233cf495625ba1d87cbfe0e4 |
|
20-Jun-2014 |
jiayl@webrtc.org <jiayl@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Limits the send and receive buffer by bytes, not by packets.
The new limit is 16MB for each buffer.
Also refactors the code to handle send failure more consistently.
BUG=3429
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21559005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6511 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 9f8164c06054016978378b7a01a9180106d92771 |
|
30-May-2014 |
jiayl@webrtc.org <jiayl@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Fix two bugs in DataChannel state transition.
1. OnStateChange should not be fired if state is not changed.
2. RemotePeerRequestClose should be a no-op if it's already closed.
TBR=pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/21559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6290 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 5dc51fbe50e632d5db225a2f6cbaaba1700e976c |
|
29-May-2014 |
jiayl@webrtc.org <jiayl@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Closes the DataChannel when the send buffer is full or on transport errors.
As stated in the spec.
BUG=2645
R=pthatcher@google.com, wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6270 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| b364016cbb7cf8f7050932bcd2b2ee5c9e600dbd |
|
28-May-2014 |
jiayl@webrtc.org <jiayl@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert r6161 "Drop the DataChannel message if it's received when the channel is not open."
The spec does not say the DataChannel has to be open to receive a message.
TBR=pthatcher@google.com
BUG=crbug/363005
Review URL: https://webrtc-codereview.appspot.com/16569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6264 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 4f5801494d7ea3e8ef0df545404cb45a4a0558b6 |
|
14-May-2014 |
jiayl@webrtc.org <jiayl@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Drop the DataChannel message if it's received when the channel is not open.
It may happen when the JS has closed the channel on the signaling thread while messages are received on the worker thread and posted before the state change is pushed to the worker thread.
BUG=crbug/363005
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19469005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6161 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| aebb1ade9d760841f243e380fa22b7ecff2d3ecc |
|
14-Jan-2014 |
henrika@webrtc.org <henrika@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
pRevert 5371 "Revert 5367 "Update talk to 59410372.""
> Revert 5367 "Update talk to 59410372."
>
> > Update talk to 59410372.
> >
> > R=jiayl@webrtc.org, wu@webrtc.org
> >
> > Review URL: https://webrtc-codereview.appspot.com/6929004
>
> TBR=mallinath@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/6999004
TBR=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7109004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5381 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 44461fa5cbecd556691b0ba963f95973f6abece1 |
|
13-Jan-2014 |
henrika@webrtc.org <henrika@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert 5367 "Update talk to 59410372."
> Update talk to 59410372.
>
> R=jiayl@webrtc.org, wu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/6929004
TBR=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5371 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 0f3356e20b70416f13e12ef596da66f6c347eea7 |
|
11-Jan-2014 |
mallinath@webrtc.org <mallinath@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update talk to 59410372.
R=jiayl@webrtc.org, wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6929004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5367 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| a23f0ca4ba5105eb76b6fa30447c806812a8f3c2 |
|
13-Nov-2013 |
sergeyu@chromium.org <sergeyu@chromium.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update talk to 56619788
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3839005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5120 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 07a6fbe83d901fc9b98579ab44e8c9632f038b36 |
|
04-Nov-2013 |
wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update talk to 56092586.
R=jiayl@webrtc.org, mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3359004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5078 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| cecfd1832dc375225da3f5f18ecac63006ed06bf |
|
30-Oct-2013 |
wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update talk to 55821645.
TEST=try bots
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3139004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5053 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 78187525665490922748d79377bcb351579e03c0 |
|
08-Oct-2013 |
wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update libjingle to 53856368.
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2366004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4941 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| a59696b2a5f0c138d4176249bac223ad6c4316d5 |
|
14-Sep-2013 |
sergeyu@chromium.org <sergeyu@chromium.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update libjingle to 52300956
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2213004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4744 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| cadf9040cbb9e7bb1b73a95e43e7d228fe6b2bdb |
|
30-Aug-2013 |
wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update talk to 51664136.
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2148004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4649 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 822fbd8b68ffdb481b9557e2950ae8d6657c8ce6 |
|
16-Aug-2013 |
wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update talk to 50918584.
Together with Stefan's http://review.webrtc.org/1960004/.
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2048004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4556 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 91053e7c5a743f4a92f5079844b0747c927f3bbd |
|
10-Aug-2013 |
wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update libjingle to 50654631.
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2000006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4519 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| a054569c15631aeab407fba92d782f3410cb3ef4 |
|
02-Aug-2013 |
wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Fix memory leak in datachannel and its test.
RISK=P3
TESTED=memcheck build
tools/valgrind-webrtc/webrtc_tests.sh --tool memcheck --test out/Debug/libjingle_peerconnection_unittest --gtest_filter=SctpDataChannelTest*
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1941005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4470 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| d64719d8954262fee94e7615422f3d027dc1ae6b |
|
01-Aug-2013 |
wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update libjingle to 50191337.
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1885005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4461 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|
| 28e20752806a492f5a6a5d343c02f9556f39b1cd |
|
10-Jul-2013 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds trunk/talk folder of revision 359 from libjingles google code to
trunk/talk
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/datachannel.cc
|