| 55674ffb32307c6f3efaab442340d3c5c075073b |
|
14-Jan-2016 |
Stefan Holmer <stefan@webrtc.org> |
Reland Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket.
Chromium reported errors when building libjingle_nacl due to some methods used virtual instead of override when they were overriding the base class. My guess is that when one method starts using override, all other in the same class must too.
R=tommi@webrtc.org
TBR=pthatcher@webtrc.org
BUG=4173
Review URL: https://codereview.webrtc.org/1589563003 .
Cr-Commit-Position: refs/heads/master@{#11251}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| e5e0e57bdfd8831b2ad917e7990e273fdfe26af4 |
|
14-Jan-2016 |
tommi <tommi@webrtc.org> |
Revert of Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket. (patchset #3 id:40001 of https://codereview.webrtc.org/1577873003/ )
Reason for revert:
Broke Chrome:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/143025/steps/compile%20%28with%20patch%29/logs/stdio
FAILED: cd ../../third_party/libjingle; python ../../native_client/build/build_nexe.py --root ../.. --product-dir ../../out/Debug/xyz --config-name Debug -t ../../native_client/toolchain/ --arch pnacl --build newlib_plib --name ../../out/Debug/gen/tc_pnacl_newlib/lib/libjingle_nacl.a --objdir ../../out/Debug/obj/third_party/libjingle/libjingle_nacl.gen/pnacl_newlib-pnacl/libjingle_nacl "--include-dirs=../../out/Debug/gen/tc_pnacl_newlib/include ../.. \"../../out/Debug/gen\" ./source ../ ../../native_client_sdk/src/libraries ../../native_client_sdk/src/libraries/nacl_io/include ../../native_client_sdk/src/libraries/third_party/newlib-extras ../expat/files/lib ../boringssl/src/include" "--compile_flags=-O2 -g -Wall -fdiagnostics-show-option -Werror -Wno-unused-function -Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args -Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts -Wno-unused-function \"-std=gnu++11\" " --gomadir /b/build/goma "--defines=\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" \"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" \"NACL_BUILD_ARCH=x86\" V8_DEPRECATION_WARNINGS \"CLD_VERSION=2\" \"_FILE_OFFSET_BITS=64\" CHROMIUM_BUILD \"CR_CLANG_REVISION=255169-1\" COMPONENT_BUILD UI_COMPOSITOR_IMAGE_TRANSPORT \"USE_AURA=1\" \"USE_ASH=1\" \"USE_PANGO=1\" \"USE_CAIRO=1\" \"USE_DEFAULT_RENDER_THEME=1\" \"USE_LIBJPEG_TURBO=1\" \"USE_X11=1\" \"IMAGE_LOADER_EXTENSION=1\" \"ENABLE_WEBRTC=1\" \"ENABLE_MEDIA_ROUTER=1\" USE_PROPRIETARY_CODECS ENABLE_PEPPER_CDMS ENABLE_CONFIGURATION_POLICY ENABLE_NOTIFICATIONS \"ENABLE_HIDPI=1\" \"ENABLE_TOPCHROME_MD=1\" USE_UDEV DONT_EMBED_BUILD_METADATA \"DCHECK_ALWAYS_ON=1\" FIELDTRIAL_TESTING_ENABLED \"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\" \"ENABLE_PDF=1\" \"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\" \"ENABLE_PRINTING=1\" \"ENABLE_PRINT_PREVIEW=1\" \"ENABLE_SPELLCHECK=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\" \"ENABLE_SUPERVISED_USERS=1\" \"ENABLE_MDNS=1\" \"ENABLE_SERVICE_DISCOVERY=1\" V8_USE_EXTERNAL_STARTUP_DATA FULL_SAFE_BROWSING SAFE_BROWSING_CSD SAFE_BROWSING_DB_LOCAL EXPAT_RELATIVE_PATH FEATURE_ENABLE_SSL GTEST_RELATIVE_PATH HAVE_OPENSSL_SSL_H NO_MAIN_THREAD_WRAPPING NO_SOUND_SYSTEM WEBRTC_POSIX SRTP_RELATIVE_PATH SSL_USE_OPENSSL USE_WEBRTC_DEV_BRANCH \"timezone=_timezone\" XML_STATIC \"USE_LIBPCI=1\" \"USE_OPENSSL=1\" \"USE_OPENSSL_CERTS=1\"" "--link_flags=-B../../out/Debug/gen/tc_pnacl_newlib/lib " "--source-list=../../out/gypfiles/third_party/libjingle/pnacl_newlib.libjingle_nacl.source_list.gypcmd"
In file included from ../webrtc/p2p/base/tcpport.cc:67:
../webrtc/p2p/base/tcpport.h:50:23: error: 'CreateConnection' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual Connection* CreateConnection(const Candidate& address,
^
../webrtc/p2p/base/portinterface.h:71:23: note: overridden virtual function is here
virtual Connection* CreateConnection(
^
In file included from ../webrtc/p2p/base/tcpport.cc:67:
../webrtc/p2p/base/tcpport.h:53:16: error: 'PrepareAddress' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual void PrepareAddress();
^
../webrtc/p2p/base/portinterface.h:63:16: note: overridden virtual function is here
virtual void PrepareAddress() = 0;
^
(etc)
Original issue's description:
> Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket.
>
> To reduce the risk of future mistakes when connecting Ports, Port::OnSentPacket was made pure virtual to ensure that new implementations take care of it.
>
> BUG=4173
> R=pthatcher@webrtc.org
>
> Committed: https://crrev.com/7307952a5bf63311e5f9a2a90089a06177e42716
> Cr-Commit-Position: refs/heads/master@{#11247}
TBR=pthatcher@webrtc.org,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=4173
Review URL: https://codereview.webrtc.org/1586063002
Cr-Commit-Position: refs/heads/master@{#11249}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 7307952a5bf63311e5f9a2a90089a06177e42716 |
|
14-Jan-2016 |
Stefan Holmer <stefan@webrtc.org> |
Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket.
To reduce the risk of future mistakes when connecting Ports, Port::OnSentPacket was made pure virtual to ensure that new implementations take care of it.
BUG=4173
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1577873003 .
Cr-Commit-Position: refs/heads/master@{#11247}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 112fe43b9f3f04592f1ccff6b4f23fcd2890bf30 |
|
30-Dec-2015 |
honghaiz <honghaiz@webrtc.org> |
Fill the remote pwd in the ice candidates when an ICE credential is received.
Also when a STUN ping arrives from an unknown address, try to find the pwd and generation from the remote ICE parameters.
BUG=
Review URL: https://codereview.webrtc.org/1549633004
Cr-Commit-Position: refs/heads/master@{#11144}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| a54a0801121e05f797e514731cc5c9bad2f5e597 |
|
17-Dec-2015 |
honghaiz <honghaiz@webrtc.org> |
Add ufrag to the ICE candidate signaling.
On the receiving side, if a candidate arrives with an old ufrag, it will be dropped. If it contains a new frag that has never seen before, it will hold the ufrag and create connections, although those connections are not pingable until the ICE credentials are received.
This could avoid a bunch of ICE generation issues.
BUG=webrtc:5138,webrt:5292
Review URL: https://codereview.webrtc.org/1498993002
Cr-Commit-Position: refs/heads/master@{#11060}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| f9945b2d1aa2d78b19987219ea872605167d7b5f |
|
15-Dec-2015 |
Honghai Zhang <honghaiz@webrtc.org> |
Only try to pair protocol matching candidates for creating connections.
If the local port and the remote candidate's protocols do not match,
do not even try to pair them.
This avoids printing out confusing logs like
"Attempt to change a remote candidate..." in p2ptransportchannel
when two remote candidates have the same port number but different
protocols.
BUG=
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1516613002 .
Cr-Commit-Position: refs/heads/master@{#11034}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 381b4217cb36f434c56e399a852a0a15522a9596 |
|
04-Dec-2015 |
Honghai Zhang <honghaiz@webrtc.org> |
Ping backup connection at a slower rate
and make it configurable from the app.
Changed the decision on whether a connection is pingable:
1.Check whether a connection is a backup connection. A connection is considered as a backup connection only if the channel is complete, the connection is active and it is not the best connection.
2. Ping a non-backup connection if it is active and for backup connection, ping it at a slower rate.
Note the default behavior is the same as before.
Also cached the channel state since we are accessing it more often.
BUG=webrtc:5034
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1455033004 .
Cr-Commit-Position: refs/heads/master@{#10900}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| a8e9f5e4e4d57978bcee052e5af020a0cd960c52 |
|
12-Nov-2015 |
honghaiz <honghaiz@webrtc.org> |
A little cleanup in p2ptransportchannel and transportchannel.
No functional changes.
BUG=
Review URL: https://codereview.webrtc.org/1411103012
Cr-Commit-Position: refs/heads/master@{#10614}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 9b5ee9c0d988b1d0dc64920937448e301dd45bd9 |
|
11-Nov-2015 |
honghaiz <honghaiz@webrtc.org> |
Send back ping response if the ping comes from an unknown address.
BUG=webrtc:5171
Review URL: https://codereview.webrtc.org/1424703012
Cr-Commit-Position: refs/heads/master@{#10610}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 9b66957b4f7dfe40c17eed597826b3ed0faf5439 |
|
04-Nov-2015 |
honghaiz <honghaiz@webrtc.org> |
Stop a session when a new connection becomes writable.
We cannot do it at the end of sorting because it may stop a session too early.
Also remove was_writable_, which is not useful.
BUG=webrtc:5119
Review URL: https://codereview.webrtc.org/1406423008
Cr-Commit-Position: refs/heads/master@{#10511}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 98f53510b222f71fdd8b799b2f33737ceeb28c61 |
|
28-Oct-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
system_wrappers: rename interface -> include
BUG=webrtc:5095
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1413333002 .
Cr-Commit-Position: refs/heads/master@{#10438}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 77d0d6e858203cbc559b2f5d6ffabb7bc2fcb8e6 |
|
27-Oct-2015 |
honghaiz <honghaiz@webrtc.org> |
When all connections timed out on writing, delete them all.
BUG=5111
Review URL: https://codereview.webrtc.org/1421123003
Cr-Commit-Position: refs/heads/master@{#10431}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| b0bb77fd615c5ce413b16f6157b2ffc25898631f |
|
26-Oct-2015 |
guoweis <guoweis@webrtc.org> |
Reland of Add experiment on weak ping delay during call set up time (patchset #1 id:1 of https://codereview.webrtc.org/1416773003/ )
Reason for revert:
https://codereview.chromium.org/1419253002 is landed to address this linker issue. Keep my fingers crossed.
Original issue's description:
> Revert of Add experiment on weak ping delay during call set up time (patchset #4 id:60001 of https://codereview.webrtc.org/1411883002/ )
>
> Reason for revert:
> This CL breaks Chromium, undefined reference link error to webrtc::field_trial::FindFullName. Adding the dependency system_wrappers to the rtc_p2p target is not enough to fix this.
>
> Looking at field_trial.h (in system_wrappers/interface/, not to be confused with the one in test/) the documentation says "WebRTC clients MUST provide an implementation of: ...FindFullName... Or link with a default one provided in: ...system_wrappers.gyp:field_trial_default).
>
> So maybe just depend on field_trial_default? Not sure what should be done in case there are implications to adding this dependency, I'm reverting this. Sorry :)
>
> Original issue's description:
> > Add experiment on weak ping delay during call set up time
> >
> > BUG=
> > R=pthatcher@webrtc.org
> >
> > Committed: https://crrev.com/3bf69b15f4c0c0ca4ab17c237084684a37bb8279
> > Cr-Commit-Position: refs/heads/master@{#10343}
>
> TBR=pthatcher@webrtc.org,juberti@webrtc.org,guoweis@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
TBR=pthatcher@webrtc.org,juberti@webrtc.org,hbos@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.webrtc.org/1413603005
Cr-Commit-Position: refs/heads/master@{#10418}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 4f6a8b5f559c5f782af396efeb42cf94de0623be |
|
23-Oct-2015 |
guoweis <guoweis@webrtc.org> |
Revert of Add experiment on weak ping delay during call set up time (patchset #1 id:1 of https://codereview.webrtc.org/1406153005/ )
Reason for revert:
Still cause break on mac. reverting it again.
Original issue's description:
> Reland of Add experiment on weak ping delay during call set up time (patchset #1 id:1 of https://codereview.webrtc.org/1423443002/ )
>
> Reason for revert:
> This should be safe to land now.
>
> Original issue's description:
> > Revert of Add experiment on weak ping delay during call set up time (patchset #4 id:60001 of https://codereview.webrtc.org/1411883002/ )
> >
> > Reason for revert:
> > guoweis - Here's the target that's failing:
> > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle_nacl.gyp&l=17
> >
> > This has unfortunately been causing problems repeatedly for us since libjingle_nacl is maintained separately from libjingle (I don't know the history).
> >
> > The way this works for Chrome in general is that the FindFullName method is implemented in init_webrtc.cc in the overrides folder in Chrome and that hooks WebRTC up with Chrome's implementation. I'm not sure if that's the right thing to do for nacl, how webrtc is initialized there etc. I'll ping the nacl team for some help too offline and include you. Reverting this change for now.
> >
> > Original issue's description:
> > > Add experiment on weak ping delay during call set up time
> > >
> > > BUG=
> > > R=pthatcher@webrtc.org
> > >
> > > Committed: https://crrev.com/3bf69b15f4c0c0ca4ab17c237084684a37bb8279
> > > Cr-Commit-Position: refs/heads/master@{#10343}
> >
> > TBR=pthatcher@webrtc.org,juberti@webrtc.org,guoweis@webrtc.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=
> >
> > Committed: https://crrev.com/a01d44022355796d4fd86d00aae6d3263573b6f1
> > Cr-Commit-Position: refs/heads/master@{#10350}
>
> TBR=pthatcher@webrtc.org,juberti@webrtc.org,tommi@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://crrev.com/e26ce1b7a4644942b239ed788a737200762db3b3
> Cr-Commit-Position: refs/heads/master@{#10379}
TBR=pthatcher@webrtc.org,juberti@webrtc.org,tommi@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.webrtc.org/1413843003
Cr-Commit-Position: refs/heads/master@{#10380}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| e26ce1b7a4644942b239ed788a737200762db3b3 |
|
23-Oct-2015 |
guoweis <guoweis@webrtc.org> |
Reland of Add experiment on weak ping delay during call set up time (patchset #1 id:1 of https://codereview.webrtc.org/1423443002/ )
Reason for revert:
This should be safe to land now.
Original issue's description:
> Revert of Add experiment on weak ping delay during call set up time (patchset #4 id:60001 of https://codereview.webrtc.org/1411883002/ )
>
> Reason for revert:
> guoweis - Here's the target that's failing:
> https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle_nacl.gyp&l=17
>
> This has unfortunately been causing problems repeatedly for us since libjingle_nacl is maintained separately from libjingle (I don't know the history).
>
> The way this works for Chrome in general is that the FindFullName method is implemented in init_webrtc.cc in the overrides folder in Chrome and that hooks WebRTC up with Chrome's implementation. I'm not sure if that's the right thing to do for nacl, how webrtc is initialized there etc. I'll ping the nacl team for some help too offline and include you. Reverting this change for now.
>
> Original issue's description:
> > Add experiment on weak ping delay during call set up time
> >
> > BUG=
> > R=pthatcher@webrtc.org
> >
> > Committed: https://crrev.com/3bf69b15f4c0c0ca4ab17c237084684a37bb8279
> > Cr-Commit-Position: refs/heads/master@{#10343}
>
> TBR=pthatcher@webrtc.org,juberti@webrtc.org,guoweis@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://crrev.com/a01d44022355796d4fd86d00aae6d3263573b6f1
> Cr-Commit-Position: refs/heads/master@{#10350}
TBR=pthatcher@webrtc.org,juberti@webrtc.org,tommi@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.webrtc.org/1406153005
Cr-Commit-Position: refs/heads/master@{#10379}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| a01d44022355796d4fd86d00aae6d3263573b6f1 |
|
21-Oct-2015 |
tommi <tommi@webrtc.org> |
Revert of Add experiment on weak ping delay during call set up time (patchset #4 id:60001 of https://codereview.webrtc.org/1411883002/ )
Reason for revert:
guoweis - Here's the target that's failing:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle_nacl.gyp&l=17
This has unfortunately been causing problems repeatedly for us since libjingle_nacl is maintained separately from libjingle (I don't know the history).
The way this works for Chrome in general is that the FindFullName method is implemented in init_webrtc.cc in the overrides folder in Chrome and that hooks WebRTC up with Chrome's implementation. I'm not sure if that's the right thing to do for nacl, how webrtc is initialized there etc. I'll ping the nacl team for some help too offline and include you. Reverting this change for now.
Original issue's description:
> Add experiment on weak ping delay during call set up time
>
> BUG=
> R=pthatcher@webrtc.org
>
> Committed: https://crrev.com/3bf69b15f4c0c0ca4ab17c237084684a37bb8279
> Cr-Commit-Position: refs/heads/master@{#10343}
TBR=pthatcher@webrtc.org,juberti@webrtc.org,guoweis@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.webrtc.org/1423443002
Cr-Commit-Position: refs/heads/master@{#10350}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 3bf69b15f4c0c0ca4ab17c237084684a37bb8279 |
|
20-Oct-2015 |
Guo-wei Shieh <guoweis@webrtc.org> |
Add experiment on weak ping delay during call set up time
BUG=
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1411883002 .
Cr-Commit-Position: refs/heads/master@{#10343}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| c1aeaf0dc37d96f31c92f893f4e30e7a5f7cc2b7 |
|
15-Oct-2015 |
stefan <stefan@webrtc.org> |
Wire up packet_id / send time callbacks to webrtc via libjingle.
BUG=webrtc:4173
Review URL: https://codereview.webrtc.org/1363573002
Cr-Commit-Position: refs/heads/master@{#10289}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 0c4e06b4c6107a1b94f764e279e4fb4161e905b0 |
|
07-Oct-2015 |
Peter Boström <pbos@webrtc.org> |
Use suffixed {uint,int}{8,16,32,64}_t types.
Removes the use of uint8, etc. in favor of uint8_t.
BUG=webrtc:5024
R=henrik.lundin@webrtc.org, henrikg@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org, tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1362503003 .
Cr-Commit-Position: refs/heads/master@{#10196}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 2b342bf99c9578247940929c02a41ef9ccec6d6e |
|
30-Sep-2015 |
Honghai Zhang <honghaiz@webrtc.org> |
Delete a connection only if it has timed out on writing and not receiving for 10 seconds.
BUG=webrtc:5034,webrtc:4937
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1371623003 .
Cr-Commit-Position: refs/heads/master@{#10119}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 98db68fdaa12c5bfca8b0004eba24d034f32de71 |
|
29-Sep-2015 |
honghaiz <honghaiz@webrtc.org> |
If gather_continually is set to true, keep the last port allocator session running while stopping all existing process of getting ports (when p2ptransportchannel first becomes writable).
BUG=5034
Review URL: https://codereview.webrtc.org/1359363003
Cr-Commit-Position: refs/heads/master@{#10110}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 1f429e34180ca19a7fb98b89bacd34d42e9b01ec |
|
28-Sep-2015 |
honghaiz <honghaiz@webrtc.org> |
Passing the new policy from PeerConnection RTCConfiguration to
p2ptransportchannel. This CL does not use the new policy yet.
BUG=
Review URL: https://codereview.webrtc.org/1369773003
Cr-Commit-Position: refs/heads/master@{#10092}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 8937437872d8ff5b30866ae4de4abf005afc7539 |
|
24-Sep-2015 |
honghaiz <honghaiz@webrtc.org> |
Do not prune if the current best connection is weak.
Otherwise, we may delete a useful connection because the current best connection may be failing.
BUG=
Review URL: https://codereview.webrtc.org/1364683002
Cr-Commit-Position: refs/heads/master@{#10063}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| a58ea7806a039c14e1f92a0757123062963b44b1 |
|
24-Sep-2015 |
honghaiz <honghaiz@webrtc.org> |
1. Add receiving state as part of the connection sorting criteria. So if a connection's receiving state changes, it will re-select a better connection if there is any.
This will paves the way for continuous nomination lite and multi-networking.
2. Combined checking and pinging to remove some redundant checking and to make it switch to more frequent ping mode earlier.
Review URL: https://codereview.webrtc.org/1311433009
Cr-Commit-Position: refs/heads/master@{#10057}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| cbecd358e032021eac11fb13e04ec7f070d4f407 |
|
23-Sep-2015 |
deadbeef <deadbeef@webrtc.org> |
Reland of TransportController refactoring. (patchset #1 id:1 of https://codereview.webrtc.org/1358413003/ )
Reason for revert:
This CL just landed: https://codereview.chromium.org/1323243006/
Which fixes the FYI bots for the original CL, and breaks them for this revert.
Original issue's description:
> Revert of TransportController refactoring. (patchset #6 id:100001 of https://codereview.webrtc.org/1350523003/ )
>
> Reason for revert:
> This CL causes problems with the WebRTC-in-Chromium FYI bots. Presumably it needs to be done in several steps, where removed files are emptied instead of removed in the first step.
>
> Original issue's description:
> > TransportController refactoring.
> >
> > Getting rid of TransportProxy, and in its place adding a
> > TransportController class which will facilitate access to and manage
> > the lifetimes of Transports. These Transports will now be accessed
> > solely from the worker thread, simplifying their implementation.
> >
> > This refactoring also pulls Transport-related code out of BaseSession.
> > Which means that BaseChannels will now rely on the TransportController
> > interface to create channels, rather than BaseSession.
> >
> > Committed: https://crrev.com/47ee2f3b9f33e8938948c482c921d4e13a3acd83
> > Cr-Commit-Position: refs/heads/master@{#10022}
>
> TBR=pthatcher@webrtc.org,deadbeef@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/a81a42f584baa0d93a4b93da9632415e8922450c
> Cr-Commit-Position: refs/heads/master@{#10024}
TBR=pthatcher@webrtc.org,torbjorng@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1361773005
Cr-Commit-Position: refs/heads/master@{#10036}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| a81a42f584baa0d93a4b93da9632415e8922450c |
|
23-Sep-2015 |
torbjorng <torbjorng@webrtc.org> |
Revert of TransportController refactoring. (patchset #6 id:100001 of https://codereview.webrtc.org/1350523003/ )
Reason for revert:
This CL causes problems with the WebRTC-in-Chromium FYI bots. Presumably it needs to be done in several steps, where removed files are emptied instead of removed in the first step.
Original issue's description:
> TransportController refactoring.
>
> Getting rid of TransportProxy, and in its place adding a
> TransportController class which will facilitate access to and manage
> the lifetimes of Transports. These Transports will now be accessed
> solely from the worker thread, simplifying their implementation.
>
> This refactoring also pulls Transport-related code out of BaseSession.
> Which means that BaseChannels will now rely on the TransportController
> interface to create channels, rather than BaseSession.
>
> Committed: https://crrev.com/47ee2f3b9f33e8938948c482c921d4e13a3acd83
> Cr-Commit-Position: refs/heads/master@{#10022}
TBR=pthatcher@webrtc.org,deadbeef@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1358413003
Cr-Commit-Position: refs/heads/master@{#10024}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 47ee2f3b9f33e8938948c482c921d4e13a3acd83 |
|
23-Sep-2015 |
deadbeef <deadbeef@webrtc.org> |
TransportController refactoring.
Getting rid of TransportProxy, and in its place adding a
TransportController class which will facilitate access to and manage
the lifetimes of Transports. These Transports will now be accessed
solely from the worker thread, simplifying their implementation.
This refactoring also pulls Transport-related code out of BaseSession.
Which means that BaseChannels will now rely on the TransportController
interface to create channels, rather than BaseSession.
Review URL: https://codereview.webrtc.org/1350523003
Cr-Commit-Position: refs/heads/master@{#10022}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 04ac81f2fd8ef6680522438fac1894db5415a0ec |
|
21-Sep-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Replace readable with receiving where receiving means receiving anything (stun ping, response or data packet).
BUG=4937
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1345913004 .
Cr-Commit-Position: refs/heads/master@{#10004}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 275a2f16fd99b0f1eb43fd4ba62541af14e797c0 |
|
21-Sep-2015 |
tommi <tommi@webrtc.org> |
Revert of Replace readable with receiving where receiving means receiving anything (stun ping, response or da… (patchset #7 id:340001 of https://codereview.webrtc.org/1351673003/ )
Reason for revert:
Broke the Windows build:
[226/365] LINK_EMBED cc_perftests.exe
FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\remoting\protocol\remoting_unittests.channel_socket_adapter_unittest.obj.rsp /c ..\..\remoting\protocol\channel_socket_adapter_unittest.cc /Foobj\remoting\protocol\remoting_unittests.channel_socket_adapter_unittest.obj /Fdobj\remoting\remoting_unittests.cc.pdb
e:\b\build\slave\win\build\src\remoting\protocol\channel_socket_adapter_unittest.cc(36) : error C3861: 'set_readable': identifier not found
ninja: build stopped: subcommand failed.
Original issue's description:
> Replace readable with receiving where receiving means receiving anything (stun ping, response or data packet).
> If a connection does not receive for 30 seconds, it will be deleted.
> BUG=
>
> Committed: https://crrev.com/ae16f8547d3b447f62f6660f13688585c6c3de15
> Cr-Commit-Position: refs/heads/master@{#10001}
TBR=pthatcher@webrtc.org,honghaiz@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.webrtc.org/1356103002
Cr-Commit-Position: refs/heads/master@{#10002}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| ae16f8547d3b447f62f6660f13688585c6c3de15 |
|
21-Sep-2015 |
honghaiz <honghaiz@webrtc.org> |
Replace readable with receiving where receiving means receiving anything (stun ping, response or data packet).
If a connection does not receive for 30 seconds, it will be deleted.
BUG=
Review URL: https://codereview.webrtc.org/1351673003
Cr-Commit-Position: refs/heads/master@{#10001}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 8902433a43bbc9cc0de4966774d3dbbe37ef96fb |
|
18-Sep-2015 |
Guo-wei Shieh <guoweis@webrtc.org> |
Revert "TransportController refactoring."
This reverts commit 9af63f473e1d0d6c47a741a046c41642dfc1c178.
Cr-Commit-Position: refs/heads/master@{#9994}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 9af63f473e1d0d6c47a741a046c41642dfc1c178 |
|
18-Sep-2015 |
deadbeef <deadbeef@webrtc.org> |
TransportController refactoring.
Getting rid of TransportProxy, and in its place adding a
TransportController class which will facilitate access to and manage
the lifetimes of Transports. These Transports will now be accessed
solely from the worker thread, simplifying their implementation.
This refactoring also pulls Transport-related code out of BaseSession.
Which means that BaseChannels will now rely on the TransportController
interface to create channels, rather than BaseSession.
This CL also adds some unit tests, and does some renaming.
For example, from "CandidateReady" to "CandidateGathered".
Review URL: https://codereview.webrtc.org/1246913005
Cr-Commit-Position: refs/heads/master@{#9993}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 7cbd188c5ed7df80bb737bd4ada94422730e2d89 |
|
18-Sep-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Remove GICE (again).
R=guoweis@webrtc.org
Review URL: https://codereview.webrtc.org/1353713002 .
Cr-Commit-Position: refs/heads/master@{#9979}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| d12140a68efdcffa1c2c18f25149905e9dae1a9c |
|
10-Sep-2015 |
guoweis <guoweis@webrtc.org> |
Revert change which removes GICE.
There are still dependencies on this functionality.
TBR=pthatcher@webrtc.org
BUG=526399
Review URL: https://codereview.webrtc.org/1336553003
Cr-Commit-Position: refs/heads/master@{#9920}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 2159b89fa2cb55beeef38f72bd45e217f3d33d4e |
|
22-Aug-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots.
This reverts commit 5bdafd44c86ee46bd7e040f19828324583418b33.
Original CL: https://codereview.webrtc.org/1263663002/
R=guoweis@webrtc.org
Review URL: https://codereview.webrtc.org/1303393002 .
Cr-Commit-Position: refs/heads/master@{#9761}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 5bdafd44c86ee46bd7e040f19828324583418b33 |
|
21-Aug-2015 |
minyuel <minyue@webrtc.org> |
Revert "Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots.""
This reverts commit 081f34b564e1a26ffbbe9515eba1fef7c736fdde.
Original code review see
https://codereview.webrtc.org/1291363005
The revert is due to a suspicion of "Reland "Remove GICE..." being the cause of failure on Linux memcheck, see
https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/4137
TBR=pthatcher@webrtc.org,
BUG=
Review URL: https://codereview.webrtc.org/1308753003 .
Cr-Commit-Position: refs/heads/master@{#9756}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 5a3acd89648e7cff7e1b76b2da710be041be54a0 |
|
21-Aug-2015 |
honghaiz <honghaiz@webrtc.org> |
First step of passive aggressive nomination.
On the controlled side, a stun request without use-candidate attribute will
be used for sending media.
BUG=4900
Review URL: https://codereview.webrtc.org/1270613006
Cr-Commit-Position: refs/heads/master@{#9747}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 081f34b564e1a26ffbbe9515eba1fef7c736fdde |
|
20-Aug-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots."
This reverts commit 475243a134be003aab30bb17294ca6c664d0ef81.
R=guoweis@webrtc.org
Review URL: https://codereview.webrtc.org/1291363005 .
Cr-Commit-Position: refs/heads/master@{#9738}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| fa301809b698017455847f45cc7e0dfa1bdfed35 |
|
11-Aug-2015 |
pthatcher <pthatcher@webrtc.org> |
Revert "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots.
This reverts commit 3449faa553ec94c52ef2d0949867befb60992c88.
TBR=deadbeef@webrtc.org, juberti@webrtc.org
NOPRESUBMIT=true
Review URL: https://codereview.webrtc.org/1274273005
Cr-Commit-Position: refs/heads/master@{#9698}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 3449faa553ec94c52ef2d0949867befb60992c88 |
|
10-Aug-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever).
R=deadbeef@webrtc.org, juberti@webrtc.org
Review URL: https://codereview.webrtc.org/1263663002 .
Cr-Commit-Position: refs/heads/master@{#9692}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 503726c3498201822079c5abe9e528498846c9f2 |
|
31-Jul-2015 |
honghaiz <honghaiz@webrtc.org> |
Fix the generation mismatch assertion error.
BUG=4860
Review URL: https://codereview.webrtc.org/1248063002
Cr-Commit-Position: refs/heads/master@{#9667}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 900996290c996193ac3e418f315354fd2bd0ea8a |
|
13-Jul-2015 |
honghaiz <honghaiz@webrtc.org> |
Add methods to set the ICE connection receiving_timeout values.
BUG=
Review URL: https://codereview.webrtc.org/1231913003
Cr-Commit-Position: refs/heads/master@{#9572}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 54360510ff9b7c61fc906d3ed360b06a5824bbf1 |
|
08-Jul-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Add flakyness check based on the recently received packets.
BUG=
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1207563002 .
Cr-Commit-Position: refs/heads/master@{#9553}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 372f2fcc59829f9eaa2b10519bebd0f71e915f93 |
|
12-Jun-2015 |
Guo-wei Shieh <guoweis@chromium.org> |
Connection resurrected with incorrect candidate type.
Connection can be resurrected with current code when there is no any existing connection for the same address. However, it's always resurrected with prflx candidate priority hence the new connection could bump down other better connection.
Migrated from https://webrtc-codereview.appspot.com/51959004/
This is based on test cases added for triggered checks.
BUG=webrtc:4724
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1172483002
Cr-Commit-Position: refs/heads/master@{#9429}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 1fe120a6b9371819515f2f05beaf62ddcc9c9f30 |
|
10-Jun-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Add triggered checks.
BUG=4590
R=guoweis@webrtc.org, juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/51979004.
Cr-Commit-Position: refs/heads/master@{#9409}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 42af6caf5c6e67eb33fb5dba9d93f01be0e638b8 |
|
15-May-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Add logging of "use candidate" and when we switch ICE "best" connections.
R=guoweis@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46309004
Cr-Commit-Position: refs/heads/master@{#9197}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 0666a9b28bfbf8ff81ff2183c9463e277998fabc |
|
10-Apr-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Remove Transport::Reset, which is never used, and only makes reading the code harder.
R=guoweis@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/43049004
Cr-Commit-Position: refs/heads/master@{#8965}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| be508a1d3634ce63b64cd740c44600453e3c3a6b |
|
06-Apr-2015 |
Guo-wei Shieh <guoweis@chromium.org> |
Implement Tcp Reconnect for TCPPort.
UDP case should not be changed.
Active TCPConnection will initiate Reconnect after OnClose and when Send or Ping fails.
Passive TCPConnection will prune itself as usual as the active side will create a new connection.
The Reconnect could make P2PCT choose a different best_connection in the case where connectivities exist b/w more than 1 Network.
Also, to avoid upper layer triggers ice restart, the WRITE_TIMEOUT caused by the socket disconnection is delayed to give the reconnect mechanism chance to kick in. The timeout event is only fired if the reconnect can't work in 5 sec. If the reconnect, there should be no ICE disconnected state trigger either in active or passive side.
BUG=1926
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31359004
Cr-Commit-Position: refs/heads/master@{#8929}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 7351f4689caae2e53b3ee54874546e8aab769d22 |
|
03-Apr-2015 |
Peter Thatcher <pthatcher@chromium.org> |
Don't send STUN pings if we don't have a remote ufrag and pwd.
BUG=4495
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44029004
Cr-Commit-Position: refs/heads/master@{#8926}
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 877ac765ad30a22148da41695fa607682af4a191 |
|
04-Feb-2015 |
pthatcher@webrtc.org <pthatcher@webrtc.org> |
Cleanup and prepare for bundling.
- Add a GetOptions function. Needed for eventual bundle testing to
confirm that channel options are preserved.
- Simplify unit tests and cleanup unused code.
This is a re-roll of 8237 (https://webrtc-codereview.appspot.com/39699004) with a default GetOption implementation.
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38909004
Cr-Commit-Position: refs/heads/master@{#8245}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8245 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| c5f697135e626044b15eacdc82fd840fbe74b351 |
|
04-Feb-2015 |
bjornv@webrtc.org <bjornv@webrtc.org> |
Revert 8237 "Cleanup and prepare for bundling."
libjingle_peerconnection_objc_test consistently failing on Mac64 Debug.
> Cleanup and prepare for bundling.
>
> - Add a GetOptions function. Needed for eventual bundle testing to
> confirm that channel options are preserved.
> - Simplify unit tests and cleanup unused code.
>
> BUG=1574
> R=pthatcher@webrtc.org, tommi@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/39699004
TBR=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34959004
Cr-Commit-Position: refs/heads/master@{#8241}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8241 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| af01d93aa2d75b39cdcaadd682c5c60336c75ea7 |
|
04-Feb-2015 |
pthatcher@webrtc.org <pthatcher@webrtc.org> |
Cleanup and prepare for bundling.
- Add a GetOptions function. Needed for eventual bundle testing to
confirm that channel options are preserved.
- Simplify unit tests and cleanup unused code.
BUG=1574
R=pthatcher@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39699004
Cr-Commit-Position: refs/heads/master@{#8237}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8237 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| dacdd9403d30cdb13ab2de645841edd2ae76950d |
|
23-Jan-2015 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Reland r7980:
Accept incoming pings before remote answer is set, to reduce connection latency.
Set ICE connection state to 'checking' after setting the remote answer, so that it can transition into 'connected' if the peer reflexive connection is up before any remote candidate is set. See more details in crbug/446908
BUG=4068, crbug/446908
R=juberti@webrtc.org, pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/38709004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8141 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 89aa276e2e9e54953efffcaaba402e0b1d62a155 |
|
15-Jan-2015 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Fix a case where empty candidate id is used
BUG=4161
R=juberti@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8071
Review URL: https://webrtc-codereview.appspot.com/35749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8079 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 61c1247224e2b696b10303b0b5479b3a246f4ff0 |
|
15-Jan-2015 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Fix a case where empty candidate id is used
BUG=4161
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8071 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 9657265f391cfe473a61b18a4579bbbeb44c9bd8 |
|
09-Jan-2015 |
pthatcher@webrtc.org <pthatcher@webrtc.org> |
Revert "Accept incoming pings before remote answer is set to reduce connection latency."
This reverts r7980.
It was causing the ICE connected state to happen while still in the new state rather than going through the checking state, which was causing an ASSERT to fire, which was causing a crash.
Review URL: https://webrtc-codereview.appspot.com/41429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8031 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| c5fd66dcdfdba3ec114cc5b5c0337eba503cee40 |
|
29-Dec-2014 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Accept incoming pings before remote answer is set to reduce connection latency.
BUG=4068
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33509004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7980 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 950c51825109c2ca352317edef0a33777d0e6678 |
|
17-Dec-2014 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Add adapter_type into Candidate object.
Expose adapter_type from Candidate such that we could add jmidata on top of this.
Created a new type of report just for Ice candidate. The candidate's id is used as part of report identifier. This code change only reports the best connection's local candidate's adapter type. There should be cleaning later to move other candidate's attributes to the new report.
This is migrated from issue 32599004
BUG=
R=juberti@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=7885
Committed: https://code.google.com/p/webrtc/source/detail?r=7906
Review URL: https://webrtc-codereview.appspot.com/36379004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7925 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 55360ae402908b24757c7983c587e69ea485e9e6 |
|
16-Dec-2014 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Revert "Add adapter_type into Candidate object."
This reverts commit aaf02cc2d4f696345ce0e6d5715f2cfa22aea689.
BUG=
TBR=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35539004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7908 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| aaf02cc2d4f696345ce0e6d5715f2cfa22aea689 |
|
16-Dec-2014 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Add adapter_type into Candidate object.
Expose adapter_type from Candidate such that we could add jmidata on top of this.
Created a new type of report just for Ice candidate. The candidate's id is used as part of report identifier. This code change only reports the best connection's local candidate's adapter type. There should be cleaning later to move other candidate's attributes to the new report.
This is migrated from issue 32599004
BUG=
R=juberti@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=7885
Review URL: https://webrtc-codereview.appspot.com/36379004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7906 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| fb108b5a28a538862a4157e17de795426d86af1e |
|
15-Dec-2014 |
pbos@webrtc.org <pbos@webrtc.org> |
Revert r7885.
Breaks compile step of other code where network name of
cricket::Candidate is used.
TBR=guoweis@webrtc.org,juberti@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/31229004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7892 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 8c9d79a29d9127d4ff8aa4ae386630c72cfb1808 |
|
12-Dec-2014 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Add adapter_type into Candidate object.
Expose adapter_type from Candidate such that we could add jmidata on top of this.
Created a new type of report just for Ice candidate. The candidate's id is used as part of report identifier. This code change only reports the best connection's local candidate's adapter type. There should be cleaning later to move other candidate's attributes to the new report.
This is migrated from issue 32599004
BUG=
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36379004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7885 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 8c9ff203c5f3c87891b46067ef6ec21b37d2dde4 |
|
04-Dec-2014 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Redo the change of https://webrtc-codereview.appspot.com/30949004/
The previous change causes a build issue as there is subclass of TransportChannel in chromium. To break the circular dependency, a stub of implementation for GetState() is provided and will be removed once the jingle_glue::MockTransportChannel has the function defined.
TBR=pthatcher@webrtc.org
BUG=411086
Review URL: https://webrtc-codereview.appspot.com/34369004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7806 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| fd8422938c7031c6bb31e2fa6288d45cbf48cb99 |
|
04-Dec-2014 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Revert "Implement GetState() for channel's connectivity check state."
This reverts commit ff72f9e692d0918b32646dadaf382aa4355d8437.
TBR=pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/33469004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7805 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| ff72f9e692d0918b32646dadaf382aa4355d8437 |
|
04-Dec-2014 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Implement GetState() for channel's connectivity check state.
Previously, IceState is considered completed when there is only one connection (and the rest was trimmed). However, since the trimming logic is only done within the scope of network, when IPv6 and IPv4 both exist, the completion event is never fired.
This change adds the GetState() to each channel and it could decide what Completion means. The transport object then aggregates all channels before determining it's completed.
Each channel's IceState will be aggregrated at Transport level for overall Ice state
BUG=411086
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30949004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7804 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 7806d8fe40068570c246898366062d734095175b |
|
26-Nov-2014 |
jiayl@webrtc.org <jiayl@webrtc.org> |
Fix an ASSERT that fires in a browser test for renegotiation.
See https://code.google.com/p/chromium/issues/detail?id=293125#c33
BUG=crbug/293125
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7753 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 930e004a817ed346a99ac8e56575326ca75e72aa |
|
17-Nov-2014 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Add jmi field for packets discarded due to network error
Also included the total packets attempted to send.
BUG=427555
Copied from https://webrtc-codereview.appspot.com/25959004/
R=harryjin@google.com, juberti@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=7693
Review URL: https://webrtc-codereview.appspot.com/32039004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7713 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 6a782c2a46d83e09bb036d34b8c2363adc26d037 |
|
14-Nov-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
Revert 7693 "Add jmi field for packets discarded due to network error" breaks chromium's webrtc_cases.
TBR=guoweis@webrtc.org
BUG=N/A
Review URL: https://webrtc-codereview.appspot.com/25179004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7706 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 312614a438c2104ccab6d0231d17604359674e15 |
|
13-Nov-2014 |
guoweis@webrtc.org <guoweis@webrtc.org> |
Add jmi field for packets discarded due to network error
Also included the total packets attempted to send.
BUG=427555
Copied from https://webrtc-codereview.appspot.com/25959004/
R=harryjin@google.com, juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32039004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7693 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 269fb4bc90b79bebbb8311da0110ccd6803fd0a8 |
|
28-Oct-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
move xmpp and p2p to webrtc
Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and
webrtc/p2p. Also makes libjingle use those version instead of the one in the talk folder.
BUG=3379
Review URL: https://webrtc-codereview.appspot.com/26999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7549 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| 28100cb38896fe298b6df11ffd31838d9faf5b8a |
|
18-Oct-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
Reverts r7459 "Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p."
BUG=N/A
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29829004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7472 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|
| d1ba6d9cbfc44618d2c553ff7851948c730ae37b |
|
15-Oct-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
Create a copy of talk/xmpp and talk/p2p under webrtc/libjingle/xmpp and webrtc/p2p.
BUG=3379
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27709005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7459 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/p2p/base/p2ptransportchannel.cc
|