| 01f364ef06cc8b1e7c64cc8038d6cb0e872384f3 |
|
07-Jan-2016 |
Peter Boström <pbos@webrtc.org> |
Remove always-on options in OveruseFrameDetector.
BUG=webrtc:5132
R=asapersson@webrtc.org
Review URL: https://codereview.webrtc.org/1556703002 .
Cr-Commit-Position: refs/heads/master@{#11169}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 5811a39f14fd77ebc0793ee93d03ee15a669bd8f |
|
10-Dec-2015 |
Peter Boström <pbos@webrtc.org> |
Replace EventWrapper in video/, test/ and call/.
Makes use of rtc::Event which is simpler and can be used without
allocating additional objects on the heap.
Does not modify test/channel_transport/.
BUG=
R=mflodman@webrtc.org
Review URL: https://codereview.webrtc.org/1487893004 .
Cr-Commit-Position: refs/heads/master@{#10968}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 7623ce4aeb9130c937ba5836490cbb3a35679e79 |
|
09-Dec-2015 |
Peter Boström <pbos@webrtc.org> |
Reland of Merge webrtc/video_engine/ into webrtc/video/ (patchset #2 id:300001 of https://codereview.webrtc.org/1507903005/ )
Reason for revert:
Bot breakage caused by TickTime::UseFakeClock has been removed.
Original issue's description:
> Revert of Merge webrtc/video_engine/ into webrtc/video/ (patchset #2 id:20001 of https://codereview.webrtc.org/1506773002/ )
>
> Reason for revert:
> Breaks Dr Memory Light https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Light/builds/4643 and all the Android Tests bots.
>
> Original issue's description:
> > Merge webrtc/video_engine/ into webrtc/video/
> >
> > BUG=webrtc:1695
> > R=mflodman@webrtc.org
> >
> > Committed: https://crrev.com/03ef053202bc5d5ab43460eebf5403232f157646
> > Cr-Commit-Position: refs/heads/master@{#10926}
>
> TBR=mflodman@webrtc.org,pbos@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:1695
>
> Committed: https://crrev.com/8237abf563bf4782ee104408b53cc8e55ce44518
> Cr-Commit-Position: refs/heads/master@{#10937}
BUG=webrtc:1695
TBR=mflodman@webrtc.org,kjellander@webrtc.org
NOPRESUBMIT=true
Review URL: https://codereview.webrtc.org/1510183002 .
Cr-Commit-Position: refs/heads/master@{#10948}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 8237abf563bf4782ee104408b53cc8e55ce44518 |
|
08-Dec-2015 |
kjellander <kjellander@webrtc.org> |
Revert of Merge webrtc/video_engine/ into webrtc/video/ (patchset #2 id:20001 of https://codereview.webrtc.org/1506773002/ )
Reason for revert:
Breaks Dr Memory Light https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Light/builds/4643 and all the Android Tests bots.
Original issue's description:
> Merge webrtc/video_engine/ into webrtc/video/
>
> BUG=webrtc:1695
> R=mflodman@webrtc.org
>
> Committed: https://crrev.com/03ef053202bc5d5ab43460eebf5403232f157646
> Cr-Commit-Position: refs/heads/master@{#10926}
TBR=mflodman@webrtc.org,pbos@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:1695
Review URL: https://codereview.webrtc.org/1507903005
Cr-Commit-Position: refs/heads/master@{#10937}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 03ef053202bc5d5ab43460eebf5403232f157646 |
|
08-Dec-2015 |
Peter Boström <pbos@webrtc.org> |
Merge webrtc/video_engine/ into webrtc/video/
BUG=webrtc:1695
R=mflodman@webrtc.org
Review URL: https://codereview.webrtc.org/1506773002 .
Cr-Commit-Position: refs/heads/master@{#10926}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 46ad5426b025eddac8e9232014d347e73d27180e |
|
07-Dec-2015 |
pbos <pbos@webrtc.org> |
Revert of "Create rtc::AtomicInt POD struct." (patchset #3 id:40001 of https://codereview.webrtc.org/1498953002/ )
Reason for revert:
Broke downstream compile step, possibly relandable when using a MSVC version that has constexpr, other than that I'm out of ideas.
.../webrtc/base/atomicops.h:71:8: note: no known conversion for argument 1 from '<brace-enclosed initializer list>' to 'const rtc::AtomicInt&'
Original issue's description:
> Reland of "Create rtc::AtomicInt POD struct."
>
> Relands https://codereview.webrtc.org/1420043008/ with brace initializers
> instead of constructors hoping that they won't introduce static
> initializers.
>
> BUG=
> R=tommi@webrtc.org
>
> Committed: https://crrev.com/84f0970d100e67a1dc4fe9a1b16b7d293302044e
> Cr-Commit-Position: refs/heads/master@{#10920}
TBR=tommi@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.webrtc.org/1505053002
Cr-Commit-Position: refs/heads/master@{#10922}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 84f0970d100e67a1dc4fe9a1b16b7d293302044e |
|
07-Dec-2015 |
Peter Boström <pbos@webrtc.org> |
Reland of "Create rtc::AtomicInt POD struct."
Relands https://codereview.webrtc.org/1420043008/ with brace initializers
instead of constructors hoping that they won't introduce static
initializers.
BUG=
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1498953002 .
Cr-Commit-Position: refs/heads/master@{#10920}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 8c38e8b9b96d72317d6ce94c1442113b4e385dcb |
|
26-Nov-2015 |
Peter Boström <pbos@webrtc.org> |
Clean up PlatformThread.
* Move PlatformThread to rtc::.
* Remove ::CreateThread factory method.
* Make non-scoped_ptr from a lot of invocations.
* Make Start/Stop void.
* Remove rtc::Thread priorities, which were unused and would collide.
* Add ::IsRunning() to PlatformThread.
BUG=
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1476453002 .
Cr-Commit-Position: refs/heads/master@{#10812}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 12411ef40e08c5e28ccde54ab3418c96676ffcbc |
|
23-Nov-2015 |
pbos <pbos@webrtc.org> |
Move ThreadWrapper to ProcessThread in base.
Also removes all virtual methods. Permits using a thread from
rtc_base_approved (namely event tracing).
BUG=webrtc:5158
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1469013002
Cr-Commit-Position: refs/heads/master@{#10760}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 0f59a88b32d95430bf12bd8c4d9b2963e018ead2 |
|
18-Nov-2015 |
Henrik Kjellander <kjellander@google.com> |
modules/video_processing: refactor interface->include + more.
Moved/renamed:
webrtc/modules/video_processing/main/interface -> webrtc/modules/video_processing/include
webrtc/modules/video_processing/main/source/* -> webrtc/modules/video_processing
webrtc/modules/video_processing/main/test/unit_test -> webrtc/modules/video_processing/test
No downstream code seems to use this module.
BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc
R=pbos@webrtc.org, stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1410663004 .
Cr-Commit-Position: refs/heads/master@{#10697}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 3c12f4dadb969afb97468aeb1548777bf860085a |
|
17-Nov-2015 |
pbos <pbos@webrtc.org> |
Revert of Create rtc::AtomicInt POD struct. (patchset #12 id:220001 of https://codereview.webrtc.org/1420043008/ )
Reason for revert:
Caused static initializers.
BUG=chromium:556866
TBR=tommi@webrtc.org
Original issue's description:
> Create rtc::AtomicInt POD struct.
>
> Prevents accidental non-atomic reads, increments and stores since
> "volatile int" doesn't enforce atomic usage.
>
> BUG=
> R=kwiberg@webrtc.org, tommi@webrtc.org
>
> Committed: https://crrev.com/b27f590ece487819c3d1fda400315e582fb975b6
> Cr-Commit-Position: refs/heads/master@{#10657}
TBR=kwiberg@webrtc.org,tommi@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.webrtc.org/1453093002
Cr-Commit-Position: refs/heads/master@{#10669}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| b27f590ece487819c3d1fda400315e582fb975b6 |
|
16-Nov-2015 |
pbos <pbos@webrtc.org> |
Create rtc::AtomicInt POD struct.
Prevents accidental non-atomic reads, increments and stores since
"volatile int" doesn't enforce atomic usage.
BUG=
R=kwiberg@webrtc.org, tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1420043008
Cr-Commit-Position: refs/heads/master@{#10657}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 5dda80abea311731144b1d544aff61c408412f12 |
|
12-Nov-2015 |
Henrik Kjellander <kjellander@google.com> |
Remove webrtc/modules/video_{capture,render}/include
BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc
R=pbos@webrtc.org, perkj@webrtc.org
Review URL: https://codereview.webrtc.org/1439823002 .
Cr-Commit-Position: refs/heads/master@{#10619}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| ff761fba8274d93bd73e76c8b8a1f2d0776dd840 |
|
04-Nov-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
modules: more interface -> include renames
This changes the following module directories:
* webrtc/modules/audio_conference_mixer/interface
* webrtc/modules/interface
* webrtc/modules/media_file/interface
* webrtc/modules/rtp_rtcp/interface
* webrtc/modules/utility/interface
To avoid breaking downstream, I followed this recipe:
1. Copy the interface dir to a new sibling directory: include
2. Update the header guards in the include directory to match the style guide.
3. Update the header guards in the interface directory to match the ones in include. This is required to avoid getting redefinitions in the not-yet-updated downstream code.
4. Add a pragma warning in the header files in the interface dir. Example:
#pragma message("WARNING: webrtc/modules/interface is DEPRECATED; "
"use webrtc/modules/include")
5. Search for all source references to webrtc/modules/interface and update them to webrtc/modules/include (*.c*,*.h,*.mm,*.S)
6. Update all GYP+GN files. This required manual inspection since many subdirectories of webrtc/modules referenced the interface dir using ../interface etc(*.gyp*,*.gn*)
BUG=5095
TESTED=Passing compile-trybots with --clobber flag:
git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel --bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel -m tryserver.webrtc
R=stefan@webrtc.org, tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1417683006 .
Cr-Commit-Position: refs/heads/master@{#10500}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 98f53510b222f71fdd8b799b2f33737ceeb28c61 |
|
28-Oct-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
system_wrappers: rename interface -> include
BUG=webrtc:5095
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1413333002 .
Cr-Commit-Position: refs/heads/master@{#10438}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 415d2cd7454d93b3727fce9147090a24e4c3ccba |
|
26-Oct-2015 |
Peter Boström <pbos@webrtc.org> |
Use webrtc/base/logging.h for video.
BUG=webrtc:5118
R=mflodman@webrtc.org
Review URL: https://codereview.webrtc.org/1415413004 .
Cr-Commit-Position: refs/heads/master@{#10403}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| e4f96501fc5b3e6de0d1ccd262372afcda1f5b4f |
|
21-Oct-2015 |
tommi <tommi@webrtc.org> |
Remove system_wrappers/interface/trace_event.h
BUG=
Review URL: https://codereview.webrtc.org/1417773002
Cr-Commit-Position: refs/heads/master@{#10346}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 8d15bd6dabae829d27443e17f2f02cfbe6fa6525 |
|
07-Oct-2015 |
ivica <ivica@webrtc.org> |
Reland of Collecting encode_time_ms for each frame (patchset #1 id:1 of https://codereview.webrtc.org/1383283005/ )
Reason for revert:
The reverted commit didn't affect the tests, but the one before: https://codereview.webrtc.org/1385563005/
I've run the test that was failing (EndToEndTest.AssignsTransportSequenceNumbers) locally multiple times, and it works fine (finishes successfully in 150-170ms).
Original issue's description:
> Revert of Collecting encode_time_ms for each frame (patchset #13 id:220001 of https://codereview.webrtc.org/1374233002/ )
>
> Reason for revert:
> Breaks EndToEndTest.AssignsTransportSequenceNumbers in video_engine_tests
> on several bots:
> http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5507
> http://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/4815
> http://build.chromium.org/p/client.webrtc/builders/Win%20SyzyASan/builds/3272
> http://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/4414
>
> It seems very unfortunate that it breaks on _exactly_ the bot configs that aren't covered by the CQ trybots.
>
> Original issue's description:
> > Collecting encode_time_ms for each frame.
> >
> > Also, in Sample struct, replacing double with the original type.
> > It makes more sense to save the original data as truthful as possible, and then
> > convert it to double later if necessary (in the plot script).
> >
> > Committed: https://crrev.com/092b13384e57b33e2003d9736dfa1f491e76f938
> > Cr-Commit-Position: refs/heads/master@{#10184}
>
> TBR=sprang@webrtc.org,pbos@webrtc.org,mflodman@webrtc.org,asapersson@webrtc.org,ivica@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/810447972425e890bc7911af27f894b86e9b7e6f
> Cr-Commit-Position: refs/heads/master@{#10185}
TBR=sprang@webrtc.org,pbos@webrtc.org,mflodman@webrtc.org,asapersson@webrtc.org,kjellander@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1390163002
Cr-Commit-Position: refs/heads/master@{#10195}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 810447972425e890bc7911af27f894b86e9b7e6f |
|
06-Oct-2015 |
kjellander <kjellander@webrtc.org> |
Revert of Collecting encode_time_ms for each frame (patchset #13 id:220001 of https://codereview.webrtc.org/1374233002/ )
Reason for revert:
Breaks EndToEndTest.AssignsTransportSequenceNumbers in video_engine_tests
on several bots:
http://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5507
http://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/4815
http://build.chromium.org/p/client.webrtc/builders/Win%20SyzyASan/builds/3272
http://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/4414
It seems very unfortunate that it breaks on _exactly_ the bot configs that aren't covered by the CQ trybots.
Original issue's description:
> Collecting encode_time_ms for each frame.
>
> Also, in Sample struct, replacing double with the original type.
> It makes more sense to save the original data as truthful as possible, and then
> convert it to double later if necessary (in the plot script).
>
> Committed: https://crrev.com/092b13384e57b33e2003d9736dfa1f491e76f938
> Cr-Commit-Position: refs/heads/master@{#10184}
TBR=sprang@webrtc.org,pbos@webrtc.org,mflodman@webrtc.org,asapersson@webrtc.org,ivica@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1383283005
Cr-Commit-Position: refs/heads/master@{#10185}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 092b13384e57b33e2003d9736dfa1f491e76f938 |
|
06-Oct-2015 |
ivica <ivica@webrtc.org> |
Collecting encode_time_ms for each frame.
Also, in Sample struct, replacing double with the original type.
It makes more sense to save the original data as truthful as possible, and then
convert it to double later if necessary (in the plot script).
Review URL: https://codereview.webrtc.org/1374233002
Cr-Commit-Position: refs/heads/master@{#10184}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 7317248ea7a052c19393bbfa2bec22c78a639c94 |
|
22-Sep-2015 |
Peter Boström <pbos@webrtc.org> |
Rename CaptureThread to EncodingThread.
Gives a less confusing name, this thread is used to pick up captured
frames and encode them.
BUG=
R=mflodman@webrtc.org
Review URL: https://codereview.webrtc.org/1332383002 .
Cr-Commit-Position: refs/heads/master@{#10010}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 36d619b01eb912b36a556543f94eb7c777fa6f57 |
|
14-Sep-2015 |
pbos <pbos@webrtc.org> |
Log timestamps when old frames are delivered.
BUG=webrtc:4994
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1335993003
Cr-Commit-Position: refs/heads/master@{#9928}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| df1a171def37eedad848cb0c387b1af6727d8676 |
|
11-Sep-2015 |
mflodman <mflodman@webrtc.org> |
Remove unused event in video_capture_input.cc.
Review URL: https://codereview.webrtc.org/1331833003
Cr-Commit-Position: refs/heads/master@{#9921}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 6718e97e730dfeb0c4290128b5682e123dd75866 |
|
24-Jul-2015 |
asapersson <asapersson@webrtc.org> |
Add encode and decode time to histograms stats:
- "WebRTC.Video.EncodeTimeInMs"
- "WebRTC.Video.DecodeTimeInMs"
BUG=chromium:488243
Review URL: https://codereview.webrtc.org/1250203002
Cr-Commit-Position: refs/heads/master@{#9630}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 235c35f292f8e225a155d98a018e257a7db442c4 |
|
22-Jul-2015 |
pbos <pbos@webrtc.org> |
Implement store as an explicit atomic operation.
Using explicit atomic operations permits TSan to understand them and
prevents false positives.
Downgrading the atomic Load to acquire semantics. This reduces the
number of memory barriers inserted from two down to one at most.
Also renaming Load/Store to AcquireLoad/ReleaseStore.
BUG=chromium:512382
R=dvyukov@chromium.org, glider@chromium.org
TBR=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1246073002
Cr-Commit-Position: refs/heads/master@{#9613}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| d89920b74a173b7bf80c6760908a382c095a66cc |
|
22-Jul-2015 |
asapersson <asapersson@webrtc.org> |
Add resolution and fps stats to histograms:
- "WebRTC.Video.InputWidthInPixels"
- "WebRTC.Video.InputHeightInPixels"
- "WebRTC.Video.SentWidthInPixels"
- "WebRTC.Video.SentHeightInPixels"
- "WebRTC.Video.ReceivedWidthInPixels"
- "WebRTC.Video.ReceivedHeightInPixels"
- "WebRTC.Video.RenderFramesPerSecond"
BUG=chromium:512752
Review URL: https://codereview.webrtc.org/1228393008
Cr-Commit-Position: refs/heads/master@{#9611}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| cddb3676e3def56dcb47a96747d5249d2419adf1 |
|
16-Jul-2015 |
Asa Persson <asapersson@chromium.org> |
Remove unused metric in overuse detector.
BUG=
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1237963002 .
Cr-Commit-Position: refs/heads/master@{#9590}
/external/webrtc/webrtc/video/video_capture_input.cc
|
| 4b91bd08979fcfb191cdae27ad24936beefce735 |
|
26-Jun-2015 |
Peter Boström <pbos@webrtc.org> |
Move frame input (ViECapturer) to webrtc/video/.
Renames ViECapturer to VideoCaptureInput and initializes several
parameters on construction instead of setters.
Also removes an old deadlock suppression.
BUG=1695, 2999
R=asapersson@webrtc.org, mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/53559004.
Cr-Commit-Position: refs/heads/master@{#9508}
/external/webrtc/webrtc/video/video_capture_input.cc
|