d1590b2571c4cb33416e14c92e4f2dfed42ec3d4 |
|
09-Dec-2015 |
mflodman <mflodman@webrtc.org> |
Lint clean video/ and add lint presubmit check. BUG=webrtc:5316 Review URL: https://codereview.webrtc.org/1507643004 Cr-Commit-Position: refs/heads/master@{#10953}
/external/webrtc/webrtc/video/video_quality_test.h
|
ce4aef16eec96862199e89b6d3ffe059558ac2c0 |
|
02-Nov-2015 |
sprang <sprang@webrtc.org> |
Adding support for simulcast and spatial layers into VideoQualityTest This is a re-land of https://codereview.webrtc.org/1353263005/ which was reverted because of perf-regressions. Changes since that CL: * Change LayerFilteringTransport to send a padding packet instead of dropping it for data that should be filtered out. This prevents confusion due to changed sequence numbers. * Changed timing of stats poller thread in VideoAnalyzer. Startup was racy wrt initializion of send_stream_. * Minor formatting issues. PERF NOTE: This change will affect some performance numbers slightly. In particular, {encode_frame_rate, encode_time_ms, encode_usage_percent, media_bitrate_bps} will change due to timing of the measurements. BUG= R=pbos@webrtc.org TBR=mflodman@webrtc.org Review URL: https://codereview.webrtc.org/1412233003 Cr-Commit-Position: refs/heads/master@{#10483}
/external/webrtc/webrtc/video/video_quality_test.h
|
7a975f75e7fa7a9335411ef22b6687f78f7b297f |
|
12-Oct-2015 |
sprang <sprang@webrtc.org> |
Revert of Adding support for simulcast and spatial layers into VideoQualityTest (patchset #10 id:180001 of https://codereview.webrtc.org/1353263005/ ) Reason for revert: Temporarily reverting as this causes some issues with perf tests. Especially tests with packet loss no longer works. Original issue's description: > Adding support for simulcast and spatial layers into VideoQualityTest > > The CL includes several changes: > - Adding flags describing the streams and spatial layers. > - Reorganizing the order of the flags, to make them easier to maintain. > - Adding a member .params_ to VideoQualityAnalyzer. > (instead of passing it to every member function manually) > - Updating VideoAnalyzer to support simulcast. > (select appropriate ssrc and fix timestamps which are sometimes increased by 1) > - VP9EncoderImpl already had code for automatic calculation of bitrate for each layer. > Changing to first read bitrates and resolution ratios from the flags, if specified. > If not specified, reverting to the old code are setting the values automatically. > - Changing the parameters in LayerFilteringTransport, replacing > xx_discard_thresholds with selected_xx, to make it easier to use for the end user. > > Committed: https://crrev.com/87f83a9a27d657731ccb54025bc04ccad0da136e > Cr-Commit-Position: refs/heads/master@{#10215} TBR=pbos@webrtc.org,mflodman@webrtc.org,ivica@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.webrtc.org/1397363002 Cr-Commit-Position: refs/heads/master@{#10252}
/external/webrtc/webrtc/video/video_quality_test.h
|
87f83a9a27d657731ccb54025bc04ccad0da136e |
|
08-Oct-2015 |
ivica <ivica@webrtc.org> |
Adding support for simulcast and spatial layers into VideoQualityTest The CL includes several changes: - Adding flags describing the streams and spatial layers. - Reorganizing the order of the flags, to make them easier to maintain. - Adding a member .params_ to VideoQualityAnalyzer. (instead of passing it to every member function manually) - Updating VideoAnalyzer to support simulcast. (select appropriate ssrc and fix timestamps which are sometimes increased by 1) - VP9EncoderImpl already had code for automatic calculation of bitrate for each layer. Changing to first read bitrates and resolution ratios from the flags, if specified. If not specified, reverting to the old code are setting the values automatically. - Changing the parameters in LayerFilteringTransport, replacing xx_discard_thresholds with selected_xx, to make it easier to use for the end user. Review URL: https://codereview.webrtc.org/1353263005 Cr-Commit-Position: refs/heads/master@{#10215}
/external/webrtc/webrtc/video/video_quality_test.h
|
c7199c2d0b4a70dedc5bb9df5d8d5c15ec17c156 |
|
07-Oct-2015 |
ivica <ivica@webrtc.org> |
Read the number of TLs for VP9 too + cleanup In video_sender.cc, properly read the number of temporal layers for VP9 too. Also, some cleanup in video_loopback.cc and video_quality_test.h. Review URL: https://codereview.webrtc.org/1351693005 Cr-Commit-Position: refs/heads/master@{#10201}
/external/webrtc/webrtc/video/video_quality_test.h
|
2d566686a23fe93ada58f1c38a0d4b9a0d68556e |
|
28-Sep-2015 |
pbos <pbos@webrtc.org> |
Unify Transport and newapi::Transport interfaces. BUG=webrtc:1695 R=stefan@webrtc.org TBR=mflodman@webrtc.org Review URL: https://codereview.webrtc.org/1369263002 Cr-Commit-Position: refs/heads/master@{#10096}
/external/webrtc/webrtc/video/video_quality_test.h
|
6b8d3551681f40b880507cecc88f478a12383cc7 |
|
24-Sep-2015 |
Erik Språng <sprang@webrtc.org> |
Reland "Wire up send-side bandwidth estimation." Revert was patchset #8 id:140001 of https://codereview.webrtc.org/1338203003/ The culprit was RTC_DCHECK(poller_thread_->Start()); in rampup_test.cc BUG=webrtc:4173 R=stefan@webrtc.org Review URL: https://codereview.webrtc.org/1362303002 . Cr-Commit-Position: refs/heads/master@{#10052}
/external/webrtc/webrtc/video/video_quality_test.h
|
c9bbeb03542cffc14b7d306e5f88b6c0e593864d |
|
23-Sep-2015 |
Erik Språng <sprang@webrtc.org> |
Revert of Wire up send-side bandwidth estimation. (patchset #8 id:140001 of https://codereview.webrtc.org/1338203003/ ) Reason for revert: Breaking some Android bots. https://chromegw.corp.google.com/i/client.webrtc/builders/Android32%20Tests%20%28L%20Nexus5%29 Original issue's description: > Wire up send-side bandwidth estimation. > > BUG=webrtc:4173 > > Committed: https://crrev.com/ef165eefc79cf28bb67779afe303cc2365885547 > Cr-Commit-Position: refs/heads/master@{#10012} TBR=stefan@webrtc.org, kjellander@webrtc.org NOPRESUBMIT=false NOTREECHECKS=false NOTRY=false BUG=webrtc:4173 Review URL: https://codereview.webrtc.org/1362923002 . Cr-Commit-Position: refs/heads/master@{#10029}
/external/webrtc/webrtc/video/video_quality_test.h
|
2d4e6c5d9d7b48aec62d1cda9f75fe0b695167aa |
|
23-Sep-2015 |
ivica <ivica@webrtc.org> |
Fixing camera capture for video_loopback In the middle of refactoring, I replaced the VideoCapturer with FrameGeneratorCapturer, to reuse the code, and with that disabled the camera. Now adding capturer_ element to VideoQualityTest and ignoring frame_generator_capturer_ from the parent class test::CallTest. Review URL: https://codereview.webrtc.org/1356933005 Cr-Commit-Position: refs/heads/master@{#10023}
/external/webrtc/webrtc/video/video_quality_test.h
|
ef165eefc79cf28bb67779afe303cc2365885547 |
|
22-Sep-2015 |
sprang <sprang@webrtc.org> |
Wire up send-side bandwidth estimation. BUG=webrtc:4173 Review URL: https://codereview.webrtc.org/1338203003 Cr-Commit-Position: refs/heads/master@{#10012}
/external/webrtc/webrtc/video/video_quality_test.h
|
5d6a06c1d29a2061bcf4b321ffceab477a404d51 |
|
17-Sep-2015 |
ivica <ivica@webrtc.org> |
Refactoring full stack and loopback tests Refactoring full stack, video and screenshare tests to use the same code basis for parametrization and initialization. This patch is done on top of recently commited full stack graphs CL https://codereview.webrtc.org/1289933003/, but virtually no changes have been made to full_stack_plot.py nor to the VideoAnalyzer in full stack, except moving it to video_quality_test.cc. Also, full_stack_samples.cc (build target) was removed and replaced with -output_filename and -duration cmdline arguments in video_loopback and screenshare_loopback. The important things to review: - video_quality_test.h Is the structure of Params good? (examples of usage can be found in full_stack.cc, video_loopback.cc and screenshare_loopback.cc) - video_quality_test.cc Is the initialization correct? The case for using Analyzer and using local renderer are different, can they be further merged? - webrtc_tests.gypi Reproducing the different bitrate settings the full stack and loopback tests had was a little bit tricky. To support both simultaneously, I added BitrateConfig to the Params struct, as well as separate start_bitrate and target_bitrate flags for loopback tests. Note: Side-by-side diff for video_quality_test.cc compares that file directly with the old full_stack.cc, so changes to VideoAnalyzer are clearly visible. Note: Recent CL I've committed added -num_temporal_layers and -sl_discard_threshold args to loopback tests. This was removed here. Support for streams and SVC will be added in a CL following this one. Review URL: https://codereview.webrtc.org/1308403003 Cr-Commit-Position: refs/heads/master@{#9969}
/external/webrtc/webrtc/video/video_quality_test.h
|