History log of /external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
98f53510b222f71fdd8b799b2f33737ceeb28c61 28-Oct-2015 Henrik Kjellander <kjellander@webrtc.org> system_wrappers: rename interface -> include

BUG=webrtc:5095
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1413333002 .

Cr-Commit-Position: refs/heads/master@{#10438}
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
c14f5ff60fb0c42c97702de112a9e8f1eccba574 23-Sep-2015 henrika <henrika@webrtc.org> Improving support for Android Audio Effects in WebRTC.
Now also supports AGC and NS effects and adds the possibility
to override default settings.

R=magjed@webrtc.org, pbos@webrtc.org, sophiechang@chromium.org
TBR=perkj
BUG=NONE

Review URL: https://codereview.webrtc.org/1344563002 .

Cr-Commit-Position: refs/heads/master@{#10030}
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
d5c75b1a0ba1548d3561109e3e5e63757509e9ae 23-Sep-2015 Peter Boström <pbos@webrtc.org> Reduce LS_INFO spam from voice_engine/.

Removes ShouldIgnoreTrace from WebRtcVoiceEngine and removes the spammy
log instances instead. Also removes trace-style logging from getters
(::GetLocalSSRC() for instance would print what SSRC it got, spamming
the log).

BUG=
R=henrika@webrtc.org

Review URL: https://codereview.webrtc.org/1347353004 .

Cr-Commit-Position: refs/heads/master@{#10028}
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
e313e0278315c918d1ae810f79e4b3f176d58659 08-Sep-2015 solenberg <solenberg@webrtc.org> Remove unnecessary fields from VoE SharedData.

BUG=webrtc:4690

Review URL: https://codereview.webrtc.org/1304933008

Cr-Commit-Position: refs/heads/master@{#9882}
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
664cdafb8ad7ccef531cb6bf7bd42752841f220f 20-May-2015 André Susano Pinto <andresp@google.com> Replace assert() with static_assert() if the condition is evaluatable at
compile time.

The condition of static_assert() is evaluated at compile time which is safer and
more efficient.

Note that static_assert() requires C++11.

The changes were generated by the misc-static-assert ClangTidy check by alexfh@google.com

R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/51019004

Cr-Commit-Position: refs/heads/master@{#9231}
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
0d266054acece70259fc1e85026194154f41e5a0 04-May-2015 Jelena Marusic <jmarusic@webrtc.org> VoE: apply new style guide on VoE interfaces and their implementations

Changes:
1. Ran clang-format on VoE interfaces and their implementations.
2. Replaced virtual with override in derived classes.

R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/49239004

Cr-Commit-Position: refs/heads/master@{#9130}
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
1d83f1e89f3e54b38d49ff877c763d0ac52fdb8b 07-Apr-2015 Bjorn Volcker <bjornv@webrtc.org> talk/media/webrtc/webrtcvoiceengine: Delay Agnostic AEC should not override HW-AEC

In https://webrtc-codereview.appspot.com/48699004/ I made the audio option delay_agnostic_aec override HW-AEC if such exists. That is not an expected behavior and is fixed in this CL.

In addition we now check if EnableBuiltInAEC() was successful before disabling the SW-AEC. This revealed a bug in that return value, also fixed here.

BUG=4472
R=henrika@webrtc.org, perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/47969004

Cr-Commit-Position: refs/heads/master@{#8936}
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
a954c07ee1c93175e6ebbeb20517b347474362ae 09-Dec-2014 henrika@webrtc.org <henrika@webrtc.org> AppRTCDemo (Android): built-in AEC should be enabled if device supports it and in combination with Java-based audio layer

BUG=4034
R=andrew@webrtc.org, perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/32179004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7849 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
3b76627afe75cd20e3751488828ebc3eb3287ef8 09-May-2014 henrika@webrtc.org <henrika@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Removes parts of the webrtc::VoEHardware sub API (relanding)

Relanding https://webrtc-codereview.appspot.com/18399004/

TBR=niklase

Review URL: https://webrtc-codereview.appspot.com/16489004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6092 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
3106b706c0a3072d9653c5293ce1f34e69edb970 09-May-2014 henrika@webrtc.org <henrika@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Revert 6090 "Removes parts of the webrtc::VoEHardwareMedia sub A..."

> Removes parts of the webrtc::VoEHardwareMedia sub API as part of a clean-up operation where the goal is to remove unused APIs.
>
> BUG=3206
> R=andrew@webrtc.org, niklas.enbom@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/18399004

TBR=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/15459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6091 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
9de3d844aede81b36f865c92d9f5a2cd07d8c9a8 09-May-2014 henrika@webrtc.org <henrika@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Removes parts of the webrtc::VoEHardwareMedia sub API as part of a clean-up operation where the goal is to remove unused APIs.

BUG=3206
R=andrew@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/18399004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6090 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
a789f3720adc6d9a8af3f5219c1bf4facca70d7f 01-Apr-2014 fischman@webrtc.org <fischman@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> VoiceEngine(iOS & Android): removed NOT_SUPPORTED

Also:
- removed underflow of a uint32 creating crazy-large delay values
- removed always-fail AudioDeviceIPhone::MicrophoneIsAvailable() impl (see
bug 3132)
- removed unnecessary exclusion of features from iOS & Android builds

BUG=2050,3132
R=andrew@webrtc.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10909005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5820 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
0e65fdaa3b383e2f882d2059e8e9dfa052099dea 21-Mar-2014 pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Fix "unreachable code" warnings (MSVC warning 4702) in webrtc.

BUG=chromium:346399
TEST=none
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10139004

Patch from Peter Kasting <pkasting@chromium.org>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5747 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
12dc1a38ca54a000e4fecfbc6d41138b895c9ca5 05-Aug-2013 pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Switch C++-style C headers with their C equivalents.

The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.

BUG=1833
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1917004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
d900e8bea84c474696bf0219aed1353ce65ffd8e 03-Jul-2013 pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Proper spacing for end-of-namespace comments.

BUG=
R=mflodman@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1760006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4293 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
956aa7e0874f2e08c335a82a2c32f400fac8b031 21-May-2013 pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Include files from webrtc/.. paths in voice_engine/

BUG=1662
R=henrikg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1434005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4079 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
6141e13873d0fdea626de08dfec2efa2c9171c76 09-Apr-2013 pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> WebRtc_Word32 -> int32_t in voice_engine/

BUG=314

Review URL: https://webrtc-codereview.appspot.com/1305004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3792 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
93bea51517bb676b88db3cec2b669b4d9b00e9f4 28-Mar-2013 henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Removed CPU APIs from VoEHardware. Code is now only used by test applications.

Recommitting https://code.google.com/p/webrtc/source/detail?r=3736 after fixing build break.

BUG=8404677
TBR=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1269004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3739 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
80fccc29de2b9eaad71ea66bb1bc8e81eb05104d 28-Mar-2013 wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Revert 3736 "Removed CPU APIs from VoEHardware. Code is now only..."

> Removed CPU APIs from VoEHardware. Code is now only used by test applications.
>
> BUG=8404677
>
> Review URL: https://webrtc-codereview.appspot.com/1238004

TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1267004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3737 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
4c138e8fca237f8b6139936aa8b9fb9b0aceb26e 27-Mar-2013 henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Removed CPU APIs from VoEHardware. Code is now only used by test applications.

BUG=8404677

Review URL: https://webrtc-codereview.appspot.com/1238004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3736 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
0989fb7bfa482074e0161ea177653a44174ac492 15-Feb-2013 tommi@webrtc.org <tommi@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Make VoiceEngineImpl inherit from VoiceEngine.
This associates the two types instead of incorrectly reinterpret casting
VoiceEngineImpl* to VoiceEngine* (since these types were previously unrelated).

Please see more details in the bug for how this is currently causing problems
with security tools.

BUG=38612
Review URL: https://webrtc-codereview.appspot.com/1099013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3520 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
96bcac8fbbb32108f4be4281fec99cb621cb818a 04-Dec-2012 leozwang@webrtc.org <leozwang@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Expose Set and Get Recording/Playout sample rate apis

Message:
This is the first cl to add Set/Get Recording and Playout sample rate apis.
In this cl, apis are enabled but returns -1, will add android
implementation in next cl, it's easy for review and coding.

Description:
This CL expose fours voice engine apis,
SetRecordingSampleRate,
RecordingSampleRate,
SetPlayoutSampleRate,
PlayoutSampleRate.

BUG=none
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/626004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3239 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc
14b43beb7ce4440b30dcea31196de5b4a529cb6b 22-Oct-2012 andrew@webrtc.org <andrew@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> Move src/ -> webrtc/

TBR=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/915006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/voice_engine/voe_hardware_impl.cc