f4d225a4b502ef227788447eb1a5bb2902019c01 |
|
17-Jun-2015 |
Yohei Yukawa <yukawa@google.com> |
Fix debug log for SpellCheckerSessionListenerImpl#TASK_CANCEL This is a follow up CL for Ifd05565ac0c057c46ec88a3fb9094c04934041d. SpellCheckerSessionListenerImpl.taskToString(TASK_CANCEL) has somehow returned "STATE_WAIT_CONNECTION" probably because of a copy-and-paste mistake. With this CL, it now returns "TASK_CANCEL", which is observable only in debug log anyway though. Bug: 21319642 Change-Id: Ib0bf11494bd3f210e6e8192fc25a33c65f7d313d
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
f05ce728f95ce2a294981ee94167d42a35f50f8c |
|
16-Jun-2015 |
Yohei Yukawa <yukawa@google.com> |
Fix a reference leak in SpellCheckerSessionListenerImpl. The primary goal of this CL is to address a reference leak in SpellCheckerSession.SpellCheckerSessionListenerImpl if the SpellCheckerSession is closed too early. Here is the minimum repro code. TextServicesManager tsm = (TextServicesManager) getSystemService(Context.TEXT_SERVICES_MANAGER_SERVICE); SpellCheckerSession session = tsm.newSpellCheckerSession(, Locale.ENGLISH, listener, false); session.close(); In order to make the state management reliable and easier to debug, this CL replaces SpellCheckerSessionListenerImpl#mOpened with an explicit state number so that we can tell three different "not open" cases: 1) not connected yet and not closed yet, 2) closed before establishing connection, and 3) closed after establishing connection. Bug: 21319642 Change-Id: Ifd05565ac0c057c46ec88a3fb9094c04934041d7
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
92adda2b616287146549d921dfe4c1199c0a4247 |
|
02-Jun-2015 |
Seigo Nonaka <nona@google.com> |
Use final in favor of initialization safety. Making a member field final would be beneficial not only for the readability but also for the initialization safety. Leaving SpellCheckerSession#mSpellCheckerSessionListener non-final does not make sense not only because we never change that member field once SpellCheckerSession object is created and but also because SpellCheckerSession instance is designed to be accessed from multiple threads at the same time, no matter if it has something to do with Bug 18945456 or not. Change-Id: I1a7ebb54a5d0beddee8799fc5b0800c6e1059099
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
bf9767cd8172de64693d7c88d29ff215f5c6c66d |
|
30-May-2014 |
Keisuke Kuroyanagi <ksk@google.com> |
Null check for sentence level spell checking method. Bug: 15334309 Change-Id: Id7dd440f7df37da76ae6381abe057ff92a76f4a1
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
c7ee1b9369ffd7c21a70738056a82dc4238e7fc1 |
|
11-Apr-2012 |
satok <satok@google.com> |
Get rid of "isSentenceLevelSpellCheckSupported" Bug: 6320351 Change-Id: I0e931b7248f8c65268b60af599c07432d58d2f1f
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
f6710615c6cc1746d1ecc7aebc9afed457dcca41 |
|
30-Mar-2012 |
satok <satok@google.com> |
Supplement for I772164d9c67e95876c228efcce2 This should be merged with I1519258dd3ce95ad01 Change-Id: I48c5f86ff43f51913eb69d697bb1d75714b67aa3
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
6183cd64a98a69ea247813c9ba0a07326c4bc1ae |
|
26-Mar-2012 |
satok <satok@google.com> |
Take sentence-level spell checking APIs public Bug: 6136149 Change-Id: I772164d9c67e95876c228efcce2356a81a06be4f
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
2428ccbbde3ca1f6643a4952a6ca881dab80ce45 |
|
08-Mar-2012 |
satok <satok@google.com> |
Fix spell checker framework Change-Id: I281d031259dd220936832668e7a4556473ccb2ce
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
8898358bfdf4693af02ad454e1deb8034379ce02 |
|
30-Nov-2011 |
satok <satok@google.com> |
Handle sentence level spell checking hidden APIs Change-Id: Ia91f1771c0b8ef458dd5b023f4c372cc36a15657
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
d404fe110558bd2e1960b428db6a2ee8bfd040cd |
|
21-Feb-2012 |
satok <satok@google.com> |
Refactor sentence level spell checking APIs Support sentence level spell checking APIs: Step 1 Change-Id: I31c0b88e7885f33a0694ab60b8f2dbceeffe42f1
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
b5052de75736527549d7e537632777c6fec2e4f0 |
|
14-Dec-2011 |
Dianne Hackborn <hackbod@google.com> |
resolved conflicts for merge of a80bab37 to master Change-Id: Id71cc68a617e1ea0dd2f3932d454be6dba336eef
|
33b8ee509f36a0168c8ce5a9091b57ab936f4c13 |
|
14-Dec-2011 |
Dianne Hackborn <hackbod@google.com> |
Fix issue #5756204: Crespo IME briefly appears shortened when... ...rotating to landscape When doing spell checking in the same process as the spell checker, we need to make sure it is still done asynchronously. Putting this in I noticed quite a few threading issues in this code, so I also addressed those (which became very obviously a problem with the async stuff here now). Also tweaked the service side to run spell checking at background priority. Change-Id: I01bafe3bec6bceeca911d6bf2f61a486a2fd4c48
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
0dc1f648a09b46c45190ba1ce7daecf7fada4347 |
|
18-Nov-2011 |
satok <satok@google.com> |
add sentence level spell checker hidden apis Change-Id: If65c89044bed064fd01a554e33176f64f7c21c0f
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
060677f4686a93d92117d7d472e754423a368bdb |
|
17-Nov-2011 |
satok <satok@google.com> |
Clean up the spell checker framework Change-Id: I64c0d813e53a4ebf8d7e63463e36f6900f1aa7d3
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
b4aff97c85e730857893742f73a082f6b8d139ca |
|
02-Nov-2011 |
satok <satok@google.com> |
Introduce an API to cancel pending/running spell check tasks Bug: 5554629 Change-Id: Ifd840ea13976813639a2ee259124a21d9bb56893
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
74061ff90453c79ddbde468f630a41425da07710 |
|
02-Nov-2011 |
satok <satok@google.com> |
Fix a memory leak of a Binder in SpellCheckerService Bug: 5499490 Change-Id: I167a3e9dfdd6edd06c6ad993fbff3a535c81b09c
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
a80838d9d63fcc9a83a9e7c99884e5b50316d4f0 |
|
20-Oct-2011 |
Jean Chalard <jchalard@google.com> |
Fix a warning from the binder. This patch fixes the following warning: W/Binder: The following Binder class should be static or leaks might occur: android.view.textservice .SpellCheckerSession.InternalListener ...in hope of removing a possible memory leaks. However in my tests it does nothing at all for the memory leak in bug 5461066, so it was probably unrelated. Change-Id: Id776665e9483121d22cc91e8d2d9f32e3413ec96 Bugs: 5481376,5461066
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
44b75030931d9c65c9e495a86d11d71da59b4429 |
|
14-Oct-2011 |
satok <satok@google.com> |
Add documents for the spell checker framework and the input method subtype Bug: 4973788 Change-Id: I7e650f336ba1bb8949899e8b2355e6d492a2e4b2
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
5357806980269d846a15c845a6fcc0384fb18860 |
|
03-Aug-2011 |
satok <satok@google.com> |
API cleanup for the spell checker framework Bug: 5110151 - Add a bundle to an argment of newSpellCheckerSession - Expose SpellCheckerSessionImpl in SpellCheckerService - Fix function names - etc Change-Id: Ia8ec783b7b4d5fcd18389854b445fc10fc502297
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|
aafd955fa8f5c31c511763c0f826b6d7acf15b9c |
|
02-Aug-2011 |
satok <satok@google.com> |
Move SpellCheckerSession SpellCheckerSession should be in android.view.textservice because this class will be used directly by users. Change-Id: I0df6d7958adda421312b5f641ac4459ca4739cc9
/frameworks/base/core/java/android/view/textservice/SpellCheckerSession.java
|