History log of /frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
31eb74fb2bc33aea6a8054c861a6e7aac7c41f4b 06-Apr-2016 Keisuke Kuroyanagi <ksk@google.com> Rewrite SuggestionsPopupWindowTest using espresso.

- Rewrite existing test about text appearance.
- Add new tests for suggestions popup.

Bug: 25904136
Bug: 27765262
Change-Id: I12e522436a83fa264cd22176d054877eec411708
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
183fd5071ea84aab82209c827fa0e4ff84a6b590 01-Apr-2016 Keisuke Kuroyanagi <ksk@google.com> Make hasTransientState be true only if user created selection is active.

Previously, hasTransientState returned true even when TextView has a
selection that hasn't been created by the user. This unnecessarily
prevents the TextView from being recycled.
This issue was introduced by Ib454b0fbbc2c2f8d198, which fixes that
setHasTransientState(true) is not always coupled with
setHasTransientState(false).

With this CL:
hasTransientState will get true when selection action mode is started.
hasTransientState will get false when selection is removed.
Note that hasTransientState intentionally continues to be true when
selection action mode is terminated with preserving selection.

Bug: 27913323
Change-Id: I960ddfd7221caeb676c23926af06a8a415dec288
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
f0bb87b7c40efeeaee58d4c7b767961c9800463e 08-Feb-2016 Keisuke Kuroyanagi <ksk@google.com> Improve selection handle behavior for bidi text.

A point on a direction boundary can be mapped to two offset and
one offset on a direction boundary can be mapped to two points.
Previously, paragraph's primary direction is always used for deciding
offset and coordinates; thus, handle movement around a direction
boundary is often nonintuitive.

With this CL:
1. For selection end handle, direction of character at offset - 1 is
used for deciding handle shape and position.
2. For getting offset from coordinates, previous offset is used to
minimize the offset delta and primary .
3. For getting coordinates form offset, new logic chooses primary or
secondary horizontal coordinate depending on the current run
direction and paragraph direction.
4. When a handle passes another one because it passes a direction
boundary, new logic keeps the handle at the run boundary instead of
minimizing the selection.

Bug: 19199637
Bug: 21480356
Bug: 21649994


Change-Id: I2a7e87ad08416f4bd01a5f68e006240f77d9036b
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
987ec6588b2279891179c9eff09fc25ec14430c4 18-Feb-2016 Siyamed Sinir <siyamed@google.com> Do not use hint text for Editor cursor positioning

When hint text is used for cursor positioning, the cursor may end up
in opposite direction when the locale and the hint text directions are
different. This CL uses the main text layout and discards the hint
layout while deciding on the position of those three views. The change
also includes fix for cursor and floating popup not displaying for
some cases after the change.

Bug: 22358087
Change-Id: I083d17b06273bc1d9b67656c5e12d4ff1231219c
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
c477b5830af5f9e87069fae4ff87a2a6b3e275fb 15-Mar-2016 Keisuke Kuroyanagi <ksk@google.com> Stop automatically creating selection action mode.

With Ic025c109539c3b5963, selection action mode is created always
when selection is made. It causes distraction in some cases.
This CL fixes this issue. This CL stops starting selection action
mode when action mode is currently not active and not intended to
restart.

Bug: 27536744
Bug: 27551819
Change-Id: I94ee66864000934a21ef0d18c1d71429c67114fa
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
fae4578311970afadca8ee28a47e1e11df00eedd 25-Feb-2016 Keisuke Kuroyanagi <ksk@google.com> Make drag&drop be atomic for undo/redo.

For undo/redo, drag&drop is recorded as a 2 operations, paste and
delete. This CL makes drag&drop be atomic operation to be properly
undoed/redoed.

Bug: 27268820
Change-Id: Ia38d663f046c2c65f348985934f5cfa054b0437e
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
a2756f601865c37f9cc9b58943bd3285cbeb4b49 26-Jan-2016 Keisuke Kuroyanagi <ksk@google.com> Merge "TextView tests: drag and drop."
e27e0850fe4acbdc911e2e4e6272be10ac2f2779 08-Jan-2016 Keisuke Kuroyanagi <ksk@google.com> Add TextView cursor positioning tests for grapheme clusters.

Bug: 25375561
Bug: 25730231
Change-Id: I7e77e6de027a81ec0f203a1ff9c24a768ffedae3
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
4307aeb935ab9c824f90d41bf181660c3937b1e4 07-Dec-2015 Keisuke Kuroyanagi <ksk@google.com> TextView tests: drag and drop.

Long press on a selection starts drag and drop both for tap and mouse.
Drag on a selection starts drag and drop for mouse.

Bug: 25730231
Change-Id: Idf5df9948f8257433782183464e94cf16b2e372d
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
ae3ecaa27654264ef2168dee218725fbf0f69d40 10-Dec-2015 Keisuke Kuroyanagi <ksk@google.com> Merge "TextView test: floating toolbar + drag handle interaction."
d2441607bdd829e8a9d5593293f69ced31b5634e 10-Dec-2015 Keisuke Kuroyanagi <ksk@google.com> Merge "TextView test: insertion handle movement tests."
ff375577952dad90bfa28073c67f97db68f106db 10-Dec-2015 Keisuke Kuroyanagi <ksk@google.com> Merge "Fix selection expansion detection logic."
d42cb8ffa77266abe3bcffe98212d313d223a86c 06-Dec-2015 Keisuke Kuroyanagi <ksk@google.com> TextView tests: tests for improved mouse text selection.

- Double tap/long press at line end
- Selection handle pops up after making selection by mouse dragging.

Bug: 19544351
Change-Id: Ie6a2567c151159b6dea682257efeb17e0feb9f08
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
b0dd77c4115d333527a06cad84bc1c6ea8b4ac8e 02-Dec-2015 Keisuke Kuroyanagi <ksk@google.com> TextView test: floating toolbar + drag handle interaction.

Bug: 25730231
Change-Id: I053c5053b3fc70910b4d0d926632b6c15fcc03be
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
e8b3dd47914a52a229c1726b79fe8f02fb59bb73 26-Nov-2015 Keisuke Kuroyanagi <ksk@google.com> TextView test: insertion handle movement tests.

Bug: 25730231
Change-Id: Iea6528f414314daf971f11bc090cfccfefee25e1
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
26454141a8c489d84b7d486ad03869ff0f44dfdc 03-Dec-2015 Keisuke Kuroyanagi <ksk@google.com> Fix selection expansion detection logic.

The logic to detect vertical expansion is inverted on RTL
text. As a result, the selection handle cannot be moved
when it's dragged toward vertically expanding and
horizontally shrinking direction.

Bug: 25893288
Change-Id: I096595d287261b1287862c6ad27ae7f6f0a73262
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
fc6e25ef6e288cf75d70cf8185ff1c8831428936 30-Nov-2015 Abodunrinwa Toki <toki@google.com> TextView tests to check that selection handles appear on selection

Bug: 25730231
Change-Id: I66e44b6375e1a76e8537fca5dc5090ff841cc934
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
ec913c0eb6c3cb70f69653ee988d440f47e5cc55 24-Nov-2015 Keisuke Kuroyanagi <ksk@google.com> Selection Test: selection handle snaps to word boundaries.

Bug: 25730231

Change-Id: I12d3fde4ff5b52aa6673de915c53b6a5f72f4b35
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
cb6e8420cbf8bc4000d4761e38fd6d830fc1aca0 24-Nov-2015 Keisuke Kuroyanagi <ksk@google.com> Selection Test: selection handle doesn't pass anther one.

Bug: 25730231
Change-Id: Ibca75126a0b2d4320d1f67dc35a2b0ac20fcdcd2
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
c24c2bbb69634435d1d9fc97671229df245bd8d0 24-Nov-2015 Keisuke Kuroyanagi <ksk@google.com> Add selection handle multiline dragging tests.

Bug: 25730231

Change-Id: I23b9e35d7a5ea8d03d8634ffca0e186ea76ebc99
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
da79ee683d74f2ad7d29147a30f3da17dd0ea6e2 25-Nov-2015 Keisuke Kuroyanagi <ksk@google.com> Add selection handle dragging tests.

- Set an id for each HandleView to access the hanlde.
- Rename DragOnTextViewActions to DragAction to use it for
dragging handles.
- Introduce HandleCoordinates to provide proper coordinates
for handles.

More tests will be added in following CLs.

Bug: 25730231
Change-Id: I9276bf2f983983ec9aae0ddcf674d3dcee566892
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
e36c7112e7c48f3c8964f95a2a489d25504356b0 03-Nov-2015 Abodunrinwa Toki <toki@google.com> Fix failing TextActivityTest.

It seems like setOrientation(...) is not working.
Instead, fix the orientation of TextViewActivity to portrait.
See: I2f9372997f8301d800109981c6e1a6d4419b641d
Bug: 24495166

Change-Id: I0c5480b7ce6ba1fb8e4e4e3daabe94ebccca4dfd
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
c9e924eb5347872aeec64ed09d1793ac8483ea10 08-Oct-2015 Abodunrinwa Toki <toki@google.com> Set device orientation for tests.

Some tests were failing in the lab based on device orientation:
In landscape mode, the TextView goes into ExtractEditTextMode.
This mode behaves a bit differently from typical TextView mode
and doesn't support accelerated drag selection (e.g. longpress+drag).

This CL adds OrientationUtil that allows test to specify the
orientation (portrait/landscape) that the test should run in.
This CL also fixes the failing tests.

Bug: 24495166
Change-Id: I2f9372997f8301d800109981c6e1a6d4419b641d
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
8a5e1ae2f4e1aaf2db2a217e841371e18851df3f 28-Sep-2015 Abodunrinwa Toki <toki@google.com> FloatingToolbarEspressoUtils + more TextView selection by touch tests

Bug: 24102650
Change-Id: Idd7d8b29ad8cfdf10d75137762bb1cb677bda6b7
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
ca4aaf3c17fdea4e373accc212867bd9f1e2be7f 22-Sep-2015 Abodunrinwa Toki <toki@google.com> Add more TextView selection (by touch) tests.

This change adds simple tests for:
- longpress and drag to select
- double-tap and drag to select

Bug: 24102650
Change-Id: I8614c8ec430dfc204159a03be409a2361cd7d844
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
90cdfe0514154bbc008d39f1c99f7a1d2684446c 15-Sep-2015 Abodunrinwa Toki <toki@google.com> TextViewActions for Espresso-testing TextView.

The plan is to add common TextView actions here so they can be used
in tests.
The locateTextAtIndex method is probably not the most efficient way
to locate a particular spot in the TextView but it works well enough
and doesn't use any private/hidden APIs. This might make it easy to
port this test as CTS.
Ideas on alternative implementations for this method are welcome.

Bug: 24102650
Change-Id: Ifb07cc86c58bd5833c37919fa9294a2374dba2a0
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java
223c8392f066823cf4a3a98957960deb80ab1680 25-Jul-2015 Abodunrinwa Toki <toki@google.com> Demo functional test for frameworks/core with Espresso

- Integrates Espresso
- Changes the Instrumentation Test runner to AndroidJUnitRunner
- Adds a demo test

This will serve as a template for other tests.

Change-Id: I10592f5adb404c2aba9dd8676ae2aa5a191ad336
/frameworks/base/core/tests/coretests/src/android/widget/TextViewActivityTest.java