History log of /frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
a6edc878293e49594a6aac7a0d0e41c7980ece07 26-Apr-2016 Mady Mellor <madym@google.com> Fix a crash when setting vertical gear location and content view null

When setting the vertical location of the gear we need the collapsed
height of the parent, the parent might not be fully laid out so move
setting the vertical location into onLayout instead

Bug: 28390732
Change-Id: I7c1bf14a54e9f1ef0a693fa13e1a6533f5967631
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java
cdd5718eacd96ed1a755c877798952a5201b7600 13-Apr-2016 Mady Mellor <madym@google.com> Fix the gear so that it is always centered based on the min noti height

This alters how the gear is positioned so that it is centered based
on what the minimum height of the notification or the height of a
collapsed group.

Bug: 27316874
Change-Id: I726f51ab8b18b485d1b2ea22ca7bb4dd71ee3d85
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java
8ae2c550257e8bfa713f9fa17b8b8b00bb288d85 06-Apr-2016 Mady Mellor <madym@google.com> Fix gear not showing on left hand side of notification

This is a work around for b/28050538, casting these values to
floats should be unnecessary. Once this bug is fixed this can
be reverted.

Bug: 28029191
Change-Id: I5c3efe9e01dbac4e9f30753a88a4fe59cb13e7e7
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java
7a9b2a67b71f8f6c5cffc3fe90cc4b513b79a9b2 23-Mar-2016 Mady Mellor <madym@google.com> Close inline controls / hide the gear when interaction outside occurs

This CL adds the behavior so that if the gear or inline controls are
visible, they will close if the user interacts with another area of
the screen (e.g. scrolls, pulls down QS, etc) this is on the lock screen
as well as the shade.

This CL makes an additional change to remove the GearDisplayedListener
and use the StackScroller to maintain state of the gear / reset as
appropriate.

Bug: 27598072
Bug: 27335311

Change-Id: Iebff9aa542c9d91389054a4ff292d0dda11fe950
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java
e9301ed60d3b013e17f157dae6920c414df1e60f 05-Apr-2016 Mady Mellor <madym@google.com> Merge "Fix showing gear behind notification when RTL language selected" into nyc-dev
4666cbd5069a3c07a8a2994ba9982ffea332c98d 04-Apr-2016 Mady Mellor <madym@google.com> Fix showing gear behind notification when RTL language selected

Need to alter the translation to place the view when in RTL.

Bug: 27596418
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java
3fd273e6113fb1b8986314a03ab6d7e90efd0bea 16-Mar-2016 Mady Mellor <madym@google.com> Add content description for gear behind notifications

Bug: 27498876
Change-Id: I244286e3eaff04268b25e40f1031b5ff7d0b3aee
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java
3a5e8dd820ec6e85121857a03fe9c6a081455f43 12-Mar-2016 Mady Mellor <madym@google.com> Revert "Revert "Improve interaction around showing / hiding the gear behind notifications""

This reverts commit 88eca2aa0e707c06731fc273af4e6181ad743c3c.

It additionally fixes an issue with notification scrolling after gear is displayed
by indicating that the user is no longer swiping by calling onDragCancelled

Change-Id: Ieba0cea35bba9c383d8b5fdca08cb5ff083666c3
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java
88eca2aa0e707c06731fc273af4e6181ad743c3c 12-Mar-2016 Mady Mellor <madym@google.com> Revert "Improve interaction around showing / hiding the gear behind notifications"

This reverts commit 273ed107f1d414571a01bf8ebd9c9ffa942d9e11.

Change-Id: I5f4d2c2dfa2bd965abd2ea2ec385639deb4511f9
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java
273ed107f1d414571a01bf8ebd9c9ffa942d9e11 04-Mar-2016 Mady Mellor <madym@google.com> Improve interaction around showing / hiding the gear behind notifications

If the gesture on the notification was not considered a dismiss gesture
the code always check if the notification had moved enough to display
the gear.

This causes some undesirable behavior:
- For unclearable notifications the gear would *always* be shown
- Even if the velocity of the gesture was enough to be a dismiss it
may have failed other requirements and then the gear would be
shown

This CL alters NotificationSwipeHelper to take into account the
velocity of the gesture, and if it was great enough to be a dismiss
but wasn't (unclearable, didn't meet other requirements) it'll just
snap the notification back into place.

Additionally this CL alters the behavior so that if the gear is
visible and the notification is swiped in the direction of the gear
it *won't* dismiss the notification but rather cover the gear. If
a dismiss gesture is made in the opposite direction of the gear, the
notification will still be dismissed.

Bug: 27378399
Bug: 27319053
Bug: 27335353

Change-Id: I0849eecc71f2c6722e811d284534c2ea29b1b8aa
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java
6e64423c196ff0160facb3e83b1481248ce38cb1 01-Mar-2016 Mady Mellor <madym@google.com> Merge "Fix settings icon row consuming the click when tapping the notification" into nyc-dev
f153f5fcb6379532f7d5ff775b1b1759b9009e9a 29-Feb-2016 Mady Mellor <madym@google.com> Fix settings icon row consuming the click when tapping the notification

This CL makes the settings icon row invisible when it's not displaying,
this way it won't get the click event on the notification row before
the parent.

Bug: 27389571
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java
b53bc276d6ec093817988a358b7c2a6c63ee0c48 12-Feb-2016 Mady Mellor <madym@google.com> Update the animation when showing / closing inline controls

This CL updates the circular reveal animation to originate
from the gear and and done button in the inline controls.

Bug: 22451710
Change-Id: I050413c980a8c9e73fe2e9a789567051d3119373
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java
f062580d395a8c99631c104d6aec250f961152dd 12-Feb-2016 Mady Mellor <madym@google.com> Improve touch target for the gear beneath a notification

This CL increases the touch target size of the gear beneath
a notification.

It also adds the logic:
- If the gear is displayed and the notification is touched
then the notification slides back over the gear
- If the grey background is touched rather than the gear
nothing happens

Bug: 22451710
Change-Id: I7c1d8943e066fdd821446c2f90807891d6b74e5c
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java
4b80b1025f82fa7becc8e126bfa4aea39affcf65 22-Jan-2016 Mady Mellor <madym@google.com> Initial implementation of dismiss gesture + inline settings icon

- Added a view to display / control the gear behind the noti
- Updated SwipeHelper to hide / show the gear based on the gesture
- Only one notification or notification group can show the gear
at a time

Couple of things left to do that will come in a follow up CL:
- Animation (to / from inline controls, fading gear based on movement)
- For children in a group there needs to be a grey background

Bug: 22451710
Change-Id: I2f93edf48109a82bab0839c73cbaba1535caee9a
/frameworks/base/packages/SystemUI/src/com/android/systemui/statusbar/NotificationSettingsIconRow.java