| 21ce0a0684aeb04cbf18e887df84ab9f42432b16 |
17-Aug-2016 |
Ajay Nadathur <ajayns@google.com> |
[SetupWizard] Setup Wizard crash on scrolling the list in Select Wi-Fi
screen
- Setupwizard was crashing because RecyclerView during keyboard scrolls
invokes onCreateViewHolder(ViewGroup, int) for header view more than
once. We return the same headerView object each time which causes
problems later on.
- Fixed the problem by wrapping the header in a framelayout and
inserting the header to the current framelayout in
onBindViewHeader(ViewHolder, int).
Testing:
-------
- Verified by running on Pixel C, no crashes observed
- Also attempted scrolling using touchscreen, works as usual.
bug:30789424
Change-Id: I89ac09e14f21ceec3628f249f2cd2a391f020072
(cherry picked from commit c3a97eece385d93a85a215281ef48bdea728af0b)
etupwizardlib/view/HeaderRecyclerView.java
|
| 325b78cfbd0d7366771ee81838bc444c69e39963 |
05-May-2016 |
Maurice Lam <yukl@google.com> |
[SuwLib] Allow extending DividerItemDecoration
Allow subclasses to extend DividerItemDecoration to control whether
dividers are allowed at a specific location.
Bug: 28445348
Change-Id: I7e61574048dc4df18a0a31fef277a5cc7f5395ec
etupwizardlib/DividerItemDecoration.java
etupwizardlib/GlifRecyclerLayout.java
etupwizardlib/SetupWizardRecyclerLayout.java
|
| 84979a6b2874d09762404c3c8a902f4aad016d01 |
26-Apr-2016 |
Maurice Lam <yukl@google.com> |
[SuwLib] Support GLIF preference
Bug: 26427729
Change-Id: Ie95b0031bacef316ccff9bc9f1a4b048016a9353
etupwizardlib/GlifPreferenceLayout.java
etupwizardlib/GlifRecyclerLayout.java
etupwizardlib/util/GlifPreferenceDelegate.java
|
| 00d3c2643211547166766a85278d87033cf66209 |
06-Apr-2016 |
Maurice Lam <yukl@google.com> |
Merge "[SuwLib] Fix RecyclerView dividers" into ub-setupwizard-belgarath
|
| e860e77e9f218f094495692eb1180848dfebc481 |
05-Apr-2016 |
Maurice Lam <yukl@google.com> |
[SuwLib] Fix RecyclerView dividers
Use the adapter item count and positions instead of the view index
and child count when drawing the decorations, because child views get
removed and added as part of RecyclerView's recycling.
Bug: 27974451
Change-Id: Ibb02856c1069b3f03978a3b44bd4ba1608aed6f2
etupwizardlib/DividerItemDecoration.java
|
| 5d7bea799d0a1231f16b9e975718035c786da5f3 |
30-Mar-2016 |
Maurice Lam <yukl@google.com> |
[SuwLib] Use framework selectableItemBackground
In RecyclerItemAdapter, use android:selectableItemBackground, only
falling back to selectableItemBackground if the former is not set.
Bug: 27942976
Change-Id: Id7dc2781b0b7b69f7e9fab180268dd4568ba79ee
etupwizardlib/items/RecyclerItemAdapter.java
|
| bb8f21ea108666cc962b016a7664b5f500c63ff3 |
25-Mar-2016 |
Ajay Nadathur <ajayns@google.com> |
[SetupWizard] NPE on "Nexus Imprint"
Error happened because "R.attr.selectableItemBackground" didn't resolve causing NPE
inside LayerDrawable.
Testing:
--------
- Ran SUW as well as visited fingerprint screen after setup. Verified
that: 1) Ripple effect works 2) No NPE
bug:27853943
Change-Id: I882ad4ed8f04f2e243b54731adc33d2a50da53ee
etupwizardlib/items/RecyclerItemAdapter.java
|
| 9b4e2c4788f066d799af15e573c1dc78102fc0d0 |
24-Mar-2016 |
Ajay Nadathur <ajayns@google.com> |
Animation in N wifi list results in list item overlap
- Changed the background color of list items in wifi screen to solid
color.
Testing:
-------
Ran suw on nexus6. verified that I don't see list items overlapping
during animations
bug:27725362
Change-Id: I8d026b718decb549ed56815a8081ee83ad600f1f
etupwizardlib/items/RecyclerItemAdapter.java
|
| efd346d200a1649d94c5a1add1636de5b7d56eef |
15-Mar-2016 |
Udam Saini <udam@google.com> |
[SetupWizard] Adds a new divider style for showing divider.
This style is used to determine if the divider item decoration should
check both the item view holder below and above where the divider would
draw itself. If set to true, both need to be true. By default, this is
set to either, so that a divider is drawn if either the item below or
above the divider allows a divider to be set.
bug:27619572
Change-Id: Ic0494542b3b62bf19061fb9feda52baac90f3972
etupwizardlib/DividerItemDecoration.java
etupwizardlib/items/ItemViewHolder.java
|
| 91e15cf64b798b087c764c5057daf7198d2c8d83 |
10-Mar-2016 |
Udam Saini <udam@google.com> |
Add a bottom line to last item in a list.
From UX studies, we've found that this is clearer to user that a given
item is selectable.
bug:27591940
Change-Id: I26e1e9d7fb0a6c89f82da341b96803d1e6997014
etupwizardlib/DividerItemDecoration.java
|
| ed01ca56495fb15117cca72bc7eff58ad4b2733e |
11-Feb-2016 |
Maurice Lam <yukl@google.com> |
[SuwLib] Allow dividers below disabled items
Bug: 27104912
Change-Id: I1ac43d7b72342d3f3697122347730aa249587b2f
etupwizardlib/items/ItemViewHolder.java
|
| ec9d8c8aa8fdeb6640fb0037b062bf10ca1c016b |
09-Feb-2016 |
Maurice Lam <yukl@google.com> |
[SuwLib] Fix showProgressBar for RecyclerLayout
Fix show and hide progress bar for RecyclerLayout by introducing
findManagedViewById method in SetupWizardLayout, so that it can
find progress bar even if it is not currently laid out in the view
hierarchy.
Also added setProgressBarShown(boolean) to make the interface
consistent with GlifLayout.
Change-Id: Icc44d91e2d6030b210304ad81c158be67b7050f1
etupwizardlib/SetupWizardRecyclerLayout.java
|
| 3885d8491a008281d18ddbbabc5b8e26848fadcc |
09-Feb-2016 |
Maurice Lam <yukl@google.com> |
[SuwLib] Support preference v14
Add SetupWizardPreferenceLayout to support Preference v14 framework.
Bug: 26994868
Change-Id: I3b7a4b57cb4df6c46fdd868357bcbdaad39f1feb
etupwizardlib/SetupWizardPreferenceLayout.java
etupwizardlib/SetupWizardRecyclerItemsLayout.java
etupwizardlib/SetupWizardRecyclerLayout.java
|
| 15391fc05a0fc45e9af85b653abffa41df575e91 |
06-Feb-2016 |
Maurice Lam <yukl@google.com> |
[SuwLib] Add divider insets
Allow SetupWizardListLayout and SetupWizardRecyclerLayout to have
divider insets.
Change-Id: I879469b15692e86d24336b13a8ee9d1a796bb036
etupwizardlib/GlifRecyclerLayout.java
etupwizardlib/SetupWizardRecyclerItemsLayout.java
etupwizardlib/util/GlifPreferenceDelegate.java
|
| 2286e48a268aaa0dc57b93b878c3a632c627acec |
30-Jan-2016 |
Udam Saini <udam@google.com> |
Adds a stable ids attribute for recycler views
bug:26877107
Change-Id: Ia1eb9646f887a6e0b61613997558d08da85d057b
etupwizardlib/GlifRecyclerLayout.java
etupwizardlib/SetupWizardRecyclerItemsLayout.java
|
| 0e9b312956dd28cef21473337800919eb0a54b2d |
28-Jan-2016 |
Maurice Lam <yukl@google.com> |
[SuwLib] Add sticky header to recycler view
Change-Id: Ib06ab550c16471fbdae3c348f9c91dd42893a138
etupwizardlib/SetupWizardRecyclerItemsLayout.java
etupwizardlib/view/StickyHeaderRecyclerView.java
|
| b611de8f91fa8f8cee67a55f90d60d0b44c91458 |
28-Jan-2016 |
Maurice Lam <yukl@google.com> |
[SuwLib] Add dividers to recycler views
Bug: 26774307
Change-Id: I48d183462894c20838a74cfec7bfb436f9fa42e8
etupwizardlib/SetupWizardRecyclerItemsLayout.java
|
| 7bc6f176937ed369b180fa89f6c311d2801f206c |
23-Jan-2016 |
Maurice Lam <yukl@google.com> |
[SuwLib] Allow requiring scroll in lists
Add ListViewRequireScrollHelper and RecyclerViewRequireScrollHelper
that will require scrolling in those layouts. SetupWizardListLayout
and SetupWizardRecyclerItemsLayout are now wired properly with the
requireScrollToBottom() method to require scrolling.
Change-Id: I1086fe02374bfbbeb1ac3f8c4ca6981f3ced0df9
etupwizardlib/SetupWizardRecyclerItemsLayout.java
etupwizardlib/util/RecyclerViewRequireScrollHelper.java
|
| 38a3832bf55aeb5dc24904d4d1ddf391dffa7d7b |
19-Dec-2015 |
Maurice Lam <yukl@google.com> |
[SuwLib] Add preference integration support
Change-Id: I2e756bcea1512886958ec70c80ae6f4616c9ed81
etupwizardlib/util/GlifPreferenceDelegate.java
etupwizardlib/view/HeaderRecyclerView.java
|
| 5a4d6cdfb63240c41527ba80b7baddba8933d770 |
04-Dec-2015 |
Maurice Lam <yukl@google.com> |
[SuwLib] GLIF layout adjustment for headers
- Store the list item directly in the view holder and update in
onBindViewHolder, so that the click handler is not prone to adapter
position changes.
- Glif[List/Recycler]Layout now returns the wrapped adapter when
getAdapter is called.
- Disable dividers for header views
Change-Id: Ie782a4de06e2296d4996cb8b81b5d7d3fc834ccf
etupwizardlib/GlifRecyclerLayout.java
etupwizardlib/items/ItemViewHolder.java
etupwizardlib/items/RecyclerItemAdapter.java
etupwizardlib/view/HeaderRecyclerView.java
|
| 180360409c9e4e9163c670ff48663244b4057eaf |
14-Nov-2015 |
Maurice Lam <yukl@google.com> |
[SuwLib] Add dividers to GLIF list layouts
Add dividers with inset support to GLIF list and recycler layouts.
Typical usage of this will be by specifying app:suwDividerInset to
either @dimen/suw_items_text_divider_inset or
@dimen/suw_items_icon_divider_inset (the default).
Bug: 25726515
Change-Id: I8f569680d71d1baba093b20f3d48570d53383acb
etupwizardlib/DividerItemDecoration.java
etupwizardlib/GlifRecyclerLayout.java
etupwizardlib/items/ItemViewHolder.java
etupwizardlib/items/RecyclerItemAdapter.java
|
| b01f3ef075d501d1f61e6f61794a5cadd3ff2026 |
21-Nov-2015 |
Maurice Lam <yukl@google.com> |
[SuwLib] Implement GlifRecyclerLayout
Bug: 25726515
Change-Id: Ibb60af51928bb5fc828761c55430cc8d31fe5c98
etupwizardlib/GlifRecyclerLayout.java
etupwizardlib/items/RecyclerItemAdapter.java
etupwizardlib/view/HeaderRecyclerView.java
|
| a4b92021cb7100daed79df590027182332061c88 |
06-Nov-2015 |
Maurice Lam <yukl@google.com> |
[SuwLib] Implement SetupWizardRecyclerItemsLayout
Make a layout for convenience implementing items with RecyclerViews,
similar to SetupWizardItemsLayout.
Change-Id: Ifbb0f9b9d4336ce789a0fca5d99f01e715186576
etupwizardlib/SetupWizardRecyclerItemsLayout.java
|
| 694b69b132851021da8f9730870d124a092cc3c8 |
05-Nov-2015 |
Maurice Lam <yukl@google.com> |
[SuwLib] Guard against RecyclerView.NO_POSITION
When an item is being clicked on, but it is currently being removed
from the recycler view (i.e. already removed from adapter, but layout
has not been processed yet), ignore the click.
Change-Id: Ifd0a90b2849af81ccbdade69561f82036c10c5dd
etupwizardlib/items/RecyclerItemAdapter.java
|
| a74bc1d5c6d7cb9e0f5add4c56a983cb492cb3c2 |
22-Oct-2015 |
Maurice Lam <yukl@google.com> |
[SuwLib] Recycler item adapter support
Implement RecyclerView item adapter for an ItemHierarchy.
Change-Id: Id7e650fafa467ca7ee3c80102efc73d4323e5b1c
etupwizardlib/items/RecyclerItemAdapter.java
|