History log of /packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
bf96dd1b542c7aa5bf5e97903b22dbd2cbe2a316 21-Feb-2016 Wenyi Wang <wenyiw@google.com> Remove AppCompat library from Contacts (1/3)

This will reduce size of GoogleContacts-N.apk by 0.7 MB (8.4 MB --> 7.7 MB)

* CL was prepared by running the following:

git revert --no-commit e7fd1ad19023a0b79b232462bcb988676c605b9a # https://googleplex-android-review.git.corp.google.com/#/c/841451/
git revert --no-commit 3d53e233beb1742d3274fb27576d4d1420e4aac2 # https://googleplex-android-review.git.corp.google.com/#/c/841473/
git revert --no-commit 903fbfc4fb63ceaccddb722217a5d5e9d80f88b3 # https://googleplex-android-review.git.corp.google.com/#/c/839578/

Also:
- added import view.Window back to PeopleActivity;
- removed an AppCompat style

Bug 27257097

Change-Id: I21653376c78ef0a435f90b565b6c40dd5b747317
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
9eb87f4e4a41fec748ce48281f85f3b3ae32fb93 23-Jan-2016 Wenyi Wang <wenyiw@google.com> Revert "Keep overflow menu button from closing on changing orientation"

Bug: 21650562

This reverts commit ff603b5e045c596c88cf1a70b9320d36437a80cb.

Change-Id: I8916df1ea8fb2ac8ebc617caea9bdd22c7bca117
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
e7fd1ad19023a0b79b232462bcb988676c605b9a 06-Jan-2016 Wenyi Wang <wenyiw@google.com> Use AppCompatContactsActivity as super class of activities (1/3)

- AppCompatContactsActivity will replace ContactsActivity eventually

- modified PeopleActivity and ContactSelectionActivity

- fixed the color of buttons in contacts_unavailable_fragment_content on K

Bug: 25629359
Change-Id: I7312fb446c6affc070db1b44b74ed857afcf8f3a
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
4c3d3e24b0de8b4170106e312f6a4ac8139e1242 17-Dec-2015 Wenyi Wang <wenyiw@google.com> Backport methods related with QuickContact

- Ignore setters and getters of status bar color on pre-L
- Ignore setters and getters of EdgeEffect color on pre-L
- Use ViewCompat to set elevation
- Use PathInterpolatorCompat to instantiate Interpolator

Bug: 25629359
Change-Id: Ie9409fbdc7f96a9feead95f2e47ca852a735a285
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
23d9b6e86d2cd15347ff7be0e911ee4992704d44 20-Nov-2015 Wenyi Wang <wenyiw@google.com> Use ContextCompat to handle getColor (2/2)

Bug: 25629359
Change-Id: I982172555532f4e7a8a756d7b4880ff0821d5f7a
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
56dfa580b5497f25169a4c875800ffff95cd31cd 18-Nov-2015 Wenyi Wang <wenyiw@google.com> Fix usage of getColor() on pre-M SDKs (2/2)

Bug: 25629359
Change-Id: I7c4ea6b1fb03e192569d41105977162f79339716
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
ff603b5e045c596c88cf1a70b9320d36437a80cb 11-Oct-2015 Wenyi Wang <wenyiw@google.com> Keep overflow menu button from closing on changing device orientation

Bug: 21650562
Change-Id: Ic2459b0768866e4a76734345ffa75edad8dac702
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
ad6e0eea7026d82a2e27ad4a01c3f2d2e2c4360d 06-May-2015 Andrew Lee <anwlee@google.com> Hide "clear" action for empty search query.

Bug: 20700084
Change-Id: I9af6c50c266b8520b098140e0f968ca3ff75d1c9
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
865847b1f567cb28664a57ac9cac05c3f2a8de32 20-Apr-2015 Brian Attwell <brianattwell@google.com> Improvements to multi select

* selection bar now uses an <- instead of X icon
* FAB animates away when entering either selection or search mode
* allow selection mode to be entered once already in search mode

Demo: https://drive.google.com/a/google.com/file/d/0B-vjphxTdjuANERMUDF6Y2NyQXc/view?usp=sharing

Bug: 19549465
Change-Id: I657bf564c8e6cdfca6f7779918c4807e09e78d9b
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
d2962a3bb669a381d31a586df3b906033a8fa571 02-Mar-2015 Brian Attwell <brianattwell@google.com> Batch deletion

Also: when re-opening the Activity from the launcher, clear the
mIsInSelectionMode variable in memory.

Bug: 19549465
Change-Id: If589983d3d84c9c18066da08f9879c22db1a75ed
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
20510ec0a26e7eeb7f3a321deb755e984445fe74 28-Feb-2015 Brian Attwell <brianattwell@google.com> Multi-select to share Part 2

UI work to supprot multi-select. Long pressing starts selection mode.
For now, you can only share the contacts that you have selected.

Manual tests:
* Starting selection mode
* starting selection mode by long pressing the Me Profile
* RTL layout
* rotation in search mode
* rotation in selection mode
* typing on keyboard while in selection mode:
$ adb shell input keyboard text 'this%sis%san%sexample' (should do nothing)
* press search key while in selection mode:
$ adb shell input keyevent 84 (should do nothing)
* sharing contacts via multi selection

Bug: 19549465
Change-Id: If438bddfaaee1f69e4c888716f926abcd00ddbc6
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
87901e0e2896ffc2a03f519bcc86e7cb88098fa1 02-Dec-2014 Brian Attwell <brianattwell@google.com> Hide keyboard when exiting search view

Bug: 18548146
Change-Id: Ia37dedca43352d609e8eef54761d1ed67ec6c133
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
b3944dcec1fb1299d8bedeef251adb0a413fba52 19-Nov-2014 Brian Attwell <brianattwell@google.com> Correctly set search string when entering search

Changes
1) When entering search mode, explicitly clear the
search query
2) Make sure that the cursor starts after the text
that is programmatically inserted via setQueryText().

Manual tests:
-Type into search bar. Exit app. Resume app.
Open search bar again. Search bar should be empty.
-Type into search bar. Rotate app. Search bar shouldn't
be empty.
-Type into search bar. Close search. Open search.
The search view should be empty.
-execute "$ adb shell input keyboard text abcd". In KK
the search view will show "dabc". Now this shows "abcd".
-Place cursor in middle of a search term. Enter new text
using the soft keyboard or use adb shell to enter new text.
In both cases the new text appears after the cursor
position.

Bug: 18410365
Change-Id: I7ce260913e3c8e7448678bd2178859fb9c9270ab
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
8d71f11c70c974518f3482c46a10a5601628a029 24-Jul-2014 Brian Attwell <brianattwell@google.com> Fix tabs when using ContactsUnavailableFragment

Also fix landscape tabs when opening the app from landscape
launcher.

Bug: 16516327
Change-Id: Id930dd1aa8d1a9001d7c7901a5822ebbf4cfa2db
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
3c763b3a614375a1dbe273feec5a7664cd5939d3 21-Jul-2014 Brian Attwell <brianattwell@google.com> Use custom ViewPagerTabs

Use the custom ViewPagerTabs from contacts common.
In portrait, the tabs are below the toolbar. In landscape
the tabs are inside the toolbar.

Bug: 16158921
Bug: 15616182
Change-Id: I6c2067fdc10fa15ebd6e0fa93aa1c4f8e7cd45a7
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
6adbf1e7870e9de4ad203d334c8786ffca7d123d 31-May-2014 Brian Attwell <brianattwell@google.com> Unified search bar style, and new animation

Change-Id: I87516ceae4a5d64edb1febd50bd96b4f7471af67
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
a05431fe824f39e60a8b25a244a1fea39805a61b 31-May-2014 Brian Attwell <brianattwell@google.com> Remove dual panel code from ActionBarAdapter

We don't want to use NAVIGATION_MODE_LIST anymore.

Removing this now will simplify my next CL that touches the
ActionBarAdapter.

Change-Id: I0b8b05aa2f5d6b5a58a56f8aedd14ed638a7599f
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
b0d3c7609a21d7432bcac0cf97411d1ff64851ba 22-May-2014 Brian Attwell <brianattwell@google.com> Revert^4: Use action bar style from ContactsCommon""

Move this into master-contacts

This reverts commit 88636968c74a13c79629fc8adf200f670a98ff02.

Change-Id: I879450b5871c5ef4b925a839dcd64c4ec1bf6141
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
88636968c74a13c79629fc8adf200f670a98ff02 22-May-2014 Brian Attwell <brianattwell@google.com> Revert "Revert^2: Use action bar style from ContactsCommon"

I am going to move this to master-contacts

This reverts commit ede793ef6a2f155ce55ad6a64c1299beae5500e4.

Change-Id: I4c31e825adf14605153efa8ceb08363bdf7ac94e
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
ede793ef6a2f155ce55ad6a64c1299beae5500e4 16-May-2014 Brian Attwell <brianattwell@google.com> Revert^2: Use action bar style from ContactsCommon

Change-Id: I9371b796f98ffde303e9e8ad6c5fbbc89200c5d6
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
15c43d91b85cbc4f66fc2e16f35fcb589bb77d5a 19-May-2014 Brian Attwell <brianattwell@google.com> Revert "Use action bar style from ContactsCommon"

This reverts commit 80df79f4279b7f4f0f2f275ff6dca47cdc6d4632.

Change-Id: I1f1f855ef55206fbee246a2379367415a8f42885
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
80df79f4279b7f4f0f2f275ff6dca47cdc6d4632 16-May-2014 Brian Attwell <brianattwell@google.com> Use action bar style from ContactsCommon

Change-Id: I5097ad30b103ceddc0e72c3d016c364a99026e71
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
5f057fa8a0d1be9529024846c9e69b5764078d2c 15-May-2014 Paul Soulos <psoulos@google.com> Removes the Group tab from the People Application.

There are still Group related code and resources that need to be removed.
This will occur in smaller subsequent CLs to reduce the scope of each.

Change-Id: Ifcedf38377f9da022942c694193e4e15f3ed77d3
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
26dc5592145eeddcd435daf2dae29d8e483f1b7b 08-Feb-2014 Brian Attwell <brianattwell@google.com> Don't initialize ActionBar with invalid tab index

If an invalid tab index is persisted to SharedPreferences then every time you
open the People app, the app will crash. This CL fixes this crash. It doesn't
prevent the tab index from getting in an invalid state in the first place.

I don't understand how this invalid tab index gets set. The
ActionBarImpl and TabPagerAdapter would both have to believe that a tab
at position 3 exists, otherwise a crash would occur before an invalid
tab index could be persisted.

TESTING
-verified that I could close and open the app from every tab position
-pushed an invalid shared_preferences.xml to a phone. This causes crashes
without this CL. This CL fixes the crashes.

Bug: 12938207
Change-Id: I6eb9a9043dcc76ce94a1cc280c7441e57a4abfd1
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
db2adcb4d4da6361301701da08c4f3c72b577fd3 10-Sep-2013 Paul Sliwowski <psliwowski@google.com> Fix bug tab selection on tablet.

Bug: 10674395
Change-Id: I1d3d7e2e72202355049de11ad0010649a27660e6
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
3b6a6f6ac9dce6028248ed7a695ed2c76890add8 05-Sep-2013 Paul Sliwowski <psliwowski@google.com> Update colors in the people app.

Change-Id: I93194f75e83fd6dba95a7bc8aafa73432dac8353
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
8d5eec3c552c2ac23bc4d3324063627d31582615 18-Jan-2013 Yorke Lee <yorkelee@google.com> Fix broken key-type to search with keyboard

Remember the query text before updating the SearchView,
and restore it again after the update is done to prevent
the loss of the first typed character after going into
search mode.
Bug: 6332454

Change-Id: I2f6eb930cbbeef57c61e830e048a40295e07df30
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
e0b2f1e2d01d1ac52ba207dc7ce76971d853298e 12-Jun-2012 Chiao Cheng <chiaocheng@google.com> Global import order fix.

Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements

Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.

Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
7f5220e23b37b76cf484b28c182a0c98749b59e2 14-May-2012 Maurice Chu <mochu@google.com> Changed tablet tabs to be a drop down spinner

The tabs in the action bar have been removed for the
tablet form factors and replaced with the action bar
drop down navigation list.

Also, this changes the list item padding in the browse
list on the 7" tablet to extend a little further on the
border to the contact detail panel in portrait mode, so
that more text of longer names can be seen.

Bug: 6426927
Change-Id: Ieced44f5241c3f4f71bdbd7818846e24076fb355
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
b0d82d2703d66b3bd4fe8dc4208cdf6a09f2f4af 08-May-2012 Daniel Lehmann <lehmannd@google.com> Fix for "Next" instead of Search showing up the first time

Bug: 6399620
Change-Id: I8d6d7f4e75a18745d7127edde9ae3326220d4fcb
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
311882ab2fc1e9c8264f5892a6d50722b834e348 28-Apr-2012 Daniel Lehmann <lehmannd@google.com> Make search button focus the search field while in search mode

- Also removed a totally unused class
- Also turned an enum into an abstract class

Bug:5188996
Change-Id: I0dde1e49b360459f71196b151160a25d24d21343
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
09d66a382d1f94618b52fec11ba54d9243a95a18 14-Apr-2012 Daniel Lehmann <lehmannd@google.com> Restore Focus after rotation if we are searching

Bug:6027055
Change-Id: I3b9e23ab115c303ac2a68d8ddba55a35e2c4ed01
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
52aa32db432085ab2cd4864bd1edd1ef843da867 09-Mar-2012 Daniel Lehmann <lehmannd@google.com> Replace enum by int

Change-Id: I0d7aafa509f6d2747e78493b67dc65de52c9bb68
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
3c877e33cb7fecc7a63af1cf3c25061d53811bf6 04-Jan-2012 Katherine Kuan <katherinekuan@google.com> Show search query in SearchView for incoming search intents

From the ContactsRequest, we extract the search query and set
it on the SearchView. However, when we update the action bar
to expand the search view, the query string gets cleared out.
Hence, set the query on the SearchView AFTER it has been
expanded.

Bug: 5790409
Change-Id: I4264cb75b8b4b23d4e97c2777a816cd49c2cb328
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
5c3a0a1440625fab859aab420cb08bc0276358a0 08-Nov-2011 Katherine Kuan <katherinekuan@google.com> Fix wrong contact being selected after editing (after a search)

- The problem is that after finding a contact via search
and editing that contact, we launch a VIEW intent to view
the contact. Then sometimes, that contact is not in the
current contact filter, so we may have to enter single contact
mode.

To avoid that, go back to the HC functionality of preserving
search mode. Now after editing, we return to the PeopleActivity
and preserve search mode if that's where we came from.
This was the relevant change from early ICS that is being
partially reverted:
Ibbaaccb03ac7961784dfa7b15c246b8d6f6489a4

The reason it was changed was to support viewing the contact
after editing a contact when the edit request came from a 3rd
party app. This still works with this change by adding
an intent extra in ContactEditorActivity.

- After the editing is done, only launch the VIEW intent
for the contact if we didn't come from the detail page for
that contact (on phone and tablet). We can just finish
the editor activity. This saves some time with setup / configuring
fragments because we don't have to resolve the VIEW intent
(i.e. On tablet, previously the VIEW intent launched the
ContactDetailActivity --> redirected to PeopleActivity -->
resolved intent to show the right contact.
Now we can just receive the onActivityResult and refresh
the page).

- Renamed ContactDetailActivity intent key to be consistent

Bug: 5542197
Change-Id: Ieaa9c147beeaa7c40f34fc1689858642b47fdbf9
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
966cc74cb9cff62cf19d7870dd1e2e849de44424 20-Oct-2011 Makoto Onuki <omakoto@google.com> Merge "Fix the double query issue on phone"
1db00f68b34f6cf7e9d19fedb559cf12f8c05e9c 19-Oct-2011 Makoto Onuki <omakoto@google.com> Fix the double query issue on phone

The issue was that fragments had separate methods for search: setSearchMode()
and setQueryString(). But now that fragments will never be in search mode
when query is empty, there's no need to expose both methods.

Changed setSearchMode() to non-public, and let setQueryString() call it
when necessary, so now we don't have to issue unnecessary queries.

Note this CL doesn't modify adapters, so they still have setSearchMode()
and setQueryString() as separate, public methods.

Also did a bit of cleaning up on how PeopleActivity handles search mode.
(When I worked on it first time I wasn't too familiar with the code, so was
afraid to change existing code too much, which left the code unnecessarily
complicated.)

Also removed all fragment.setSearchMode()/setQueryString() calls in
ContactSelectionActivity.configureListFragment(). As far as I checked
there's no way to invoke this activity with reqeust.isSearchMode/getQueryText
set.

Also removed ContactEntryListFragment.get/setContactRequest, which weren't used
anywhere.

Bug 5274171

Change-Id: I794db7ed54cb6b8f45d69430ec2f77e7fa83fb8c
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
aaadf9393e98b04a40d249cd97ec758047268ed9 20-Oct-2011 Katherine Kuan <katherinekuan@google.com> Use text (instead of icons) for action bar tabs on tablet

Bug: 5345494
Change-Id: Id83008d868be9fba1d1bfe8c8d60adf0bff0cdcf
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
1ff189a390ce5011f729637baf248646560c1bc6 08-Sep-2011 Daisuke Miyakawa <dmiyakawa@google.com> Replace tab texts with icons

Also replaces existing "contact card" icons with ":D"

Bug: 5274359
Change-Id: I04b77bfdab17f4a2468e8ecde88fab7477c11e3f
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
0bf7cd0124fa6f74fe3d64619740420ded86dcce 23-Aug-2011 Katherine Kuan <katherinekuan@google.com> Asset swap and make SearchView use themed context

- Make SearchView in action bar in People app use action bar
themed context so the query text and icons are white instead
of gray. Create a custom theme to make the hint text lighter
than the default DarkActionBar hint text color (as directed
by UX and framework)

- Replace panel_message asset (background of contact editor on
tablet and contact unavailable fragment)

- Replace the panel_content asset (background of group detail
fragment)

Bug: 5127109
Bug: 5199518
Change-Id: Icae927e1d158241140d18028d38cac25dbf282fc
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
9d2a74ef7b1817ad0708e41151358f5899aeeb67 15-Aug-2011 Makoto Onuki <omakoto@google.com> New tab order: GROUPS / ALL / FAVORITES

To be consistent with the phone app.

Bug 5161134

Change-Id: Ieb50b78d140ca5404620c9ad03fb31433b7b666d
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
e668051b61d05c267a8e3c1bfd2fe9b034aa6ae1 12-Aug-2011 Makoto Onuki <omakoto@google.com> New search behavior for empty query

It's a very lightweight change to implment the new spec, which says:
- Don't start searching until the user types the first letter
- But if the search view is shown, make the ALL tab current, and disable swipe

With this CL,
- No changes to ActionBarAdapter.isSearchMode(). It still returns true
if the search view is visible, even if it's empty.
- However, in order to make the all fragment show the normal list for
empty query, only turn the fragment into the search mode if the query is
non-empty.

Also reverts I25908651 as we no longer do a search with empty query.

Bug 5104010

Change-Id: I50038994c6d65aab71ceefdf9218f3c7ad2bc6a4
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
d8a61b7296bf7388505f0211d7ef44700e766193 27-Jul-2011 Katherine Kuan <katherinekuan@google.com> Use new search pattern in People app

- Magnifying glass should go inside the EditText field
- "Done" button on keyboard should hide the keyboard
- When going to a search result (contact card),
the "up" button should return to the search results
and not relaunch PeopleActivity

Bug: 5081198
Change-Id: I32e103c39c40da26bfd12f1fa8cef000f33ee1c9
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
5267367e202dcb39ef0fe912a7be9209548ec436 25-Jul-2011 Makoto Onuki <omakoto@google.com> Change the search UI on 2-pane

- Don't always show the search view. Instead, show the search icon as an
option menu.
- If the icon is tapped, show the search view.
- Don't show "Searching all contacts". Just show the search view right
next to the app icon.

This simply means to use the 1-pane search UI on 2-pane as well.

Bug 5055536

Change-Id: I9a4b16048285cd30975bcb2bae5ec3d01d15f20e
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
35d4aec605ce915ff5c574892a2069a37e0b9a77 20-Jul-2011 Makoto Onuki <omakoto@google.com> Implement sticky tab

Remember the last selected tab and open it when the app starts.

Bug 5046301

Change-Id: I94a11b3397181b09f72e91c20bf451e7ac8eb5ed
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
d84ea5c8b0a8376e7cf80b0e15b65a72fd99d7a9 14-Jul-2011 Adam Powell <adamp@google.com> Follow framework API change

Change-Id: I6bbc24d20d3bd254f6e2d54c14100fa9ab8513ed
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
e0c66aff27473d0edbd95660b95f0f2a80ab63ec 13-Jul-2011 Makoto Onuki <omakoto@google.com> Show the "UP" icon on the search mode.

- On both 1-pane and 2-pane.
- Also just use a bool resource instead of styles to get
the "should show the home icon" setting.
- Also clean up how we set action bar display options.

Bug 4983521

Change-Id: I81f61a98bfc6695784a323cb28e05d7e3f7f932d
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
250ce43794cdf6820f7a13ef0195a566bd0c8c64 13-Jul-2011 Makoto Onuki <omakoto@google.com> PeopleActivity: Swipe!

I was originally planning to create a set up classes to abstract out the
logic to controll fragment visibilities, but with the last refactoring on
ActionBarAdapter() I think it's managable without them...

Change-Id: Ic6c8a2b87005bc0cd3ab41dee7ac99db794274eb
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
4d788fc27ac855bd6e0cec17dff39a18564f0089 12-Jul-2011 Makoto Onuki <omakoto@google.com> People: Action bar tab refactoring

- Now ActionBarAdapter manages the action bar tabs.
- Now ActionBarAdapter.setCurrentTab() should always be used to select
a tab programmatically, rather than directly calling
ActionBar.setSelectedNavigationItem().

- Do not re-create/re-initialize ActionBarAdapter/ActionBar for new
intents.

- Simplify fragment visibility update logic in PeopleActivity.

- Do not clear ActionBarAdapter.Listener in PeopleActivity.onPause;
do this only in onDestroy.
Activity is paused when we're processing onNewIntent(), but we still want to
get callbacks during this.

Change-Id: I93ec35e569e1854923503734693b6404cff92f50
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
30cc2916916535a8140637f54925c93189868de5 12-Jul-2011 Isaac Katzenelson <isaack@android.com> Temporary fix for crash on rotation in search mode

Change-Id: Iffc020090dddc4e3aa18972940dbe642c49d4dfd
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
495db43f0a08bd71ba28a42f89b80d38af15afec 07-Jul-2011 Katherine Kuan <katherinekuan@google.com> Bring back account filter

- ContactListFilterController no longer loads accounts and groups,
to display in the action bar drop down menu. Now it just stores
current filter and saves it to preferences.
- ContactListFilterLoader is no longer needed because we're not
loading groups anymore
- Move adapter from ContactListFilterController to the
AccountFilterActivity
- AccountFilterActivity loads a list of accounts and returns
a ContactListFilter as an activity result based on the account
selected
- If "customize" is selected, then the CustomContactListFilterActivity
will be launched.
- Show header in contacts list according to what account filter
was selected
- Update filter activities to holo theme

- TODO: Remove the "display phones only" option in the
customize menu on the phone

Change-Id: I45e0bdee80e7885d39bf09183a66ec50d81d1982
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
4ba903cdf132a6be2e5efa33187b18ca8446e503 08-Jul-2011 Makoto Onuki <omakoto@google.com> Fix for search view/IME issues

- Set the search view as the custom action bar view on tablet too,
(not as an acition view of a menu item.)
- Add a dummy view to the action bar to prevent the search view from
getting the initial focus.
- Call SearchView.setIconified(false) to make sure the IME will pop up
when setting focus on the search view.

Fix for:
- tablet: Keyboard keeps popping up upon app launch.
- tablet: Keyboard keeps going away after each character is typed.
- tablet: Have the search view request focus again.
- phone: Keyboard won't pop up when the search view is shown

Note:
- The width of the search view on the tablet is temporary until we
get redlines.

Bug 4691469

Change-Id: I70d1dddebf63120e8fbbafd6a0548d8553a8927c
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
59dc2751d64f60f743b8a9e78186aa5b79dcaf83 07-Jul-2011 Isaac Katzenelson <isaack@android.com> Fix "Tab not maintained on rotation"

Change-Id: I331794c948dab876c808ba1274cb11dbdb70155d
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
1ee9df6facd2340416d6a33aeb739707643d2fc3 12-Jun-2011 Katherine Kuan <katherinekuan@google.com> Fix search view on phone

- Take SearchView out of the action bar on the phone
and put it into the overflow menu
- Hide menu item if already in search mode

Bug: 4575326
Change-Id: I63003bb2c31712510ffa30eadb65b8a511f42011
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
f3f933a798c9cfffb1c1c0cc770187b5b0b763eb 10-Jun-2011 Katherine Kuan <katherinekuan@google.com> Fix NPE in ActionBarAdapter

- Fixing the SearchView will require more work, but temporarily
add a null check before calling any method on the SearchView so it
doesn't crash anymore in Monkey tests

Bug: 4584460
Change-Id: Ibb31a1931213cdce82b593c9de62e600d5ba2e35
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
b5760b94bbf56ce348876ec36f4669d20a1530f5 02-Jun-2011 Katherine Kuan <katherinekuan@google.com> Add tabs to People app

- Move account filter into overflow menu
- Use action bar in tab and standard mode so the SearchView
is right aligned and part of the options menu instead of the
custom view in the action bar
- Make visibility of action bar home icon a style so the icon
can be hidden on the phone
- TODO: Make physical search button work on the phone so the
search box can be removed from the action bar
- TODO: Fix SearchView focus problems

Change-Id: I7b3ba49f80e1911fb4a096679a00560967584426
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
eb5c3228af1e86db5552bc8baf6bf62c77612f3e 23-Feb-2011 Dmitri Plotnikov <dplotnikov@google.com> Prevent empty search results from showing up before typing

Bug: 3446388
Change-Id: I6994eca6c90357e61dfbdc22283e3169ece25efc
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
c5792ae6760291d435e91e0fdd28ece6b3311439 21-Jan-2011 Adam Powell <adamp@google.com> API change - bug 3370353 and bug 3370338

Change-Id: I470771606f15936e3a20f4c0aaac0fe99b2a587f
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
8db1913dc30cd83ac27e10a4cfda12b4bf08dcfe 13-Jan-2011 Dmitri Plotnikov <dplotnikov@google.com> Making search mode triggered by focus in, but ignore focus out

Bug: 3340666
Change-Id: I75422950c9f708f4651ebf74a43f65eebcea9d11
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
fa49a66979567894c85fe2489d1375216d67597e 13-Jan-2011 Dmitri Plotnikov <dplotnikov@google.com> Preventing multiple instances of contact browser from launching

There is a lot of complexity (and simplifications) in
this CL because as it turns out having fragment transactions
was causing focus to be acquired by the search field,
which was causing all kinds of problems. So now we only
have one permanent list fragment (which should go into the XML
file) and we just change modes on it.


Bug: 3345023

Change-Id: I096be24b7598350a074eb1dadc954c7619f26669
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
1173ae29217fc83f254404f8a5fa10419ee83c93 09-Jan-2011 Dmitri Plotnikov <dplotnikov@google.com> Fixing ContactBrowserActivityTest

Change-Id: Ie492eae15c7163d0f8a3577e73ae14b786709a35
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
3e076bb53d39eb3757b376a003c412e4f44b0e3d 11-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Adding a hint to search view

Change-Id: Ie5c964a45458159c82c48414a54e19524289f794
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
11cbbf445e4724246836f006f06ad16cc82ca439 09-Dec-2010 Dmitri Plotnikov <dplotnikov@google.com> Switching to framework styles in action bar

Change-Id: I218710421d40e28557252ac22f95c8e0c1791513
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
02cbf8b0e73a7e169445e341f387356242f0334d 24-Nov-2010 Dmitri Plotnikov <dplotnikov@google.com> Preventing keyboard from showing while loading contact browser

Bug: 3224228

Change-Id: Ic036e07c3da8deeaf11671295ac0509dd10d7f71
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
8b8264620f9362e089322d1e3a7cc5620900e6f9 17-Nov-2010 Dmitri Plotnikov <dplotnikov@google.com> Resurrecting empty state UI

Change-Id: Idc1ee48d62d4f0c01756f9b7689e0f31235b61d9
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
4597c92d655d45447780b32c7572acef110b6ed1 15-Nov-2010 Dmitri Plotnikov <dplotnikov@google.com> Renaming BaseAccountType to AccountType

Change-Id: Iff47bac0e1a118f4a5319526304df16cb89bd0cd
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
a31fe548862fef70d3244dc3414a478f91b098f6 13-Nov-2010 Dmitri Plotnikov <dplotnikov@google.com> Fixing contact filters for local (unsynced) contacts.

Bug: 3159239
Change-Id: Id469b19d35dc62e092db64f0ee3356a7ec2f2680
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
9ce839e2a86b1742682fdec69641c6ed9d665a06 12-Nov-2010 Dmitri Plotnikov <dplotnikov@google.com> New assets and layout in the contact filter pulldown

Change-Id: I549eccac6f6fe4e28a4a26a5a2433b3562dd8c91
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
3bfccddd6f61f6196a7f0af426c9e3f742de37f3 04-Nov-2010 Dmitri Plotnikov <dplotnikov@google.com> Fixing the size of the search field

Change-Id: I196ac49cc8a8120f3073b9a7afb8bbd84ad757a6
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
174fdc2dcb965f11cf4eb25e4ea961f0e1e56c85 29-Oct-2010 Dmitri Plotnikov <dplotnikov@google.com> Automatically selecting first found contact.

Change-Id: I232f37d1b5256c315d514a2c8dee9e9eeca5dcb7
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
ab4d29f6a2edbfae008dbaff35f25baad73aa0df 28-Oct-2010 Dmitri Plotnikov <dplotnikov@google.com> Changing search navigation in Contacts

Search will be fully modal: when the search field
is focused, the app is in the search mode, period.
Back button will cancel search mode.

Change-Id: Ibeb6c28de7ed1a79129aed862a543a6ed2a36435
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
9806ed099226a19e92c29d9efa791cd187fd2a53 26-Oct-2010 Dmitri Plotnikov <dplotnikov@google.com> Fixing contact search

Bug: 3129260
Change-Id: Idb822c10da86cb58a7d46456135bdfa215723993
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
0b51a8d4539cc516dc2c02948335347d1df8769b 22-Oct-2010 Dmitri Plotnikov <dplotnikov@google.com> Forwarding keyboard input to the search view

Change-Id: I111214dc5bfd2194fef4647ec54fa671a7d1b8ed
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
c9916d303cc48b4a4ff94ef9c56d7ca5da72c4de 13-Oct-2010 Dmitri Plotnikov <dplotnikov@google.com> Improving layout of aggregation suggestions

Change-Id: I8690c36d0e80f89ee5043703e3a20bc46357f6e5
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
bee8d3bd37edf44c535c0cc401e8d03f095b8328 13-Oct-2010 Dmitri Plotnikov <dplotnikov@google.com> Improved layout of contact filter view

Also, no longer showing the down-arrow when there
is no filter or only one filter.

Change-Id: Ie9bbb7aa279ff2013e4c24ca8f302d864679c35c
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
251e4f7dc45928053133fe15fd456da00b7cbe8c 06-Oct-2010 Dmitri Plotnikov <dplotnikov@google.com> Contact filter uses custom UI instead of NotifyingSpinner

Change-Id: Ia51c6944d67e41050be4e3e60856b15b77ffa090
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
15ccbb4d22fd65165cacb7970cbe61de1aa9aac4 06-Oct-2010 Dmitri Plotnikov <dplotnikov@google.com> Moving contact filter spinner to the action bar

Change-Id: I29506d0e71e15e4804899146855f22690969d1f5
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
88a405fcd3fecfa24c756a8a453a957ecc9f95ae 28-Sep-2010 Dmitri Plotnikov <dplotnikov@google.com> Fixing preservation of tab selection on rotation

Change-Id: I954e5ba21466a4e6489b40f47171e576c57537e8
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
1a59cffd839069ce91a9febb8a136442340ab4c8 18-Sep-2010 Dmitri Plotnikov <dplotnikov@google.com> Switching to tab and search UI provided by the framework.

Could not make the search UI always on: apart from some
serious technical difficulties the UX is odd.

First the UX issue: I type in
a query and then switch to some tab. If we leave the
query string in the field there is a disconnect between
that query and what you see in the list. If we wipe off
the query and then we have to retype it completely on
the next search.

Now the technical issue: the search field grabs focus
so whenever I open Contacts, the search field is focused
and the keyboard is up.

Also had to hack SearchView a bit because it does not expose
the API of its constituent AutocompleteEditText.

Change-Id: Ie8848d16ab724e9bb6b7025e88b495c7297d49a7
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
2eb26aacc35a624607187418d61c78258eee8b2c 06-Aug-2010 Dmitri Plotnikov <dplotnikov@google.com> Fixing bug with query string change

To repro the bug, click on search, enter "a", backspace "b"
The result will be for the filter "a".

This CL fixes the problem

Change-Id: Ie85ff4945de4ebbe623dee4a8430dac73c52f0cb
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java
fcfdffb439ccf1ddef971109b82e782c47161572 16-Jul-2010 Dmitri Plotnikov <dplotnikov@google.com> Renaming NavigationBar to ActionBarAdapter

Also, moving browser modes to a class of their own.

Change-Id: Ie2745581537e09717a2c7a58ecebec1b7ada0c81
/packages/apps/Contacts/src/com/android/contacts/activities/ActionBarAdapter.java