| d375c35c89364aa101f11fa2c2f1270742d50f9b |
|
29-Mar-2016 |
Wenyi Wang <wenyiw@google.com> |
Update content description after updating primary
Here's what went wrong: we set content description of photos in
CompactRawContactsEditorView.getPhotos() (see ag/834274) and then
we modify "primary" before entering photo picker (see ag/854600).
We need to update content description of photos after modifying
"primary" to reflect the change in which photo is checked.
Bug 27881948
Change-Id: Iad9723c9adbeaf8396fc46c578cc4a519d9ba85a
(cherry picked from commit 5a59c26c4e43fedcd449dfae97ea435f1ce885e3)
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| ab36017cd9385e3180aff694939cc4280fd008eb |
|
15-Dec-2015 |
Wenyi Wang <wenyiw@google.com> |
Fix NPE in getPhotos()
Avoid calling toString() on a null CharSequence.
This change affects content description used in Talkback only.
Bug: 26179572
Change-Id: Iba6f1258dbe6c5797e05e9b1aa1e07b70cc17fda
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| da258ff16a03b150e4c8004aa2be6f20c196a1ec |
|
17-Nov-2015 |
Walter Jang <wjang@google.com> |
Use selected photo ID as the "photo to display" lookup parameter
Don't use the photo ID passed in on the Intent to open the
editor since that will never change.
Bug 25729444
Change-Id: I84082245ac491c9481cc469d0b7342755250ec66
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 62e6e4d8ed36623fc3d601438b3616e72bad0d64 |
|
16-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Show visible and non deleted editor view to Editor UI." into ub-contactsdialer-a-dev
|
| d482e0c41f5ebc7a11b781f6dcfbaed1f4f7ba3a |
|
16-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Show visible and non deleted editor view to Editor UI.
BUG 25713840
Change-Id: I0c682b6873f5dd6c286c87020a3863dea6214e21
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 9086fb91b69241f53eaa09067b10797c0000891e |
|
16-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Unset super primary of writable accounts photos
Bug: 25714956
Change-Id: I2d24f57732b069f08a4913db20702f98b853db12
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 42d740c24e913dc8065f2dbbfeaf598bf2fb4180 |
|
13-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Fix for undefined method
Change-Id: Ic04e7e0deb85d7a2bcdfe730fb05e80cf2b5ad42
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 228e02f29dbe84c52129ba07cd44b83bea5f2751 |
|
13-Nov-2015 |
Walter Jang <wjang@google.com> |
Don't return invisible values deltas from KindSectionData
Also don't cache values deltas inside KindSectionData
Bug 25431751
Change-Id: I65478e25dfa536342a75f71db48af3e22a4bead1
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 0b144564a6cf26bfa4da2b7972f580b90d7ede2c |
|
07-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Enable Talkback for photo picker
- When pressing a button, Talkback speaks the button text.
- When pressing a photo, Talkback speaks photo's account type,
user name, and whether the photo is checked or not.
- When double tapping a photo, Talkback speaks the account type,
user name, and that the photo is checked.
Bug: 25498370
Change-Id: Id43a220a4d5625470ff0ad1ff40a840d9c6bcd84
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| b7933743dd27d537c64303e33e23a1461989f6c6 |
|
02-Nov-2015 |
Tingting Wang <tingtingw@google.com> |
Change accessibility message for account picker.
BUG 25324831
Change-Id: Ib20e7b2f0e581e25942b9dea993617642d813eb5
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 3e8cc3545302155fdd262ab1935029247e82254d |
|
29-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Add account type icon to account info header and change style of
"Saving to"
Screenshots: https://drive.google.com/a/google.com/folderview?id=0BwSNbQ_IWQd2NUFqb21MUm11WU0&usp=sharing
The changes related with "Saving to" (b/25366902) are in:
- res/layout/editor_account_selector.xml
- src/com/android/contacts/editor/CompactRawContactsEditorView.java
The changes related with account type icon (b/25189655) are in the
other files. The account type icon is added to account info header
in both full editor and read-only editor.
Bug: 25189655
Bug: 25366902
Change-Id: I4f149f639debd31296da81f6678cda8d01007ea9
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| e394595987e288807b8c02c78d7d33e854f152b1 |
|
27-Oct-2015 |
Walter Jang <wjang@google.com> |
Set read only display name as primary in fragment not view (DN 2/2)
Also, don't remove the display name from the editor input
field when checking for pending changes, instead just
skip the name mime type after detmining that the read only
display name was used and that it didn't change.
Bug 21956248
Bug 25314004
Change-Id: I9da8430206a721a52b8dad19e5eb235cb9e57fb3
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 7be9d27563e5873f349bc1cf6ef9915b24967328 |
|
28-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Hide account container in compact editor." into ub-contactsdialer-a-dev
|
| 1594c6f3603e071c75294c9c430cee45ef642479 |
|
27-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Hide account container in compact editor.
Show account container when editing ME profile.
Hide account container when linking a writable contact with
a readonly one in editor. Also, showing unlink menu in this case.
BUG 25231329
Change-Id: Ia8cb59b93e0a3e46bcfa265d2d16518b3900204a
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| b8ab8612a80604dddbd1f87bc0b7aa5143af0ca3 |
|
27-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Allow G+ profile photo to be saved as ME profile.
Bug: 25282799
Change-Id: Ie3872383311b401b2e8f3a983e27fcfe592c84f7
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 2bb85d2c733b8e88da27f6bd90546fa032d4da05 |
|
23-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Fix account selector UI in Contact editor.
1) Hide the "Saving to" account container when there're both
read-only and writable contacts.
2) Add more space between name field and whatever are above it.
3) Show linked contacts selector when there's only one read-only.
BUG 25219324
Change-Id: I9229132a833400de5cb542bc5363a4e3f36c9d1a
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 23709545a1060e48f60e90f592c44811910e88c8 |
|
22-Oct-2015 |
Walter Jang <wjang@google.com> |
Allow "Saving to" and linked selectors to be displayed at the same time
Also, only show contacts that can be opened in the full editor
in the linked accounts selector.
Bug 25186290
Change-Id: Iefecb47b40160b291acdc358fad4a6c17492df07
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| ac4b12f5e303647f7a6437e36be7026446d4e99f |
|
21-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Fix NullPointerException in Contact Editor.
Contacts App crashes when trying to edit a new read-only contact.
It only happenes sometimes.
Change-Id: Ib3a5d139e029d5b4ae296485ac3fa4f68f6b9881
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 82acd42c04554bd565c42e0a6674159d6887e1fe |
|
17-Oct-2015 |
Walter Jang <wjang@google.com> |
Choose the right contact to display in the single name field
* Also guard against there not being a primary raw contact delta
* Fix account info header when there are no accounts
Bug 25035441
Bug 23589603
Change-Id: I6ba6bd3b7377295f9522dbf0623962fb6e7af367
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| be5e1b109ce134c7f3f45cd4fc27b69454d7ad31 |
|
17-Oct-2015 |
Walter Jang <wjang@google.com> |
Show "local only" account name for me profile
Bug 24988734
Change-Id: Ief827757e148d240ec74b46c1dfbb11c1c68a18c
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 9488a766fd27dfe5324205a95e9465aacc470e58 |
|
16-Oct-2015 |
Walter Jang <wjang@google.com> |
Fix the account selector and linked accounts titles
Bug 24988734
Bug 23589603
Change-Id: I1032decbd7aee04efd0b61aaf39a14a54b69be6b
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| f695eb38011cf1140f73f533be726f420bc0a3fd |
|
16-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Editor should only show one name field.
BUG 24974860
Change-Id: Iaefd1fc42f440ca378aa4cc91b47e6688739107f
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 708774a560438e66f35cbb26b47fe32898b9ed15 |
|
16-Oct-2015 |
Walter Jang <wjang@google.com> |
Add missing import
Change-Id: I73fe94c9ea5c4969c9e2685215b9051379fd9de6
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| fc0a90d5be5723874cb41fa704d93ce384f005c8 |
|
16-Oct-2015 |
Walter Jang <wjang@google.com> |
Merge "Put back setting photo" into ub-contactsdialer-a-dev
|
| 4c9cf3ae7056b7189372973e2f04fb9e0f2c3242 |
|
16-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Put back setting photo
Bug: 24910349
Bug: 19697372
Bug: 23589603
Change-Id: I7789add9ae05928b0cd1e540da97dc6c0c9e7771
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 45b86d5e83a7d6eca4abe5cdfece2e9050b1809c |
|
16-Oct-2015 |
Walter Jang <wjang@google.com> |
Put back setting of photo from template
* Mistakenly remove it in ag/790426
* Also looks like we weren't setting from template it to true
after removing the photo.
* Finally, don't set super primary on the local profile
Bug 24981999
Bug 19697372
Bug 23589603
Change-Id: I3e759d5ea75e10c62108728874b771446ac61631
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| e5e7aefb0c258d69e1e4dac841f3815f55c75835 |
|
15-Oct-2015 |
Walter Jang <wjang@google.com> |
Don't show groups on the compact editor if there's more than 1
Bug 24980001
Bug 23589603
Change-Id: I4492c0036f826d591f59e5ab18b034afe21990ff
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 5585c6ef5e8f075bdc3d514887322c6fa683f4cb |
|
14-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Use the terms "Link and Unlink" instead of "Merge and separate".
BUG 24704875
Change-Id: I466907482434c0312f8ab922cdfa5e2e82ec4637
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| a0b6940902fd68241b27b32cffdd2ecf7446f919 |
|
13-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Raw contact drop down should keep order in Editor.
In compact editor UI, linked raw contacts drop down should keep order.
Also, the order in the comma style list should be the same as
in the drop down.
BUG 24898494
Change-Id: Ieed213388e52c5355c5e9ad33c1ee9db40696117
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 3f18d6197a54aad10bea9c5cc2c89ca82809e793 |
|
08-Oct-2015 |
Walter Jang <wjang@google.com> |
Fix some photo selection fragment bugs (E18)
* Hide the photo source dialog when there is only
1 photo in the aggregate
* Fix reverting to photo selection fragment on
rotate after taking or selecting a photo
* Unset super primary on other photo valuesdeltas
after taking a new photo (also fixes full
res image not loading on quick contacts after
the editor is closed?)
* Show full resolution photos on photo selector
even if they have not yet been saved to CP2
Bug 19697372
Bug 23589603
Change-Id: Idd6966ba981d251ae713950ea2f0d2d60c7b30c0
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 81365081af63f8a09cf10613ecd653b3b1ee7e5f |
|
08-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Fix bugs on Contact editor." into ub-contactsdialer-a-dev
|
| 91cee2852497e918e9e04a6fb549c1117ed47ae0 |
|
07-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Fix bugs on Contact editor.
1) Remove primary photo checkbox in full editor. Primary photo should
be set in photo picker.
2) Remove save menu if there's only one read only contact in the full editor.
3) Add account type icon in account info when there's only one account
for a contact.
4) Return back to Compact editor after saving results in full editor.
BUG 24547289
Change-Id: I02f8ee01f7cc7d1b0b06ad338570dc4b17c55e31
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 4f5594a0437e8592b6f828f8344d3f83cbd9aad6 |
|
07-Oct-2015 |
Walter Jang <wjang@google.com> |
Add a name to raw contacts created to edit read-only contacts (E17)
This is a revert of the parts of ag/771915 (E5) where we changed
to moved to always showing all of the names.
Bug 24509375
Bug 23589603
Change-Id: Ief4773592233dc05b40bae8fb425d1c258d0b68f
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| cbd431df6e9c7116850249461faf9f5a9b8b89c3 |
|
06-Oct-2015 |
Walter Jang <wjang@google.com> |
Move finding primary/writable raw contacts to KindSectionDataList (E16)
This will help us since editing the 1) name and 2) photo, and 3) finding
the primary account used to sort editors so that new fields get added
to the primary account all do something similar to find the
ValuesDelta that changes are written too.
We can also enforce that only the same DataKind/mime-type are added
to a KindSectionDataList and passed to a KindSectionView.
Bug 24509375
Bug 23589603
Change-Id: I2fc603c3cea2fb7f10a96c8592688ccf3deef56a
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 655ad1a2eeb36171d5f6e407bf7704f56f5583ca |
|
06-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Show all merged accounts in Contact editor.
Show all merged rawContacts' accounts in Contact editor, not
just primary account.
Expand all accounts to a list.
Clicking each account (rawContact) will go to the full editor
to editor the rawContact.
BUG 24547289
Change-Id: I671a946f87b25d9393daccb600287e35826fa6eb
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 31a74ad969b650eb733e536569254ed3978c4f54 |
|
03-Oct-2015 |
Walter Jang <wjang@google.com> |
Compact editor photo picker 1/2 (E15)
* Added photo selection fragment
* Swap between editor and photo selection fragments in CompactEditorActivity
* Moved PhotoHandler (which receives callbacks from PhotoSourceDialogFragment)
from the editor fragment to CompactEditorActivity since sourcing a photo
happens now from the editor photo view and the action bar when in the
photo selection fragment is visible.
* Extract code to get a bitmap or full size photo from a ValuesDelta in
CompactEditorPhotoView and move it to EditorUtiUtils so that it can be used
on both the photo selection fragment and the photo view
Bug 19697372
Bug 23589603
Change-Id: Iecebca44f505527d0be7a3803cd1d8fd4fef65e0
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| d675315606e8be431e6e5487e0b1cc33036a6ed7 |
|
02-Oct-2015 |
Walter Jang <wjang@google.com> |
Delay loading groups until compact editors are bound (E14)
Bug 24533689
Bug 23589603
Change-Id: I517b61d116f2d91237c493dc8a18f09aed9ad48a
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 2ae2175d1835a945e9e3ad16a88825999ec10afd |
|
25-Sep-2015 |
Walter Jang <wjang@google.com> |
Put company editor field below other names (E12)
Screenshots: https://go/b22828525
Bug 22828525
Bug 23589603
Change-Id: I0ff3a18810a6cc18ac6903119b8272092b8fa411
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 79658e14360a4ec75530a9dcae338f48c9d5f043 |
|
24-Sep-2015 |
Walter Jang <wjang@google.com> |
Remember editor expansion state on rotates (E10)
* Prompt user about discarding changes when back pressed
on editor (regressed in E5)
* Show a toast and close when no editors (i.e. input
fields) can be bound.
* Try to clarify the different behavior of
CompactSectionSectionView for names and groups.
Bug 23589603
Change-Id: If045ddb6d839574dc4109195b0d8841cd6083561
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| f10ca15ffa550b36805d2330fc210b58601a215c |
|
23-Sep-2015 |
Walter Jang <wjang@google.com> |
Add group membership support to compact editor (E9)
Bug 23589603
Change-Id: I71082af35a35dc7d0658ffb671a4436f794f5b0c
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 192a01c63c836a7a6ac3e75d8cc14e764f34a42b |
|
23-Sep-2015 |
Walter Jang <wjang@google.com> |
Phonetic names must be displayed next to structured names (E7)
Also keep phonetic name and nickname fields together with the
structured name editor field for the same account.
Bug 23589603
Change-Id: I3298d91dcd0451576374eed2401a768bec84b8e8
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 3e5ae0db65e842d49d047568fb5d6f331298da32 |
|
20-Sep-2015 |
Walter Jang <wjang@google.com> |
Show all aggreagate contact names on the editor
Stop copying the name from read only contacts
to the new raw contact created in order to enable
editing of read only contacts. We also don't need to
match the name displayed by quick contacts.
In the new design, we are showing multiple names with
read-only accounts marked with the account type icon
and name.
Bug 23589603
Change-Id: Ifd8d18b17fc9645c15814bbb1a649a82fe246bbd
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 28a27279554af7b1e5ff664d3da97954c462a797 |
|
20-Sep-2015 |
Walter Jang <wjang@google.com> |
Revert moving between the compact and full editors (E5)
We are reverting most of the changes made to fix
b/19624360 in MNC. The reason to do this is to reduce
the massive complexity moving between the two editors
introduced.
Since the compact editor now expands in place, the full
editor will likely only used to view read-only raw
contacts now.
Bug 23589603
Change-Id: Idfcc07d8aae65295d4b3f0a0e3e7f5eb701a46c4
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| f5dfea4a5c94382a632eae5c538881f7da726a50 |
|
16-Sep-2015 |
Walter Jang <wjang@google.com> |
Add a multi account KindSectionView (E4)
* This allows us to treat all kinds (i.e. mime types) the
same (except for name and photo).
* We can also set the icons and add empty editors naturally
(w/o checking if the kind section is the last on in the list)
* Finally, we can also expand to the full editor in place now
Bug 23589603
Change-Id: Ibdecd8a9ef33cd1db70ffd9fd17e7883555d1fa4
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 363d3fd790e44b06969abbc21b5cf5ccf0e81d3f |
|
16-Sep-2015 |
Walter Jang <wjang@google.com> |
Only iterate through raw contact delta list once (E3)
* Also, don't treat emails and phone numbers differently
since we'll be adding a new KindSectionView for them.
* Introduced a multi account aware KindSectionData holder
object to be used by the new KindSectionView
* Moved the utility method to get the icon for each kind
from the exisitng KindSectionView to EditorUiUtils
Bug 23589603
Change-Id: I6b4858b093ce1b4a65c97b95febc61f2197db091
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 03cea2e87a94d197eb63661fc82871aa33dd71ba |
|
19-Sep-2015 |
Walter Jang <wjang@google.com> |
Don't change the default account when saving contacts (E2)
Also address some comments on ag/766424 that were given
after that CL was submitted.
Bug 23667287
Bug 23589603
Change-Id: If2a5aee5c17358278fd3b59ed56b4c5344e5ecf6
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 708ea9e6f6f671178c0424f89e911000d4f330dc |
|
11-Sep-2015 |
Walter Jang <wjang@google.com> |
Add account selector to compact editor (E1)
But don't pass the account with dataset back and forth
between the compact and full editors since we will be
merging the two editors shortly.
Bug 23667287
Bug 23589603
Change-Id: I4cb6a79e6ee453cb171418b5ed317f43982dfac0
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| defc69ce69b25daa4e3f41b7c7c6cbd1aa3e83ce |
|
26-Aug-2015 |
Walter Jang <wjang@google.com> |
Show proper label for phone only accounts
I broke the account label for phone only contacts
when I extracted the logic to set the account label
on the full editor to a utility method so that it
could also be used on the compact editor in ag/712716
Bug 22859536
Change-Id: I3e64f7f6834a1da83078cc783e04b3c2faa0702f
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| ae9c9ec49c460d34f7c649c3a3bf684fc5ef262d |
|
08-Jul-2015 |
Walter Jang <wjang@google.com> |
Hide all empty email and phone KindSectionViews expect the last
Bug 22331611
Change-Id: I5c4544ed3cc82982f159f7c1758a1e6cd8868c48
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 995bb4af702a619bda3819daeeaa68c55d9e96bd |
|
06-Jul-2015 |
Walter Jang <wjang@google.com> |
Don't delete kind sections when there are >1 emails in the raw contact
* Also fix jank when deleting compact editor input fields
We were animating removal of input fields when there was more
than one field in the raw contact (i.e. Editor.deleteEditor)
but not when hiding entire KindViewSections
(i.e. KindSectionView.setVisibility(GONE)). When animating
KindSectionView removals, we must mark it for deletion
since we need to re-assess the number of KindSectionViews that
are visibile (in order to show icons) before the removal
animation finishes (the visibility is set to GONE at the end
of the animation).
* Prevent nicknames from being deleted
Bug 22228718
Bug 22299522
Change-Id: I28dad184c53e89f067d54675fcb3e7ebac9d971e
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 19d985fd21c6a9652c1b642bb0b4e6903a26d2e6 |
|
01-Jul-2015 |
Walter Jang <wjang@google.com> |
Group non-phone and email fields together on compact editor
Bug 22228718
Change-Id: I561ee25bad95a716744ba7d74fb6b49463b029da
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 4a9351db3c8385469bad037544d4b60d76504f5e |
|
30-Jun-2015 |
Walter Jang <wjang@google.com> |
Fix showing all phone nums and emails for joined contacts
We must delete the entire KindSectionView for emails and
phone numbers for all but the last raw contact that is being
edited.
Also, icons must be updated whenever an editor housed in
a kindview is deleted since we only want to show the icon
once for all the kindviews added to the compact layout
for all the raw contacts in the delta list.
Bug 22203548
Change-Id: If12c4fc10a9c9c09cbcfb86c5bf1472d89f6b890
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| c4cecc7e7534c7f5d887222d9e6f1a43364f7665 |
|
25-Jun-2015 |
Walter Jang <wjang@google.com> |
Show google account types on editor as "account" instead of "contact"
Also, missed the copy of the account type display lable setting
logic for read-only contacts in ag/712716 so replacing that with
the static utility method.
Bug 18719390
Bug 21637149
Change-Id: I112b32a25d4d3682ca8e58ef327660bd163cb273
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 2d3f31c210ffc617e82e3b41fc32b54ec2a5011a |
|
19-Jun-2015 |
Walter Jang <wjang@google.com> |
Show account info for inserts and read-only contact edits
Bug 21637149
Change-Id: I224ab188230f119f49f4ab7ddef4b51c451aa892
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| fa127a1c0ca95139664771edc3d5d97331c93b19 |
|
18-Jun-2015 |
Walter Jang <wjang@google.com> |
Allow users to edit photos for read-only contacts again
Similar to ag/711429 (for editing read-only names), we set the
photo bitmap from the read-only contact but set the newly created
(and writable) raw contact as the delta underlying the photo editor
view so that if the photo is updated by the user, the new raw
contact is set as changed and not the read-only raw contact.
Bug 21873945
Change-Id: Ibd40f3d708332fe6f87d247773b871d575d7d12e
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 06f73a15ed812d99ea28d836b02a5538bb1200c9 |
|
17-Jun-2015 |
Walter Jang <wjang@google.com> |
Ignore new raw contact display names when saving contacts
Now that we have logic to ignore the display name
we add to newly created raw contacts (when the
user wants to edit a read-only contact) when
determining whether the user made any edits,
we can enable changing the display on the compact
editor again.
Note, there is one glitch -- the name disappears
on the compact editor after you click more fields
(but only when editing read-only contacts).
Tested scenarios:
1) Edit read-only contact, more fields, back, back
No bogus contact is created and the read-only
name is displayed on both editors.
2) Edit read-only contact, change name on compact
editor, back, re-edit read-only contact, and split
The read-only contact is unchanged and a new
contact with the edited name is created.
3) Edit read-only contact, more fields, change name on
full editor, back, back, re-edit read-only contact,
and split
Same result as (2)
4) Edit read-only contact, add phone on compact
editor, back, re-edit read-only contact, and split
The read-only contact is unchanged and a new
contact with the read-only name and phone number is
created.
5) Edit read-only contact, more fields, add phone on full
editor, back, back, re-edit read-only contact, and split
Same result as (4)
Bug 21858251
Bug 21464081
Change-Id: I9028fee38b8ea7569968654a756eb98025318e69
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 0299c1d4ff397d57dbc87d1bd453077cafbb36b7 |
|
17-Jun-2015 |
Walter Jang <wjang@google.com> |
Merge "Don't allow read-only photos to be changed in compact editor" into mnc-dev
|
| ab50e6f5cf14e1bdb6cd3598372fefc2fa6b0b83 |
|
15-Jun-2015 |
Walter Jang <wjang@google.com> |
Don't allow read-only photos to be changed in compact editor
Also don't display compact editor photos for non-editable contacts
Bug 21873945
Change-Id: I7523e9cc7f8342e546659ede6a3dd822d790a259
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 65d3520d3cee5c3c4c4c213adf210d008c0a0409 |
|
16-Jun-2015 |
Walter Jang <wjang@google.com> |
Don't allow read-only names to be changed in compact editor
Bug 21858251
Change-Id: I3a66d30123ae1a64acbd162f7991a56cf37bcc72
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 398cd4b1fbfa7d2fabfc4addf6a156a841a5aa6a |
|
16-Jun-2015 |
Walter Jang <wjang@google.com> |
Pass the preferred name ID into the contact editor
Bug 21870691
Change-Id: I99cc6bf8d90f32469ca7cf105567dcc3edf48e9f
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| c59de249035f7149afa39d020cd2a1b2f972ef68 |
|
15-Jun-2015 |
Walter Jang <wjang@google.com> |
Don't set super primary name on compact editor unless it changes
Also fix the contact being loaded unnecessarily when transitioning
to the full editor.
Bug 21464081
Change-Id: Ic833f64a073898c8524892428512ce65f2f14625
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 88b0a8cc7c512c5f28dad958da276974c845355c |
|
08-Jun-2015 |
Walter Jang <wjang@google.com> |
Revert KindSectionView logic NOT show an empty input field
We don't need to make it optional to show an emtpy input
field since we've changed our minds on not allowing
users to add email and phone numbers on the compact editor.
Bug 21661221
Change-Id: Iec0d3a37a76c787d17922dbc184142dfca98a9de
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| ac679af994faece43536f1e8b2613f30c50300e1 |
|
01-Jun-2015 |
Walter Jang <wjang@google.com> |
Pass the preferred photo ID into the contact editor
Bug 21498424
Change-Id: I35e8fa3cff4d963f8017bdd596132fe749479a17
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 28c98b7511b4c00b47abcce83a713c9bccf1b74a |
|
02-Jun-2015 |
Walter Jang <wjang@google.com> |
Can add mulitple email and phones on compact editor again
Bug 21162602
Change-Id: If484b5f3a0de2d6176863c19519ed63a45aa7c1d
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| a26490b189312af2b73e56a1c9a7da974f7831c6 |
|
27-May-2015 |
Walter Jang <wjang@google.com> |
Attach aggregation listener to super primary name field
Bug 21435555
Change-Id: I03bb5ee5650491338192796cd8fc132af50a5ce8
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| bf63a6d6a888b3e1b5fb91accf2dadaab4384539 |
|
05-May-2015 |
Walter Jang <wjang@google.com> |
Fix contact name passing from compact to full editor on inserts
Bug 19624360
Change-Id: I50c415b59c4bad1d08f18f8c2bc7d57ddb73c418
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 41b3ea1c712f01164feb55455f1391564cb76dee |
|
10-Mar-2015 |
Walter Jang <wjang@google.com> |
Update compact editor photo to full res when possible
Bug 19655206
Change-Id: If30c7ba83851dcc7c98fa1be4bed92e302ba8245
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 3b21027019af908d9bbbc66785172541fae764e1 |
|
04-Mar-2015 |
Walter Jang <wjang@google.com> |
Update compact editor photo selection logic
* Look for non-empty super primary
* Look for any non-empty photo
* Use empty super primary (or the fallback ValuesDelta)
Bug 19124091
Change-Id: I2e397600802598d8ef820b0beb9cf85538c6b7a1
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 3a37a1a441dcc02ad93b8ccce15dda9f70caf5e8 |
|
04-Mar-2015 |
Walter Jang <wjang@google.com> |
Only show 1 phonetic name (per RawContactDelta) on compact editor
Also remove the delete button on the phonetic name
to be consitent with the fully expanded editor.
Bug 19124091
Change-Id: I851943a55d81723af7ec556f4dfef6de4f3d9b5d
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 151f3e6883e5785019f7b5083dc8baf3e305dc18 |
|
27-Feb-2015 |
Walter Jang <wjang@google.com> |
Try to show the "right" name on the compact contact editor
* If a super primary is set use it on the compact editor
* If a super primary is not set and the compact editor
name value is changed, set it as super primary. But
don't make an unchanged name super primary when expanding
to the full editor. Also unset super primary if
the name field becomes blank.
* On the full editor, set the last changed name to super
primary. Also unset super primary if
the name field becomes blank.
Bug 19124091
Change-Id: I1352f25f4decf31c5aeda20dbef133ce48d5d248
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 36d6a163bc31f76490d3bc0867a56437711bd1f7 |
|
20-Feb-2015 |
Walter Jang <wjang@google.com> |
Start the fully expanded editor when "More fields" is clicked
Note, StructuredName must be handled specially on inserts when it is
passed to the fully expanded editor when creating a new contact
because normally the contact name is not overriden.
Bug 19124091
Change-Id: I1d2b383c50b42a3624a7a8c18dd3278d7c3b069d
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| d35e5eff8737e757a4179d49dfe9c7db999b4e9d |
|
24-Feb-2015 |
Walter Jang <wjang@google.com> |
Get join suggestions for the compact editor name field
Also fix photo height in portrait -- made a mistake in
ag/641233.
Bug 19124091
Change-Id: I988cbcf457002bc6f0996c87a8611fca82bdf78a
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| a5e4bb287ea08f895c84d5de56fcc2483386b306 |
|
24-Feb-2015 |
Walter Jang <wjang@google.com> |
Use a split screen for the compact contact editor in landscape
Also renamed the compact header since we're not doing the
toolbar over the photo right now.
Bug 19124091
Change-Id: I91032e149252d635d564064a3652df4cc0233c6c
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 0e72ce9d97e0133a5f7cc348eef363bef9395979 |
|
23-Feb-2015 |
Walter Jang <wjang@google.com> |
Show edit contact photo options is a dialog
* Instead of a ListPopupWindow. This is more consistent with
the behavior of the other edit contact menu options.
* Also add an option menu icon to change the photo to
make this feature more easily accessible and since
users may not realize they can click the photo to
launch the choices dialog.
Bug 19124091
Change-Id: Ia4c37b3093f39d55784323f9a6d7bcf49ee96d16
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| f46abd89a3386cbdadff99e96df826bb27f987e9 |
|
21-Feb-2015 |
Walter Jang <wjang@google.com> |
Apply the quick contact color to default photos in the compact editor
Bug 19124091
Change-Id: I375fc8c88ab7b1bd452fbeab0e3e6444b83be094
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 1044645b9c2050436f4f0e0c7e5b8da2931879ba |
|
20-Feb-2015 |
Walter Jang <wjang@google.com> |
Hide extra empty kind editor on compact contact editor
* Also left align "More fields"
* Only show one structured name
* Be a bit smarter about the profile photo before
we have a real split screen
Bug 19124091
Change-Id: I046ea59437b035d43df045363677a3aaba0dca43
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| 3efae4aeae8715fbfcf67c56f123da49330ea01a |
|
18-Feb-2015 |
Walter Jang <wjang@google.com> |
First pass on photo support for compact contact editor
Only updates the primary photo for now.
Bug 19124091
Change-Id: I1886888b4cf249da4c483d570b9db6e05564518a
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| b6ca272f26b47ecef8fafe94326c4d553576c521 |
|
20-Feb-2015 |
Walter Jang <wjang@google.com> |
Add placeholder button for showing fully expanded contact editor
Bug 19124091
Change-Id: I8051b8df460fd0bbc30466d736c7606caaa0837c
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| e720fdeb3ef0892834d7ab9af8cc44dd9eb9be17 |
|
17-Feb-2015 |
Walter Jang <wjang@google.com> |
Always show email and phone fields
* This fixes showing an almost blank screen when
writing the "me" profile also when adding a new contact.
* Also fixed a bug when writing the "me" profile --
we weren't calling the RawContact.setAccountToLocal
in createNewRawContactDelta in the base editor fragment.
Bug 19124091
Change-Id: I93422047796189b4df060bfa39aa3c84ce47fa25
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| b1c8762a9a398617d54c5c669359e283689e24a0 |
|
14-Feb-2015 |
Walter Jang <wjang@google.com> |
Fix up names on the compact contact editor
* Don't show a blank structured name if there is a non-empty
value and don't ever show more than one blank structured
name either
* Group phonetic and nicknames together instead of interleaving
with structured names and each other
* Use a KindSectionView for nicknames (for now) so that it
isn't intended so differently from everything else.
Bug 19124091
Change-Id: I50f41c0a0efb39de98a5b96c7da47b6ad6243633
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|
| cab3dcec1401a32aff583d946b4a9f8af954358f |
|
10-Feb-2015 |
Walter Jang <wjang@google.com> |
First pass on showing only non-empty field on compact edit view
Bug 19124091
Change-Id: I49660c326f5829540463295218530f0a2d0fad9d
/packages/apps/Contacts/src/com/android/contacts/editor/CompactRawContactsEditorView.java
|