| 62a2074bb3b8dc66996e9fc6a8748b999ab2b51c |
|
25-Feb-2016 |
Walter Jang <wjang@google.com> |
Log where quick contact was opened from (1/3)
Bug 27341012
Bug 18388581
Change-Id: I0628e9ad842ab64fc1bf6196500a64fddf465466
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| f8c8ac348cf217766a6626a5b7191a0de11f06d3 |
|
20-Feb-2016 |
Walter Jang <wjang@google.com> |
Revert "Don't pass read-only portions of RawContactDeltaList to contact save service"
This reverts commit e5bac73a8b241a43143e5780c07597cd6fa9230f.
Revert "Don't prune read only contacts in SaveService for joins and splits"
This reverts commit I717717a3c8b55315dcf3dde026af4c267f62e709.
Bug 27108237
Bug 27250533
Bug 23896510
Change-Id: If52f514c01f0d346fddc4083c710b7147761dd7d
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| e5bac73a8b241a43143e5780c07597cd6fa9230f |
|
03-Feb-2016 |
Wenyi Wang <wenyiw@google.com> |
Don't pass read-only portions of RawContactDeltaList to contact save service
Bug 23896510
Change-Id: Ie50aa5c0581779c12861072ec838f26d444fb549
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| c41a1e5f5f4872c3a0da5dec7671b66d9d80eb4e |
|
29-Jan-2016 |
Wenyi Wang <wenyiw@google.com> |
Revert "Show check mark when none is primary in photo picker"
This reverts commit bb601f2d4a7ed4db46dd87a4d451d42c666f1591.
Change-Id: Ia7a677e7f5d5a28fc45a1e3b85da52d9b1382485
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| bb601f2d4a7ed4db46dd87a4d451d42c666f1591 |
|
14-Nov-2015 |
Wenyi Wang <wenyiw@google.com> |
Show check mark when none is primary in photo picker
If there is a photo in photo picker that is marked as primary,
we will use check that photo in photo picker.
Otherwise, with this CL, we compare the photo URI passed from
QuickContact to editor with the photo URIs in photo picker to
decide where to add a check mark.
Bug: 25092609
Change-Id: I0ae77f9874a60f45dcfb305d058ade9de4fef4a4
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| dd7d456a080f48d93aa3a9f9b04da0f17a8833a7 |
|
08-Dec-2015 |
Wenyi Wang <wenyiw@google.com> |
Catch exception in starting ContactSaveService
This CL follows ag/798285 and adds try/catch blocks for all the places
that start ContactSaveService using static methods in ContactSaveService.
Bug: 23896510
Change-Id: Ie35cf0d213386a81a662777a5b37d6f3a3fc5633
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| da258ff16a03b150e4c8004aa2be6f20c196a1ec |
|
17-Nov-2015 |
Walter Jang <wjang@google.com> |
Use selected photo ID as the "photo to display" lookup parameter
Don't use the photo ID passed in on the Intent to open the
editor since that will never change.
Bug 25729444
Change-Id: I84082245ac491c9481cc469d0b7342755250ec66
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 0d9c24b77d319db5ecf21e92898625fdec5c1ec2 |
|
29-Oct-2015 |
Walter Jang <wjang@google.com> |
Warn about saving pending changes before unlinking
Also, remove unchanged new raw contacts that were
created to edit read-only contacts before unlinking.
Bug 25314004
Change-Id: Id75083456cd24fc1b06e489380614172bd370ad4
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| e3373dceb689209533e95a2cfbfbf1d9008ab6f6 |
|
27-Oct-2015 |
Walter Jang <wjang@google.com> |
Don't save editor before showing join suggestions
This requires us to pass the raw contact ID of the
contact to join to both the (new) confirmation
dialog and the contact save service so that we
have it to do the join after the save completes.
Bug 25314004
Bug 21956248
Change-Id: Icdcb2165a0e599dfa3745fe8a919b208d4a48b43
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| e394595987e288807b8c02c78d7d33e854f152b1 |
|
27-Oct-2015 |
Walter Jang <wjang@google.com> |
Set read only display name as primary in fragment not view (DN 2/2)
Also, don't remove the display name from the editor input
field when checking for pending changes, instead just
skip the name mime type after detmining that the read only
display name was used and that it didn't change.
Bug 21956248
Bug 25314004
Change-Id: I9da8430206a721a52b8dad19e5eb235cb9e57fb3
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 1594c6f3603e071c75294c9c430cee45ef642479 |
|
27-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Hide account container in compact editor.
Show account container when editing ME profile.
Hide account container when linking a writable contact with
a readonly one in editor. Also, showing unlink menu in this case.
BUG 25231329
Change-Id: Ia8cb59b93e0a3e46bcfa265d2d16518b3900204a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 7ab14cbdb81cbb62c31db4102d1107d61a3823f3 |
|
26-Oct-2015 |
Walter Jang <wjang@google.com> |
Merge "Don't skip pending check when save to account changed" into ub-contactsdialer-a-dev
|
| 13aede84cf83a9fb4bfb2f28eb77429b3b43169d |
|
26-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Use string "Contacts unlinked" when unlinking
Also removed the period in "Contact saved."
Bug: 25231225
Change-Id: I95908809b144911ced124ea52abe5d6cdece3774
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 2c7fdac948e7b815ff5ef3a6989b8f1f4eeba323 |
|
26-Oct-2015 |
Walter Jang <wjang@google.com> |
Don't skip pending check when save to account changed
Bug 25231216
Change-Id: I342a25ce52735052c2b4d5a6620581067c68762a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 23709545a1060e48f60e90f592c44811910e88c8 |
|
22-Oct-2015 |
Walter Jang <wjang@google.com> |
Allow "Saving to" and linked selectors to be displayed at the same time
Also, only show contacts that can be opened in the full editor
in the linked accounts selector.
Bug 25186290
Change-Id: Iefecb47b40160b291acdc358fad4a6c17492df07
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 552a6b87a572bca7983484869035107705d8b228 |
|
22-Oct-2015 |
Walter Jang <wjang@google.com> |
Remove discard editor menu option
Also hide voicemail menu options for the me profile
Bug 25165475
Bug 25164540
Change-Id: I0c0dc318ac9bbe8a36656c2383091d7c9d4ce5cf
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 838d2bab64b4bd29f8e956100c01909d08cc6279 |
|
14-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Merge "Avoid saving contact when user doesn't intend to do so." into ub-contactsdialer-a-dev
|
| 7394c4375bb7e0b279d813e7a73ffcb10e5825c2 |
|
14-Oct-2015 |
Wenyi Wang <wenyiw@google.com> |
Avoid saving contact when user doesn't intend to do so.
We will not save contact when user:
1. picks a photo;
2. presses "Recent" button;
3. presses "Home" button;
Bug: 24898586
Change-Id: I40339de573ac069abffada1a6329009c3b97076c
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| c683d2273c4174c0e300ef2f4b17c77fb313da39 |
|
14-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Fix bug when showing overflow menu in Compact editor.
Set default value for rawContact id to display alone.
BUG 24899070
Change-Id: Ibdb25080e62f669f9c466bf55e67dbbe63ff6afb
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| ba6c41ca6da97f56f608a9ef92617f2401f8371e |
|
13-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Improve raw contact editor in Contact Editor.
1) When clicking save on raw contact editor, UI should return to
the quick contact UI.
2) Remove overflow menu on raw contact editor.
BUG 24899070
Change-Id: Iae6954744294fc48fe8dba02459f647f1764c48b
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 81365081af63f8a09cf10613ecd653b3b1ee7e5f |
|
08-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Merge "Fix bugs on Contact editor." into ub-contactsdialer-a-dev
|
| 91cee2852497e918e9e04a6fb549c1117ed47ae0 |
|
07-Oct-2015 |
Tingting Wang <tingtingw@google.com> |
Fix bugs on Contact editor.
1) Remove primary photo checkbox in full editor. Primary photo should
be set in photo picker.
2) Remove save menu if there's only one read only contact in the full editor.
3) Add account type icon in account info when there's only one account
for a contact.
4) Return back to Compact editor after saving results in full editor.
BUG 24547289
Change-Id: I02f8ee01f7cc7d1b0b06ad338570dc4b17c55e31
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 4f5594a0437e8592b6f828f8344d3f83cbd9aad6 |
|
07-Oct-2015 |
Walter Jang <wjang@google.com> |
Add a name to raw contacts created to edit read-only contacts (E17)
This is a revert of the parts of ag/771915 (E5) where we changed
to moved to always showing all of the names.
Bug 24509375
Bug 23589603
Change-Id: Ief4773592233dc05b40bae8fb425d1c258d0b68f
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 31a74ad969b650eb733e536569254ed3978c4f54 |
|
03-Oct-2015 |
Walter Jang <wjang@google.com> |
Compact editor photo picker 1/2 (E15)
* Added photo selection fragment
* Swap between editor and photo selection fragments in CompactEditorActivity
* Moved PhotoHandler (which receives callbacks from PhotoSourceDialogFragment)
from the editor fragment to CompactEditorActivity since sourcing a photo
happens now from the editor photo view and the action bar when in the
photo selection fragment is visible.
* Extract code to get a bitmap or full size photo from a ValuesDelta in
CompactEditorPhotoView and move it to EditorUtiUtils so that it can be used
on both the photo selection fragment and the photo view
Bug 19697372
Bug 23589603
Change-Id: Iecebca44f505527d0be7a3803cd1d8fd4fef65e0
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| d675315606e8be431e6e5487e0b1cc33036a6ed7 |
|
02-Oct-2015 |
Walter Jang <wjang@google.com> |
Delay loading groups until compact editors are bound (E14)
Bug 24533689
Bug 23589603
Change-Id: I517b61d116f2d91237c493dc8a18f09aed9ad48a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 3daa9a34380f0368292f366c397c26f7e90db0df |
|
25-Sep-2015 |
Wenyi Wang <wenyiw@google.com> |
Change ringtone behavior based on version.
Bug: 12800232
Change-Id: I9e05d737a847392c277d50a353e4d65ecd70f9a2
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 3e5ae0db65e842d49d047568fb5d6f331298da32 |
|
20-Sep-2015 |
Walter Jang <wjang@google.com> |
Show all aggreagate contact names on the editor
Stop copying the name from read only contacts
to the new raw contact created in order to enable
editing of read only contacts. We also don't need to
match the name displayed by quick contacts.
In the new design, we are showing multiple names with
read-only accounts marked with the account type icon
and name.
Bug 23589603
Change-Id: Ifd8d18b17fc9645c15814bbb1a649a82fe246bbd
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 28a27279554af7b1e5ff664d3da97954c462a797 |
|
20-Sep-2015 |
Walter Jang <wjang@google.com> |
Revert moving between the compact and full editors (E5)
We are reverting most of the changes made to fix
b/19624360 in MNC. The reason to do this is to reduce
the massive complexity moving between the two editors
introduced.
Since the compact editor now expands in place, the full
editor will likely only used to view read-only raw
contacts now.
Bug 23589603
Change-Id: Idfcc07d8aae65295d4b3f0a0e3e7f5eb701a46c4
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 03cea2e87a94d197eb63661fc82871aa33dd71ba |
|
19-Sep-2015 |
Walter Jang <wjang@google.com> |
Don't change the default account when saving contacts (E2)
Also address some comments on ag/766424 that were given
after that CL was submitted.
Bug 23667287
Bug 23589603
Change-Id: If2a5aee5c17358278fd3b59ed56b4c5344e5ecf6
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 708ea9e6f6f671178c0424f89e911000d4f330dc |
|
11-Sep-2015 |
Walter Jang <wjang@google.com> |
Add account selector to compact editor (E1)
But don't pass the account with dataset back and forth
between the compact and full editors since we will be
merging the two editors shortly.
Bug 23667287
Bug 23589603
Change-Id: I4cb6a79e6ee453cb171418b5ed317f43982dfac0
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 97a04fec29361033d49729b9ca436ff119692b93 |
|
18-Sep-2015 |
Jay Shrauner <shrauner@google.com> |
Merge "Fix IllegalStateException in onOptionsItemSelected" into ub-contactsdialer-a-dev
|
| ceb81f60667091ca9a637304b1a3874e24e5355b |
|
17-Sep-2015 |
Wenyi Wang <wenyiw@google.com> |
Merge "Modified doPickRingtone() and onRingtonePicked() to handle silent ringtone" into ub-contactsdialer-a-dev
|
| c284bbb83c890b4c22c8028bab6540b140affaf9 |
|
17-Sep-2015 |
Jay Shrauner <shrauner@google.com> |
Fix IllegalStateException in onOptionsItemSelected
Check the fragment is still attached to a running activity.
Bug:24140802
Change-Id: I4dc283105c019589b47961baf49ad44cd60733c1
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 5ed0e93814e4275362a009df1f12586bfc637cdd |
|
16-Sep-2015 |
Wenyi Wang <wenyiw@google.com> |
Modified doPickRingtone() and onRingtonePicked() to handle silent ringtone
Bug: 12800232
Change-Id: Ic26b94b5c1b2597b20e822eaa5321f89af2a97b2
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 8753906a4eb4223bfbdec77a5baac25b79b88434 |
|
09-Sep-2015 |
Walter Jang <wjang@google.com> |
Merge "Don't show aggregation suggestion for new me contacts" into ub-contactsdialer-a-dev
|
| 82ed2b5380e134705f96e7e1f1586a25f8ac403f |
|
09-Sep-2015 |
Walter Jang <wjang@google.com> |
Don't allow the me profile to be deleted
Bug 23353783
Change-Id: Ie4784ed0725497200129915d1cbb6bbb047fb278
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 953cea238c9969fd7703fbce2bf8a915b5c38955 |
|
09-Sep-2015 |
Walter Jang <wjang@google.com> |
Don't show aggregation suggestion for new me contacts
Bug 23353464
Change-Id: Ifb63c73b59153ff7bdc26b3f4f471d3521bed0b2
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 03debc685e254b85df07fc9d213f17967a5fca9a |
|
20-Jul-2015 |
Walter Jang <wjang@google.com> |
Pass MaterialPalete colors to contact editor as ints not Parcelable
The MaterialPalette class is not public and crashes the edit contact
app selector if any third party app also has a filter for
android.intent.action.EDIT in their manifest.
Bug 22564102
Change-Id: I0926108bf83431e4c80412571062f7bc561c3de5
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 2241783345a24acd27c52d938943b2ca76dc7329 |
|
09-Jul-2015 |
Walter Jang <wjang@google.com> |
Allow split of aggregate contact composed of >1 read-only contacts
Bug 22382957
Change-Id: I33f22a5ba9c55fe722601b54cecc59a173d6940b
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 2d3f31c210ffc617e82e3b41fc32b54ec2a5011a |
|
19-Jun-2015 |
Walter Jang <wjang@google.com> |
Show account info for inserts and read-only contact edits
Bug 21637149
Change-Id: I224ab188230f119f49f4ab7ddef4b51c451aa892
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| c90cc15b804fb00339a3b98e5c951549f9b03599 |
|
19-Jun-2015 |
Walter Jang <wjang@google.com> |
Make saving a contact less confusing
* Add always visible save menu item (a checkmark icon) on both
the compact and full editors. Selecting it saves changes
and closes the editor (what back does currently).
* On the compact editor, make back perform a discard,
including warning the user if there are unsaved changes.
* On the full editor, back still saves and goes back to
the full editor. This is not ideal but it's out of
scope to not save changes between the two editors
when editing an existing contact.
Bug 19983789
Change-Id: Ie23b75978db70f2b438a824e39f0ae8fb8aa99ec
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 06f73a15ed812d99ea28d836b02a5538bb1200c9 |
|
17-Jun-2015 |
Walter Jang <wjang@google.com> |
Ignore new raw contact display names when saving contacts
Now that we have logic to ignore the display name
we add to newly created raw contacts (when the
user wants to edit a read-only contact) when
determining whether the user made any edits,
we can enable changing the display on the compact
editor again.
Note, there is one glitch -- the name disappears
on the compact editor after you click more fields
(but only when editing read-only contacts).
Tested scenarios:
1) Edit read-only contact, more fields, back, back
No bogus contact is created and the read-only
name is displayed on both editors.
2) Edit read-only contact, change name on compact
editor, back, re-edit read-only contact, and split
The read-only contact is unchanged and a new
contact with the edited name is created.
3) Edit read-only contact, more fields, change name on
full editor, back, back, re-edit read-only contact,
and split
Same result as (2)
4) Edit read-only contact, add phone on compact
editor, back, re-edit read-only contact, and split
The read-only contact is unchanged and a new
contact with the read-only name and phone number is
created.
5) Edit read-only contact, more fields, add phone on full
editor, back, back, re-edit read-only contact, and split
Same result as (4)
Bug 21858251
Bug 21464081
Change-Id: I9028fee38b8ea7569968654a756eb98025318e69
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 398cd4b1fbfa7d2fabfc4addf6a156a841a5aa6a |
|
16-Jun-2015 |
Walter Jang <wjang@google.com> |
Pass the preferred name ID into the contact editor
Bug 21870691
Change-Id: I99cc6bf8d90f32469ca7cf105567dcc3edf48e9f
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| c59de249035f7149afa39d020cd2a1b2f972ef68 |
|
15-Jun-2015 |
Walter Jang <wjang@google.com> |
Don't set super primary name on compact editor unless it changes
Also fix the contact being loaded unnecessarily when transitioning
to the full editor.
Bug 21464081
Change-Id: Ic833f64a073898c8524892428512ce65f2f14625
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 4e1a8de3527343115669cf588b5ebf793350c257 |
|
12-Jun-2015 |
Walter Jang <wjang@google.com> |
Fix bug causing a read-only default account to be set
Bug 21464081
Change-Id: I97653796b7abbab8df61060c03b0ff0222c1442c
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 6dd0d4e8e49ccff2ed57453c0ddd0735d6ec7a40 |
|
09-Jun-2015 |
Walter Jang <wjang@google.com> |
Don't initially focus any contact editor input field
Bug 21644158
Change-Id: I84d1406b4db1646dcbf059ce84a2cc7534b0bd83
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| ac679af994faece43536f1e8b2613f30c50300e1 |
|
01-Jun-2015 |
Walter Jang <wjang@google.com> |
Pass the preferred photo ID into the contact editor
Bug 21498424
Change-Id: I35e8fa3cff4d963f8017bdd596132fe749479a17
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| a35ef54b651d17536169bb0ba0423ca5ef2839b4 |
|
02-Jun-2015 |
Walter Jang <wjang@google.com> |
Don't allow newly writable contact splits
It will result in an empty contact
Bug 21464081
Change-Id: I36e79b82ff7d8d3002eabfe735bccda75ee110a7
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 3e76408e47ca135c092b5eee73ae49d8697b0a10 |
|
22-May-2015 |
Walter Jang <wjang@google.com> |
Distinguish between editor back button presses and framework stopage
We carry whether the editor fragment is being stopped
because of a back button press or because the framework
stopped the hosting Activity all the way through the various
editor fragment callbacks and the ContactSaveService because
it is not until ContactEditorBaseActivity.onSaveFinished
where we start the next Intent -- starting it causes a
"flash" if recents is clicked and follwed by an immediate
starting of the next editor Activity, which is the bug
that was filed.
With this change, we only use the ContactSaveService
resultIntent to go back to the compact editor on back
presses. The expected behavior/tested scenarios are
described at go/b21198041
Bug 21198041
Bug 19624360
Change-Id: Ic350e12aa447cff81747e003f504f25100bd5c60
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| bf63a6d6a888b3e1b5fb91accf2dadaab4384539 |
|
05-May-2015 |
Walter Jang <wjang@google.com> |
Fix contact name passing from compact to full editor on inserts
Bug 19624360
Change-Id: I50c415b59c4bad1d08f18f8c2bc7d57ddb73c418
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| a69f58fcf5c143ac7dd6421a30004d56813e321a |
|
02-Apr-2015 |
Walter Jang <wjang@google.com> |
Don't add compact editor fragment if it's already there
Bug 20040887
Change-Id: Ib968203e0340cd442e5652376a9e2aa7347994b1
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 18f2e2ff824f1af19c7f7f6de7b5fa2eb2fb562e |
|
19-Mar-2015 |
Walter Jang <wjang@google.com> |
Don't parse extras twice when inserting contacts
This is causing phone number (and other insert data
besides name) to be rendered twice when inserting a new
contact.
Bug 19849999
Change-Id: I8d211658a2b568eba2379795ecfbaf93639bbd3f
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 261e106d87056d0c9727dd9ae436d5aadadd0762 |
|
13-Mar-2015 |
Walter Jang <wjang@google.com> |
Compact contact editor UI tweaks
* Move delete ActionBar icon option back into the overflow
* Move the "More fields" option back to left alignment and
give it accent color
* Make unfocused fields 25% black
* Layout/padding tweaks
- Remove the 0 bottom padding on names so that all fields
have the same spacing between each other
- Use the min edit height on the "More fields" row
so that the spacing is the same as the other fields.
Bug 19729447
Change-Id: Ia11c74c1b65f96f937d6e51ed143f5f088b41561
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 055c66d459732973f7341331b143d7ab9974c4ed |
|
12-Mar-2015 |
Walter Jang <wjang@google.com> |
Fixed some contact editor compiler warnings
Change-Id: I31deaeeedc4ae49da6b0326b128767785cd01852
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| ee4d4ae4012ef3e18e18c8e66b34797e8523f860 |
|
12-Mar-2015 |
Walter Jang <wjang@google.com> |
No toast when navigating back to the compact editor for existing contacts
Bug 19624360
Change-Id: Ic1b344583a453e482acb2c2911ae05eee077fb43
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 1e8801bc9bc60bdd1c95f582c460590272cfad64 |
|
10-Mar-2015 |
Walter Jang <wjang@google.com> |
Pass full res contact photos between the compact and full editors
Bug 19624360
Bug 19655206
Change-Id: I590ec7ecec75a9af95b824f5db9cda8f8aeda675
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 921287ef72ca601027bf2971b0733493adde16d2 |
|
10-Mar-2015 |
Walter Jang <wjang@google.com> |
Fixes for returning to the compact editor from the expanded one
* Don't abort the save even if there are no unsaved changed
when returning the compact from the full editor
* No need to pass the material palette on insert intents.
It does, however, need to be passed back to the compact
editor when editing an existing contact w/o a picture.
* Fix returning to the compact editor repeatedly by
removing the Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET
on compact editor intents.
* Updated StructuredNameEditorView#getDisplayName to fall
back to the display name directly from the ValuesDelta.
This is required when the name is passed to the
contact editor, and the user does not change it, in which
case it will not be written to the underlying data
structure, and thus not passed subsequent expantions.
Bug 19624360
Change-Id: Ife285f3e411a869a76fbbff4d42939c866db617c
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 5a7a23bdb698b8e741a425c9617c5e33e6314cdd |
|
06-Mar-2015 |
Walter Jang <wjang@google.com> |
Return to the compact contact editor on back from the fully expanded one
Bug 19624360
Change-Id: I249f1e456a2d85c5ecd831358692d56b09ee5a5b
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| b810373530d919d89c75c86709b2bf0a3d8823aa |
|
06-Mar-2015 |
Walter Jang <wjang@google.com> |
Contact editor "discard changes" should do a discard
Not a split contact!
Change-Id: I4e4edbedc73c99ef4ee1e15e8984b7cfa8f8ba37
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| e95ce440a7dd7277fbc4eb78c3d74b85fd55af2f |
|
04-Mar-2015 |
Brian Attwell <brianattwell@google.com> |
Merge "Batch join contacts"
|
| d3946cae17273ed1c2fceb507990882e3f828ba9 |
|
03-Mar-2015 |
Brian Attwell <brianattwell@google.com> |
Batch join contacts
* Add new action to ContactSaveService to support joining more than
two contacts toghether.
* Add new dialog fragment for the join
Bug: 19549465
Change-Id: Ib0b1d5e7652e429f8e78d81dd3d98d03b3129e1e
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| f638b6f61faf9317a911a042057a33e3d9d67bef |
|
03-Mar-2015 |
Walter Jang <wjang@google.com> |
Supress "saved" Toasts when expanding the compact editor
Bug 19124091
Change-Id: I38a329be3f997ae93ec90810d24473f5ef800488
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 36d6a163bc31f76490d3bc0867a56437711bd1f7 |
|
20-Feb-2015 |
Walter Jang <wjang@google.com> |
Start the fully expanded editor when "More fields" is clicked
Note, StructuredName must be handled specially on inserts when it is
passed to the fully expanded editor when creating a new contact
because normally the contact name is not overriden.
Bug 19124091
Change-Id: I1d2b383c50b42a3624a7a8c18dd3278d7c3b069d
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| d35e5eff8737e757a4179d49dfe9c7db999b4e9d |
|
24-Feb-2015 |
Walter Jang <wjang@google.com> |
Get join suggestions for the compact editor name field
Also fix photo height in portrait -- made a mistake in
ag/641233.
Bug 19124091
Change-Id: I988cbcf457002bc6f0996c87a8611fca82bdf78a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 0e72ce9d97e0133a5f7cc348eef363bef9395979 |
|
23-Feb-2015 |
Walter Jang <wjang@google.com> |
Show edit contact photo options is a dialog
* Instead of a ListPopupWindow. This is more consistent with
the behavior of the other edit contact menu options.
* Also add an option menu icon to change the photo to
make this feature more easily accessible and since
users may not realize they can click the photo to
launch the choices dialog.
Bug 19124091
Change-Id: Ia4c37b3093f39d55784323f9a6d7bcf49ee96d16
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| d94574a91d3f725c96530c0d1e71d8188a9cbcf6 |
|
21-Feb-2015 |
Walter Jang <wjang@google.com> |
Merge "First pass on photo support for compact contact editor"
|
| 3efae4aeae8715fbfcf67c56f123da49330ea01a |
|
18-Feb-2015 |
Walter Jang <wjang@google.com> |
First pass on photo support for compact contact editor
Only updates the primary photo for now.
Bug 19124091
Change-Id: I1886888b4cf249da4c483d570b9db6e05564518a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| c6100ffd22ae176a3e84a1062d8cb92d955faef2 |
|
20-Feb-2015 |
Brian Attwell <brianattwell@google.com> |
Avoid senseless disambiguation #2/2
This makes having two contacts apps on the same
device tolerable.
Bug: 18777272
Change-Id: Ib75eadfb94eee2c5c8305747eddd01ba9a8b1dc4
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| e720fdeb3ef0892834d7ab9af8cc44dd9eb9be17 |
|
17-Feb-2015 |
Walter Jang <wjang@google.com> |
Always show email and phone fields
* This fixes showing an almost blank screen when
writing the "me" profile also when adding a new contact.
* Also fixed a bug when writing the "me" profile --
we weren't calling the RawContact.setAccountToLocal
in createNewRawContactDelta in the base editor fragment.
Bug 19124091
Change-Id: I93422047796189b4df060bfa39aa3c84ce47fa25
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 49ed2033f83005f92c30068ae33c3138d75e1825 |
|
12-Feb-2015 |
Walter Jang <wjang@google.com> |
Wire up saving edits using the compact contact editor
Also fix refreshing the edit activity data after joining
Bug 19124091
Change-Id: I161e38d9eaea89e3d090986d2b52cb6f8ee85422
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 2d6ccf7bd5205a2c200def3501df5ddb3ca6c1c9 |
|
12-Feb-2015 |
Walter Jang <wjang@google.com> |
Add back discard changes dialog listener
Bug 19343391
Change-Id: I043947150800ff8f4fb7d219b39fd9f687ec2689
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 92f8ccc1f15df787b7434224857c056721281046 |
|
06-Feb-2015 |
Walter Jang <wjang@google.com> |
Do setIntentExtras, on[Save|Join]Completed in base contact edit fragment
Do setGroupMetaData in the child classes since the layout will be
drastically different between the two.
Also moved a public Intent extra constant to the base.
Bug 19124091
Change-Id: Idd20ff39b91eb3584c69e406f1e3472bcb278f42
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 3e9a62449b8ca3a38b1d51019c6ea13972263bc2 |
|
05-Feb-2015 |
Walter Jang <wjang@google.com> |
Move suggest joins popup & activiy to BaseEditContactFragment
Bug 19124091
Change-Id: Ic5a6b8b6359dc9691cfcac2348ba895c542d05d9
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 1eb21f12372b31794ef5a567013c1d2d98081120 |
|
04-Feb-2015 |
Walter Jang <wjang@google.com> |
Move join suggestion view to base contact edit fragment
So that we can keep setEnabled logic entirely within
the base fragment.
The rest of the join suggestion functionality will be
ported to the base so it can be shared with the compact
editor in a seperate CL.
Bug 19124091
Change-Id: I4d494c9b0c2db8a6dba6d9d752d049f48848f731
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| b55107303cc46906c265582a8931172f13d684b6 |
|
03-Feb-2015 |
Walter Jang <wjang@google.com> |
Handle reading loaded Contact data in the base edit fragment
This reduces the number of abstract methods sub classes
must implement and also keeps us from having to duplicate
the logic to set up the new/local/me/existing RawContactData
List (mState) in all sub edit fragments.
The crux of this CL is moving the "bindEditor" methods
into the base fragment.
Also renamed the various bindEditors methods which are
mostly reading fields the loaded Contact and settting up
mState to be "setState" since we it seemed more appropriate
to reserve the name bindEditors for setting up the actual
Views.
Bug 19124091
Change-Id: Ieb4a906ac372faa20694e546caa3bcba8c6b53b4
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 505fd3ba4bfaeaa23b951736b210911e970ae775 |
|
03-Feb-2015 |
Brian Attwell <brianattwell@google.com> |
Merge "Don't use hidden QuickContact APIs"
|
| eda5c85e54ca3de71a9155df5f45fbf6911cb4a6 |
|
03-Feb-2015 |
Brian Attwell <brianattwell@google.com> |
Don't use hidden QuickContact APIs
Bug: 18777272
Change-Id: Ia3a1fe77223dfd67ff5c9d9c011253dbb7695b6a
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| ed8f6c9744dd38e089598acfba6fb90446954e6e |
|
31-Jan-2015 |
Walter Jang <wjang@google.com> |
Add edit contact menu options to compact editor
* Also moved #setListener and #load from the sub contact editor
fragments to the base fragment
* Moved location of #setData in the base contact editor fragment
Bug 19124091
Change-Id: Icbe3d46e1bf60f3e79437db7bc6c05a7a95f824b
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| ba59deb669cf377bedf08af53c9196db3c1cc404 |
|
26-Jan-2015 |
Walter Jang <wjang@google.com> |
Move data loading and account creation to edit contact base class
While moving things from ContactEditorFragment to ContactEditorBaseFragment:
* The data loader callbacks, #onActivityCreated, #setData, and account
creation methods were not changed in any way
* For the restoration of contact editor state, one small change was made.
A new key, KEY_AUTO_ADD_TO_DEFAULT_GROUP, was added because the other
options passed in via intentExtras argument to #load are saved
so this looks like an oversight in the existing version.
Bug 19124091
Change-Id: I7973f9c5703082f6d8db53c9db22d08a230c5876
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 3f990ba4e35a99078d831c041290e574a320caa5 |
|
27-Jan-2015 |
Walter Jang <wjang@google.com> |
Move some contact editor functionality into new base classes
To make room for a new "compact" contact editor.
The Status and SaveMode interfaces in ContactEditorFragment were
moved to ContactEditorBaseActivity but the Listener interface
was moved to the ContactEditorBaseFragment.
The logic in ContactEditorFragment to construct the result
Intent after successful saves was alos moved to the
ContactEditorBaseFragment.
This reverts commit 02375f1e45ade453c56810f32d63dfe8eebe4f44.
Change-Id: Ib0129d9ba4e4351677b6979c5f720df2094bf48d
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 02375f1e45ade453c56810f32d63dfe8eebe4f44 |
|
26-Jan-2015 |
Walter Jang <wjang@google.com> |
Revert "Move some contact editor functionality into new base classes"
This reverts commit 5d1c571dbe5b4a60aec6cb81d69e9e595813268e.
Change-Id: Ia9df02198b460529c157fbee6012349b0eca0bf3
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|
| 5d1c571dbe5b4a60aec6cb81d69e9e595813268e |
|
22-Jan-2015 |
Walter Jang <wjang@google.com> |
Move some contact editor functionality into new base classes
To make room for a new "compact" contact editor.
The Status and SaveMode interfaces in ContactEditorFragment were
moved to ContactEditorBaseActivity but the Listener interface
was moved to the ContactEditorBaseFragment.
The logic in ContactEditorFragment to construct the result
Intent after successful saves was alos moved to the
ContactEditorBaseFragment.
Bug 19124091
Change-Id: I5dd0b64580026a72757025915ee59be0b7d1dcbc
/packages/apps/Contacts/src/com/android/contacts/editor/ContactEditorBaseFragment.java
|