History log of /packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
68d86c656e5522dec1b04e85ebc0e0f78e436c3d 21-Feb-2016 Sailesh Nepal <sail@google.com> [Gradle] Allow dialer to be compiled as a library

This CL adds a new build-library.gradle file for AOSP dialer.
This allows the dialer to be built as a library that can be
included from GoogleDialer.

Switching to a library project meant making two other changes:
- changed all switch statements that used resources to if statements.
This was required because resource IDs are not final in library
projects.
- changed InCalUI code to import com.android.dialer.R instead of
com.android.incallui.R. See http://b.android.com/82743 for more info
on why this is required.

src-N isn't supported yet. Also, this isn't the ideal project layout.
In the future we should consider switching to the following layout:
- dialer/incallui/ <- incall UI as an independent library project
- dialer/dialerlib/ <- dialer code as an independent library project
- dialer/app <- skelent app that builds a standalone dialer AOSP app

Bug: 26676586
Change-Id: I07fbee4d33cc683539e4f8b3953c93f1427af9d7
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
bf0f0fd52ee2315ffd01f7968e5808bea9fdc045 18-Nov-2015 Nancy Chen <nancychen@google.com> getContext() -> getActivity() in fragments for backwards compatibility.

getContext() did not exist prior to API level 23, so override
getContext() to return the activity in dialer code.

Bug: 25776171
Change-Id: I817a1ba2ef29c032065b1e7eee6c033b050fb61d
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
e3cae63fc19a431d902fb8ae50eab732e735b2a0 28-Oct-2015 Ta-wei Yen <twyen@google.com> DiatactsActivity title indicate dialpad status, removed excessive "showing item"
messages.

+ DiatactsActivity set its' title to "Phone Dialpad" or just "Phone", so user
using Talkback can know the state of the activity when it is launched
+ SpeedDialFragment and SearchFragment no longer send accessibility events when
its' content is changed.
+ Add AccessibilityDelegate ContentChangedFilter to filter out
TYPE_WINDOW_CONTENT_CHANGED event for View.

Bug:25190037
Change-Id: If1fa34cc9a5d24dec3fe261da9c071bb5388ec58
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
135e465360dc36f1b9602660e290825d1e1fd00e 24-Oct-2015 Yorke Lee <yorkelee@google.com> Fix issue with entering '+' with switch access

Distinguish between a manual long press and system long
press (via accessibility) when modifying the current
dial string.

Bug: 23554996
Change-Id: I3fc610c8e24bdb39729b827715e08a3e7d73ba1f
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
762b357ec94aef3e7ee6f991c553aa950840a8bc 18-Sep-2015 Yorke Lee <yorkelee@google.com> Protect against more Telecom privileged operations

Make sure that all invocations of TelecomManager methods that
could possibly require a permission are protected by a permission
check.

Some of these are overcautious - for example, the UI should never
show the option to return to a call (READ_PHONE_STATE) if we didn't
detect an active call (READ_PHONE_STATE) in the first place, so
it is not strictly necessary to protect against the former. But not
crashing is the most preferable of all options.

Bug: 20266292

Change-Id: Id91dd16e34320a5e607f91dbce9a4296025eeaaf
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
827a90fb309fd26f5b155c1ad612512011d58437 18-Sep-2015 Yorke Lee <yorkelee@google.com> Wrap some privileged Telecom operations with permission checks

If the Dialer is not the default dialer and does not have the
CALL_PHONE permission, don't call TelecomManager methods that
will cause SecurityExceptions.

Bug: 20266292
Change-Id: I229dd045269a262632c4a911e2321203443de684
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
c8d6e16572f900f01545ebf947d15e7006fe4e46 15-Sep-2015 Yorke Lee <yorkelee@google.com> Log various call initiation entry points

Speed dial (PhoneNumberPickerInteraction, SpeedDialFragment)
Regular search (RegularSearchFragment)
Remote Directory (RegularSearchFragment)
Call Log (CallLogAdapter)
Smart Dial Search (SmartDialSearchFragment)
Dialpad (DialpadFragment)

Bug: 23164804
Change-Id: I7cc881ac655fca6d4f365b5de36a4087c4f17700
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
e3a2d133a9fdf12462dab75ed7d6c6c6061fa5e3 15-Sep-2015 Yorke Lee <yorkelee@google.com> Refactor IntentUtil.getCallIntent variants to use builder

Use the builder pattern to create a Call intent to replace the
numerous variants of getCallIntent. This will facilitate the
addition of future extras to the created call intent.

Bug: 23164804

Change-Id: Ibab8473274de8e423f621ae6fbb9685eeb2a7cab
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
306324b84809a2b53beb55260eef071d2d33f6d0 11-Sep-2015 Yorke Lee <yorkelee@google.com> Remove EXTRA_CALL_ORIGIN from Dialer

This is legacy code from the PhoneApp days and no longer
does anything.

The method signatures in IntentUtils were kept unchanged to
reduce code churn since they will be modified in a later CL.

Change-Id: I76bcdd9b1302eed701e3d1cb5027a937ab2234c4
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
d77017d981b11611657f74f48290e88b7fa99c7b 01-Sep-2015 Yorke Lee <yorkelee@google.com> Don't show dialpad when adding a call

When receiving a DIAL intent with the "add_call_mode" extra set,
don't show the dialpad when DialtactsActivity is launched.

Bug: 23519909
Change-Id: I5e8d462b3e75a12a5ccd38cfb8871b9626f2e9bb
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
7de107bff21b046c50a42bebf57eb244772412e9 27-Aug-2015 Yorke Lee <yorkelee@google.com> Don't strip post dial string when handling DIAL intent

Also add tests and update test APK manifest to allow it to be
installed.

Bug: 22007312
Change-Id: Ibc71d9efd8666c38b0d879a27dae3f5642ce383c
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
407bfa30cc7dd8107521292edd8d7c25545d75df 26-Aug-2015 Yorke Lee <yorkelee@google.com> Use View.performHapticFeedback for haptic vibration

This ensures that haptic feedback always behaves similarly to
other system widgets regardless of device.

Bug: 23523043
Change-Id: Ic1cac22ef87dcaf92a1ac8e11f82956f90e99f99
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
c72f419b18258cfc6f29590e3b97dac8b175f904 05-Aug-2015 Tyler Gunn <tgunn@google.com> Add "Call with Note" from dialpad.

Bug: 22685114
Change-Id: Id7d16634a0baad03b28b509b62315f43fa022ee4
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
575ae388961252a771488c357e425fca191594b2 16-Jul-2015 Yorke Lee <yorkelee@google.com> Add permission prompts for contacts and dialpad search

Update the following fragments to handle denied permissions
-Contacts Search (Contacts and Location)
-Dialpad Search (Phone)

Tweak and remove some of the onTouch listener logic as they are
no longer valid with the new UI. Instead of intercepting the touches
when the query is empty and returning to the main dialer activity,
allow the fragments to remain on screen if the permission request
UI is showing.

Modify signature of onEmptyViewActionButtonClicked to remove unused
permissions parameter.

Bug: 22174668
Change-Id: I96d00f2ab45df936dca602ac025f723638ac02c4
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
6bc6716bcecf319109d47a90e8f223c96c5a66fb 27-Jun-2015 Yorke Lee <yorkelee@google.com> Accessibility fix for Dialer search results

In portrait mode, resize the listview to fit above the dialpad,
so that accessibility services can correctly traverse the
view hierarchy.

Bug: 20172384

Change-Id: I35fb49be7bea5d13d951c4d954ddaf9d8d12780e
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
200bb14d08e8162e893eec2ca928491d75eab8e0 20-Jun-2015 Andrew Lee <anwlee@google.com> Set FAB to invisible on hide if no animation.

ScaleIn animation will not trigger if FAB is already visible, so if
we don't scaleOut, set the visibility of the FAB to GONE.

Bug: 21903907
Change-Id: I25ef78ca4e042665d62c40b791d7217310515597
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
83131715419e89eebe8e4ea7ada7f96ec37dd8f9 17-Apr-2015 Santos Cordon <santoscordon@google.com> "Emergency" dialpad behavior.

Change-Id: I132a119238c8de7249a4944e6dda472b3851637e
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
b7330e3802e8f9182ae1f5e54857a713b2f13547 23-May-2015 Yorke Lee <yorkelee@google.com> Handle runtime phone permission

We don't have access to the call log without the phone
permission, so disable the following functionality:

1) Call log display
2) Show call history overflow menu option
3) Last number dialed functionality

Bug: 20266292
Change-Id: I2f1d4b8b5f747d2fa04c3a9c291f9cf5147646b7
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
c16ea5ad67bf454158b364dec2f26c95a879c350 20-May-2015 Yorke Lee <yorkelee@google.com> Handle runtime permissions in Dialer

Conditionally disable the following features if the required
permissions are not available:
1) Display of all contacts
2) Display of speed dial
3) Caller ID in call log
4) Import/export contacts
5) Conversion of People.CONTENT_ITEM_TYPE and Phones.CONTENT_ITEM_TYPE
into a phone number (via DIAL intent)
6) UndemoteOutgoingCallReceiver
7) Contact Search
8) Contact lookup in call detail activity
9) Nearby places search

Bug: 20266292

Change-Id: I6d26902acb0eac407ae7bc18c11aa6ec57299506
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
791b488fb8f835bb7976cb1f839a0b3ccf04132c 15-May-2015 Yorke Lee <yorkelee@google.com> Fix potential Dialer NPEs

Fix NPEs encountered during monkey tests

Bug: 21167534
Change-Id: I98b6f675adfd233d3583c363f7daeca1bc14d8b7
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
ea4c33bc813213c9e0c48c66d4c8e0d71353919f 13-May-2015 Jay Shrauner <shrauner@google.com> Merge "Fix NPE in keyPressed when getView is null" into mnc-dev
fefc60eeff8be1043d6541518b760e110a02501d 13-May-2015 Jay Shrauner <shrauner@google.com> Fix NPE in keyPressed when getView is null

Bug:21120753
Change-Id: I2e82e4a8e7b8226a2d74753d37ff36d1d3ab367e
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
247df6ee4f43af916f7e7f339ed181a18807ef36 13-May-2015 Andrew Lee <anwlee@google.com> Reorganize Intent utilities, add send SMS intent.

+ Rename CallIntentUtils.java to IntentUtil.java.
+ Consolidate various intent creation methods to new file, and update
referenes throughout the application.

Bug: 20433758
Change-Id: Iee9e37985217c38c816124d0e74dff40a2871680
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
fdfeaaf4e5ae0277a03529e501eb1c562f769851 05-May-2015 Andrew Lee <anwlee@google.com> Change FAB icon and behavior for contacts tab.

+ Change the icon/behavior depending on the tab position.
+ Move current tab position logic from DialtactsActivity into the
lists fragment.
- Delete unused method, shift some helpers around.

Bug: 19366434
Change-Id: I6da767300907b3afd006248afb882bebde7bdfe6
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
b82e8dae149a9f247e5c9fcae02ced460670b0e7 18-Apr-2015 Yorke Lee <yorkelee@google.com> Use TelecomManager.placeCall API

Bug: 20348183
Change-Id: If1b193f933b4a7b2b322784b0cbbc66c210b25df
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
a409b6af2a5b9a10dc9839ba68b4555f038de670 16-Apr-2015 Yorke Lee <yorkelee@google.com> Change hasVoicemailNumber to getVoicemailNumber

Bug: 20223485

Change-Id: Iaa8f140746d1266febfcacf0f007ef2b4ebba968
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
3af7e5675e118b3f135b5bab1da1f666c8f268d6 15-Apr-2015 Yorke Lee <yorkelee@google.com> Use TelecommManager.getDefaultOutgoingPhoneAccount

Bug: 20224972
Change-Id: If7f1bde0229044f60bc889b380bc3e49e043e3ff
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
beb1dfe1884d8707b2c2e32125098a87cce794fb 19-Mar-2015 Andrew Lee <anwlee@google.com> Remove extra options from dialpad menu.

These are now exposed as shortcuts in the search fragment.

Bug: 19372539
Change-Id: I526570cf8326dbfac1770c0f3c06b72ee1166cc8
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
8a397adffe40af39fe4ca20865cc3748a29376a1 04-Feb-2015 Brian Attwell <brianattwell@google.com> Merge "Move CallUtil into Dialer. P1/3"
8204324a69c4d6b1b95351ab2863b5ddac6fb0a5 03-Feb-2015 Brian Attwell <brianattwell@google.com> Move CallUtil into Dialer. P1/3

CallUtil relies on the a priviliged intent that should only
be used by system apps. Therefore, it shouldn't be used by an
unbundled Contacts app.

I'm leaving one (isVideoEnabled) method from CallUtil inside
ContactsCommon. This way, when the changes that Tyler made
inside m-wireless-telephony-shamu-dev (b/19062133) get
merged back into master both ContactsCommon and Dialer
will be updated.

Bug: 18777272
Change-Id: I49c9cc714ded01d523ed770a5bf62cf92c378e2f
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
d5c512afca0341039e494e4df976b18ff07d146a 30-Jan-2015 Yorke Lee <yorkelee@google.com> Add DialpadFragment on-demand instead at on startup

Add the DialpadFragment dynamically instead of everything at
startup. Once added, it is then shown/hidden instead of removed
for performance reasons.

Reduces startup time on a N5 from 603ms to 440ms.

Bug: 18431193

Change-Id: I0482bd8277896ed8a6956fc03b6afaf44b442eb3
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
f5554ceb3c152949b4b6278b7f5e1522148a574c 27-Jan-2015 Yorke Lee <yorkelee@google.com> Add systrace events to track Dialer startup performance

Bug: 18431193
Change-Id: I92db4ae61405d8d8445b72e7ac0daa0794af8335
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
1eb16ea1adca302ff19f64d6ae55e586194a6127 16-Jan-2015 Nancy Chen <nancychen@google.com> When dialing voicemail, check voicemail number of correct default SIM.

Before dialing voicemail when a default SIM is set, Dialer checks first if it
has a valid voicemail number. However, the previous code was checking the
voicemail number of the first SIM as opposed to the default SIM. This
change corrects the logic.

Bug: 18938231
Change-Id: Ia83aa44bc773e99aabbe7474439d22eb1c4e6fd9
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
5ebf6c6a64481b07acf4ead0ee85362f1ec03712 06-Dec-2014 Nancy Chen <nancychen@google.com> Use a BroadcastReceiver for Dialpad behavior upon call hangup.

The case handled here is when a user is in the Dialer app while there is
a call in progress and then the call ends, the Dialpad should revert to
its "normal" mode, i.e. digits. The previous approach, using
PhoneStateListener, was safe for single SIM phones, but no longer works
on Multi-SIM phones because a PhoneStateListener only listens to state
changes from a single subscription (e.g. SIM). A more robust way of
knowing when a call hass ended is to receive a
TelephonyManager.ACTION_PHONE_STATE_CHANGED broadcast.

Bug: 18269410
Change-Id: I9b0578d4281bc75d0f804dc695f4bd1a9c02f2cd
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
39c18f27ed2929fae220a9b4a101d8dc7c83e217 04-Dec-2014 Nancy Chen <nancychen@google.com> Bypass Dialpad code and allow InCallUI check voicemail number for MSIM.

Since user needs to select a subscription before Dialer can check whether a
voicemail number is set up for a certain subscription, go directly to
calling voicemail when the user dials '1' on a MSIM phone where 'Ask
first' is set.

Bug:18233678
Change-Id: I10dd56c14bfb98e4f8410e2de400da44e328682f
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
ede886737944f0237993d4b55d579fe9cfb9ba28 14-Nov-2014 Yorke Lee <yorkelee@google.com> Move ToneGenerator recreation/release to onStart/onStop

There is no reason to do the costly ToneGenerator initialization
inside onResume, which gets called during the Dialer -> InCallUI
transition. Move it to onStart/onStop so it only happens when Dialer
is actually in the background.

Measurement of time taken for InCallActivity start -> onResumed, 10 runs

Before: Average 541.9ms SD: 152.4ms
After: Average 350.5ms SD: 81.1ms

Bug: 18373617

Change-Id: I192e2bcc9fd4b7d423d804f333d8d32bff3f58c1
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
72d6625a51804acec2d9c9b38dc740a65443bc56 08-Nov-2014 Evan Charlton <evanc@google.com> Allow ILD information to be populated

Expose the dialpad's ILD (international / long distance) fields to be
populated by the dialer.

Bug: 13334252

Change-Id: Ia366148ef1318a2dacc4971d51a3bd34ec3c39de
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
18c52ffec7896bbbb7f161994b4453d91fcc79ef 30-Oct-2014 Nancy Chen <nancychen@google.com> Adn queries for multi-SIM. (1/3)

Bring up a dialog if no default subscription account is set by the
user when handling ADN queries.

Bug: 17917937

Change-Id: Icd6a6dc2843463ba68d281a24e00fdba1880adf4
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
622ba6ca7d736435d7f3ec879cc2ef55e9ef0b94 31-Oct-2014 Brian Attwell <brianattwell@google.com> Merge "Use improved analytics in Dialer" into lmp-mr1-dev
beab3bbc2c977a48e3affc3e61cc2fdbb22c4ae2 27-Oct-2014 Brian Attwell <brianattwell@google.com> Use improved analytics in Dialer

Remove dependencies on old analytics code.
Initialize analytics inside DialerApplication.

Improving analytics CL #4/4

Bug: 18039620
Change-Id: I52f68e50297db2aae61d67d9bdbe66cb1d75aafc
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
d45a1f0a112758b5f204467b43819201c5c984e3 28-Oct-2014 Yorke Lee <yorkelee@google.com> Remove "Dial to add call" text in Dialpad

Also remove some unnecessary strings

Bug: 17647791
Change-Id: I0e5797b3aad35dd37607fde944c1329fbeffbe88
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
c311af1f33f9d408c7eee5a6eeda46f1d1b7265b 23-Oct-2014 Brian Attwell <brianattwell@google.com> Delete duplicated class

Also renamed dialerbind package

Analytics CL #2/5

Bug: 18039620
Change-Id: I45722015978038cdccb6a848c28e4b6c90d5aa4f
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
f663fa083983a9b417f642e246d0873e0c424bb9 14-Oct-2014 Nancy Chen <nancychen@google.com> Make a general call to voicemail when calling back from call log.

A voicemail call log entry is saved with the number of the voicemail
that was called. In the multi-sim case, however, we don't want to call
back to the voicemail number of the original call because it might be
the number of a different phone account.

Bug: 17925501
Change-Id: I528c4039cc227608e040ae71b6b10488376fb357
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
e8dc29f5e298505943901e92dd8186c427c57596 23-Sep-2014 Andrew Lee <anwlee@google.com> Merge "Hide the FAB if the dialpad chooser is shown." into lmp-dev
62e1d70e9779bd120b5fb9d5e89d952b5ef9ab6b 23-Sep-2014 Andrew Lee <anwlee@google.com> Hide the FAB if the dialpad chooser is shown.

This bug was happening because in onHiddenChanged, the dialpad button
was being made to be shown. Now, only reveal the fab at that point if
the dialpad chooser is not visible.

There is some slight quirk... I would have thought that checking
!mDialpadChooser.isShown() should have been sufficient, but it
returns false at that point. The isDialpadChooserVisible check
works fine.

Bug: 17609779
Change-Id: I11eb3dc81a2849874202a3ea06e40c097b50ac9a
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
eb21b03409db58d897e1600b45beba5dbc7011c8 22-Sep-2014 Yorke Lee <yorkelee@google.com> Fix for janky dialpad ripples

Bug: 17611750
Change-Id: Ica20f1bd060e30280f3f4540ac03db99ec817308
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
9dc924c8bcc0bc8d996452e9ce3215b5f064962e 12-Sep-2014 Tyler Gunn <tgunn@google.com> Renaming Telecomm to Telecom.

- Changing package from android.telecomm to android.telecom
- Changing package from com.android.telecomm to
com.android.server.telecomm.
- Renaming TelecommManager to TelecomManager.

Bug: 17364651
Change-Id: I44d6d6546cac53232e4e2be0ebe0391d02411309
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
29ae4ae721a1f6d89a8fdca0fd4d49a1e5ecc4a7 10-Sep-2014 Yorke Lee <yorkelee@google.com> Set the visibility of the FAB correctly even if mAnimate is false

When launching directly into the dialpad from a dial intent, the
FAB wasn't getting shown sometimes due to animation being skipped.
Make sure to force it to appear regardless of whether animation is
required.

Bug: 17443578
Change-Id: Ic53628b9792038cda0e3e447e5268e8e6fd22190
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
ae274c05cdb6707ca9593bedf20c016cd8164c0b 06-Sep-2014 Jay Shrauner <shrauner@google.com> Use framework scheme definitions

Use PhoneAccount defined values for SCHEME_{TEL, SIP, VOICEMAIL}.

Bug:17398074
Change-Id: I77dfa539646b9c5ae5dca220bbc906048a17b383
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
d36fa13013a66e435df223602f3975b2892f4589 03-Sep-2014 Andrew Lee <anwlee@google.com> Merge "Use different FAB for dialpad, and use new animations." into lmp-dev
405a6e6822fb19a9d14329da92e03e75e2e72703 21-Aug-2014 Andrew Lee <anwlee@google.com> Use different FAB for dialpad, and use new animations.

+ Use scaleIn/scaleOut for FABs in the Dialer application.
+ Add assets for green fab.
+ Update dialpad fragment, both the Java and layouts, to have their
own FAB containers and FABs.
+ Change DialpadSlidingLinearLayout into
DialpadSlidingRelativeLayout.
- Removed or relocated dial some FAB handling, visibility, and
translation functions. Now that the FABs in the dialpad fragment
and DialtactsActivity are distinct, the logic can be scoped more
precisely to a particular fragment/view.

Bug: 16399233
Change-Id: I86f9f0053dc3c50fe0d5046389632af7ddff9f67
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
4e077af2b9a50a72f4268a795bc744cd4aae5e54 03-Sep-2014 Jay Shrauner <shrauner@google.com> Fix NPE when activity is null

Bug:17360566
Change-Id: I20f3b0843bc8766ea1ded91b30c2662ea08cf7df
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
105015e3b07650638e696dcf4cdeb8f4d1b14de4 22-Aug-2014 Nancy Chen <nancychen@google.com> API Review PhoneManager -> TelecommManager. Rename methods (1/6)

PhoneManager
- handlePinMMI docs should explain what a Pin is and what MMI is
- rename isInAPhoneCall to isInCall
- rename showCallScreen to showInCallScreen
- merge this class into TelecommManager, we don't need both

Bug: 16960458

Change-Id: I6d1939175c0292641f6ece0b630db8a864871d7e
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
bff84d90c5854d3dd23fd550e5311cd31b32bfb0 20-Aug-2014 Yorke Lee <yorkelee@google.com> Fix for overflow menu disappearing during rotation

Bug: 17146511
Change-Id: I101b9839a0626dea8ba89d82e3487f8c4654723d
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
ba1fca910e44151a4e2f7f221d737c239dd610c1 06-Aug-2014 Santos Cordon <santoscordon@google.com> Remove ldaps from AOSP code.

Bug: 16327484
Change-Id: I1331cc2ac865972ce9bd096fda9f168e73a36d9f
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
6c523c6ed4afeeef19922eabf68145222b7df147 31-Jul-2014 Sai Cheemalapati <saicheems@google.com> Merge "Changing Dialer Fragments to implement Analytics." into lmp-dev
a610bd6e2aecf06bf6d14f869bad68e0110d3fe3 30-Jul-2014 Sai Cheemalapati <saicheems@google.com> Changing Dialer Fragments to implement Analytics.

Dialer's Fragments now implement AnalyticsFragment.
All Fragments now have access to sendHitEvent, which is a no op in
AOSP Dialer.

Change-Id: Ife6ab7d5369a1c96caaedbe1c59e6d07a0adae87
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
c7db678907ef1ae16aec7e963ef4884a272ab48e 30-Jul-2014 Nancy Chen <nancychen@google.com> Minor style change in dialpad

Forgot to upload this change to 513750 after fixing.

Bug: 15697565
Change-Id: I58d55d0a1844dffed3de31ab61a120323e8a56d7
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
00067445f4120fca1a3089290f21a46b2384b00e 30-Jul-2014 Nancy Chen <nancychen@google.com> Fade menu overflow icon in and out for dialpad

When there are no digits, the menu overflow icon should be invisible and
all options disabled. Fade in when a digit is typed and fade out when
there are no longer any digits.

Bug: 15697565
Change-Id: I86540e0b2e456b18686e19ae4a0ab4f751407cfc
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
659d2f22f093b9549a3d5f7722f6151932c9e93f 09-Jul-2014 Nancy Chen <nancychen@google.com> Remove SelectAccountDialogFragment for PhoneAccount on Dialer app (1/2)

One-time select will no longer be available within the dialer app so the
fragment and menu item have been removed.

Bug: 15473965
Change-Id: I13410b328f5b5ce887b8f3a9ba2c734d58008c56
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
d15629deb20dd45572ee27fb2890e9a5a2a86ca3 08-Jul-2014 Santos Cordon <santoscordon@google.com> Update showCallScreen & isInAPhoneCall to use PhoneManager.

Change-Id: Ibe6900a0560611346d4ec8e109349b0c82c8a463
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
1d1bd0da0b32a5b8cb1c7c5585acccb180b19849 01-Jul-2014 Ihab Awad <ihab@google.com> Rename Telecomm "Subscription" to "Account" (3/7)

Change-Id: I866e9d4f629a2b23acb3d3d3f2baeb0a674522f7
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
e9b9290142e0e0e767536bc0e8f89f80f7ad3926 27-Jun-2014 Santos Cordon <santoscordon@google.com> Move call-related SystemAPIs to TelecommManager. (3/3)

Bug: 15672803
Change-Id: I46e448fe93a9c5b4ae013e8b2fd6f0ce89b94e69
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
87ba489564b25d4a64c9faaeafea46e2f72d8933 12-Jun-2014 Nancy Chen <nancychen@google.com> Add icon indicating subscription in call log/call history

Display an icon in the call details showing which connection provider
(subscription) is responsible for the call.

Bug: 15473965

Change-Id: I0c6755864083799b8bafe20c3692b0d943beeee3
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
da371ea4c1eb7acc391b1a5fed564cbaa4c0cd7b 24-Jun-2014 Nancy Chen <nancychen@google.com> Fixed bug with selecting "Send Text Message"

Bug: 15847101
Change-Id: Ifa0ff4130e9cb48eb5a894fa8087dae77359d59f
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
fd723cae1dc2de0f83ec14639d4431674dd3b82e 19-Jun-2014 Sai Cheemalapati <saicheems@google.com> Update Emergency Dialer to match Dialer (3/7).

Emergency dialer style updated to match style in Dialer and
InCallUI.
Moved all dialpad resources to PhoneCommon.

Change-Id: I86747a58b196209a4543448ab939236eace7c52a
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
801d88e55c59414cee422ca0433cec8b1c39d1e6 20-Jun-2014 Yorke Lee <yorkelee@google.com> Revert "Update Emergency Dialer to match Dialer (2/5)."

This reverts commit 9598b51d20cb27acb8dfd47abf2accb612cddb3c.

Change-Id: I7c2d2b95740888af25b5b257572476b0f20900e3
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
9598b51d20cb27acb8dfd47abf2accb612cddb3c 19-Jun-2014 Sai Cheemalapati <saicheems@google.com> Update Emergency Dialer to match Dialer (2/5).

Emergency dialer style updated to match style in Dialer and
InCallUI.
Moved all dialpad resources to PhoneCommon.

Change-Id: I69ee95b20b9a6a7007288a754e12ea20763c3842
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
bd22a2c7d698fe3fa8cbcdb5e49e6d106355deba 20-Jun-2014 Yorke Lee <yorkelee@google.com> Merge "Fix Dialer tests"
7d20f8273886411ffc864231d59f780e450de3db 20-Jun-2014 Yorke Lee <yorkelee@google.com> Fix Dialer tests

Fix Dialer tests and also wrap all startActivity calls that have
the potential to fail with a catch block for ActivityNotFoundException

Change-Id: I02ce4b985eeb0e3e607b8008a333e02168acd378
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
8e0662990043a3b430a96d8e94b9d773f5a4deff 19-Jun-2014 Nancy Chen <nancychen@google.com> Add reference to TelephonyManager, renaming, remove checkbox (1/2)

Incorporating API calls to TelephonyManager.getSubscriptions.
Added new SubscriptionManager class to wrap data about subscriptions for
the purpose of passing between Dialer and its fragments.
* This particular CL deals with the renaming of the menu strings and the
* passing of data between the Dialer and its fragments.

Bug: 15473965

Change-Id: Id52b925c618952bd77970c157fa63e665203b04c
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
4c92456688e34683c2879d89b6011b741b33a379 12-Jun-2014 Nancy Chen <nancychen@google.com> Add select sim dialog for dialpad menu

Also handles passing sim card information set in dialer menu
to the dialpad fragment.

Bug: 15473965
Change-Id: I075bf727402ba315c035eb741c563aafe67d60f6
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
fbf7ee3329bf91214273d47d33449a064aece30d 07-Jun-2014 Andrew Lee <anwlee@google.com> Always show options menu in Dialer dialpad.

We disable options if there are no digits in the text field. The
PopUpMenu does not reflect this visually right now though. This
also fixes bad centering of the "dial to add call" text, because
now the text field will have equal left/right margins from the
edges of the screen..

Bug: 15453278
Change-Id: I6f4a7a597ed289fb1b59c9fcac261d151144b642
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
1d7ef6a59ae175d1577ca707e2682924a60d341d 30-May-2014 Santos Cordon <santoscordon@google.com> Update showCallScreen to use Telecomm (5/6)

Use TelephonyManager#showCallScreen instead of referencing ITelephony
directly. This way TelephonyManager can accurately route the calls to
Telecomm instead.

Bug: 15008165
Change-Id: Ib674e2e48efaa1cc97d1513dc2c2b27fdb343657
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
46fd712ad2896858d977274f94a08aef5bdf0e4c 19-May-2014 Yorke Lee <yorkelee@google.com> Add send message option to dialpad

Bug: 14052383
Change-Id: I45e9ffc829664af0010eb99be453160bcab2ac3d
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
2a58ab88d23238f252d5ccc6a6798f58b0e9ef56 15-May-2014 Andrew Lee <anwlee@google.com> Cleanup dialpad show/hide logic.

This is the first step in cleaning up the DialtactsActivity logic to
make it easier to transition between different states, and handle
the states in between (hopefully).

Originally, I thought to also block show/hide actions if there was
already a dialpad transition in progress, but in the end I did not
do this because it made the UI seem unresponsive.

- Delete custom predraw listener in DialpadFragment; it doesn't
appear to be used (?) and made the animation logic more confusing.
- Replace the fragment custom animations with our own animations,
which seem to perform better.
- Changed the animation xmls from objectAnimators to translates.
- Replaced isDialpadShowing with uses of mIsDialpadShown.
- Reorder show/hide logic. Now it is less parallel, but better
reflects the ordering/nature of fragment transactions.
- Reorder some methods to group them more logically.
- Pull out a helper method for updating the search fragment's
yTranslation.
- Pull out a helper method for updating the floating action bar.
- Delete predraw method in DialpadFragment; doesn't appear to be
used and caused.

Bug: 14900155
Change-Id: I768324b2293622ea43974f7f566eec9b11fb0d4e
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
a73e189f57d70e81e6c5150d10032dae29846fd7 13-May-2014 Andrew Lee <anwlee@google.com> Use one ImageButton for the floating action button.

This means that the touch feedback transition can continue to
propagate, even while we're switching the icons.

Change-Id: Ia0c4e7bb4556c84cabccbda5f4c5861e25e2928f
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
6269a64c2ac2522636c955d48a8e41fac0535cf1 09-May-2014 Andrew Lee <anwlee@google.com> Remove animate hide.

No longer do opacity transition on hide; slide out animation for
the Y translation will still apply.

Bug: 14471388
Change-Id: Ib1f900b248bd422600d318c82c666f8e94a349c8
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
03982754da3fc42d62beac6b003a0e3d9a3eb480 08-May-2014 Andrew Lee <anwlee@google.com> Move overflow menu and remove add contact button.

Add contact is now included as an item on the overflow menu..

Bug: 14471388
Change-Id: I4078b6f2b653dca5e42fb6088659ca059046c85c
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
b1ec21ed93078cf922c257637a1118f000121a84 07-May-2014 Andrew Lee <anwlee@google.com> Adjust dialpad slide out animation.

Bug: 14471388
Change-Id: I6f12ea8e472e54c4d5c8c4175166da48028116ac
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
cdfa6c66fa29ee0de675cd77b3bc72f6fba5ef0c 07-May-2014 Andrew Lee <anwlee@google.com> Modify the calls in Dialer to animate the dialpad in.

Bug: 14471388
Change-Id: I7b8b59ffd49f3e5512798cd6d9e86f2f9d0417d6
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
eed2e4fbcbc614aad8f62b9a4ba78f161a2fd06a 06-May-2014 Yorke Lee <yorkelee@google.com> Fix missing add to contacts button

Change-Id: Ia174eac37dbea09dde546f09784e8b3d6bf82258
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
f0c7eb8d857ed4dd68add8528dc798bfcbae832b 05-May-2014 Yorke Lee <yorkelee@google.com> Move more Dialpad resources to ContactsCommon

Change-Id: Ifc0c2d9cbccc0e972a23edc045fef57c63c9723b
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
877ace10c8aac66798a42d74204032e518e31e49 05-May-2014 Yorke Lee <yorkelee@google.com> Allow configuration of dialpad buttons visibility

The overflow menu/add contact buttons should have their
visibility toggled based on whether or not the digits can be edited.

For InCallUI, since the digits are not editable, none of these
action buttons should ever show up.

Change-Id: I2ce982fb0e2f5993f291f00ec309d99b3ddddbe8
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
ec9a6feb3110fde5805f999a9666a18be82089c1 29-Mar-2014 Yorke Lee <yorkelee@google.com> Refactor dialpad into its own view

Initial work needed to make the dialpad shareable within Dialer
and InCallUI. This CL refactors the code that controls the appearance
of the dialpad into a new custom view called DialpadView.

The parent activity/fragment is still responsible for assigning listeners
and handling event callbacks from the DialpadView.

Change-Id: I11ab8159619413caf1c3d8fa16fff475b822633b
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
5a60cf4d91cbe439a0372f4f2374e6a7f7936a41 01-May-2014 Yorke Lee <yorkelee@google.com> Fix font scaling problems in Dialpad

Change-Id: I49ae1763782529ad3ada03bb92b843b5608c3139
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
a5d5cdf2ed131289943033cfd775dd34ffd7ff45 23-Apr-2014 Yorke Lee <yorkelee@google.com> Add floating dialpad action button

* Replace fake action bar at the bottom of the screen with a floating
action button which casts a shadow.

* Remove the now unused mDialpadOverflowMenu button in DialtactsActivity

* Modify dialpad layout to add a bottom row of buttons which provide
access to the add contact button and overflow menu

* Fix dialpad layout so the heights applied in XML are actually
respected - previously they were being ignored and each dialpad key
was being assigned the height of MATCH_PARENT

Bug: 13932988

Change-Id: I6e48c00c5ceeeffed142c3dd259e630d6daf8111
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
86e21f733049560e77b92f17a58474312d72ec3e 03-Apr-2014 Yorke Lee <yorkelee@google.com> Add actionbar to Dialer

Initial changes to replace the fake actionbar affordances in Dialer
with an actual actionBar. This puts the dialer in an intermediate
hybrid state where we are now using the system actionbar for search,
but the searchview is not yet themed to look like our old search
bar, so this is definitely still WIP UI.

This CL retains the fake action bar at the bottom of the screen to
continue allowing quick access to call history while other changes
are underway, but replaces the searchview and the overflow menu
with framework provided actionbar functionality.

Other related changes:
* The searchview (in the top actionbar) is hidden when scrolling to
devote the entire screen area to the speeddial list
https://folio.googleplex.com/phone/L/0407/#/03.png
* Functionality provided by the fake overflow menu has been moved to
the real actionbar overflow menu
* Various modifications to child fragments/listviews to take into
account the existence of an actionbar
* Cleaned up unneeded styles and related-dead code

Bug: 13933082

Change-Id: Ifd855bd67af7bf2d2a403ef9556ade54e8d57ee6
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
13a54c7689f18363c873e966a9e4e9d76ed3ffa7 28-Mar-2014 Yorke Lee <yorkelee@google.com> Remove dead code

Change-Id: I6a48467f047d8e845d484fccb751d3a5de52066c
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
1dfa8ddc17a7f62f14d8435fd9712d1be0ebdf7e 25-Mar-2014 Yorke Lee <yorkelee@google.com> Fix NPE during activity recreation

Bug: 13630676
Change-Id: I3b68d5f21a4b77eab5b5493dcde670ad08cdc372
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
fb00cb8395f99842a41fd68980b2e87ae840c617 19-Mar-2014 Ihab Awad <ihab@google.com> Fix problem where swiping upward in overflow menu did not display the
correct options menu items.

b/13441681

Change-Id: If4f6970a4dd92e20ab1c04eae5228a0475bf445c
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
39fcd12c8d93038787ca61b461b6abbb1b79e80b 08-Mar-2014 Yorke Lee <yorkelee@google.com> Make dialpad slide down when dismissed by tapping outside

The dialpad currently simply disappears from view immediately when
dismissed by tapping in the space above it. instead, it should
slide downwards.

Change-Id: Idba1b8c6ccf40a6b12ea611d880e9f86183e6478
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
526c0b832e27dc38a8dc6eae1f16c50acb51c6e8 27-Feb-2014 Ihab Awad <ihab@google.com> New appearance and look and feel for dialpad.

http://b/13189041

Change-Id: I91028c8fdee31c1f76610573a4396eb979c30170
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
949ddad1a2d23e3e9336891a551a19bd6b5dd0ed 20-Dec-2013 Alan Viverette <alanv@google.com> Support long-click during lift-to-type accessibility mode

BUG: 8310727
Change-Id: Icf9e103d2d6f5b5e7acb8c7f16244f0cebe9ffaa
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
02e388e56434e842637f6d3cad3c94a6c50ce259 02-Dec-2013 Yorke Lee <yorkelee@google.com> Merge "Remove ContactPrefs from DialpadFragment"
637e7d3f6fb3b23669bbfb79776d04b50d74758c 26-Nov-2013 Yorke Lee <yorkelee@google.com> Remove ContactPrefs from DialpadFragment

DialpadFragment currently instantiates an instance of ContactsPrefs
that is not needed.

Change-Id: I8207f8d55c578a748c5edab1f722b18b5d38b48b
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
b3c6951e15865ac5a9007d281e12f380a16967e8 25-Nov-2013 Yorke Lee <yorkelee@google.com> Merge "Fix Dialer tests"
3671725b58a9768016e141c77424dedb5fd2c55a 21-Nov-2013 Yorke Lee <yorkelee@google.com> Fix Dialer tests

* Empty geocode is now " " instead of "-" per UX request
* DialpadFragment now throws IllegalArgumentException instead
of Log.wtf so that it can be tested
* Added contact id column to contactsprovider query
* Modified PhoneNumberDisplayHelper to take an instance of
PhoneNumberUtilsWrapper so that it can be mocked out
Fix label-related tests that were failing due to a change in how we
treat empty labels

Bug: 9111164

Change-Id: If2244586b9d09fa2839fa0ddfc9f369f9dc66e51
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
76af8945db9001aec63e6645a814d70d567f5729 21-Nov-2013 Yorke Lee <yorkelee@google.com> Remove use of SystemProperties

Remove private reference to SystemProperties, needed for Verizon
requirements (per team email discussion)

Bug: 6948882
Change-Id: Idc826e4a93609799e3c741d36fca5124abbc5bb9
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
a4ef50949a828e5757cbf8fceeb235c84e38d818 12-Nov-2013 Chiao Cheng <chiaocheng@google.com> Dismiss dialpad when user touches spaces above it.

Only applies if the user has not input any digits yet.

Bug: 11648799
Change-Id: I28a57fcd7eae0faaf5e234e9ec7531140903e2f5
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
32faffb75268467768bac14797de444623c97148 07-Oct-2013 Yorke Lee <yorkelee@google.com> Fix accessibility issues with dialpad

Each dialpad key needs to manually have the "focusable" flag set so that
hovering and lift-to-type works properly.

The edittext containing digits needs to receive focus at least once in
order for it to report sendAccessibilityEventTypeViewTextChanged type events.
In JB-MR2, the ViewPager would automatically give focus to the dialpad
fragment when it was swiped into view, but now we have to manually give it
focus ourselves when the dialpad fragment is swiped into view.

Bug: 11067558
Change-Id: I56a1891b12d5ec7771a37e1f7c361242ebfe028d
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
2d471771184f504c10b8d2ccef3bb2480c45f5a7 03-Oct-2013 Yorke Lee <yorkelee@google.com> Fix infinite dialpad tones due to rapid presses

Use a set of views, instead of a simple counter to track whether
or not tones should still be played.

Bug: 10906908
Change-Id: I6bdb08c253f17d9b0aa867b5cbdf4770bc52510b
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
5fb49ead1acf66b1098ef7a107f3038681f263bc 02-Oct-2013 Yorke Lee <yorkelee@google.com> Don't allow dialpad presses until it is fully in position

Bug: 11006188
Change-Id: I67861038510591384daf4e2c5da06af3dda5439c
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
ca19504ff58c91497885d9705905f7ab25e97ce0 26-Sep-2013 Yorke Lee <yorkelee@google.com> Don't call finish when calling from the dialpad

Change-Id: Ib5c98b51c4f3113e434208b83310754b825a197f
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
88517c68bac750e467f4b21caf7805c8b44b27f6 07-Sep-2013 Yorke Lee <yorkelee@google.com> Merge "Tweak Dialpad redlines" into klp-dev
cbb72d24c4b353ecbc5d5cfaa6f56416fb3afd29 06-Sep-2013 Yorke Lee <yorkelee@google.com> Merge "Add call shortcuts to phone number list adapters" into klp-dev
778408732c1e8fb81d1b5dc6df92725aa397e978 06-Sep-2013 Yorke Lee <yorkelee@google.com> Tweak Dialpad redlines

Centralize dialpad keys
Change voicemail icon

Bug: 10445734
Bug: 10510368
Change-Id: I1e9dc98c9aed07c26bdfe176f4a4c94c65fc6d85
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
c45baecabd157ee8e9ce75791e1afe4c702c25a8 06-Sep-2013 Yorke Lee <yorkelee@google.com> Fix accessibility issues with dialpad

Bug: 10314426
Change-Id: Ieecb5cc64ce93fb8457ed0cab0d054b5a1b1586c
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
e142481570d7fbda5d035555fe217314e396ae90 05-Sep-2013 Yorke Lee <yorkelee@google.com> Add call shortcuts to phone number list adapters

* Add a new class DialerPhoneNumberListAdapter, which both
RegularSearchListADapter and SmartDialNumberListAdapter extend.
DialerPhoneNumberListAdapter allows the addition of pre-defined call
shortcuts at the end of the phone number list that can be toggled
on or off.

* For the SmartDialSearchFragment, the only shortcut that is available is
always the Add number to contacts shortcut.

* For the RegularSearchFragment, if the user enters a string that contains
all dialable numbers, it is treated as a phone number and the call directly
and add number to contacts shortcuts are enabled. Otherwise, it is treated
as a name, and only the add contact with a new name shortcut is enabled.

* Add a intent that allows the user to directly create a new contact
that has the name field pre-populated. This intent is used if the user
enters input that looks like a name in the search view.

Bug: 10339630
Change-Id: I2ae757ce505d85a8780d28d89e09fb7084c773b1
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
f6673d3e5cbd10febea04f02035591ab15c5c7c0 24-Aug-2013 Yorke Lee <yorkelee@google.com> Hide dialpad fragment and exit search ui when phone number selected

Bug: 10328290
Change-Id: I3fc560f0727c493ae5f051320ea6abe4715f0e79
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
fce269a30e2ec112ea4c287d97e08ef7b3b31b89 12-Aug-2013 Yorke Lee <yorkelee@google.com> Clean up todos for dialer

* Remove account filter header container
* Remove frequent header position
* Move dialer database updating to DialtactsActivity

Change-Id: I8a6a092f25609537a47ffafb28aa4df9f55b1bd5
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
92ecd0f1d9a296f4654b5863ff1d991f435166f2 10-Aug-2013 Yorke Lee <yorkelee@google.com> Merge "Hide dial button in-call so that in-call chooser dialog shows up" into klp-dev
d121059a49b2a771bb5c25f7dc8fa6ab45242a92 10-Aug-2013 Yorke Lee <yorkelee@google.com> Merge "Make sure to not call getTelephonyManager with null context" into klp-dev
bddd6fb09fb0bbf7787e600b3b4c044482a94d61 09-Aug-2013 Yorke Lee <yorkelee@google.com> Make sure to not call getTelephonyManager with null context

Bug: 9465444

Change-Id: Ibe7f463da5ba0a5276701fa10ce01c28a5d4b16d
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
ea695cb0f877ad49a98df184efe982de83ed09d7 09-Aug-2013 Yorke Lee <yorkelee@google.com> Handle dialpad animations better

This change prevents the dialpad from animating in when
the dialer is launched directly with a dial intent.

Change-Id: I6d7378de0484dcdadecbbc0e9c25d4c8ed1e3800
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
4e4d12f1d2a82694ee376d58bb0fe450dd325802 09-Aug-2013 Yorke Lee <yorkelee@google.com> Hide dial button in-call so that in-call chooser dialog shows up

Bug: 10248510
Change-Id: Ib70b6b5eee8f1f16e2a9ea306292e324bfe3474d
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
8898cd0577d41cfa4e6acf785c9e904bd71fbdfd 08-Aug-2013 Yorke Lee <yorkelee@google.com> Removing and renaming classes from Dialer

* No code was changed, just either removed or renamed
* Reshuffled a couple of ids around in dialpad_fragment to fix some
compile time errors that somehow weren't caught before
Change-Id: I9e2381edfb14b0940015deb8cbd94786a1242f43
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
f74011e7a9b4007f6795ecee5adc2739d5fad4e6 02-Aug-2013 Yorke Lee <yorkelee@google.com> Initial cleanup of unused old dialer code

Removed unused classes and renamed NewDialpadFragment to DialpadFragment.
Removed some unused static imports

Change-Id: If16a8bfe8cc113a570514b6d0edd87cb946758fa
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
c3766338b312f9c8a6bdb2facaf4b0a4bd199de4 31-Jul-2013 Yorke Lee <yorkelee@google.com> Switch from old dialer to new dialer

Change-Id: I51351f252338eee4d0be5723beafc044786b801e
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
661834dd3b45b477165effe126a9c243750ae8d6 31-May-2013 Christine Chen <christinech@google.com> Add SmartDial database for the Dialer app.

- Creates a database helper to create a smartdial database for the Dialer app.
- Queries all rows in the Contact database and copies related columns to
the smart dial database.
- Create another prefix database to contain all prefixes of a contact.
- During keypad input, the prefix databse is queried to find contact
suggestions, and suggestions are ranked by the usage data and contact
status (starred, primary contact, etc.)
- Created unit test for the SmartDial database insertion and prefix
computing functions.

Change-Id: I4d7c3b3bcc52dd6efa4d6e69d3f1687c3abaeb69
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
a2955d420859e61e6817eb6886999d652bad31d9 11-Jun-2013 Yorke Lee <yorkelee@google.com> am 1dd46a5c: Fix crash in Dialer in landscape mode

* commit '1dd46a5c676325d20b7a042d0d0d3c7d9365d0bd':
Fix crash in Dialer in landscape mode
1dd46a5c676325d20b7a042d0d0d3c7d9365d0bd 10-Jun-2013 Yorke Lee <yorkelee@google.com> Fix crash in Dialer in landscape mode

Bug 9369806

Change-Id: I286ebb828c0f6ce7c005c541661b9aa67284847e
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
ff43216e62d2ab2b6773466a06420081dc8900e5 21-May-2013 Christine Chen <christinech@google.com> Preserves changes in phone number on dialer.

Added check on whether the intent is new to decide when to fill in the
number in dialer automatically. If the intent is not new, the dialer
will be filled with previously used number, preserving any edits on that
number.

Bug: 8484457
Change-Id: I45f02d395ce402670b380485b5ba1e7190600ec3
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
f78d3444bd50cf3c4ddccff67b1d04422fa65f6d 29-May-2013 Jay Shrauner <shrauner@google.com> Use TelephonyManager instead of ITelephony

Switch to using public TelephonyManager calls (needed for unbundling).

Bug: 6948882
Change-Id: I301590efa5c45dfc3d31a16181694941a2bee092
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
14b5dc80abc65855be0eef3f5baf17ef719a66d7 22-May-2013 Yorke Lee <yorkelee@google.com> Added SmartDialMap interface

All character validation, remap and index calculations in both
SmartDialTrie and SmartDialNameMatcher now go through a
SmartDialMap. The LatinSmartDialMap is used by default.

Bug: 8769026
Change-Id: I4ff90acc380e802f035ca1fbc55c022bf3b76aa3
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
1b0da236015f2a7801566fb44e1c2585a44cd6a2 22-May-2013 Yorke Lee <yorkelee@google.com> Smart dialing caching not starting immediately

Bug 9086662
Change-Id: Iab8fc869180188930f84edb794e0a24a1a0a2229
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
3a18654bf87df4f17880551b6cfa45c871917960 07-May-2013 Yorke Lee <yorkelee@google.com> Animation for smart dialing suggestions

Suggestions now appear with a fade in and slide up animation.
Suggestions vanish with a fade out and slide down animation.
If a suggestion is moved into the middle, it slides to the left/right
as appropriate.

Change the layout containing suggestions to a LinearLayout, in order to
better support animations.

Renamed SmartDialAdapter to SmartDialController, and also refactored
it to handle entries for a LinearLayout instead of a GridView, as well
as adding animation support and view management.

Use null object pattern in SmartDialEntry to better handle null entries.

Start displaying suggestions on the first digit entered.

Bug 8840240

Change-Id: If4e16006c0b36d2244434e0b2d8f3d3b997b0ad2
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
dbb6c6fc024bbacf3b495a44bdddccf8502793ae 14-May-2013 Yorke Lee <yorkelee@google.com> Fix Dialer NPE

Make sure that smart dialing state is properly set before
any digits in the dialpad EditText is populated.

Also turn smart dialing off by default even if the system
setting hasn't been previously set.

Bug 8963485

Change-Id: If556d8b1405cc9e60043774b3aafd5e111e4e7ee
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
a8fd33fdb65b936bd130a6d9c6bd4b3615d24886 13-May-2013 Yorke Lee <yorkelee@google.com> Merge "Setting to toggle smart dialing on/off" into jb-mr2-dev
50e3bc935962ca360d7a681cd8be90b2eee77ea6 07-May-2013 Yorke Lee <yorkelee@google.com> Setting to toggle smart dialing on/off

Bug 8840243

Change-Id: I1d1fea4f958821f3a9273ba189e2140367049516
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
f744f53ed980ba901b458b070a1b5eb4526b69f3 20-Nov-2012 Yorke Lee <yorkelee@google.com> Allow vanity numbers via paste/DIAL intent

https://googleplex-android-review.googlesource.com/#/c/253417/

Converts vanity numbers such as 1-800-FLOWERS to the numeric
equivalents when the number string is populated via a DIAL intent
or pasted from the clipboard. Does not remove valid formatting such
as dashes, periods, spaces, etc.

Bug: 8858358

Change-Id: I553c91628b8fd86ff38a8eeec7823ebdc96bfe6b
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
f43f537a0100693570606c436a81a12e21fb5b9e 02-Apr-2013 Yorke Lee <yorkelee@google.com> Remove smart dialing content observer

The content observer doesn't help to detect changes that happen
outside the application (e.g. user modifies a contact in the People
app), and seems to be called multiple times while in the dialer for
no reason, causing multiple unnecessary recaches. Instead, just force
a recache in onResume upon startup to refresh the cache.

Bug 8527847

Change-Id: I52f5c435ad573ce8b195d7b7828f19501e068c60
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
472c2778dd4395416fe2eb9c7ffe62a0e36a101e 19-Mar-2013 Santos Cordon <santoscordon@google.com> Always show WAIT/PAUSE in dialer overflow menu.

Used to hide menu items when not applicable. Now we show them always
and only perform the action in those cases where menu items were
previously visible.

Updated code to do zero-position checks when there is no
selection...previously missing check.

Changed code to use chars instead of Strings when dealing with single
digits.

Consolidated duplicate code with updateDialString() function.

bug: 7478840
Change-Id: I2aa5d3badd40079e9aa75abf7e4051f9dba5e667
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
55b030a8bbb0323a4823fc34f3167a248a0ff899 28-Jan-2013 Yorke Lee <yorkelee@google.com> Smart Dialling v2 with phone number support

Behavior:
Use a prefix tree to cache contacts instead of an array list
Perform matches against phone numbers as well
DialpadFragment now ignores results from stale tasks where
queries no longer match
Add ability to not use default phone number for phone number
disambiguation dialog
Contacts are now ranked by the order which they were sorted
by in the ContactsProvider (affinity)
Change remapAccentedChars to always return lowercase characters to avoid
overhead of uppercase character conversion

Resource/Layout changes:
Tweak margins so that the section containing smart dial
suggestions looks cleaner
Use color resource instead of hardcoding color values
Add phone number to SmartDial items

ContentObserver:
Add a contentobserver to be notified on changes in contacts
Refactored cache to allow for forced cache refreshes
Use a single instance of SmartDialCache

Tests:
Added SmartDialTrie tests

Comments:
Comment cleanup

Change-Id: Ica2854e2845d4d75048aa1fd982f139496d21bf3
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
24506db412615a318894c2d37b8a1ca0b0152e4c 05-Feb-2013 Yorke Lee <yorkelee@google.com> Don't show old matches if no smartdial matches found

Change-Id: If851c291273aa5296f1d59edccc83e6d4019be76
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
9185a786f0e1e6d87f1add958b0e115e04ff8cbe 07-Dec-2012 Chiao Cheng <chiaocheng@google.com> Fixing import order.

Change-Id: Idcab1877b341b42440e336fa09ba7d631c28c7d0
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
33dff202e94cb50c0566becdd240a015fecb4f49 12-Nov-2012 Yorke Lee <yorkelee@google.com> Cherrypick Arabic/Farsi pasting into dialpad fix

Bug: 6656969
Change-Id: I0bb094125eb9be2b6508e6ca658ae23da9da19d1
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
b9ea6cf17f0adf1deb38b95d6908a1a3621bafd7 15-Nov-2012 Yorke Lee <yorkelee@google.com> Use SmartDialCache object for caching

Extract caching methods from SmartDialLoaderTask
and use a standalone SmartDialCache object instead. This
cache object handles caching failures as well as concurrent
multiple cache requests.

Bug: 6977981
Change-Id: I6df9e273191c7ac434d094e567d7a91814f8c030
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
ac834156f56a4d4edcf207865f8235647fa26980 08-Nov-2012 Yorke Lee <yorkelee@google.com> Merge "Add smart dialling capabilities to dialer"
1be0178a11b1cc3b06867b14446e1e041e97a82c 08-Nov-2012 Yorke Lee <yorkelee@google.com> Add smart dialling capabilities to dialer

Layout changes to dialpad fragment to make space for smart dial suggestions.
This feature does not appear in landscape mode.
SmartDialTextView automatically resizes text to fit within the bounds of the view.
SmartDialAdapter highlights certain portions of the matching name based on match
positions provided by SmartDialNameMatcher.
SmartDialLoaderTask is an AsyncTask that caches all contacts with a phone number
into memory, or matches all contact names against a provided query to return a
list of matches (maximum of 3).
SmartDialNameMatcher contains utility functions to remove accents from accented
characters and normalize a phone number. It also contains the matching logic that
determines if a contact's display name matches a numeric query.
Added some tests for SmartDialNameMatcher

Bug: 6977981
Change-Id: I43e1a70d8d0d46e02fc67fe1caaec9a1769124f5
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
291e976e870d05ec9dd9d8286fb7291c0a76a523 06-Nov-2012 Chiao Cheng <chiaocheng@google.com> Change dial pad to show chooser onStart instead of onCreate.

This fixes the problem where the chooser is not shown when the dialpad is
started and pushed to recents before a call comes in. When the call comes
and dial pad is selected from recents, the dialpad is shown. Instead, we
should be showing the chooser so the user has the option of getting back
into the call.

Bug: 5761141
Change-Id: I315117c6607dbb71e5359cf98785591d20c21881
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
fe000c2346f425fb76f14b36e5cb8360929f8a1e 30-Oct-2012 Chiao Cheng <chiaocheng@google.com> Move PhoneNumberFormatter to common.

Bug: 6993891
Change-Id: I21b3afb81855ae728b9e20f8af8632c9cd9f4e58
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
16c19ef7518f5d67b7970eca07f4f50baf695fc1 30-Oct-2012 Chiao Cheng <chiaocheng@google.com> Move StopWatch class into common.

Bug: 6993891
Change-Id: I0137ea3a72e0ee1a75f9218fec471049abf36d97
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
35071c06d1587942f5a66c8f12e6247e8f904d26 16-Oct-2012 Chiao Cheng <chiaocheng@google.com> Removing contacts dependencies from CallDetailActivity.

Bug: 6993891
Change-Id: I3ef54efc0ff92367ea4f9b68c1629a99d90ff22c
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
9554500572ba82fbd7adb0a1637206ef870ef09e 15-Oct-2012 Chiao Cheng <chiaocheng@google.com> Changing com.android.contacts.R to com.android.dialer.R.

Bug: 6993891
Change-Id: I921ec71fffbd4d4a058bab29ded8a6ac62adfb70
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
9d4f3b20793a007b4489547aa40fc1049d0d8fef 06-Sep-2012 Chiao Cheng <chiaocheng@google.com> Moving resources from Contacts to Dialer.

- Also moving some shared utilities.

Bug: 6993891
Change-Id: I5fa18d26e4f5423f4d3f3450b8f3e3dacbfb947a
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
91197049c458f07092b31501d2ed512180b13d58 24-Aug-2012 Chiao Cheng <chiaocheng@google.com> Moving more classes from contacts into dialer.

- These classes are only used by dialer code.
- Fixed import order.

Bug: 6993891
Change-Id: I7941a029989c4793b766fdc77a4666f9f99b750a
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
8a372c2c67c3cf6bd5a6d4c999d68094938e365c 24-Aug-2012 Chiao Cheng <chiaocheng@google.com> Move common phone classes to new location.

- removed dependency on com.android.phone.common jar (old package)

Bug: 7054788
Change-Id: I8c1f6449534a946f4660a9e8924079c08ff1786c
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java
94b10b530c0fc297e2974e57e094c500d3ee6003 18-Aug-2012 Chiao Cheng <chiaocheng@google.com> Initial move of dialer features from contacts app.

Bug: 6993891
Change-Id: I758ce359ca7e87a1d184303822979318be171921
/packages/apps/Dialer/src/com/android/dialer/dialpad/DialpadFragment.java