History log of /system/connectivity/apmanager/firewall_manager.cc
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
be12882aa9307c62e1ae6ad8a69d5c663bed3b3e 13-Oct-2015 Peter Qiu <zqiu@google.com> Use ControlInterface for creating proxies

This removes the IPC specific (D-Bus) dependencies from FirewallManager
and ShillManager.

Bug: 24194427
TEST=Verify wifi bootstrapping on both dragonboard (Android) and wolf
TEST=(Chrome OS)

Change-Id: Iac3b91300f938e8080d6ab4513fe84dea2880693
/system/connectivity/apmanager/firewall_manager.cc
8d0c31bb481b712a3b2e6612390679e29053c620 13-Oct-2015 Alex Vakulenko <avakulenko@google.com> apmanager: Rename "chromeos" -> "brillo" in include paths and namespaces

libchromeos is transitioning to libbrillo and chromeos namespaces
and include directory is changing to brillo.

Bug: 24872993
TEST=built for aosp and brillo, all unit tests pass on dragonboard
Change-Id: I4c6efbc5bbf80d251e5d91bc3db49f02bc0e4732
/system/connectivity/apmanager/firewall_manager.cc
7a420d3e06aa7fb5eba305dc587624eb58bde7b7 22-Sep-2015 Peter Qiu <zqiu@google.com> Compile apmanager on Android

Noticeable changes to get apmanager to compile on Android:
- Conditional include headers for D-Bus service constants
based on the target platform.
- Use firewalld proxy instead of permission_broker proxy on
Android.
- Use stub shill proxy instead of the real one until libshill-client
is ready.

Bug: 24164800
TEST=Compile apmanager on both Android and Chrome OS
TEST=Run apmanager on Chrome OS device

Change-Id: I7885323796e0043a1e3cc46c129e2736faf4fced
/system/connectivity/apmanager/firewall_manager.cc
9b2ecc45cd5cf99e0ced28d4b522e6dee5b52968 17-Sep-2015 Peter Qiu <zqiu@google.com> Abstract firewall proxy interface

Provide an abstraction for firewall proxy, to allow different proxy
implementations. Chrome OS will continue to use the implementation
based on permission_broker.

Bug: 23757625
TEST=Build an image with "wifi_bootstrapping" USE flag, boot it up
TEST=on a device. Verify a provisioning AP is up "Developer xxx"
TEST=and a client can connect to it.

Change-Id: I7d902d8741bb12f79b3b1458e114d6305cfb6339
/system/connectivity/apmanager/firewall_manager.cc
25c7e10c1977cbd5bf139d50640101aee9d0da22 08-Sep-2015 Peter Qiu <zqiu@google.com> Generate DBus interfaces for client libraries

The generated dbus-proxies.h and dbus-proxy-mocks.h are now created by
by the daemon that exposses the interface, instead of letting the
daemon using the interface generate them. This creates then a client
library that other daemons can use.

This patch installs these libraries for login_manager, power_manager,
debugd, apmanager and shill, and makes all their callers use these
interfaces instead of using the xml directly.

This patch moves the code dependency on the .xml files to an ebuild
dependency.

This patch only contains the apmanager changes. The original CL is here:
https://chromium-review.googlesource.com/296026

BUG=23619937
TEST=./build_packages

Change-Id: I80855787fb22438bcc2e36eede987e8cc0d083e4
/system/connectivity/apmanager/firewall_manager.cc
326b6cfba5ab73c9e41a7585d1bc95871631122a 02-Sep-2015 Peter Qiu <zqiu@google.com> Re-license apmanager to Apache2

This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.

The license header was added to .gyp, the NOTICE was replaced with a copy
of the Apache2 license and MODULE_LICENSE_* file was updated.

BUG=23619937
TEST=grep 'Chromium OS Authors' doesn't find anything.

Change-Id: I4ade0a15ff18ab159d4a2f99525b62c780b13c89
/system/connectivity/apmanager/firewall_manager.cc
943cf3a0afdad2cc6bea02b181f09e6ff23df628 24-Feb-2015 Peter Qiu <zqiu@chromium.org> apmanager: add DHCP firewall rule per interface basis

With the recent update in permission_broker to allow firewall rules per
interface basis, update apmanager to dynamically request/release DHCP
port access when an AP service is started/terminated. And only request
the port access for the interface that AP service is running on.

BUG=chromium:450408
TEST=USE="asan clang" FEATURES=test emerge-$BOARD apmanager
Run security_Firewall test
Manual Test:
1. Use "iptables -S" command to verify no firewall rule is added
for port 67 when AP service is not started.
2. Start an AP service, verify firewall rule for port 67 is added
for the wifi interface (wlan0 for wolf device) and client can
connect to it with IP connectivity.
3. Stop the AP service, verify firewall rule for port 67 is deleted.
CQ-DEPEND=CL:252931

Change-Id: If7a5150d224ff1a5085b5e8032a162e8ca07c545
Reviewed-on: https://chromium-review.googlesource.com/252941
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/apmanager/firewall_manager.cc
02f60b32590a5bac2044a4edad27ebaf568c2bbd 12-Feb-2015 Jorge Lucangeli Obes <jorgelo@chromium.org> permission_broker, apmanager: Support specific interfaces.

BUG=brillo:185
TEST=Unit tests pass.
TEST=platform_Firewall passes.
CQ-DEPEND=CL:249651

Change-Id: Ib6170f9d348eae43fbdc1fa908c67fb3d7cfbc3d
Reviewed-on: https://chromium-review.googlesource.com/249622
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
/system/connectivity/apmanager/firewall_manager.cc
1810c01237329106f339ac4bdf6baa58efa76917 05-Feb-2015 Peter Qiu <zqiu@chromium.org> apmanager: add firewall rules during run time

Use permission_broker to add firewall rules when apmanager starts.
Also remove the temporary hack in webservd upstart script for
adding firewall rules on behalf of apmanager.

BUG=chromium:450408
TEST=Verify firewall rule for UDP port 67 (DHCP port) is added
when apmanager starts, and removed after apmanager is
terminated.
Run security_Firewall autotest.
CQ-DEPEND=CL:246272,CL:247141,CL:247210

Change-Id: I4b25dc753a12ff91ed68d712f096ed570e635ad8
Reviewed-on: https://chromium-review.googlesource.com/246699
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/apmanager/firewall_manager.cc