| 8a3f68edbcf7fe59380609588787baa54cbd9bdd |
|
11-Jan-2016 |
Samuel Tan <samueltan@google.com> |
shill: make remote service monitoring RPC-mechanism-specific
Code that monitors remote RPC endpoints is RPC-mechanism-specific,
so it should live in RPC-mechanism-specific source files.
Move all code that creates D-Bus service watchers from Manager
into ChromeosManagerDBusAdaptor, and remove expectations for
service watcher creation/deletion from Manager unittests. Remove
CreateRPCServiceWatcher from ControlInterface, since we leave the
details of creating the RPC service watcher to the RPC adaptors.
Also, create a ChromeosManagerDBusAdaptor unittest, along with the
classess necessary to support these unittests (DBusServiceWatcherFactory,
MockDBusServiceWatcherFactory, MockDBusServiceWatcher), to test for the
creation/deletion of D-Bus service watchers that is now done in
this adaptor.
While there, remove an unnecssary comment from icmp_session_factory.cc.
BUG: 26489902
TEST: Unit tests pass when shill is built with SHILL_USE_BINDER=true
TEST: Unit tests pass when shill is built with SHILL_USE_BINDER=false
Change-Id: I31be9ead90e0e538247401042c5b5012a924c0dd
/system/connectivity/shill/dbus/mock_dbus_service_watcher_factory.h
|