| 015a0adaa9b595125543f37d78bad571c639a316 |
|
21-Oct-2015 |
Ningyuan Wang <nywang@google.com> |
shill: kill dhcpcd process synchronously
Kill the dhcpcd process synchronously in order to ensure no dhcpcd
instance is left runnning.
Bug: 25146029
TEST=unittest and manual test on Dragon board.
Change-Id: Ibb9c5683f77aea662df884d065b49ee2c029a030
/system/connectivity/shill/dhcp/dhcp_config_unittest.cc
|
| 289a5a5e18bb1a676b3dfce111af4c2c00c7776e |
|
21-Sep-2015 |
Samuel Tan <samueltan@google.com> |
shill: use different service_constants.h path for Android builds
Use the service_constants.h file from the external/cros/system_api/dbus
instead of chromeos/dbus/service_constants.h, since this header file
is installed into different directories when building shill for Android
and Chrome OS.
BUG: 22956441
Change-Id: I7e6ea46b4893588d2862792cf43aa83fdf7c30b4
TEST: shill still compiles using emerge.
/system/connectivity/shill/dhcp/dhcp_config_unittest.cc
|
| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/dhcp/dhcp_config_unittest.cc
|
| 8ee1c83abf0050cb808fe154babe934546e77821 |
|
12-Aug-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: dhcp: use ProcessManager to manage dhcpcd processes
This removes the glib dependency for spawning/monitoring dhcpcd processes.
While there, fix a typo in process manager.
This is a part of series CLs that convert shill over to MessageLoopForIO
and chromeos dbus.
BUG=chromium:516841
TEST=unittests
Change-Id: I192fcc68c51e78da60431635abd7b3439fadd5b0
Reviewed-on: https://chromium-review.googlesource.com/292963
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dhcp/dhcp_config_unittest.cc
|
| 608ec29525f553d51f0a92e84176e3d4b45930a9 |
|
31-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: use ControlInterface to create proxy objects
So that appropriate proxy objects can be created based on the type of
the control interface.
While there, remove ProxyFactory related files.
BUG=chromium:513791
TEST=USE="asan clang cellular wimax dhcpv6" FEATURES=test emerge-$BOARD shill
Change-Id: I465b0807ab4ccacac3891638db41384f43ef83c5
Reviewed-on: https://chromium-review.googlesource.com/289855
Reviewed-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dhcp/dhcp_config_unittest.cc
|
| 7adad988e41954c134cbb4e5ab8a1a152e1e3c78 |
|
24-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: remove dbus-c++ dependencies from DHCPConfig
Use KeyValueStore instead of DBus::Variant map to store IP
configurations in the callback from dhcpcd proxy.
BUG=chromium:507966
TEST=unittests
Change-Id: I476b3dc822b400fc5ea62e483c74bb2e80a5e746
Reviewed-on: https://chromium-review.googlesource.com/288288
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dhcp/dhcp_config_unittest.cc
|
| 0bfabaae654ba3bf597a303b7517a0e14fd65089 |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: dhcp: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: I504db9cd6fdc8ed6700f77e1da459115c5d48cf4
Reviewed-on: https://chromium-review.googlesource.com/278073
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dhcp/dhcp_config_unittest.cc
|
| d1c7b413bf7e1f264d1acfdfb2f698413f6cf352 |
|
12-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: DHCPCDProxy: Ignore messages from unbound PIDs
When an interface is destroyed, shill and dhcpcd race to destroy
configuration. The situation that this CL resolves is one where
dhcpcd still has an outstanding signal that is delivered to the
DHCPCDProxy after the PID has been unbound from the DHCPProvider.
This CL maintains a short set of previously unbound PIDs that
can be used to dismiss messages from recently departed dhcpcd
instances without triggering an error message.
While here, correct the DHCPConfig unit test to use a mocked
DHCPProvider instead of a real one, and move testing of the
Bind and Unbind methods to the DHCPProvider unit test where it
makes more sense.
BUG=chromium:498908
TEST=Unit tests + "rmmod asix; modprobe asix" # Reload ethernet
TEST="grep 'Unknown DHCP client PID' /var/log/messages"
Change-Id: Ic55b0b2281651fd78a7e6fccb1b0fc2e7e520bcb
Reviewed-on: https://chromium-review.googlesource.com/277138
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dhcp/dhcp_config_unittest.cc
|
| 8e0151e84f077cc9c0646d5bafd925ed235a1c12 |
|
04-Jun-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: refactor DHCPConfig
To better support DHCPv6 configurations, move IPv4 specific code
from DHCPConfig to the newly created DHCP4Config. The idea is to
have the base class DHCPConfig supports the basic interaction with
dhcpcd daemon, and the derived class (IP specific) for processing
events and parsing IP configurations.
An upcoming CL will add a new class DHCP6Config for processing
IPv6 configurations.
BUG=chromium:496302
TEST=USE="asan clang" FEATURES=test emerge-$BOARD shill
TEST=Run network_Dhcp* client tests and wifi_matfunc suite
Change-Id: I1f23ec46a52b42fccf7bbc8906c5f5e506f2d1c8
Reviewed-on: https://chromium-review.googlesource.com/275274
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dhcp/dhcp_config_unittest.cc
|
| 675d0b0f04936050a357722f52dc078a3ab671d8 |
|
03-Jun-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: move dhcp codes to dhcp directory
Number of files related to dhcp will increase significantly after
refactoring DHCPConfig and adding support for DHCPv6. So move
these files to a dedicated directory.
BUG=chromium:496302
TEST=USE="asan clang" FEATURES=test emerge-$BOARD shill
Change-Id: I7f47365158fc5e1d902946dc3403720402f9b6ad
Reviewed-on: https://chromium-review.googlesource.com/275019
Reviewed-by: Zeping Qiu <zqiu@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dhcp/dhcp_config_unittest.cc
|