c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2 This patch automatically replaced the license on all text files from Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as a reference. The license header was added to .gyp and .gypi, the NOTICE was added with a copy of the Apache2 license and MODULE_LICENSE_* file was added. BUG=23587594 TEST=grep 'Chromium OS Authors' doesn't find anything. Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/dns_client_unittest.cc
|
3b30ca58d13cf66b75ba0729b222ddc42ae68b33 |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Top-level unit tests: Switch pointer/ref spacing Switch to Chrome style spacing. BUG=chromium:501026 TEST=Unit tests Change-Id: I86c072b89281e0de18928b47860b99d779af061a Reviewed-on: https://chromium-review.googlesource.com/278037 Reviewed-by: Rebecca Silberstein <silberst@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
8d6b59704591ba9fad57751858835dc332dbdd37 |
|
28-Oct-2014 |
Peter Qiu <zqiu@chromium.org> |
shill: export a shared library for RTNL interface. Export a shared library "libshill-net-<(libbase-ver)" from shill, which currently includes the RTNL interface and other codes that it depends on (mainly ByteString, IPAddress, IOHandler, TimeStamp, and Sockets). All the library codes are moved to under "shill/net/". Upcoming changes: - Remove dependency for "shill/error.h" which depends on dbus-c++. - Add Netlink interface to the shared library. BUG=chromium:427982 TEST=unittests CQ-DEPEND=CL:226103 Change-Id: I7f5c183b8a347c02e80ffed5e3497f691dde517c Reviewed-on: https://chromium-review.googlesource.com/226110 Reviewed-by: Peter Qiu <zqiu@chromium.org> Tested-by: Peter Qiu <zqiu@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
cd47732488cd101eaf0d3558dde5a7d4e4fc260b |
|
17-Oct-2014 |
Ben Chan <benchan@chromium.org> |
shill: Replace scoped_ptr with std::unique_ptr. BUG=None TEST=`USE='wimax' FEATURES=test emerge-$BOARD shill` TEST=`USE='wimax clang asan' FEATURES=test emerge-$BOARD shill` Change-Id: Id9737d9a9c75ecb6abb466b5559ff06dcf0751cd Reviewed-on: https://chromium-review.googlesource.com/224138 Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
cc225ef3b77b5e098cc12c661a947e1737480777 |
|
30-Sep-2014 |
Ben Chan <benchan@chromium.org> |
shill: Replace NULL with nullptr. BUG=None TEST=`USE=wimax FEATURES=test emerge-$BOARD shill` Change-Id: I30ab47ff32dcadad09ae7a2baf4d4123a6ef0d8e Reviewed-on: https://chromium-review.googlesource.com/220657 Reviewed-by: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
f3a8f9064976d12c4f8ed3c6a5cc9ea4655c686d |
|
20-Aug-2014 |
Peter Qiu <zqiu@chromium.org> |
shill: Add IPv6 connection support. Added support to shill for it to be able to complete portal detection using IPv6 connection. The IPv6 support is added to AsyncConnection, DNSClient, and HTTPRequest. BUG=chromium:394010 TEST=unit tests, manual test with future CL that initiate IPv6 portal detection. Change-Id: I20b768211f3ecfcd53406805038c0490a488ee78 Reviewed-on: https://chromium-review.googlesource.com/213273 Reviewed-by: Peter Qiu <zqiu@chromium.org> Tested-by: Peter Qiu <zqiu@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
8a5322984f2d81bcbfd8d44c59747a11bd9b904b |
|
17-Jun-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
shill: Fix most of warnings from cpplint Fix most cpplinter's warnings. On a few occasisions, the warnings produced were false-positives, so added explicit // NOLINT comment overrides. There were a few instances of disallowed non-const reference usage (reported as runtime/reference error by cpplint) for "DBus::Error &error" which should potentially be changed to pointers to comply with C++ coding style but I will let Shill owners do that since there is quite a few of those and the change isn't brain-dead simple... BUG=None TEST=platform2 still compiles and all unit tests pass. Change-Id: Ic2e31896aa13d20eeb1a85dee74f3db8cccfde2e Reviewed-on: https://chromium-review.googlesource.com/204164 Tested-by: Alex Vakulenko <avakulenko@chromium.org> Reviewed-by: mukesh agrawal <quiche@chromium.org> Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
be277dd19182e3de5422fd5ea5094053e88a396f |
|
06-Feb-2014 |
Ben Chan <benchan@chromium.org> |
shill: Consolidate error matchers. This CL consolidates error matchers in various unit tests into testing.h to avoid code duplication. BUG=None TEST=Build and unit tests. Change-Id: If941e845bfc44ef550e0f892fe71ea1a60195876 Reviewed-on: https://chromium-review.googlesource.com/185087 Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
fc34925d45add6f1c81a42a7632621e69bfdc43e |
|
30-Aug-2012 |
Han Shen <shenhan@google.com> |
Fix shill unittest build problem for gcc 4.7. gcc 4.7 is more strict about type conversion in initilization list, for example - const char apple[] = {0xff, 0xfe}; The above compiles ok prior to gcc 4.7, but fails on gcc 4.7 with -Wall -Werror. The reason is that 0xff is out of bound for (signed) char type. TEST=Built/tested using gcc 4.7 BUG=None Change-Id: I597cac783954b856726494b757d69ddbc6c4436b Reviewed-on: https://gerrit.chromium.org/gerrit/31908 Reviewed-by: mukesh agrawal <quiche@chromium.org> Commit-Ready: Han Shen <shenhan@chromium.org> Tested-by: Han Shen <shenhan@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
f582b50dc416de301f3e4a5f1712a93b9ce02e95 |
|
05-Apr-2012 |
Paul Stewart <pstew@chromium.org> |
shill: Fix timer canceling The move to new callback closures included the frequent replacement of "task_factory_.RevokeAll()" with "weak_ptr_factory_.InvalidateWeakPtrs()". The former canceled all pending timers, whereas the latter also effectively canceled all I/O callbacks. This caused both portal detection and the service proxy to stop working. This CL creates CancelableClosures for the affected timers, and cancels these closures instead of invalidating all weak pointers. BUG=chromium-os:28885 TEST=Manual: Test both passing and failure cases of portal detection, ensuring that DNS timeouts work correctly. Use "curl -x" to test HTTP proxy. Change-Id: Id61dfb6a1a4ce0defaa08a99e318bc510c6c84b3 Reviewed-on: https://gerrit.chromium.org/gerrit/19644 Reviewed-by: Eric Shienbrood <ers@chromium.org> Commit-Ready: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
9a24553461df7036755060423f90804011612249 |
|
07-Mar-2012 |
Eric Shienbrood <ers@chromium.org> |
Make Enable/Disable work using new callbacks for async support. Use new-style callbacks to implement the Manager EnableTechnology and DisableTechnology operations asynchronously. This allows devices to be enabled and disabled from the UI ,and for the UI to display available networks once the device is enabled. Removed the behavior whereby setting the Device.Powered property had the side effect of enabling or disabling the device. To replace this, I added new Device.Enable and Device.Disable calls for enabling and disabling individual devices. Also separated the in-memory value of the Powered property from the persisted value. Whenever a client requests that a device be enabled or disabled, the desired power state is immediately saved in the profile, but the in-memory value isn't updated until the operation completes. On startup, shill now automatically starts any devices for which the persistent Powered property is set, and does not start devices for which it is not set. BUG=chromium-os:23319,chromium-os:27814 TEST=Manual testing on device + unit tests passing. Change-Id: Id676be3fc662cfd5efb730c67687edfd16b2dc6b Reviewed-on: https://gerrit.chromium.org/gerrit/18123 Commit-Ready: Eric Shienbrood <ers@chromium.org> Reviewed-by: Eric Shienbrood <ers@chromium.org> Tested-by: Eric Shienbrood <ers@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
3e20a2341d0aeb7681e4ee0f89eae6817ade2b3b |
|
16-Feb-2012 |
Eric Shienbrood <ers@chromium.org> |
shill: Convert code to use the newest version of libchrome. The biggest change is a switch from using the deprecated Task and CallbackN mechanisms to using the new Callback mechanism. Note: Original CL was https://gerrit.chromium.org/gerrit/16156. This is logically another patch to that CL, but since the latter was already merged, and is considered closed by Gerrit, it's necessary to create a new CL. BUG=chromium-os:15330 TEST=Build shill and run it on a zgb with a modem. Build and run unit tests. CQ-DEPEND=I37628863370323d30cac493764ea28f8ffd42637 Change-Id: I3ae78a3aa44ec167b79f2170d07650ece888254f Reviewed-on: https://gerrit.chromium.org/gerrit/18030 Reviewed-by: Eric Shienbrood <ers@chromium.org> Tested-by: Eric Shienbrood <ers@chromium.org> Commit-Ready: Eric Shienbrood <ers@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
b5c8940ae68f85c8c822936f41f4993c51624dcf |
|
13-Mar-2012 |
Eric Shienbrood <ers@chromium.org> |
Revert "shill: Convert code to use the newest version of libchrome." This reverts commit ffebe0c489e0ecccf497547d7078c30cbc8072e2 Unit tests ran on local machine, but wouldn't run on CQ because of some kind of environment difference. Change-Id: Ia876c0c17f4cd84bca5e2f1bacd7e24a81832d4d Reviewed-on: https://gerrit.chromium.org/gerrit/17969 Reviewed-by: Eric Shienbrood <ers@chromium.org> Tested-by: Eric Shienbrood <ers@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
08a4ffb4ecf5893eb55c523d528bf3e52c66facf |
|
16-Feb-2012 |
Eric Shienbrood <ers@chromium.org> |
shill: Convert code to use the newest version of libchrome. The biggest change is a switch from using the deprecated Task and CallbackN mechanisms to using the new Callback mechanism. This cannot be submitted until vapier submits his CL that slot-enables the libchrome build (https://gerrit.chromium.org/gerrit/15415). BUG=chromium-os:15330 TEST=Build shill and run it on a zgb with a modem. Build and run unit tests. CQ-DEPEND=Ic24bb16aac3e1d130a784f34e848e308719a43be Change-Id: I081a7aa66bee391b867a43e08db2eacdff760945 Reviewed-on: https://gerrit.chromium.org/gerrit/16156 Tested-by: Eric Shienbrood <ers@chromium.org> Commit-Ready: Eric Shienbrood <ers@chromium.org> Reviewed-by: Eric Shienbrood <ers@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
bdb02e664f79f29b3bce9be4ca05c82d8ede697f |
|
23-Feb-2012 |
Paul Stewart <pstew@chromium.org> |
shill: Prepare DNSClient and HTTPRequest for destroy-on-callback Refactor both classes so that it's okay for the callback to destroy the object (i.e., do nothing to the object after the callback is called). As a part of this, clean up some of the callback semantics, so, for example, DNSClient callbacks are passed an Error reference and an IP Address instead of having to use a getter. Additionally remove the blemish where an immediate timeout in Start() both returned failure and called the callback. BUG=chromium-os:23318 TEST=Fixed unit tests, manual Change-Id: Ib7787a7aa6f7f3d00caa539d6b0221ff5f3d60b3 Reviewed-on: https://gerrit.chromium.org/gerrit/16435 Commit-Ready: Paul Stewart <pstew@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
e692740c0623d4cb5d92d36214982ee45a03a5db |
|
24-Jan-2012 |
Paul Stewart <pstew@chromium.org> |
shill: Add Portal Detection object Add a utility object that will perform a repeated test of an HTTP URL and return the result to a callback. BUG=chromium-os:23318 TEST=New unit tests Change-Id: I0449dbe51fb1dcef2ecd3bb88de1bcaf2950f749 Reviewed-on: https://gerrit.chromium.org/gerrit/15472 Commit-Ready: Paul Stewart <pstew@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|
c2350ee42c6734750ef8a57bae20f23a224cbc53 |
|
19-Oct-2011 |
Paul Stewart <pstew@chromium.org> |
shill: Create an asynchronous resolver object Resolve DNS requests using the c-ares library but using the shill event loop to handle events. BUG=chromium-os:21664 TEST=New unit test Change-Id: I99776b6cc74977d31198c67357c42a75f4047942 Reviewed-on: https://gerrit.chromium.org/gerrit/10328 Reviewed-by: Chris Masone <cmasone@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/dns_client_unittest.cc
|