| fa1eb722d0742d89c26b9c5c81d02ef2a138cbf2 |
|
21-Dec-2015 |
Alex Vakulenko <avakulenko@google.com> |
shill: Disable RTTI
There is no longer a reliance on RTTI in libbrillo, so disable RTTI
in the rest of Brillo codebase.
Shill also used dynamic_cast<> in many places but it looks like there
is no reason for that. Using static_cast<> in those places seems to
work just as well and doesn't require RTTI.
Bug: 26292405, chromium:220387
TEST: Compiles, all unit tests pass on Dragonboard
Was able to bootstrap a device from scratch and networking
seems to work fine.
Change-Id: Id0c47168e634e354b4279f613246e6667df6fb5f
/system/connectivity/shill/ethernet/ethernet_service_unittest.cc
|
| bad1c10ffd2d4ac14f7bd9f4ef6a8982e711f566 |
|
19-Sep-2015 |
mukesh agrawal <quiche@google.com> |
shill: remove references to GLib
There are a number of references to GLib (the object),
even though no one uses GLib in a substantive way.
Remove these obsolete references.
Bug: 23386647
TEST=unit tests
Change-Id: I8d574980bc8e853c8b87ef64b581d64a71491201
/system/connectivity/shill/ethernet/ethernet_service_unittest.cc
|
| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/ethernet/ethernet_service_unittest.cc
|
| 7e779d87abbba4d9e50ef28513a27c7bbd5cd550 |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: ethernet: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: I2477041b9267ca58c94cfc15749be6bc2c992655
Reviewed-on: https://chromium-review.googlesource.com/278074
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/ethernet/ethernet_service_unittest.cc
|
| 3de88a00f446215b3299fe5834d4f120863e3ac7 |
|
05-Dec-2014 |
Paul Stewart <pstew@chromium.org> |
shill: Ethernet: Retain EthernetService for life
Make the EthernetService held by the Ethernet device remain valid
for the lifetime of the Device. This allows Ethernet services to
be configured whether or not a link is available. To modify this
lifetime, it is necessary to break the reference loop between the
Ethernet device and its Service.
Instead of calling RegisterService and DeregisterService with the
EthernetService, toggle the visibility and autoconnect properties
to allow the service to disconnect and regain L2 connectivity as
link appears and disappears.
BUG=chromium:439176
TEST=The following:
- Unit tests with ASAN
- The following autotests:
+ network_Dhcp*
+ network_VPNConnect
- Manual:
+ Start shill with Ethernet connected, disconnect, reconnect
+ Start shill with Ethernet USB disconnected, connect USB (with Ethernet attached)
+ Start shill with Ethernet USB disconnected, connect USB with Ethernet detached,
then connect Ethernet
+ Monitor "list-services" to make sure the Ethernet service is only visible
(and connects) when both USB and Ethernet are connected.
Change-Id: I7f0ef8397606b69990b8dc03be75f6166aa5c017
Reviewed-on: https://chromium-review.googlesource.com/233770
Trybot-Ready: Paul Stewart <pstew@chromium.org>
Reviewed-by: Peter Qiu <zqiu@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/ethernet/ethernet_service_unittest.cc
|
| 87602518c59af2f9e8288d81a1f877dd80f24433 |
|
08-Nov-2014 |
Ben Chan <benchan@chromium.org> |
shill: ethernet: Move ethernet code to its own sub-directory.
This CL is part of a series of CLs, which aim to reorganzie shill's flat
source code structure into a more modular form by moving technology
specific code into their own sub-directories.
BUG=chromium:433419
TEST=`FEATURES=test emerge-$BOARD shill`
TEST=`USE='clang asan' FEATURES=test emerge-$BOARD shill`
Change-Id: I9a716161c9c4f8f608d815748bde6781d83d1b34
Reviewed-on: https://chromium-review.googlesource.com/229871
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/ethernet/ethernet_service_unittest.cc
|