| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/external_task_unittest.cc
|
| a24480aaca4d392d6d08cebdc508ee49615839d3 |
|
12-Aug-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: ExternalTask: use ProcessManager to manage processes
This removes glib dependency for spawning/monitoring processes
for external tasks.
This is a part of series CLs that convert shill over to MessageLoopForIO
and chromeos dbus.
BUG=chromium:516841
TEST=unittests
Change-Id: I6cec2326671bf0da09cd8ec7731b5c510cbed0ed
Reviewed-on: https://chromium-review.googlesource.com/292982
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/external_task_unittest.cc
|
| 3b30ca58d13cf66b75ba0729b222ddc42ae68b33 |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Top-level unit tests: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: I86c072b89281e0de18928b47860b99d779af061a
Reviewed-on: https://chromium-review.googlesource.com/278037
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/external_task_unittest.cc
|
| cd47732488cd101eaf0d3558dde5a7d4e4fc260b |
|
17-Oct-2014 |
Ben Chan <benchan@chromium.org> |
shill: Replace scoped_ptr with std::unique_ptr.
BUG=None
TEST=`USE='wimax' FEATURES=test emerge-$BOARD shill`
TEST=`USE='wimax clang asan' FEATURES=test emerge-$BOARD shill`
Change-Id: Id9737d9a9c75ecb6abb466b5559ff06dcf0751cd
Reviewed-on: https://chromium-review.googlesource.com/224138
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/external_task_unittest.cc
|
| cc225ef3b77b5e098cc12c661a947e1737480777 |
|
30-Sep-2014 |
Ben Chan <benchan@chromium.org> |
shill: Replace NULL with nullptr.
BUG=None
TEST=`USE=wimax FEATURES=test emerge-$BOARD shill`
Change-Id: I30ab47ff32dcadad09ae7a2baf4d4123a6ef0d8e
Reviewed-on: https://chromium-review.googlesource.com/220657
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/external_task_unittest.cc
|
| a41ab517725d036b63420f8445550246f8f50b99 |
|
23-Jul-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
shill: Sort headers alphabetically (build/include_alpha)
We are going to enable build/include_alpha linter warning soon,
so in preparation for this, fixed the warnings in shill.
BUG=None
TEST=cpplint.py --filter=-build/include_order,+build/include_alpha shill/*
Change-Id: I113ed7f9dd3f465a3f660599320cdb434e7cc214
Reviewed-on: https://chromium-review.googlesource.com/209636
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/connectivity/shill/external_task_unittest.cc
|
| a0ddf46e466bd4ba3d20952f0a6988c680c1af14 |
|
06-Feb-2014 |
Ben Chan <benchan@chromium.org> |
shill: Update to build against libchrome-242728.
BUG=chromium:341521
CQ-DEPEND=CL:193660
TEST=Tested the following:
1. `FEATURES=test USE='cellular wimax' emerge-$BOARD platform2`
2. Run the following tests:
- network_3GSmokeTest
- network_VPNConnect.*
- network_WiMaxSmoke
- wifi_matfunc
Change-Id: Ic1553c182ab7a833a68c45f012f646b8930cb095
Reviewed-on: https://chromium-review.googlesource.com/193606
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/external_task_unittest.cc
|
| c4f9aa0e795b6f79c628a763831d4dc6c01fb72b |
|
16-Aug-2013 |
mukesh agrawal <quiche@chromium.org> |
shill: provide ability to configure children to terminate with parent
If shill crashes and restarts, it will re-initialize its state about
its peer daemons (e.g. wpasupplicant, ModemManager). Child processes,
however, do not always provide a way to query their current state.
For dhcpcd, we deal with this problem by having the child process
(dhcpcd) monitor D-Bus events to determine when shill exits. When
that occurs, dhcpcd terminates itself. In this way, a newly spawned
shill process doesn't have to worry about an old dhcpcd conflicting
with one fired off by the (new) shill process.
Since pppd doesn't have integrated D-Bus support, doing the same
for pppd could be hairy. Instead, use prctl() to ask the kernel
to deliver SIGTERM to pppd when shill exits.
BUG=chromium:261710
TEST=manual
Manual test
-----------
- plug in ppp dongle
- wait for network to connect
- killall -9 shill
- egrep 'pppd.+Terminating on signal 15' /var/log/net.log
Change-Id: I7513ccfa8de0b154d233d8a4d6f1bc701af32974
Reviewed-on: https://gerrit.chromium.org/gerrit/66031
Commit-Queue: mukesh agrawal <quiche@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/external_task_unittest.cc
|
| e3d4b3cde7c8f4c3f27a88014b64de814dc9acb7 |
|
01-Aug-2013 |
mukesh agrawal <quiche@chromium.org> |
shill: add unit test for ExternalTask::DestroyLater
The new test verifies that DestroyLater defers actual destruction
of the ExternalTask to the event loop.
While there: refactor some code, to reduce duplication across
test cases.
BUG=chromium:246826
TEST=unit tests (old+new)
Change-Id: Idd3ad4e447f2f59132742d6daca5699328e950df
Reviewed-on: https://gerrit.chromium.org/gerrit/64018
Commit-Queue: mukesh agrawal <quiche@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/external_task_unittest.cc
|
| ae30e9e4f9050a5a2c3b18d20f8bd23f20aa8f38 |
|
28-May-2013 |
mukesh agrawal <quiche@chromium.org> |
shill: create external_task abstraction
This moves code out of L2TPIPSecDriver into a new ExternalTask
class, and updates the L2TPIPSecDriver code appropriately.
While there:
- fix a couple bug in L2TPIPSecDriverTest::ExpectInFlags.
(The function was returning early, and not checking the value
of the flag.)
- remove RpcTask::GetRpcInterfaceIdentifier, since the only
place it was called from was a test.
BUG=chromium:209938
TEST=unit tests, manual
Manual test
-----------
- connect to CrOS_WPA2_Buffalo2_AG300H_2.4GHz
- /usr/local/lib/flimflam/test/connect-vpn l2tpipsec-psk \
Cisco-ASA-173 172.22.22.173 \
Cisco-ASA-173 chromeos_psk \
CrOS_Password <password>
- check that ppp0 has an IP address
- egrep "l2tpipsec_vpn.+pppd: local" /var/log/net.log
(should match)
Change-Id: I54aed25f14597d0324249aaddba2095d296ded7d
Reviewed-on: https://gerrit.chromium.org/gerrit/57193
Reviewed-by: Darin Petkov <petkov@chromium.org>
Commit-Queue: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/external_task_unittest.cc
|