| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/mock_service.cc
|
| 1e006c610db980bca337121134d2ba54497b7a59 |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Top-level mocks: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: I730ed5115e62319c2745dd6cef642e228b0fb66e
Reviewed-on: https://chromium-review.googlesource.com/278036
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| a0ddf46e466bd4ba3d20952f0a6988c680c1af14 |
|
06-Feb-2014 |
Ben Chan <benchan@chromium.org> |
shill: Update to build against libchrome-242728.
BUG=chromium:341521
CQ-DEPEND=CL:193660
TEST=Tested the following:
1. `FEATURES=test USE='cellular wimax' emerge-$BOARD platform2`
2. Run the following tests:
- network_3GSmokeTest
- network_VPNConnect.*
- network_WiMaxSmoke
- wifi_matfunc
Change-Id: Ic1553c182ab7a833a68c45f012f646b8930cb095
Reviewed-on: https://chromium-review.googlesource.com/193606
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 457728b3eeb2d67c980e0d20675f0a0f750903e1 |
|
09-Jan-2013 |
Darin Petkov <petkov@chromium.org> |
shill: Log service's unique name rather than friendly name.
This way we consistently identify the service throughout shill's logs
as well as alleviate PII concerns due to SSIDs leaking into
logs. Renamed Service::UniqueName() to Service::unique_name(), per
style. Made Service::friendly_name() protected to limit its accidental
use.
BUG=chromium-os:37679
TEST=unit tests, tested on device and inspected logs
Change-Id: Idcdba75875a9d10cda51b714730ef633876481c6
Reviewed-on: https://gerrit.chromium.org/gerrit/40926
Tested-by: Darin Petkov <petkov@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Darin Petkov <petkov@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| bfb825563ecdf282162dfb4e43ded89c99b0fbb5 |
|
25-Oct-2012 |
Paul Stewart <pstew@chromium.org> |
shill: Properly return and emit WatchedServices property
Instead of copying the "Services" property, properly return a list
of services that are in a non-"Idle/Failure/Unknown" state. Also
emit this as a PropertyChange signal in Manager::SortServices.
Also fix a long-standing bug where EnumerateAvailableServices returned
invisble servces.
While we're here, add unit tests that assert that when a Service
state is changed, this eventually causes the above property changes
to be emitted.
BUG=chromium-os:35700,chromium-os:35701
TEST=Unit tests
Change-Id: Ifc3487f1e4856372d88da428e10d0fb40f7efd3e
Reviewed-on: https://gerrit.chromium.org/gerrit/36505
Reviewed-by: Gaurav Shah <gauravsh@chromium.org>
Commit-Ready: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 053fa82aad4ce9bc99ab3dc278d4e12ab0be14c0 |
|
05-Jun-2012 |
Joshua Kroll <joshkroll@chromium.org> |
Remove TechnologyIs method from the Service class and its subclasses. This is step 1 in removing the method altogether.
BUG=chromium-os:29696
TEST=Ran the shill unit tests.
Change-Id: I793cddee870afbdae778b1ea0527ad2398481411
Reviewed-on: https://gerrit.chromium.org/gerrit/24524
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Joshua Kroll <joshkroll@chromium.org>
Commit-Ready: Joshua Kroll <joshkroll@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| ce4ec19216ccd15ae349ee42498657afc2c75bd8 |
|
14-Mar-2012 |
Paul Stewart <pstew@chromium.org> |
shill: vpn: Pin route on default connection
If "trusted_ip" and "gateway" are both specified in the OpenVPN
config, pin a host route to the VPN server. As a bonus change,
add a MockService::connection() and supply a default value so
Service does not need to befriend so many tests.
BUG=chromium-os:27483
TEST=New unit tests
Change-Id: I010fca6336b227c4086efb0481dcb8052245213e
Reviewed-on: https://gerrit.chromium.org/gerrit/18155
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
Commit-Ready: Darin Petkov <petkov@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 1b2531423a15ccc5ac5acaf09edac9a687902dfa |
|
26-Jan-2012 |
Paul Stewart <pstew@chromium.org> |
shill: Implement more of Profile DBus interface
Return a DBus path from Manager.GetActiveProfile().
Implement the "Profiles" property on the manager Manager.
Fix the "Entries" property on the Profile to only report group
identifiers that correspond to technologies (not ipconfig,
devices, etc).
Fix the "Services" Profile property, to only appear as a property
of the active profile.
BUG=chromium-os:25538, chromium-os:23702
TEST=Manual: Running "list-profiles" from the flimflam test suite now
works correctly.
Change-Id: I3120fe54f02662822186ac033fab0b3566449705
Reviewed-on: https://gerrit.chromium.org/gerrit/14904
Commit-Ready: Paul Stewart <pstew@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 3426c8fc7a3943f2d8fcb2ec78f0593088b42bed |
|
12-Jan-2012 |
Thieu Le <thieule@chromium.org> |
shill: Move Metrics from singleton to Shill daemon
While implementing chromium-os:24810, it was discovered that Metrics is
cleaner if it is passed around like ControlInterface, Dispatcher,
Manager, etc. This approach also makes Metrics more testable.
BUG=chromium-os:24810
TEST=Unit tests, network_WiFiManager suite
Change-Id: I556a1bd11f21f0b93ecfeaae8855dfb99ed5e5f9
Reviewed-on: https://gerrit.chromium.org/gerrit/14099
Commit-Ready: Thieu Le <thieule@chromium.org>
Reviewed-by: Thieu Le <thieule@chromium.org>
Tested-by: Thieu Le <thieule@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 8a3188dbc04245c17a4729d16a632547ce4bf585 |
|
01-Dec-2011 |
mukesh agrawal <quiche@chromium.org> |
shill: improve conformance with WiFiRoaming tests
This patch makes several changes to get shill passing more of
the WiFiRoaming suite. shill now passes 13 of the 18 tests.
Overview of changes:
- Clean up Services when their last Endpoint disappers.
- Make a new WiFi connection request pre-empt an existing one.
- Make Device::SelectService no-op if new service is same as old.
(part of resolving crosbug.com/23703)
- Move auto-connect logic to its own function, and run that function
in a deferred task (partly resolves crosbug.com/24276)
- Add a non-deferred variant of Service::Connect (part of resolving
crosbug.com/24276).
- Have service sort order reflect whether or not services are
connecting, failed, connectable, and configured for auto-connect.
BUG=chromium-os:24276,chromium-os:23223,chromium-os:22943,chromium-os:23703
TEST=WiFiRoaming, unit tests, manual
Manual testing: per https://gerrit.chromium.org/gerrit/12963
Collateral changes:
- updated TESTING
- added crosbug.com/24461 for problem with autotest and profiles
- declared some functions as const
- removed some useless comments
Change-Id: I36d6eb7108a377dbf409d3e5673deffb85c0633e
Reviewed-on: https://gerrit.chromium.org/gerrit/12687
Reviewed-by: Thieu Le <thieule@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
Commit-Ready: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 48e6d6d0ec0f90d9b2206f60c1ff2a825c5ce9c1 |
|
06-Dec-2011 |
Thieu Le <thieule@chromium.org> |
shill: Add preliminary UMA support
Add preliminary UMA framework and support for common service metrics and one
WiFi metric (Network.Shill.WiFi.Channel) so we can thrash out how the
metrics fit in the current code. Other metrics will be added in the
future and are tracked by separate bugs.
BUG=chromium-os:22062
TEST=Unit tests
Change-Id: If3dc6da2e66e846e2178a1700b2576218b90abda
Reviewed-on: https://gerrit.chromium.org/gerrit/12474
Commit-Ready: Thieu Le <thieule@chromium.org>
Reviewed-by: Thieu Le <thieule@chromium.org>
Tested-by: Thieu Le <thieule@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 435de2cd55a95836381b53acbce8cbbad98ec04d |
|
18-Nov-2011 |
Gaurav Shah <gauravsh@chromium.org> |
Implement {Available|Connected|Enabled}Technolgies and DefaultTechnology
This is Part 1 of a series of changes required for the Manager to generate
the right set of DBus events allowing shill to properly tell Chrome about
connectivity.
Some other side-effects in the change (needed to implement the above):
- Emit these manager properties over DBus everytime we re-sort the Service
vector.
- Add a technology data member to Device, this allows easy enumeration of
technologies.
- Add interface for getting a handle to the selected service on a device.
- Map connected state to online instead of ready state. This is needed for
so that Chrome doesn't wait for the portal detection code to switch the
state from ready->online.
- Default set the ethernet service as connectable.
BUG=chromium-os:14887
TEST=1) manual test to verify shill properly configures the ethernet
device and Chrome correctly detects that.
2) new unit tests
Change-Id: Ib10f2f0836f8d4aacaad1491f58ed9b3b5d37e7d
Reviewed-on: https://gerrit.chromium.org/gerrit/12019
Tested-by: Gaurav Shah <gauravsh@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 6515aabcd1fbbb9ff2090c9675c17eeef64e7474 |
|
13-Oct-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Make profiles backed with StoreInterfaces
Rely on persistence of data in StoreInterface to maintain
Service/Device/IPConfig info for entities that are not
currently active, instead of maintaining lists in Profile
objects themselves.
BUG=chromium-os:17253
TEST=unit, run on device
Change-Id: I206f44ddf16c584354f8fcadb57032f047f33d0a
Reviewed-on: http://gerrit.chromium.org/gerrit/10024
Commit-Ready: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 22aa71b334c716f20999c2e08e5b797207b0afae |
|
16-Sep-2011 |
Paul Stewart <pstew@chromium.org> |
shill: Implement service sorting
Sort the list of Services for presentation to
RPC callers, essentially copying the current flimflam
sorting criteria. Introduce the TechnologyOrder to
the Manager.
BUG=chromium-os:20114
TEST=New unit tests
Change-Id: I766b2297ba3170a7a6ab5adfe68425a8011be4fb
Reviewed-on: http://gerrit.chromium.org/gerrit/8205
Tested-by: Paul Stewart <pstew@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 7a4e4008dc09effe39c94a5f9575644a79ee1388 |
|
06-Sep-2011 |
mukesh agrawal <quiche@chromium.org> |
shill: implement Manager.GetService (error-case only)
BUG=chromium-os:20254
TEST=unittests, WiFiManager/000_SSID_Length_Limit
this gives us enough to pass the autotest for
network_WiFiManager/000_SSID_Length_Limit.
Change-Id: Ib0305e707d2203327d846be3e0b206033d6a884a
Reviewed-on: http://gerrit.chromium.org/gerrit/7567
Commit-Ready: mukesh agrawal <quiche@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 51a7e939ed0d260392a40bc5d58e6d2651c6ddc0 |
|
28-Jul-2011 |
mukesh agrawal <quiche@chromium.org> |
shill: push service naming down into Service class (instead of being
handled in each subclass)
BUG=chromium-os:17974
TEST=FEATURES="test nostrip noclean" emerge-x86-generic shill, and run on device
Change-Id: Ic251fec9c76fec1a4c3aa5ac8d0aba4c664e029d
Reviewed-on: http://gerrit.chromium.org/gerrit/4927
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 6791a43add38926966bd420e89541717fb2cb2b5 |
|
12-Jul-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Enable Profile objects to manage a list of Services to persist.
The Manager will hang on to a list of active services. They will be sorted,
someday, in an order that makes sense. Every service will be associated with
a Profile, though it may the an ephemeral profile that won't persist state to
disk. Profiles will maintain a map of service name to service references to
track the services whose state they persist to disk. Services may move between
Profiles, and will certainly need to be bound to one after they are registered
with the Manager, so support for this is provided as well.
BUG=chromium-os:17436
TEST=unit tests
Change-Id: Id43a0e1d97302b6f574bd2213d4f3d176bb5223f
Reviewed-on: http://gerrit.chromium.org/gerrit/4033
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| b2e326bf37654683cdc8c0cbbab29d1af7910af8 |
|
12-Jul-2011 |
Chris Masone <cmasone@chromium.org> |
Re-land "[shill] Get rid of Entry as a first-class citizen""
This reverts commit 7c1ab1cb74bf6397c67e1cdc825043a93c4bce33.
Also, fixes some compile problems that only repro with debug flags
and that cause runtime dbus errors with the new version of libdbus
BUG=chromium-os:17436
TEST=unit tests
Change-Id: I479308e684b802f167788daeaf4ec39d0b63ee17
Reviewed-on: http://gerrit.chromium.org/gerrit/3961
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Darin Petkov <petkov@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 7c1ab1cb74bf6397c67e1cdc825043a93c4bce33 |
|
12-Jul-2011 |
Chris Masone <cmasone@chromium.org> |
Revert "[shill] Get rid of Entry as a first-class citizen"
This reverts commit 7c982eade99f01cb6b8719ed4d385c0ec6b50f75
Change-Id: I554c12003c18f09ac7f736e98b9ecd63829100e9
Reviewed-on: http://gerrit.chromium.org/gerrit/3957
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 9c9e8fb31c9b39fb2832e0804d5c71b3ef685427 |
|
12-Jul-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Get rid of Entry as a first-class citizen
Entry was a bad idea. Instead, merge that stuff back into Service and
make Profile objects just have a list of Services. Live Services will
be registered with Manager; ones that exist only within a Profile will
have to be accessed by querying the Profile over DBus, just like
today.
BUG=chromium-os:17436
TEST=unit tests
Change-Id: Id07d762925b252219aa79340931e34b87f10007e
Reviewed-on: http://gerrit.chromium.org/gerrit/3951
Reviewed-by: Darin Petkov <petkov@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 7aa5f90848b530999d8b6788ecb40aa30871c7ae |
|
11-Jul-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Back property storage in Service objects with Entry objects
Much of Shill Service state is persisted to disk, by creating an Entry
in a Profile. We should store this info just once, so that we don't
have to worry about keeping multiple data stores in sync. This is a
first step in that direction.
BUG=chromium-os:17436
TEST=unit tests
Change-Id: If94db2a38a7d79c56e2c746b2f069cfd7ab4bf65
Reviewed-on: http://gerrit.chromium.org/gerrit/3876
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Darin Petkov <petkov@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| 2b10554b6c736f3421102d483b74b70bb82f997c |
|
22-Jun-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Use ref-counted pointers more, break unneeded header deps
1) Replace more bare pointers with ref-counted pointers.
2) Move declarations of *RefPtr into a header file with fwd-declared classes
3) Make class headers include that, move inclusion of real headers to .cc files.
BUG=None
TEST=unit tests
Change-Id: I8208c82377c6dbefe6903561a503b8db63f063d6
Reviewed-on: http://gerrit.chromium.org/gerrit/3177
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| e0dea765d1f41c43aa6fcd094dff84393451843c |
|
09-Jun-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] FindService should return a ServiceRefPtr, and should always return something
We weren't explicitly returning a value from FindService on failure,
which was causing a unit test to pass erroneously. Once I fixed it,
the test started failing because of a dumb thing I was doing in
MockService. So, fix that so that the tests can pass as they should.
BUG=None
TEST=unit tests
Change-Id: Ice304e514ea0e3add779ac061b0945b5712dea29
Reviewed-on: http://gerrit.chromium.org/gerrit/2374
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| c1e50412f45518e23d51ba8bb8694c366943d945 |
|
07-Jun-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Start replacing bare pointers with scoped_refptrs where appropriate
BUG=chromium-os:16259
TEST=unit tests
Change-Id: I5e1531b726bbb40917d25dc3ae44da9a6a420e00
Reviewed-on: http://gerrit.chromium.org/gerrit/2236
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Darin Petkov <petkov@chromium.org>
/system/connectivity/shill/mock_service.cc
|
| a82b7111f2b0515a8d79e6e8034836a5d1342468 |
|
26-May-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] device, service objects need to register unique paths
BUG=chromium-os:15752
TEST=unit tests
Change-Id: I54a5b1fb3e156fb62ffff0bc49a411135c01a1d0
Reviewed-on: http://gerrit.chromium.org/gerrit/1897
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/mock_service.cc
|