| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/result_aggregator_unittest.cc
|
| a92b0a0438803ebb3432d7b42672fbb7fb6bccf4 |
|
13-Aug-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: usage of EventDispatcherForTest and NullRPCIdentifier
Switch tests to use EventDispatcherForTest instead of EventDispatcher,
since EventDispatcher no longer owns a message loop.
Update references for DBusAdaptor::kNullPath to
ControlInterface::NullRPCIdentifier, since RPC identifier is specific
to control interface and opaque to the internal code.
BUG=chromium:517680
TEST=unittests
Change-Id: Ia932143e433b44c84bd176baac660d1fa75261d8
Reviewed-on: https://chromium-review.googlesource.com/293550
Commit-Ready: Zeping Qiu <zqiu@chromium.org>
Tested-by: Zeping Qiu <zqiu@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/result_aggregator_unittest.cc
|
| fa3043cd7dfabf084ee2daa177d197cf67fd3cd6 |
|
17-Jul-2015 |
Samuel Tan <samueltan@chromium.org> |
shill: refactor ErrorType matcher to shill/testing.h
Refactor the ErrorType matcher, which is used in several
shill unit tests, to shill/testing.h. Also, rename the matcher
to ErrorTypeIs to be consistent with other matchers in the
same file.
BUG=None.
TEST=Compile shill and run unit tests.
Change-Id: Iffe5096f3cad1ae3c91d46f6ad5257590c38c090
Reviewed-on: https://chromium-review.googlesource.com/286540
Tested-by: Samuel Tan <samueltan@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Samuel Tan <samueltan@chromium.org>
/system/connectivity/shill/result_aggregator_unittest.cc
|
| 3b30ca58d13cf66b75ba0729b222ddc42ae68b33 |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Top-level unit tests: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: I86c072b89281e0de18928b47860b99d779af061a
Reviewed-on: https://chromium-review.googlesource.com/278037
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/result_aggregator_unittest.cc
|
| cc225ef3b77b5e098cc12c661a947e1737480777 |
|
30-Sep-2014 |
Ben Chan <benchan@chromium.org> |
shill: Replace NULL with nullptr.
BUG=None
TEST=`USE=wimax FEATURES=test emerge-$BOARD shill`
Change-Id: I30ab47ff32dcadad09ae7a2baf4d4123a6ef0d8e
Reviewed-on: https://chromium-review.googlesource.com/220657
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/result_aggregator_unittest.cc
|
| 7c1aacb5cb9b6f960fe7702f40a0c7715e7b12b3 |
|
16-Sep-2014 |
Samuel Tan <samueltan@chromium.org> |
shill: add timeout support for ResultAggregator
Add a new ResultAggregator constructor, which takes a
callback, event dispatcher, and timeout duration as
parameters. If the operation does not complete (i.e.
ResultAggregator is not destructed) within the specified
time duration, ReusltAggregator will invoke the callback
with the error kOperationTimeout.
BUG=chromium:414524
TEST='P2_TEST_FILTER="shill::* FEATUERS="test" USE="clang asan"
emerge-squawks platform2' succeeds.
Change-Id: I057cd7c1b4864283507952d2ef6a18255fcda32e
Reviewed-on: https://chromium-review.googlesource.com/218328
Reviewed-by: Samuel Tan <samueltan@chromium.org>
Tested-by: Samuel Tan <samueltan@chromium.org>
Commit-Queue: Samuel Tan <samueltan@chromium.org>
/system/connectivity/shill/result_aggregator_unittest.cc
|
| 46c27cc8f83428ce6b290c4d92e73fbcad899457 |
|
11-Jul-2013 |
mukesh agrawal <quiche@chromium.org> |
shill: fix DisableTechnology with multiple devices of a technology
For some Devices (e.g. Cellular), EnableTechnology and DisableTechnology are
asynchronous operations. Previously, shill would invoke the completion
callback for these operations, as each Device completed its work.
Unsurprisingly, this would fail on the second device.
Fix this by introducing ResultAggregator, which aggregates the results from
multiple asynchronous operations. Now, if the Devices process
EnableTechnology or DisableTechnology asynchronously, then we will return
only after the final Device has completed the request.
While there: merge the code for EnableTechnology and DisableTechnology,
since the methods were symmetric, but non-trivial.
Note that one ugly case remains: if one or more Devices fails immediately,
but others all succeed asynchronously, we will not report any failure.
BUG=chromium:258206
TEST=new unit tests, manual
Manual testing
--------------
- grab a device with two cellular modems (e.g. on-board and usb)
- disable cellular from the ash tray
-> shill should not crash
- enable cellular from the ash tray
-> shill should not crash
Change-Id: I09f94326342900e4cee6929d9edbe5cf735c92d7
Reviewed-on: https://gerrit.chromium.org/gerrit/62016
Commit-Queue: mukesh agrawal <quiche@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/result_aggregator_unittest.cc
|