39910dcd1d68987ccee7c3031dc269233a8490bb |
|
10-Nov-2015 |
Alex Deymo <deymo@google.com> |
Split payload application code into a subdirectory. This patch splits from the main libupdate_engine code the part that is strictly used to download and apply a payload into a new static library, moving the code to subdirectories. The new library is divided in two subdirectories: common/ and payload_consumer/, and should not depend on other update_engine files outside those two subdirectories. The main difference between those two is that the common/ tools are more generic and not tied to the payload consumer process, but otherwise they are both compiled together. There are still dependencies from the new libpayload_consumer library into the main directory files and DBus generated files. Those will be addressed in follow up CLs. Bug: 25197634 Test: FEATURES=test emerge-link update_engine; `mm` on Brillo. Change-Id: Id8d0204ea573627e6e26ca9ea17b9592ca95bc23
/system/update_engine/omaha_request_params.h
|
d942f9d3c8529f896329b19261df6eba044de1b2 |
|
07-Nov-2015 |
Alex Deymo <deymo@google.com> |
Return the error reason to the caller of SetTargetChannel. This patch sends back to the caller an error message indicating why the channel change didn't work. Bug: 25595865 Test: Deployed on a device and attempted to change to "foo" channel. Error message lists available channels. Test: FEATURES=test emerge-link update_engine Change-Id: Idcc67d5c7878ce7af60652d7bf5bf81135325f97
/system/update_engine/omaha_request_params.h
|
3be05c82442b2fbab693b6399f64610e8542462b |
|
23-Oct-2015 |
Alex Deymo <deymo@google.com> |
Fix use-after-free in unittest setup code. When setting the root prefix in a unittest, we need to reset it after so it isn't accidentally used by other tests. Bug: chromium:547127 Test: USE="clang asan" FEATURES=test emerge-link update_engine Change-Id: Ib84bbf265a380976407100a4fba4d2600d62dde6
/system/update_engine/omaha_request_params.h
|
856166594771c61973856f563e622ccb7dd48aa1 |
|
16-Oct-2015 |
Alex Deymo <deymo@google.com> |
Read ProductId, ProductVersion and Channel setting in Brillo. The ProductId, ProductVersion and current/target channels are specified in a very different way in Brillo compared to Chrome OS. This patch moves the logic to read and parse /etc/lsb-release in Chrome OS to a new image_properties module and implements the equivalent module in Brillo. This new module replaces some of the logic previously in the OmahaRequestParams class, both for parsing the read-only properties from the rootfs and parsing and storing the target channel in the stateful partition. The Chrome OS version of the new module keeps the same behavior, except that it falls back to "stable-channel" if the the current channel is missing in the rootfs (unlikely in Chrome OS). On the other hand, the new Brillo implementation reads these settings from the /etc/osrelease file and /etc/osrelease.d directory and doesn't allow to override those setting during development. The persisted target_channel and powerwash_allowed settings are stored in Prefs as many other settings. Finally, since Brillo images don't contain a channel name baked in the image, we store the channel name where we got the image from at the time of the update. The first boot after provisioning will default to "stable-channel". Bug: 25013069 Test: unittest in Chrome OS; `mm` and tested on a Brillo device. Change-Id: Icc114b8098af3edaaba715c9c2e3ebe9f417c876
/system/update_engine/omaha_request_params.h
|
ac41a82e4be1be43913292d13d58b5eb2c572f53 |
|
16-Sep-2015 |
Alex Deymo <deymo@google.com> |
Set default updater URL and version per platform. Chrome OS and Brillo devices require different production update URL and updater string ID sent to Omaha. This patch moves these constants to a platform-dependent file with the definition of the constants. Bug: brillo:587,brillo:588 Test: FEATURES=test emerge-link update_engine; `mma`; deployed on a dragonboard. Change-Id: Ibe3b30c32c2fb2caf3ed10a4198272dc13a44d12
/system/update_engine/omaha_request_params.h
|
aea4c1cea20dda7ae7e85fc8924a2d784f70d806 |
|
20-Aug-2015 |
Alex Deymo <deymo@google.com> |
Re-license update_engine to Apache2 This patch automatically replaced the license on all text files from Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as a reference. The license header was added to .gyp and .gypi files, the NOTICE was replaced with a copy of the Apache2 license and MODULE_LICENSE_* file was updated. BUG=b/23084294 TEST=grep 'Chromium OS Authors' doesn't find anything. Change-Id: Ie5083750755f5180a8a785b24fe67dbf9195cd10
/system/update_engine/omaha_request_params.h
|
02c1864e204997175302b1aebe3e0be9c6699ea5 |
|
06-Nov-2014 |
David Pursell <dpursell@chromium.org> |
update_engine: Allow `cros flash` on base images. A goal of the upcoming debugd dev tools (crbug.com/403170), is to enable a path to modify a base image such that a developer could run `cros flash` on it. Currently update_engine disallows custom omaha URLs and forces a hash check for base builds, which breaks `cros flash`. This CL relaxes the restriction slightly to allow use on a base build as long as the system is in dev mode and the debugd dev tools are also enabled (dev tools are currently enabled only in dev mode when there is no owner). The check is done in update_attempter.cc, which only allows an unofficial Omaha URL if these conditions hold true (unofficial meaning not the main AU server or the AU test server). The other main change is AreHashChecksMandatory() in omaha_response_handler_action.cc, which now allows skipping hash checks for unofficial Omaha URLs. BUG=chromium:428053 TEST=Ran unit tests, `cros flash` on base images in various states. CQ-DEPEND=CL:227431 Change-Id: I8583ce6aa70feac8fe74b7a3992e8a4e761833c3 Reviewed-on: https://chromium-review.googlesource.com/228293 Reviewed-by: Alex Deymo <deymo@chromium.org> Trybot-Ready: David Pursell <dpursell@chromium.org> Commit-Queue: David Pursell <dpursell@chromium.org> Tested-by: David Pursell <dpursell@chromium.org>
/system/update_engine/omaha_request_params.h
|
e89487039d0eca8130d822cabf75a729609509e0 |
|
12-Nov-2014 |
Alex Deymo <deymo@chromium.org> |
update_engine: Enforce virtual destructors on virtual classes. This patch enables -Wnon-virtual-dtor enforcing that virtual classes such as interfaces have a virtual destructor. This is required by the Google Coding Style and avoids some problems where the derived class' destructor is not called. BUG=None TEST=FEATURES=test emerge-link update_engine Change-Id: Id907e3c14923fcccc20b83bd064fa9c9c51fffb3 Reviewed-on: https://chromium-review.googlesource.com/228927 Commit-Queue: Alex Deymo <deymo@chromium.org> Tested-by: Alex Deymo <deymo@chromium.org> Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
/system/update_engine/omaha_request_params.h
|
74b5f55e6ff608857664fe151f54d78bfe0b75bb |
|
07-Oct-2014 |
Gilad Arnold <garnold@chromium.org> |
update_engine: Relocate inference and storage of P2P related properties. This change moves the inference of P2P related properties from OmahaRequestAction to OmahaResponseHandlerAction, and their storage from OmahaRequestParams to PayloadState. This is needed in order for the UpdateCanStart policy to be able to decide P2P properties, which only happens after the Omaha response is received and processed, and prior to applying the update. Further, P2P properties do not affect the Omaha request, and so there's no reason for them to reside in OmahaRequestParams nor decided as early as OmahaRequestAction. Additional cleanup includes swapping expected/actual arguments to EXPECT macros where appropriate, and removing redundant .Times(1) expectation qualifiers. BUG=chromium:384087 TEST=Unit tests. Change-Id: I6d5b4b44745d5dab7e350bdf019dbf804bf196a1 Reviewed-on: https://chromium-review.googlesource.com/223618 Reviewed-by: Gilad Arnold <garnold@chromium.org> Commit-Queue: Gilad Arnold <garnold@chromium.org> Tested-by: Gilad Arnold <garnold@chromium.org>
/system/update_engine/omaha_request_params.h
|
560ae1da0e62f7897699f63631452f0c4144d413 |
|
28-Oct-2014 |
Alex Deymo <deymo@chromium.org> |
update_engine: Mock out UpdateAttempter and OmahaRequestParams. These classes are used by other classes so we need to have a way to unit test those. This patch converts some public methods on these classes to virtual methods so they can be mocked. It implements a new MockOmahaRequestParams with all the public methods behaving like the real object by default. This is now the default class used by the FakeSystemState. Finally, the UpdateAttempterMock is renamed to MockUpdateAttempter to be more consistent with other classes in the project. BUG=None TEST=Unittest pass. Follow up CL using these classes also passes. Change-Id: Iacb7e19d10c1526cea9659c27ab798cad126816f Reviewed-on: https://chromium-review.googlesource.com/225855 Reviewed-by: Alex Deymo <deymo@chromium.org> Commit-Queue: Alex Deymo <deymo@chromium.org> Tested-by: Alex Deymo <deymo@chromium.org>
/system/update_engine/omaha_request_params.h
|
afd70ed1393d936579acbd9242c326be47213a69 |
|
01-Oct-2014 |
Gilad Arnold <garnold@chromium.org> |
update_engine: Remove legacy logic and tests. This removes logic that was used for tracking whether updates were disabled by device policy, and unit tests that checked for the presence of such logic. This logic is now part of the Update Manager's UpdateCheckAllowed policy request. It is safe to remove the old check because it'll always conclude that the update request can be sent, given that the said policy has concluded the same. BUG=None TEST=Unit tests. Change-Id: Ibbb3728f7239f608a6317bc5a8b76cac7f54bc5f Reviewed-on: https://chromium-review.googlesource.com/220876 Reviewed-by: Alex Vakulenko <avakulenko@chromium.org> Commit-Queue: Gilad Arnold <garnold@chromium.org> Tested-by: Gilad Arnold <garnold@chromium.org>
/system/update_engine/omaha_request_params.h
|
05735a1879a553153458aae0a25fa5d42e3e408f |
|
03-Sep-2014 |
Ben Chan <benchan@chromium.org> |
update_engine: Include base/macros.h instead of base/basictypes.h update_engine no longer uses the integer types from base/basictypes.h. It should simply include base/macros.h for the DISALLOW_COPY_AND_ASSIGN macro instead. BUG=None TEST=`FEATURES=test emerge-$BOARD update_engine` Change-Id: Idf18bc69339b7170122b289342c724c862454062 Reviewed-on: https://chromium-review.googlesource.com/216140 Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Alex Deymo <deymo@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org>
/system/update_engine/omaha_request_params.h
|
88b591f24cb3f94f982d7024c2e8ed25c2cc26a2 |
|
29-Aug-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
update_engine: Replace NULL with nullptr Replaced the usage of NULL with nullptr. This also makes it possible to use standard gtest macros to compare pointers in Update Manager's unit tests. So, there is no need in custom UMTEST_... macros which are replaced with the gtest macros (see change in update_engine/update_manager/umtest_utils.h): UMTEST_ASSERT_NULL(p) => ASSERT_EQ(nullptr, p) UMTEST_ASSERT_NOT_NULL(p) => ASSERT_NE(nullptr, p) UMTEST_EXPECT_NULL(p) => EXPECT_EQ(nullptr, p) UMTEST_EXPECT_NOT_NULL(p) => EXPECT_NE(nullptr, p) BUG=None TEST=FEATURES=test emerge-link update_engine USE="clang asan" FEATURES=test emerge-link update_engine Change-Id: I77a42a1e9ce992bb2f9f263db5cf75fe6110a4ec Reviewed-on: https://chromium-review.googlesource.com/215136 Tested-by: Alex Vakulenko <avakulenko@chromium.org> Reviewed-by: Alex Deymo <deymo@chromium.org> Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/update_engine/omaha_request_params.h
|
9abb763fa3840d69cc1098c0233162557a7f99ea |
|
07-Aug-2014 |
Ben Chan <benchan@chromium.org> |
update_engine: Use integer types from stdint.h This CL replaces the deprecated int* and uint* types from 'base/basictypes.h' with the int*_t and uint*_t types from 'stdint.h'. BUG=chromium:401356 TEST=`FEATURES=test emerge-$BOARD update_engine` Change-Id: I658b34ad9e6feb938e0b569b72947a052ef8f8af Reviewed-on: https://chromium-review.googlesource.com/211380 Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org>
/system/update_engine/omaha_request_params.h
|
072359ca138504065e1e0c1189eb38c09576d324 |
|
18-Jul-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
update_engine: fixed remaining linter and some spelling errors Fixed remaining errors from cpplint as well as some spelling errors mostly in comments. BUG=None TEST=FEATURES=test emerge-link update_engine Change-Id: I484988ab846ac5a3c68c016ddccfb247f225ec27 Reviewed-on: https://chromium-review.googlesource.com/208897 Reviewed-by: Alex Vakulenko <avakulenko@chromium.org> Commit-Queue: Alex Vakulenko <avakulenko@chromium.org> Tested-by: Alex Vakulenko <avakulenko@chromium.org>
/system/update_engine/omaha_request_params.h
|
cf175a098081f3f0e9ca52d997a7ce1585c14c2d |
|
11-Jul-2014 |
Gilad Arnold <garnold@chromium.org> |
Fix cpplint errors. The only non-obvious change here is the switch from dynamic_cast to static_cast in three cases of down-casting in UpdateAttempter. dynamic_cast is banned by style, nor does it add any safety in this particular case (subsequent code dereferences the result right away without checking whether it's null). BUG=None TEST=None Change-Id: I9d49b46362feaf9c6fa13b2715ebe9fe50308a9a Reviewed-on: https://chromium-review.googlesource.com/207470 Tested-by: Gilad Arnold <garnold@chromium.org> Reviewed-by: Alex Vakulenko <avakulenko@chromium.org> Commit-Queue: Gilad Arnold <garnold@chromium.org>
/system/update_engine/omaha_request_params.h
|
d2779df63aaad8b65fc5d4badee7dbc9bed7f2b6 |
|
16-Jun-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
update_engine: fixed warnings from cpplint Fixed all the cpplint warnings in update engine. BUG=None TEST=Unit tests still pass. Change-Id: I285ae858eec8abe0b26ff203b99a42a200ceb71c Reviewed-on: https://chromium-review.googlesource.com/204027 Reviewed-by: Alex Vakulenko <avakulenko@chromium.org> Tested-by: Alex Vakulenko <avakulenko@chromium.org> Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/update_engine/omaha_request_params.h
|
76b2b4822d57360d0c77f070bd8fc25bc08fd93e |
|
01-Apr-2014 |
Gilad Arnold <garnold@chromium.org> |
Fix/extend unit test related functionality. * Adds mock methods to UpdateAttempterMock and turning corresponding base methods into a virtual (needed for subsequent unit testing). * Adds a setter to OmahaRequestParams. * Limited general cleanup. BUG=chromium:346914 TEST=Unit tests. Change-Id: I0519ad5c43ddebabc1aff6585cf43a290a2081dc Reviewed-on: https://chromium-review.googlesource.com/192660 Reviewed-by: Alex Deymo <deymo@chromium.org> Commit-Queue: Gilad Arnold <garnold@chromium.org> Tested-by: Gilad Arnold <garnold@chromium.org>
/system/update_engine/omaha_request_params.h
|
75039d7397f03dff77bdf4e26398049ff88edc4c |
|
25-Mar-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
update_engine: update to libbase 242728 Made update_engine link with libchrome-242728 and fixed compile issues due to changes in namespaces and include file layout. Also removed some of suppressed compiler warnings and fixed the issues masked by them (e.g. mismatched printf-like specifiers). Added -Wextra compiler option to enable additional useful warnings to ensure more strict checking... Had to disable "unused-parameter" though since we have a lot of functions (mainly in fakes) that do not use all of their parameters. BUG=chromium:351593 TEST=Unit tests passed. CQ-DEPEND=CL:191721 Change-Id: I1aa63a48d5f1f4ea75ba6b00aec7aa5f3bad15c4 Reviewed-on: https://chromium-review.googlesource.com/191510 Reviewed-by: Alex Vakulenko <avakulenko@chromium.org> Commit-Queue: Alex Vakulenko <avakulenko@chromium.org> Tested-by: Alex Vakulenko <avakulenko@chromium.org>
/system/update_engine/omaha_request_params.h
|
759c275760b51defcfe5545abb887ad2616335f4 |
|
18-Mar-2014 |
Alex Deymo <deymo@chromium.org> |
Fix header guards to comply with Google Coding Style. The Google Style Guide says that every header file should have a define guard and the format of the symbol name should be <PROJECT>_<PATH>_<FILE>_H_ This patch does all the minor fixes to comply with this and includes a header guard for the bzip.h file, which didn't have it. Also, the Copyright notice is adjusted to the Chromium OS code, replacing "Chromium Authors" by "Chromium OS Authors". BUG=None TEST=build passes. Change-Id: I6575cc307c464d60a5cb2b132cf1e46acb6500b5 Reviewed-on: https://chromium-review.googlesource.com/190445 Tested-by: Alex Deymo <deymo@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: Alex Deymo <deymo@chromium.org>
/system/update_engine/omaha_request_params.h
|
8f191b22a1a1ab2b803d65ee488729206e648695 |
|
06-Aug-2013 |
David Zeuthen <zeuthen@chromium.org> |
p2p: Use p2p for updates This is the main patch for enabling use of p2p for consuming and/or sharing updates via p2p. Refer to the ddoc and other documentation for how this works. BUG=chromium:260426,chromium:273110 TEST=New unit tests + unit tests pass + manual testing Change-Id: I6bc3bddae1e041ccc176969a651396e8e89cb3f0 Reviewed-on: https://chromium-review.googlesource.com/64829 Reviewed-by: David Zeuthen <zeuthen@chromium.org> Commit-Queue: David Zeuthen <zeuthen@chromium.org> Tested-by: David Zeuthen <zeuthen@chromium.org>
/system/update_engine/omaha_request_params.h
|
968d057f7a37bc981e2a732fb07521cfc8dcb16a |
|
23-Aug-2013 |
Chris Sosa <sosa@chromium.org> |
Never defer updates on interactive checks. Looks like we had a bug when adding the deferred logic. We should never defer on interactive checks as it's really confusing to a user who's doing an interactive check. This change is simple enough but I've changed all unittests that tested deferred behavior to also make sure they allow an update if interactive is set. BUG=chromium:274056 TEST=Unittests Change-Id: Ib63dbd20e64bed2da84e68c96291335e00e944a2 Reviewed-on: https://gerrit.chromium.org/gerrit/66864 Reviewed-by: Chris Sosa <sosa@chromium.org> Tested-by: Chris Sosa <sosa@chromium.org> Commit-Queue: Chris Sosa <sosa@chromium.org>
/system/update_engine/omaha_request_params.h
|
28e479c3b08cb4d1280905f5d3510f8ec4ed719c |
|
12-Jul-2013 |
Chris Sosa <sosa@chromium.org> |
Don't allow rollback on the stable-channel. This change explicitly disallows rollback on the stable-channel. BUG=chromium:252539 TEST=unittests + on device. Change-Id: I71caf95daae185790cf9fb0fda790eaf960bbe6b Reviewed-on: https://gerrit.chromium.org/gerrit/61687 Tested-by: Chris Sosa <sosa@chromium.org> Reviewed-by: David Zeuthen <zeuthen@chromium.org> Commit-Queue: Chris Sosa <sosa@chromium.org>
/system/update_engine/omaha_request_params.h
|
c1972483fa3446852b42ce97d1ea43b9caaaf56f |
|
01-May-2013 |
Chris Sosa <sosa@chromium.org> |
Add EC and Firmware Versions to the Omaha Response. This CL adds 2 additional utils methods to get the version for both the fw and ec versions. I've added a unittest to verify these work and piped in the values into the omaha response. BUG=chromium:219871 TEST=Unittests + on device Change-Id: Iadf70fff858988f52797d94bcdb062bb2482bbf3 Reviewed-on: https://gerrit.chromium.org/gerrit/49713 Commit-Queue: Chris Sosa <sosa@chromium.org> Reviewed-by: Chris Sosa <sosa@chromium.org> Tested-by: Chris Sosa <sosa@chromium.org>
/system/update_engine/omaha_request_params.h
|
db0acdfca1ea33987e8b29325f4594417d1fae57 |
|
02-Apr-2013 |
Jay Srinivasan <jaysri@chromium.org> |
Support changing from non-canary to canary channel in update engine. Now that we have added support in lsb-release for both the board appid and canary app id to be specified, we should use the appropriate appid according to the channel from which we want to download the new payload. This change in update engine will enable the change from non-canary to canary channels. This feature when be lit up end to end when the UI for this scenario is ready. BUG=chromium:225866 TEST=Unit tests pass. Tested all channel changes on my ZGB. Change-Id: Ia9c37c72f53f6c69436f0a96e35d2584d84653c8 Reviewed-on: https://gerrit.chromium.org/gerrit/47181 Commit-Queue: Jay Srinivasan <jaysri@chromium.org> Reviewed-by: Jay Srinivasan <jaysri@chromium.org> Tested-by: Jay Srinivasan <jaysri@chromium.org>
/system/update_engine/omaha_request_params.h
|
1c0fe79c7ef2b43946d756b54c8505d2bf48b93b |
|
29-Mar-2013 |
Jay Srinivasan <jaysri@chromium.org> |
Cancel the current download if user chooses a different channel. In my earlier CL, to keep the implementation simple, we disallowed changing a channel until the previous change completed in its entirety. Given that the UI is not going to be updated for M27, such a restriction turned out to be very confusing when playing around with channel changing. So, we decided to implement a simple form of canceling the download if the user selected a different channel while we're downloading the bits. This implementation can easily be extended to support a general form of cancel in the future, if required. This CL also adds validation of libchromeos API calls when interpreting the policy values. It also cleans up some bogus error messages that were logged earlier when we abort a download. BUG=chromium:222617 TEST=All scenarios pass on ZGB. Unit Tests pass. Change-Id: I7cd691fe461d9ce47314299f6e2598944650ee33 Reviewed-on: https://gerrit.chromium.org/gerrit/46095 Commit-Queue: Jay Srinivasan <jaysri@chromium.org> Reviewed-by: Jay Srinivasan <jaysri@chromium.org> Tested-by: Jay Srinivasan <jaysri@chromium.org>
/system/update_engine/omaha_request_params.h
|
ae4697c073b84b260990a141acd53c6806da0708 |
|
19-Mar-2013 |
Jay Srinivasan <jaysri@chromium.org> |
Enhanced channel changing behavior This CL adds a new DBUS API to UpdateEngine called SetTargetChannel to change the current channel of the device with an option to indicate whether to do eventually or immediately. The API will be called with the option to do it immediately in a subsequent CL in Chrome UI. For now the old API (set_track) has been wired up to call the new API to produce the old behavior (i.e. change eventually). The old API will be removed after Chrome UI code stops using it. It's the UI's responsibility to ask the user for confirmation for the powerwash that may happen in some cases and call the API with the appropriate value whether or not the powerwash should happen. For now, we're restricting the changing of channels to only those devices that are on canary-channel or running test builds. This restriction will be lifted off once the UI work is ready to give warning to the users about the powerwash that may happen when they move to a more stable channel. We also enforce ReleaseChannelDelegated and ReleaseChannel policies correctly now as follows: * If ReleaseChannelDelegated is false, SetTargetChannel will fail as we need to honor (only) the ReleaseChannel value in this case. * If ReleaseChannelDelegated is true, we'll allow the SetTargetChannel call to specify. In this case, we'll ignore the value of ReleaseChannel, if any. BUG=chromium-os:39095 TEST=Tested on ZGB by going from canary to dev-channel with and without powerwash. TEST=Existing unit tests have been updated and they pass. TEST=New unit tests have been added. Change-Id: Ifbf806a06e1c30d2f318e94d73735d1812049abd Reviewed-on: https://gerrit.chromium.org/gerrit/44619 Commit-Queue: Jay Srinivasan <jaysri@chromium.org> Reviewed-by: Jay Srinivasan <jaysri@chromium.org> Tested-by: Jay Srinivasan <jaysri@chromium.org>
/system/update_engine/omaha_request_params.h
|
bbdd4909bcd20448ad89aa1e02c936e42aedf548 |
|
11-Jan-2013 |
Gilad Arnold <garnold@chromium.org> |
AU: add an interactive flag to Omaha requests Such a flag can be used to distinguish between user-initiated (interactive) checks and those that are due to background scheduling. In the former case, we may want to suppress the probabilistic throttling that's commonly used with latest releases. This CL piggybacks the new functionality on top of an existing dataflow used for distinguishing between interactive / scheduled checks, only it pushes it further so it is evident in the Omaha request as well. Comes with a unit test for ensuring that the Omaha flag is set as expected. BUG=chromium-os:26594 TEST=Dbus initiated checks correctly tainted Change-Id: Ia2b3ff5ce3a866c64e453557028b8cbd92c1a258 Reviewed-on: https://gerrit.chromium.org/gerrit/41081 Commit-Queue: Gilad Arnold <garnold@chromium.org> Reviewed-by: Gilad Arnold <garnold@chromium.org> Tested-by: Gilad Arnold <garnold@chromium.org>
/system/update_engine/omaha_request_params.h
|
55f50c24c2624487b803ba2f93588494cc69e523 |
|
11-Jan-2013 |
Jay Srinivasan <jaysri@chromium.org> |
Segregate UMA metrics for production scenarios from test scenarios. Currently we separate the UMA metrics only by one category: whether the device is in dev mode or not. In addition, we need to exclude the noise from these two categories: 1. Most of our testing on MP-signed images which are performed with autest. 2. All our hwlab tests run in non-dev mode but they use dev-signed images with dev-firmware keys. So this CL defines additional bit fields to represent these states and if any of these three flags are set, the UMA metric is sent to a DevModeErrorCodes bucket. Thus the NormalErrorCodes bucket will have only the production errors and thus we can monitor more effectively. BUG=chromium-os:37613 TEST=Updated unit tests, ran on ZGB for all scenarios. Change-Id: Id9cce33f09d1cc50cb15e67c731f7548940cbc24 Reviewed-on: https://gerrit.chromium.org/gerrit/41103 Reviewed-by: Chris Sosa <sosa@chromium.org> Commit-Queue: Jay Srinivasan <jaysri@chromium.org> Tested-by: Jay Srinivasan <jaysri@chromium.org>
/system/update_engine/omaha_request_params.h
|
480ddfa079ebd01ed87e495332dec121d9ae781f |
|
02-Jun-2012 |
Jay Srinivasan <jaysri@chromium.org> |
Scatter downloads to reduce bandwidth spikes. Support in update_engine to honor the enterprise policy to scatter the downloading of ChromeOS automatic updates so that we reduce bandwidth spikes caused due to simultaneous downloads of updates by a large number of enterprise devices. This has no effect on consumer devices. BUG=chromeos-29615: Implement scattering of downloads in UpdateEngine TEST=Manually tested all scenarios, Unit tests added for all new code. CQ-DEPEND=I1f56b5516970d5988eebb2cf8f93f6905823801d Change-Id: I4a8f4974467a064d723ab13cbd78b1ca3ceff420 Reviewed-on: https://gerrit.chromium.org/gerrit/21574 Commit-Ready: Jay Srinivasan <jaysri@chromium.org> Reviewed-by: Jay Srinivasan <jaysri@chromium.org> Tested-by: Jay Srinivasan <jaysri@chromium.org>
/system/update_engine/omaha_request_params.h
|
0a70874c61118a2b276edc731ad890c6826be2be |
|
20-Mar-2012 |
Jay Srinivasan <jaysri@chromium.org> |
Implement the update engine portion for new enterprise policies. Enterprises need the ability to stop the auto updates and pin clients to a given target version. This CL adds support for these features in the update_engine. BUG=27307: Implement StopAutoUpdate based on enterprise policy TEST=Added new unit tests, manually tested all cases on ZGB. CQ-DEPEND=I523c3f67e0cb07fd24744dc0a30382ff2fe2128a Change-Id: Id576401afc6d2c93f0e9ece7c6c0ddcf4b1bc00d Reviewed-on: https://gerrit.chromium.org/gerrit/17867 Commit-Ready: Jay Srinivasan <jaysri@chromium.org> Reviewed-by: Jay Srinivasan <jaysri@chromium.org> Tested-by: Jay Srinivasan <jaysri@chromium.org>
/system/update_engine/omaha_request_params.h
|
7fbbe8a9e57ec52f7bc597d0cb607036300ac54c |
|
01-Aug-2011 |
Patrick Dubroy <dubroy@chromium.org> |
Update engine should use the release channel policy if it exists. The release channel (aka update track) can be specified by a device policy. When this is the case, the update engine should use the value specified by the policy instead of the value specified in /etc/lsb-release. BUG=chromium-os:17015 TEST=Added two new tests: - Added test that OmahaRequestParams uses the release channel passed in to it when the value is valid, and otherwise uses /etc/lsb-release. - Added test that the update engine correctly picks up the release channel that's specified by the policy. Change-Id: I2fe03712220bb3286476b12cd1f1b330ad006d7c Reviewed-on: http://gerrit.chromium.org/gerrit/5072 Tested-by: Patrick Dubroy <dubroy@chromium.org> Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
/system/update_engine/omaha_request_params.h
|
f2065b4d77be793fe0a5b4280fe23433cbecaa1b |
|
18-May-2011 |
Darin Petkov <petkov@chromium.org> |
AU: Use crossystem hwid to obtain the hardware class. This is more portable than reading the HWID from the ACPI file and should work on ARM. BUG=chromium-os:15255 TEST=unit tests, ran AU on Cr-48, checked the Omaha update check request Change-Id: I8a2750140da7da99c217a6976f46b1b226696276 Reviewed-on: http://gerrit.chromium.org/gerrit/1078 Tested-by: Darin Petkov <petkov@chromium.org> Reviewed-by: Thieu Le <thieule@chromium.org>
/system/update_engine/omaha_request_params.h
|
10d02dd60d4c4f41f7f4ed92322fa7b597760118 |
|
10-Jan-2011 |
Darin Petkov <petkov@chromium.org> |
AU: Don't allow stateful /etc/lsb-release override in normal boot mode... ... on official images except for the release track. BUG=chromium-os:6244 TEST=unit tests, tested on device Change-Id: I2d2a634c7b5ac7dd4619f52d1f79b6d88c359e46 Review URL: http://codereview.chromium.org/6225001
/system/update_engine/omaha_request_params.h
|
a3df55badfc7dc25792aba1ca6e7ade582b566a7 |
|
15-Nov-2010 |
Darin Petkov <petkov@chromium.org> |
AU: Don't allow deltas if the rootfs track is different than the request track. Currently such deltas are destined to fail because the rootfs hash will be different than the expected hash. BUG=9160 TEST=unit tests, tested on device Change-Id: I588fcedb4a0ae16aca7197f771afab077d78fe05 Review URL: http://codereview.chromium.org/4988002
/system/update_engine/omaha_request_params.h
|
583667b33cb62b97fbbd792d6c830c530d759ec1 |
|
27-Oct-2010 |
Satoru Takabayashi <satorux@chromium.org> |
AU: Implement getting of tracks through GetTrack. Add SetTrack and GetTrack to UpdateEngine.xml as well. BUG=chromium-os:8104 TEST=tested on device with update_engine_client Change-Id: I10ef2552e9280524b3a8d5f232d104a81a114e06 Review URL: http://codereview.chromium.org/4181001
/system/update_engine/omaha_request_params.h
|
49d91329a3a84d7e2b35f6e1ffc8a9b4d478515b |
|
26-Oct-2010 |
Darin Petkov <petkov@chromium.org> |
AU: Implement switching of tracks through SetTrack. On official images, update engine allows updating the track only to dev-channel or beta-channel. The track is verified both at setting and at getting time. BUG=8104 TEST=unit test; tested on device Change-Id: Ic81d4e3a9e09554d2239ee5c7a6c78e4dfe30d19 Review URL: http://codereview.chromium.org/4103002
/system/update_engine/omaha_request_params.h
|
fbb40098314ab45efa60667ad7ccae354c4f18da |
|
30-Jul-2010 |
Darin Petkov <petkov@chromium.org> |
Add a hardware_class attribute (for HWID, HWQual ID) to the Omaha request. BUG=1600 TEST=unit tests, gmerge and looked at request logs Review URL: http://codereview.chromium.org/3007020
/system/update_engine/omaha_request_params.h
|
84c763cffce6778711792944387fadb760c55c8d |
|
30-Jul-2010 |
Darin Petkov <petkov@chromium.org> |
AU: Remove instances of Omaha ID -- machine ID and user ID. Also add a unit test to make sure we are not sending machineid or userid attributes. BUG=1439 TEST=unit tests, gmerged on device, checked for update, looked at logs Review URL: http://codereview.chromium.org/2808082
/system/update_engine/omaha_request_params.h
|
5a7f565a542196f24eb87ddac96508f8a84e3329 |
|
23-Jul-2010 |
Darin Petkov <petkov@chromium.org> |
Add support to update_engine_client for -app_version and -omaha_url. These options prevent auto-detection of these parameters. Note that this CL makes the check_for_update DBus method obsolete from the client's point of view. BUG=4593 TEST=unit tests, gmerged on device and tried the client with different options. Review URL: http://codereview.chromium.org/3048008
/system/update_engine/omaha_request_params.h
|
3f0303aa211e2de2d466cef063ff6f39fffe32dd |
|
16-Jul-2010 |
Andrew de los Reyes <adlr@chromium.org> |
AU: pass whether or not we can tolerate a delta to the server BUG=4848 TEST=attached unittests Review URL: http://codereview.chromium.org/3017006
/system/update_engine/omaha_request_params.h
|
a4a8a8ccc2d9e0285728ed247b43f09433e63323 |
|
16-Jul-2010 |
Darin Petkov <petkov@chromium.org> |
Turn OmahaRequestPrepAction into OmahaRequestDeviceParams. Pass the params to OmahaRequestAction's ctor. This simplifies a bit executing as well as testing of OmahaRequestAction and testing of OmahaRequestDeviceParams. It also allows us to initialize the params once per update attempt and use them for all OmahaRequestActions. BUG=560 TEST=unit tests, gmerged on device and forced an update through dev server, inspected logs. Review URL: http://codereview.chromium.org/2836053
/system/update_engine/omaha_request_params.h
|