| c920bb27fd72b4dec235ce6831bb2258f8fd5da1 |
|
01-Feb-2016 |
Alex Vakulenko <avakulenko@google.com> |
Fix memory leak when removing CommandInstance from CommandQueue
The observers for CommandInstance were forcefully cleared in
CommandInstance::DetachFromQueue which caused failure of invoking
CommandInstance::Observer::OnCommandDestroyed() and, as a result,
CloudCommandProxy::OnCommandDestroyed was not called which caused
leaking CloudCommandProxy object instance.
BUG: 25707196
Change-Id: I119a67efce4968ffaa528632e77045265b8e8f2b
Reviewed-on: https://weave-review.googlesource.com/2428
Reviewed-by: Vitaly Buka <vitalybuka@google.com>
/external/libweave/src/commands/command_instance.h
|
| 34668e731bb194b443bc0e6029d6d3583f08de28 |
|
15-Dec-2015 |
Vitaly Buka <vitalybuka@google.com> |
Reformat
Change-Id: Ia98499f9ada220151b24ecb8b60b02524d700bc4
Reviewed-on: https://weave-review.googlesource.com/1967
Reviewed-by: Vitaly Buka <vitalybuka@google.com>
/external/libweave/src/commands/command_instance.h
|
| 88f55d8a6765d176973bfa0ce7d1000305ad6770 |
|
04-Dec-2015 |
Alex Vakulenko <avakulenko@google.com> |
Add "component" property to command instance
When sending commands, we'll use "component" to route the command to
the target component it was designated for.
As a temporary stop-gap, use "device" as the component name before
we have full implementation of component/trait schema model.
Also removed CommandDictionary from CommandInstance::FromJson since
the validation will be done outside of JSON parsing code in the future
Component Manager class.
BUG: 25841719
Change-Id: I5c649c257fb48ecaaedc1ced84931009f94c2bb3
Reviewed-on: https://weave-review.googlesource.com/1764
Reviewed-by: Vitaly Buka <vitalybuka@google.com>
/external/libweave/src/commands/command_instance.h
|
| 2c7740aac024de03aafcf09ee69f157384d44038 |
|
30-Nov-2015 |
Alex Vakulenko <avakulenko@google.com> |
Remove CommandDefinition class
In preparation for traits support, remove CommandDefinition class
and incorporate the missing functionality into CommandDictionary.
BUG: 25841719
Change-Id: Iead48aa0503e9de6061c4c1588b0b930dd82c8d0
Reviewed-on: https://weave-review.googlesource.com/1680
Reviewed-by: Alex Vakulenko <avakulenko@google.com>
/external/libweave/src/commands/command_instance.h
|
| 3bfb13d1a7a1d1677b3b3af9264f7cbecb6b71bd |
|
24-Nov-2015 |
Vitaly Buka <vitalybuka@google.com> |
Fix GCC 4.7 errors
GCC 4.7.2 fail overriding constructors defined with virtual and default.
Debian build also fails linking without -lrt.
INT64_C is not defined on Debian with 4.7.2. "ll" should be enough.
Change-Id: Ia779f094ed64fc3b1941429485e81520d017c2f5
Reviewed-on: https://weave-review.googlesource.com/1671
Reviewed-by: Alex Vakulenko <avakulenko@google.com>
/external/libweave/src/commands/command_instance.h
|
| c4305600835b91630f9ca4b10ad9070ea55a726c |
|
25-Nov-2015 |
Vitaly Buka <vitalybuka@google.com> |
Replace Get* methods returning unique_ptr with reference alternative
Existing code created temporarily objects and returned them to the
client. It was not efficient and error-prone as client code could
retrieve pointers to internal objects without keeping unique_ptr alive.
Change-Id: I9e17c8d9f66dfc9f52ce9ffc9a31992b16b00461
Reviewed-on: https://weave-review.googlesource.com/1672
Reviewed-by: Alex Vakulenko <avakulenko@google.com>
/external/libweave/src/commands/command_instance.h
|
| 8a05bebb95f5f3f9bf6b72bd9e58b6ba6b8c9bdd |
|
25-Nov-2015 |
Alex Vakulenko <avakulenko@google.com> |
Remove object schema type system
Since libweave no longer semantically parses command/state definitions
and validates commands and states, there is no need for this extra
code.
BUG: 25841230
Change-Id: I53dfab20db8c97b621c07fe234a7b3c6da7325bb
Reviewed-on: https://weave-review.googlesource.com/1660
Reviewed-by: Vitaly Buka <vitalybuka@google.com>
/external/libweave/src/commands/command_instance.h
|
| 36bf1b5778249e1ef807a92b24046783d84bfb40 |
|
23-Nov-2015 |
Alex Vakulenko <avakulenko@google.com> |
Remove schema validation from command parameters/returns
Do not use ObjectSchema and instead pass parameters, progress and
return values as opaque JSON objects.
BUG: 25841230
Change-Id: I0ea5fc31d526b1e5d6c66453b613e7284aa3fcac
Reviewed-on: https://weave-review.googlesource.com/1611
Reviewed-by: Vitaly Buka <vitalybuka@google.com>
/external/libweave/src/commands/command_instance.h
|
| 5a1f600e9d7d26c36b3e22ff0dc0ae9e3b2425fc |
|
02-Nov-2015 |
Paul Westbrook <pwestbro@google.com> |
Remove the unneeded libweave directory
Change-Id: I30fd8c5626cf83da6415ffa14a2019ef43be9916
Reviewed-on: https://weave-review.googlesource.com/1450
Reviewed-by: Paul Westbrook <pwestbro@google.com>
/external/libweave/src/commands/command_instance.h
|