History log of /external/skia/src/core/SkMipMap.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
e2412d5738e4ee37a897cc51996431a4dfb10436 17-Feb-2016 cblume <cblume@chromium.org> Adding direct access to SkMipMap levels.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639693002

Review URL: https://codereview.chromium.org/1639693002
/external/skia/src/core/SkMipMap.cpp
d10f5b3ac90322071b40e62fb585644ddd767223 17-Feb-2016 fmalita <fmalita@chromium.org> Use geometric mean when selecting a mipmap scale

Workaround for anisotropic mipmap quality issues.

R=reed@google.com,robertphillips@google.com
BUG=skia:4863,chromium:586894
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1697423002

Review URL: https://codereview.chromium.org/1697423002
/external/skia/src/core/SkMipMap.cpp
33ed3ad9f62b3c84d439b92ab45732d4fa6d05ad 09-Feb-2016 fmalita <fmalita@chromium.org> Relocate anisotropic mipmap logic to SkMipMap::extractLevel()

Pass a full x/y scale and defer the anisotropic heuristic to SkMipMap.

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1686563002

Review URL: https://codereview.chromium.org/1686563002
/external/skia/src/core/SkMipMap.cpp
507ef6d68115ae9e6d884bb36436a1463523d893 31-Jan-2016 mtklein <mtklein@chromium.org> SkNx Load/store: take any pointer.

This means we can remove a lot of explicit casts in code that uses SkNx.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1650653002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review URL: https://codereview.chromium.org/1650653002
/external/skia/src/core/SkMipMap.cpp
6121405df5689875c7309c20632a82897fce4127 26-Jan-2016 cblume <cblume@chromium.org> Cleaning up trailing spaces and typos.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1631993002

Review URL: https://codereview.chromium.org/1631993002
/external/skia/src/core/SkMipMap.cpp
8f66a8862f96bb364cfc857df7d29757f62f3396 25-Jan-2016 fmalita <fmalita@chromium.org> Delete 2 legacy flags

No longer used in Chrome/Android:

SK_SUPPORT_LEGACY_ANISOTROPIC_MIPMAPS
SK_SUPPORT_LEGACY_PRESCALE_SEMANTICS

R=caryclark@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1632633002

Review URL: https://codereview.chromium.org/1632633002
/external/skia/src/core/SkMipMap.cpp
921d7ac75206740e69fc6bc9893971249a909fe1 22-Jan-2016 fmalita <fmalita@chromium.org> Anisotropic mipmap fixes

1) when selecting a level scale, use max(scaleX, scaleY) instead of
current sqrt(scaleX * scaleY)

2) track and apply non-uniform fixup scales

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1617183004

Review URL: https://codereview.chromium.org/1617183004
/external/skia/src/core/SkMipMap.cpp
550e9b0ef1c0fba42e2e902a467af322ad2413da 20-Jan-2016 mtklein <mtklein@chromium.org> SkNx miplevel building

All sizes approximately twice as fast.

Before:
micros bench
1649.35 mipmap_build_512x512 nonrendering
1824.42 mipmap_build_511x512 nonrendering
2100.66 ? mipmap_build_512x511 nonrendering
2375.94 mipmap_build_511x511 nonrendering

After:
micros bench
730.32 ! mipmap_build_512x512 nonrendering
922.12 mipmap_build_511x512 nonrendering
999.07 mipmap_build_512x511 nonrendering
1342.93 ! mipmap_build_511x511 nonrendering

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606013003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/3bd5aba2a0e165997f683cf3aa306661e71464f6

Review URL: https://codereview.chromium.org/1606013003
/external/skia/src/core/SkMipMap.cpp
26def8687f9763dcc00ab3022aee4b86700970c1 20-Jan-2016 mtklein <mtklein@google.com> Revert of SkNx miplevel building (patchset #3 id:40001 of https://codereview.chromium.org/1606013003/ )

Reason for revert:
Paranoid revert to see if it helps skia:4823

Original issue's description:
> SkNx miplevel building
>
> All sizes approximately twice as fast.
>
> Before:
> micros bench
> 1649.35 mipmap_build_512x512 nonrendering
> 1824.42 mipmap_build_511x512 nonrendering
> 2100.66 ? mipmap_build_512x511 nonrendering
> 2375.94 mipmap_build_511x511 nonrendering
>
> After:
> micros bench
> 730.32 ! mipmap_build_512x512 nonrendering
> 922.12 mipmap_build_511x512 nonrendering
> 999.07 mipmap_build_512x511 nonrendering
> 1342.93 ! mipmap_build_511x511 nonrendering
>
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606013003
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/3bd5aba2a0e165997f683cf3aa306661e71464f6

TBR=reed@google.com,mtklein@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1607323002
/external/skia/src/core/SkMipMap.cpp
3bd5aba2a0e165997f683cf3aa306661e71464f6 19-Jan-2016 mtklein <mtklein@chromium.org> SkNx miplevel building

All sizes approximately twice as fast.

Before:
micros bench
1649.35 mipmap_build_512x512 nonrendering
1824.42 mipmap_build_511x512 nonrendering
2100.66 ? mipmap_build_512x511 nonrendering
2375.94 mipmap_build_511x511 nonrendering

After:
micros bench
730.32 ! mipmap_build_512x512 nonrendering
922.12 mipmap_build_511x512 nonrendering
999.07 mipmap_build_512x511 nonrendering
1342.93 ! mipmap_build_511x511 nonrendering

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606013003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Review URL: https://codereview.chromium.org/1606013003
/external/skia/src/core/SkMipMap.cpp
ab11c3f14cf829512460a627f5928c96f6fb3a97 17-Jan-2016 reed <reed@google.com> remove SK_SUPPORT_LEGACY_MIPLEVEL_BUILDER code

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1599133002

TBR=

Review URL: https://codereview.chromium.org/1599133002
/external/skia/src/core/SkMipMap.cpp
67b09bf6b7422c7a3209781cbb7827224e3ffc17 17-Jan-2016 reed <reed@google.com> use pixmaps in mipmap api

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1598803002

Review URL: https://codereview.chromium.org/1598803002
/external/skia/src/core/SkMipMap.cpp
326253ef22d39e72a729e8069e54b34ade72ad1b 16-Jan-2016 reed <reed@google.com> speedup mip builders

1. push the inner-loop into the procs
2. for the 3x3 and 3x2 cases, skip the redundant horizontal read/expand

Some before/after timings (unfortunately there's a lot of variance) -- on MacBook Air

Before

9/9 MB 1 1.45ms 1.65ms 1.92ms 2.93ms 31% ▂█▂▁▁▁▂█▆▂ nonrendering mipmap_build_512x512
9/9 MB 1 1.85ms 2.33ms 2.47ms 3.69ms 28% ▃██▄▃▂▁▂▁▁ nonrendering mipmap_build_511x512
9/9 MB 1 2.15ms 2.21ms 2.37ms 3.28ms 15% █▂▂▁▁▁▁▅▁▁ nonrendering mipmap_build_512x511
9/9 MB 1 2.74ms 3.9ms 4.03ms 5.89ms 25% ▄▂▃▄█▂▁▂▇▅ nonrendering mipmap_build_511x511

After

10/10 MB 1 1.08ms 1.09ms 1.1ms 1.18ms 3% ▁▁▁▁▁▁▁█▃▁ nonrendering mipmap_build_512x512
10/10 MB 1 1.22ms 1.44ms 1.66ms 2.83ms 30% ▂▂▄▁▁▃█▅▂▁ nonrendering mipmap_build_511x512
10/10 MB 1 1.45ms 1.91ms 2.04ms 3.75ms 36% ▁▁▁▃▅█▃▂▂▂ nonrendering mipmap_build_512x511
10/10 MB 1 1.7ms 1.7ms 1.81ms 2.41ms 13% █▁▁▁▁▁▁▁▁▄ nonrendering mipmap_build_511x511

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1593073002

Review URL: https://codereview.chromium.org/1593073002
/external/skia/src/core/SkMipMap.cpp
32e0b4a34a2d461927056677e0ef99241e29df0d 15-Jan-2016 reed <reed@google.com> use triangle filter for odd dimensions in mip-levels

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1592473002

Review URL: https://codereview.chromium.org/1592473002
/external/skia/src/core/SkMipMap.cpp
96fcdcc219d2a0d3579719b84b28bede76efba64 27-Aug-2015 halcanary <halcanary@google.com> Style Change: NULL->nullptr
DOCS_PREVIEW= https://skia.org/?cl=1316233002

Review URL: https://codereview.chromium.org/1316233002
/external/skia/src/core/SkMipMap.cpp
385fe4d4b62d7d1dd76116dd570df3290a2f487b 26-Aug-2015 halcanary <halcanary@google.com> Style Change: SkNEW->new; SkDELETE->delete
DOCS_PREVIEW= https://skia.org/?cl=1316123003

Review URL: https://codereview.chromium.org/1316123003
/external/skia/src/core/SkMipMap.cpp
91284caa23274d2336884913bc7806745071bd72 02-Jun-2015 reed <reed@google.com> check (runtime) for null-pixels even when lock succeeds

BUG=492818
TBR=

Review URL: https://codereview.chromium.org/1159953006
/external/skia/src/core/SkMipMap.cpp
cf01e31df6bbda270dca2ee3b4967caf51e465dc 24-May-2015 reed <reed@chromium.org> deprecate calling lockPixels

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1156003002
/external/skia/src/core/SkMipMap.cpp
f36cca8a61e0aa0730dea5e35ea781ac8ae59014 08-May-2015 fmalita <fmalita@chromium.org> Remove unused SK_SUPPORT_LEGACY_ROUND_MIPMAP_LEVEL_CHOICE guard

R=reed@google.com,robertphillips@google.com

Review URL: https://codereview.chromium.org/1135823003
/external/skia/src/core/SkMipMap.cpp
c1e1faae076a26e0706146e490a60d2894835cd5 06-May-2015 reed <reed@google.com> use floor for mip-level choice

this chrome change must land first: https://codereview.chromium.org/1131663002/

BUG=skia:

Review URL: https://codereview.chromium.org/1131613002
/external/skia/src/core/SkMipMap.cpp
0c9b1a8d05ea6ec5dfae0ead854304673d94d2c2 18-Mar-2015 reed <reed@chromium.org> add kGray_8_SkColorType

patch from issue 1014783003 at patchset 60001 (http://crrev.com/1014783003#ps60001)

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1010343002
/external/skia/src/core/SkMipMap.cpp
dc14fa4ec7739465d9bb9dbf1f0e537c80ad867f 27-Jan-2015 reed <reed@google.com> speedup mipmap building

mipmap_build benchmark:

before: 3.36ms
after: 2.20ms

BUG=skia:

Review URL: https://codereview.chromium.org/873393002
/external/skia/src/core/SkMipMap.cpp
83c8dec46a7a191b8e5a0b31a866e0b743f4dd72 20-Jan-2015 reed <reed@google.com> remove legacy flags for old image filtering

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/857193003
/external/skia/src/core/SkMipMap.cpp
7729e56a29a44bd47c69c8dc3247421595940acc 16-Jan-2015 reed <reed@chromium.org> use log2(scale) to compute mip level

now w/ expanded suppressions

This reverts commit b50ced703030dfbda4fc3ef5e6ec9a52fc0405f8.

BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/856723003
/external/skia/src/core/SkMipMap.cpp
b50ced703030dfbda4fc3ef5e6ec9a52fc0405f8 16-Jan-2015 reed <reed@google.com> Revert of use log2(scale) to compute mip level (patchset #7 id:120001 of https://codereview.chromium.org/849333002/)

Reason for revert:
need more suppressions

Original issue's description:
> use log2(scale) to compute mip level
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/15fd47f8a07615a7f5d78581aee4c80ff9f17fd9

TBR=robertphillips@google.com,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/856783004
/external/skia/src/core/SkMipMap.cpp
15fd47f8a07615a7f5d78581aee4c80ff9f17fd9 16-Jan-2015 reed <reed@google.com> use log2(scale) to compute mip level

BUG=skia:

Review URL: https://codereview.chromium.org/849333002
/external/skia/src/core/SkMipMap.cpp
ca8e350a8dfd541fd93b986733daa82dc5bea1c9 15-Jan-2015 reed <reed@google.com> Revert "choose better mip level"

This reverts commit 09544fcf9611be6efc0c38ab9d9a3f82181341fb.

BUG=skia:
TBR=
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/849173003
/external/skia/src/core/SkMipMap.cpp
09544fcf9611be6efc0c38ab9d9a3f82181341fb 15-Jan-2015 reed <reed@google.com> choose better mip level

BUG=skia:

Review URL: https://codereview.chromium.org/845793005
/external/skia/src/core/SkMipMap.cpp
09a22e9597e271c44dc7c2b71c72cf62a7de1e19 21-Nov-2014 mtklein <mtklein@chromium.org> Watch out for SkFixed overflow in SkMipMap.cpp.

Tested with -fsanitize=signed-integer-overflow.
This new assert used to trigger in MipMap unit test.

Don't appear to be any GM diffs.

BUG=skia:

Review URL: https://codereview.chromium.org/729373004
/external/skia/src/core/SkMipMap.cpp
9d93c2ebb31bf996905532446644f242339a774e 08-Oct-2014 reed <reed@google.com> Add SkCachedData and use it for SkMipMap

This reverts commit 37c5a815d8ea33247968212ef4cc83394ceee1bc.

TBR=mtklein

Review URL: https://codereview.chromium.org/635333002
/external/skia/src/core/SkMipMap.cpp
37c5a815d8ea33247968212ef4cc83394ceee1bc 03-Oct-2014 reed <reed@google.com> Speculative revert to diagnose crash in chrome. Revert "Add SkCachedData and use it for SkMipMap"

This reverts commit 92561a0b99ad6c08ab7a11dd1872f028199392e9.

crasher in question:
https://code.google.com/p/chromium/issues/detail?id=420178

Review URL: https://codereview.chromium.org/617613003
/external/skia/src/core/SkMipMap.cpp
92561a0b99ad6c08ab7a11dd1872f028199392e9 02-Oct-2014 reed <reed@google.com> Add SkCachedData and use it for SkMipMap

Review URL: https://codereview.chromium.org/592843003
/external/skia/src/core/SkMipMap.cpp
a3264e53ee3f3c5d6a2c813df7e44b5b96d207f2 30-May-2014 commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> Revert "Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)"

This reverts commit eecaea4148805834f223681f70b6488ceba12d09.

R=robertphillips@google.com, scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/301283003

git-svn-id: http://skia.googlecode.com/svn/trunk@14989 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkMipMap.cpp
57212f9469c8056bab3c85243dbb904e386eab95 30-Dec-2013 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Revert "Revert of https://codereview.chromium.org/113823003/"

This reverts commit 68b4b32066ea0ba9dbb5d326a836f8a54297b7aa.

BUG=

Review URL: https://codereview.chromium.org/122293002

git-svn-id: http://skia.googlecode.com/svn/trunk@12842 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkMipMap.cpp
4ad4ae907fa83773f671137b0e4e8c9525ab81cd 30-Dec-2013 commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> Revert of https://codereview.chromium.org/113823003/
Reason for revert: need to update callsites in linux codecs

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=

Author: reed@google.com

Review URL: https://codereview.chromium.org/122283002

git-svn-id: http://skia.googlecode.com/svn/trunk@12841 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkMipMap.cpp
a306d93cd73c3fc1d81479cbba98638f1e055385 30-Dec-2013 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> remove Sk64 from public API, and start to remove usage internally

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/113823003

git-svn-id: http://skia.googlecode.com/svn/trunk@12840 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkMipMap.cpp
4469938e92d779dff05e745559e67907bbf21e78 31-Oct-2013 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Revert "Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning""

This reverts commit 1e787c38fa71f2a21fd728f1b1d620b9b09b0d3d.

BUG=

Review URL: https://codereview.chromium.org/54603004

git-svn-id: http://skia.googlecode.com/svn/trunk@12057 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkMipMap.cpp
6fcbfcead5dc1b61fa5b4c139a1a3714e8c58091 31-Oct-2013 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Revert "add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning"

This reverts commit 1d22c4aaf9d8f053f25194a1ed74b137bfb19497.

git-svn-id: http://skia.googlecode.com/svn/trunk@12056 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkMipMap.cpp
081560e3abe25c4821b79ca1465f4dbd371c4b5c 31-Oct-2013 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning

BUG=
R=robertphillips@google.com, senorblanco@chromium.org, vandebo@chromium.org

Review URL: https://codereview.chromium.org/51033004

git-svn-id: http://skia.googlecode.com/svn/trunk@12055 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkMipMap.cpp
d94697c21ae479df4190a1afbf08d85ce244a4ef 24-Jul-2013 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> add mipmaps to scaledimagecache

BUG=

Review URL: https://codereview.chromium.org/19789016

git-svn-id: http://skia.googlecode.com/svn/trunk@10305 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkMipMap.cpp
a79919883e275e7a5e00afc50be10cc721f6ba1d 19-Jul-2013 skia.committer@gmail.com <skia.committer@gmail.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10175 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkMipMap.cpp
dc6c8babf04fe6c19087d441896a3d49f3322cc7 18-Jul-2013 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> add copyright notices

git-svn-id: http://skia.googlecode.com/svn/trunk@10169 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkMipMap.cpp
eed6f1b76b6690796e3d40993b1504ba1eca2df5 18-Jul-2013 reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> pull mipmap class into its own (private) header

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/19462007

git-svn-id: http://skia.googlecode.com/svn/trunk@10161 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/core/SkMipMap.cpp