| 70d1554d8ea08ddb887550f98b9cfd0afd395d65 |
|
22-Nov-2015 |
halcanary <halcanary@google.com> |
SkPDF: add `final` keyword to leaf classes
Review URL: https://codereview.chromium.org/1461403002
/external/skia/src/pdf/SkPDFShader.h
|
| 96fcdcc219d2a0d3579719b84b28bede76efba64 |
|
27-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: NULL->nullptr
DOCS_PREVIEW= https://skia.org/?cl=1316233002
Review URL: https://codereview.chromium.org/1316233002
/external/skia/src/pdf/SkPDFShader.h
|
| 2766c00fc0b6a07d46e5f74cdad45da2ef625237 |
|
26-Jun-2015 |
mtklein <mtklein@chromium.org> |
remove SkInstCnt
It's been outclassed by Valgrind and leak sanitizer,
and it seems to be causing problems for external folks building Skia.
I'm not sure why our own builds seem unaffected.
Latest thread:
https://groups.google.com/forum/#!topic/skia-discuss/oj9FsQwwSF0
BUG=skia:
Review URL: https://codereview.chromium.org/1217573002
/external/skia/src/pdf/SkPDFShader.h
|
| 2b86155b42c2493ff0c558ce105a464769962274 |
|
09-Apr-2015 |
halcanary <halcanary@google.com> |
SkPDF: ResourceDict replaced by factory function
Motivation: Having a class here was unnecessary, since the only thing
that set this class apart was how it is created, not how it behaves.
BUG=skia:3585
Review URL: https://codereview.chromium.org/1068343003
/external/skia/src/pdf/SkPDFShader.h
|
| 547019e1a671b1b30746e69b9647b201500e1504 |
|
24-Mar-2015 |
halcanary <halcanary@google.com> |
SkPDF: clean up extra references
This cleans up code left behind from http://crrev.com/870333002
Review URL: https://codereview.chromium.org/1029263004
/external/skia/src/pdf/SkPDFShader.h
|
| 2e3f9d8a9309686eeb4c76ccfde5800da87a68b3 |
|
27-Feb-2015 |
halcanary <halcanary@google.com> |
PDF: Canon now owns a reference to all interned objects
Add SkPDFCanon::reset function to unref all objects.
No longer possible to remove object from canon
Motivation: this doesn't change these object's lifetime, (they will
still be fully unrefed when SkDocument::close() is called, but we no
longer have to remove them from the array when their destructor is
called.
Review URL: https://codereview.chromium.org/966863002
/external/skia/src/pdf/SkPDFShader.h
|
| 792c80f5a7b66e75d42664ccb298f31962c6654c |
|
20-Feb-2015 |
halcanary <halcanary@google.com> |
PDF: Now threadsafe!
The PDF canvas is now just as threadsafe as any other Skia canvas.
DM updated to thread PDF tests.
SkDocument_PDF now owns SkPDFCanon, and pointers to that canon are
passed around to all classes that need access to the canon.
BUG=skia:2683
Review URL: https://codereview.chromium.org/944643002
/external/skia/src/pdf/SkPDFShader.h
|
| bf799cd228282431e6311900dd383083f8af7164 |
|
10-Feb-2015 |
halcanary <halcanary@google.com> |
Simplify reference management in SkPDF
Prior to this change, SkPDFObject subclasses were required
to track their resources separately from the document
structure. (An object has a resource if it depends, via an
indirect reference, on another object). This led to a lot
of extra code to duplicate effort. I replace the
getResources() function with the much simpler addResources()
function. I only define a non-trivial addResources() method
on arrays, dictionaries, and indirect object references.
All other specialized classes simply rely on their parent
class's implementation.
SkPDFObject::addResources() works by recursively walking the
directed graph of object (direct and indirect) references
and adding resources to a set. It doesn't matter that there
are closed loops in the graph, since we check the set before
walking down a branch.
- Add SkPDFObject::addResources() virtual function, with
four implementations
- Remove SkPDFObject::getResources() virtual function and
all implementations.
- Remove SkPDFObject::GetResourcesHelper()
- Remove SkPDFObject::AddResourceHelper()
- In SkPDFCatalog::findObjectIndex(), add an object to the
catalog if it doesn't exist yet.
- SkPDFCatalog::setSubstitute() no longer sets up resources
- SkPDFDocument.cpp no longer needs the Streamer object
- SkPDFDocument.cpp calls fDocCatalog->addResources to build
the resource list.
- SkPDFFont::addResource() removed
- All SkPDF-::fResource sets removed (they are redundant).
- removed SkPDFImage::addSMask() function
- SkPDFResourceDict::getReferencedResources() removed.
Motivation: this removes quite a bit of code and makes the
objects slightly slimmer in memory. Most importantly, this
will lead the way towards removing SkPDFObject's inheritance
from SkRefCnt, which will greatly simplify everything.
Testing: I usually test changes to the PDF backend by
comparing checksums of PDF files rendered from GMs and SKPs
before and after the change. This change both re-orders and
re-numbers the indirect PDF objects. I used the qpdf
program to normalize the PDFs and then compared the
normalized outputs from before and after the change; they
matched.
Review URL: https://codereview.chromium.org/870333002
/external/skia/src/pdf/SkPDFShader.h
|
| 530ea8e24bc88f2d7973c35a703f18c1dafb56dc |
|
23-Jan-2015 |
halcanary <halcanary@google.com> |
More changes to SkPDFShader to eliminate multiple inheritance!
Review URL: https://codereview.chromium.org/873543002
/external/skia/src/pdf/SkPDFShader.h
|
| bc59ac6b12bbded2117fe3aa9643b2d138e5ddda |
|
23-Jan-2015 |
halcanary <halcanary@google.com> |
Simplify SkPDFShader class. Now invalid objects are never created.
"Constructors should not do real work"
I have verified that all test PDFs render identically.
Review URL: https://codereview.chromium.org/862113004
/external/skia/src/pdf/SkPDFShader.h
|
| fb62b3d423fa34c672df42f47017dbef087d19e9 |
|
21-Jan-2015 |
halcanary <halcanary@google.com> |
SkPDFCanon
SkPDFCanon's fields and methods will eventually become part of
SkPDFDocument/SkDocument_PDF. For now, it exists as a singleton to
preflight that transition. This replaces three global arrays in
SkPDFFont, SkPDFShader, and SkPDFGraphicsContext. This code is still
thread-unsafe (http://skbug.com/2683), but moving this functionality
into SkPDFDocument will fix that.
This CL does not change pdf output from either GMs or SKPs.
This change also simplifies some code around the SkPDFCanon methods.
BUG=skia:2683
Review URL: https://codereview.chromium.org/842253003
/external/skia/src/pdf/SkPDFShader.h
|
| c3796c7a74e103d9b367ad9449fcdacfa20d83e1 |
|
13-Jan-2015 |
fmalita <fmalita@chromium.org> |
Generic PDF shader fallback
Instead of ignoring unsupported shaders (and essentially filling with
solid black), convert them to bitmap shaders using on-the-fly
rasterization.
BUG=skia:3299
R=reed@google.com,halcanary@google.com
Review URL: https://codereview.chromium.org/841763005
/external/skia/src/pdf/SkPDFShader.h
|
| 93a2e213441c75033b04365c7d68c8d3887288ac |
|
24-Jul-2013 |
commit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Implemented transparent gradients
R=vandebo@chromium.org, edisonn@google.com
Author: richardlin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18585002
git-svn-id: http://skia.googlecode.com/svn/trunk@10297 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/pdf/SkPDFShader.h
|
| 05141c23ed2731bf04e7a1ca2a03ca23014b7222 |
|
27-Apr-2012 |
robertphillips@google.com <robertphillips@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Fixed minor c++ issues found by cppcheck
http://codereview.appspot.com/6127049/
git-svn-id: http://skia.googlecode.com/svn/trunk@3771 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/pdf/SkPDFShader.h
|
| 386dfc049baa400c13e4e98727d4c04d0242b7b8 |
|
18-Apr-2012 |
vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
[PDF] Handle failures of matrix inversion
Previously reviewed in https://codereview.appspot.com/6033047. Rolled back
because of unrelated fixed-point bugs.
Review URL: https://codereview.appspot.com/6052051
git-svn-id: http://skia.googlecode.com/svn/trunk@3715 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/pdf/SkPDFShader.h
|
| 8aa66b6f76f72b8e0a15323a932436ca462bf14d |
|
17-Apr-2012 |
vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "[PDF] Handle failures of matrix inversion" while I investigate fixed point failures.
This reverts commit r3711
Review URL: https://codereview.appspot.com/6050049
git-svn-id: http://skia.googlecode.com/svn/trunk@3712 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/pdf/SkPDFShader.h
|
| ebad2d9e2003c76a7c496e25c79e371277961ee8 |
|
17-Apr-2012 |
vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
[PDF] Handle failures of matrix inversion.
Review URL: https://codereview.appspot.com/6033047
git-svn-id: http://skia.googlecode.com/svn/trunk@3711 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/pdf/SkPDFShader.h
|
| 7d6c8f997f8fe2c222f9d6d31f984c2e7cf16cc5 |
|
22-Mar-2012 |
vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
[PDF] Move most of the headers to be private.
Compute font stats in SkPDFDocument in order to make more of the headers private.
Previous review: https://codereview.appspot.com/5868049/
Review URL: https://codereview.appspot.com/5875049
git-svn-id: http://skia.googlecode.com/svn/trunk@3470 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/pdf/SkPDFShader.h
|
| 76d6de0845910f18306125bbcaef7edf6e8f6649 |
|
21-Mar-2012 |
vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "[PDF] Move most of the headers to be private."
This reverts r3457
TBR=epoger@google.com
Review URL: https://codereview.appspot.com/5866051
git-svn-id: http://skia.googlecode.com/svn/trunk@3458 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/pdf/SkPDFShader.h
|
| bd960c7f1915c73ceec1c1ee7cd23b48107cb0bd |
|
21-Mar-2012 |
vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
[PDF] Move most of the headers to be private.
Compute font stats in SkPDFDocument in order to make more of the headers private.
Previous review: https://codereview.appspot.com/5865048/
Review URL: https://codereview.appspot.com/5868049
git-svn-id: http://skia.googlecode.com/svn/trunk@3457 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/pdf/SkPDFShader.h
|
| 008c498b58e674c6fe595a359e3adbafddd05540 |
|
21-Mar-2012 |
vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
Revert "[PDF] Move most of the headers to be private."
This reverts r3453
TBR=epoger@google.com
Review URL: https://codereview.appspot.com/5869048
git-svn-id: http://skia.googlecode.com/svn/trunk@3454 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/pdf/SkPDFShader.h
|
| f7f9aa8bd957766ebf6a296360a2d5857abed265 |
|
21-Mar-2012 |
vandebo@chromium.org <vandebo@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> |
[PDF] Move most of the headers to be private.
Compute font stats in SkPDFDocument in order to make more of the headers private.
Review URL: https://codereview.appspot.com/5865048
git-svn-id: http://skia.googlecode.com/svn/trunk@3453 2bbb7eff-a529-9590-31e7-b0007b416f81
/external/skia/src/pdf/SkPDFShader.h
|