| 5ec26ae9bfca635ccc98283aad5deda11519d826 |
|
25-Feb-2016 |
bsalomon <bsalomon@google.com> |
Move Budgeted enum out of SkSurface, use in GrTextureProvider
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
DOCS_PREVIEW= https://skia.org/?cl=1728093005
Committed: https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
Review URL: https://codereview.chromium.org/1728093005
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| bd500f09ce5b1ca464431d693f9ec5da60a59230 |
|
25-Feb-2016 |
bsalomon <bsalomon@google.com> |
Revert of Move Budgeted enum out of SkSurface, use in GrTextureProvider (patchset #6 id:100001 of https://codereview.chromium.org/1728093005/ )
Reason for revert:
Need workaround for chrome to build
Original issue's description:
> Move Budgeted enum out of SkSurface, use in GrTextureProvider
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
> DOCS_PREVIEW= https://skia.org/?cl=1728093005
>
> Committed: https://skia.googlesource.com/skia/+/57599fe6c0336feaeeeb9b1996e77b70219b483c
TBR=reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1734043002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 57599fe6c0336feaeeeb9b1996e77b70219b483c |
|
25-Feb-2016 |
bsalomon <bsalomon@google.com> |
Move Budgeted enum out of SkSurface, use in GrTextureProvider
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1728093005
DOCS_PREVIEW= https://skia.org/?cl=1728093005
Review URL: https://codereview.chromium.org/1728093005
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 1530283c483cb88aa725bce50a6d193dd00ee570 |
|
01-Dec-2015 |
kkinnunen <kkinnunen@nvidia.com> |
Generate list of GPU contexts outside tests
Use DEF_GPUTEST_FOR_*_CONTEXT macros to obtain the
test GPU context.
Makes changing the context -related classes easier,
since not all tests need to be changed.
BUG=skia:2992
Review URL: https://codereview.chromium.org/1448873002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 60029a5397f75aae4bdb994f26bd297edc3e433c |
|
09-Nov-2015 |
robertphillips <robertphillips@google.com> |
Update Layer Hoisting to store its atlas texture in the resource cache
BUG=skia:4346
Committed: https://skia.googlesource.com/skia/+/42597bc99f00553825843b5ed41e81b121773368
Review URL: https://codereview.chromium.org/1406013006
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| cf1d19805a289c612532cf2d4505bb348b78ba77 |
|
06-Nov-2015 |
robertphillips <robertphillips@google.com> |
Revert of Update Layer Hoisting to store its atlas texture in the resource cache (patchset #6 id:100001 of https://codereview.chromium.org/1406013006/ )
Reason for revert:
Android
Original issue's description:
> Update Layer Hoisting to store its atlas texture in the resource cache
>
> BUG=skia:4346
>
> Committed: https://skia.googlesource.com/skia/+/42597bc99f00553825843b5ed41e81b121773368
TBR=bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4346
Review URL: https://codereview.chromium.org/1413483004
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 42597bc99f00553825843b5ed41e81b121773368 |
|
06-Nov-2015 |
robertphillips <robertphillips@google.com> |
Update Layer Hoisting to store its atlas texture in the resource cache
BUG=skia:4346
Review URL: https://codereview.chromium.org/1406013006
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 07b41eb962fdb007f788fcd82e338d7aef126064 |
|
04-Nov-2015 |
robertphillips <robertphillips@google.com> |
Update RecordReplaceDraw unit test
Review URL: https://codereview.chromium.org/1407143011
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 67b8b5e67a427382fed8c5d8b3c70a21ed2492c6 |
|
03-Nov-2015 |
reed <reed@google.com> |
Revert of Revert[2] of "stop using drawSprite (at least w/ no filters) as it is going away" (patchset #1 id:1 of https://codereview.chromium.org/1410343011/ )
Reason for revert:
failing on msaa
Original issue's description:
> Revert[2] of "stop using drawSprite (at least w/ no filters) as it is going away"
>
> Fixed assert in test that was calling GrRecordReplaceDraw(). That function now uses
> drawBitmap, so updated the test to check for that (instead of drawSprite).
>
> This reverts commit 21b766347064837e6b78d600755901aad88cd6e0.
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/7b81994d95f10cda80ddb85af68a2651ff31782f
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1420053009
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 7b81994d95f10cda80ddb85af68a2651ff31782f |
|
03-Nov-2015 |
reed <reed@google.com> |
Revert[2] of "stop using drawSprite (at least w/ no filters) as it is going away"
Fixed assert in test that was calling GrRecordReplaceDraw(). That function now uses
drawBitmap, so updated the test to check for that (instead of drawSprite).
This reverts commit 21b766347064837e6b78d600755901aad88cd6e0.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1410343011
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 96fcdcc219d2a0d3579719b84b28bede76efba64 |
|
27-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: NULL->nullptr
DOCS_PREVIEW= https://skia.org/?cl=1316233002
Review URL: https://codereview.chromium.org/1316233002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| c6ad06acefa096716f8dabed5342f9b89dc43dfe |
|
19-Aug-2015 |
mtklein <mtklein@chromium.org> |
unsigned -> int for counts and indices in picture-related code
also, (C)
BUG=skia:
Review URL: https://codereview.chromium.org/1300163002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| d309e7aa0efa2d5dd7e7b1af97026fcd3a047e98 |
|
30-Apr-2015 |
bsalomon <bsalomon@google.com> |
This replaces the texture creation/caching functions on GrContext with a GrTextureProvider interface. The goal is to pass this narrowly focused object in places that currently take a GrContext but don't need and shouldn't use its other methods. It also has an extended private interface for interacting with non-texture resource types.
Review URL: https://codereview.chromium.org/1107973004
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 36352bf5e38f45a70ee4f4fc132a38048d38206d |
|
26-Mar-2015 |
mtklein <mtklein@chromium.org> |
C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}
NOPRESUBMIT=true
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1037793002
Review URL: https://codereview.chromium.org/1037793002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| d0423587ac56ae84d3f1eb796d5c1e2dfba9646e |
|
06-Feb-2015 |
bsalomon <bsalomon@google.com> |
One createTexture function, attempt to recycle scratch in createTexture.
Review URL: https://codereview.chromium.org/864383003
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 72c9faab45124e08c85f70ca38536914862d947c |
|
09-Jan-2015 |
mtklein <mtklein@chromium.org> |
Fix up all the easy virtual ... SK_OVERRIDE cases.
This fixes every case where virtual and SK_OVERRIDE were on the same line,
which should be the bulk of cases. We'll have to manually clean up the rest
over time unless I level up in regexes.
for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end
BUG=skia:
Review URL: https://codereview.chromium.org/806653007
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 783fe16b8ed1cd1cff34eacc33296874a32f293b |
|
07-Jan-2015 |
robertphillips <robertphillips@google.com> |
Rename SkDrawPictureCallback to SkPicture::AbortCallback
Committed: https://skia.googlesource.com/skia/+/7ef197255deb4e2fa64c03c7130d56ddf164e83c
Review URL: https://codereview.chromium.org/829983003
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 8ea6dabbb15ef276645b7a6ebab44a4a532ac990 |
|
07-Jan-2015 |
reed <reed@chromium.org> |
Revert of Rename SkDrawPictureCallback to SkPicture::AbortCallback (patchset #2 id:20001 of https://codereview.chromium.org/829983003/)
Reason for revert:
speculative revert to unblock DEPS roll
Original issue's description:
> Rename SkDrawPictureCallback to SkPicture::AbortCallback
>
> Committed: https://skia.googlesource.com/skia/+/7ef197255deb4e2fa64c03c7130d56ddf164e83c
TBR=reed@google.com,robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/824013004
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 7ef197255deb4e2fa64c03c7130d56ddf164e83c |
|
06-Jan-2015 |
robertphillips <robertphillips@google.com> |
Rename SkDrawPictureCallback to SkPicture::AbortCallback
Review URL: https://codereview.chromium.org/829983003
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 478dd723362fefc2023aee03e11216d913eeac03 |
|
16-Dec-2014 |
robertphillips <robertphillips@google.com> |
Fix layer hoisting image filter corner cases
This CL fixes 5 bugs related to hoisting image filters:
For image filters the src layer (the one prior to filtering) often needs to be
smaller then the final layer. This requires the saveLayer's optional bounds
to be stored (in SkLayerInfo.h and SkRecordDraw.cpp) and then used in
compute_source_rect and carried around in GrCachedLayer.
The image filters can add an extra offset to the final draw operation.
This is now computed in GrLayerHoister::FilterLayer and carried around in
GrCachedLayer.
Filtered layers must use exact matches. This is now done in GrLayerCache::lock.
The filter cache requires a valid matrix so it can compute the correct offset.
This is now done in GrLayerHoister::FilterLayer.
Filtered layers need to be drawn with drawSprite while unfiltered (and therefore
hopefully atlased) layers can be drawn with drawBitmap. This is now done in
draw_replacement_bitmap.
Committed: https://skia.googlesource.com/skia/+/702eb9622102599d94ab6798e6227cf29f48c2d3
Review URL: https://codereview.chromium.org/803183003
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 86f032832fc3527ab561bcbd9d2a546f7f676f73 |
|
16-Dec-2014 |
robertphillips <robertphillips@google.com> |
Revert of Fix layer hoisting image filter corner cases (patchset #3 id:40001 of https://codereview.chromium.org/803183003/)
Reason for revert:
Breaking DM
Original issue's description:
> Fix layer hoisting image filter corner cases
>
> This CL fixes 5 bugs related to hoisting image filters:
>
> For image filters the src layer (the one prior to filtering) often needs to be
> smaller then the final layer. This requires the saveLayer's optional bounds
> to be stored (in SkLayerInfo.h and SkRecordDraw.cpp) and then used in
> compute_source_rect and carried around in GrCachedLayer.
>
> The image filters can add an extra offset to the final draw operation.
> This is now computed in GrLayerHoister::FilterLayer and carried around in
> GrCachedLayer.
>
> Filtered layers must use exact matches. This is now done in GrLayerCache::lock.
>
> The filter cache requires a valid matrix so it can compute the correct offset.
> This is now done in GrLayerHoister::FilterLayer.
>
> Filtered layers need to be drawn with drawSprite while unfiltered (and therefore
> hopefully atlased) layers can be drawn with drawBitmap. This is now done in
> draw_replacement_bitmap.
>
> Committed: https://skia.googlesource.com/skia/+/702eb9622102599d94ab6798e6227cf29f48c2d3
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/790643009
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 702eb9622102599d94ab6798e6227cf29f48c2d3 |
|
16-Dec-2014 |
robertphillips <robertphillips@google.com> |
Fix layer hoisting image filter corner cases
This CL fixes 5 bugs related to hoisting image filters:
For image filters the src layer (the one prior to filtering) often needs to be
smaller then the final layer. This requires the saveLayer's optional bounds
to be stored (in SkLayerInfo.h and SkRecordDraw.cpp) and then used in
compute_source_rect and carried around in GrCachedLayer.
The image filters can add an extra offset to the final draw operation.
This is now computed in GrLayerHoister::FilterLayer and carried around in
GrCachedLayer.
Filtered layers must use exact matches. This is now done in GrLayerCache::lock.
The filter cache requires a valid matrix so it can compute the correct offset.
This is now done in GrLayerHoister::FilterLayer.
Filtered layers need to be drawn with drawSprite while unfiltered (and therefore
hopefully atlased) layers can be drawn with drawBitmap. This is now done in
draw_replacement_bitmap.
Review URL: https://codereview.chromium.org/803183003
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 7bc0b42567a304313a9c6eaaeba28076d24cbd85 |
|
11-Dec-2014 |
reed <reed@google.com> |
update test after I added a clip call, making the count odd
BUG=skia:
TBR=
NOTREECHECKS=True
NOTRY=True
Review URL: https://codereview.chromium.org/797633002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 2ff1fcede1e9525285c5de1f35fb2dcb0fab32bd |
|
11-Dec-2014 |
reed <reed@google.com> |
Defer saves() until they're needed
patch from issue 759443006 at patchset 40001 (http://crrev.com/759443006#ps40001)
BUG=skia:
Review URL: https://codereview.chromium.org/767333002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| c88cedaf8806cc9afa36497dc93eb0d1c329fb6c |
|
04-Dec-2014 |
mtklein <mtklein@chromium.org> |
Fix up RecordReplaceDrawTest memory leak.
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/151/steps/dm/logs/stdio
BUG=skia:
Review URL: https://codereview.chromium.org/779973002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| e99d499caa7dbc80b58e0faf5ce137e7d30cc5d0 |
|
03-Dec-2014 |
robertphillips <robertphillips@google.com> |
Fuse GrReplacements and GrLayerCache
The conversion step from GrCachedLayer to ReplacementInfo isn't necessary.
Review URL: https://codereview.chromium.org/769533004
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 01d6e5f462d1d52203ee1a6660415877e4cf2dde |
|
01-Dec-2014 |
robertphillips <robertphillips@google.com> |
Use variable length key (rather than accumulated matrix) as save layer hoisting key
Adding the rendering canvas' CTM to the layer hoisting key (i.e., Add support for hoisting layers in pictures drawn with a matrix - https://codereview.chromium.org/748853002/) has increased the cache miss rate due to accumulated floating point error. This CL fixes part of the issue by using the chain of operation indices leading to each saveLayer as the key. The canvas' CTM must still form part of the key but should be less subject to accumulated error.
BUG=skia:2315
Review URL: https://codereview.chromium.org/753253002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 4477c3c0e6eb064772aefe8737425cd1c2ce557f |
|
27-Oct-2014 |
mtklein <mtklein@chromium.org> |
Cut down SkBBH API more.
- The expected case is now a single bulk-load insert() call instead of N;
- reserve() and flushDeferredInserts() can fold into insert() now;
- SkBBH subclasses may take ownership of the bounds
This appears to be a performance no-op on both my Mac and N5. I guess
even the simplest indirect branch predictor ("same as last time") can predict
the repeated virtual calls to SkBBH::insert() perfectly.
BUG=skia:
Review URL: https://codereview.chromium.org/670213002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 65151754b9fdb6a968d7307764c20655d1b680a0 |
|
16-Oct-2014 |
piotaixr <piotaixr@chromium.org> |
Override SkCanvas::drawImage() in SkRecorder.
BUG=skia:2947
Review URL: https://codereview.chromium.org/610003002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 68cd2aa797f707a9847f8eba0758787cafd43e43 |
|
01-Oct-2014 |
robertphillips <robertphillips@google.com> |
Update GrRecordReplaceDraw to use SkTDynamicHash & add ReplaceDraw
Having hoisted layers from different pictures invalidates the assumptions of the old GrReplacements object. This is fixed by switching to a SkTDynamicHash-based back-end.
Sub-picture-layers also require that the replacement drawing occur for the sub-pictures too. The ReplaceDraw object is added to make this happen and limit the replacement lookup to saveLayer draw commands.
This is split out of (Fix sub-picture layer rendering bugs - https://codereview.chromium.org/597293002/).
BUG=skia:2315
Review URL: https://codereview.chromium.org/607763008
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| ee6631ef90fb5a9c80de6eacd37632f11367a088 |
|
29-Sep-2014 |
robertphillips <robertphillips@google.com> |
Update RecordReplaceDrawTest to generate and pass pictures
This CL splits the unit test changes out of (Fix sub-picture layer rendering bugs - https://codereview.chromium.org/597293002/).
For various reasons GrRecordReplaceDraw now needs to take an SkPicture (rather than an SkRecord and a BBH).
R=egdaniel@google.com, bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/608823002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| a0537deca24abc2713e72f61e9cec14bdcc703d0 |
|
18-Sep-2014 |
robertphillips <robertphillips@google.com> |
Copy layer-hoisting related SkPaints
This is intended to disconnect the lifetimes of the optimization data, cached layers and replacement objects.
Note that the optimization data already makes a copy of the paint in the SkPicture. Additionally the replacement object will probably go away at some point.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/579843002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| 46625e06e23b65c05013fc686a8223d6d5b49050 |
|
08-Sep-2014 |
robertphillips <robertphillips@google.com> |
Fix two SkRecord-backed layer hoisting bugs
The two bugs are/were:
The old loop to draw the hoisted layers included the saveLayer call which caused double application of the layer's paint (This is the +1 change).
The hoisted layer is intended to be drawn in device coordinates. The old code was drawing it in the coordinate space of the saveLayer thus it was misplaced (This is the setMatrix change).
Committed: https://skia.googlesource.com/skia/+/7c0cfd4ff8f6db50a8731c886db732b106268937
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/551843002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| e5ea500d4714a7d84de2bf913e81be3b65d2de68 |
|
03-Sep-2014 |
reed <reed@google.com> |
Hide fields in SkImageInfo
R=rmistry@google.com
TBR=bsalomon
Author: reed@google.com
Review URL: https://codereview.chromium.org/536003002
/external/skia/tests/RecordReplaceDrawTest.cpp
|
| d982eb22d7bce655a609e9b481b3ddfeff361067 |
|
03-Sep-2014 |
robertphillips <robertphillips@google.com> |
Replace SkPictureReplacementPlayback with GrRecordReplaceDraw
I think this is sufficiently specialized to keep it in Ganesh for the time being.
R=bsalomon@google.com, mtklein@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/535953002
/external/skia/tests/RecordReplaceDrawTest.cpp
|