| be57983f4bd875c39a229bab5112b32dad004057 |
|
10-Nov-2015 |
Karl Wiberg <kwiberg@webrtc.org> |
Rename Maybe to Optional
And add examples of good and bad usage to the documentation.
R=aluebs@webrtc.org, henrik.lundin@webrtc.org, pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1432553007 .
Cr-Commit-Position: refs/heads/master@{#10588}
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| 102c6a61bc0b42dc0956d013530fc0213b7e881b |
|
30-Oct-2015 |
kwiberg <kwiberg@webrtc.org> |
Replace rtc::cricket::Settable with rtc::Maybe
The former is very similar to the latter, but less general (mostly in
naming).
This CL, which is the first to use Maybe at scale, also removes the implicit conversion from T to Maybe<T>, since it was agreed that the increased verbosity increased legibility.
Review URL: https://codereview.webrtc.org/1430433004
Cr-Commit-Position: refs/heads/master@{#10461}
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| facbbecb516547adc2ac684c8e0be95ad79dfd88 |
|
24-Sep-2015 |
solenberg <solenberg@webrtc.org> |
Remove use of DeviceManager from ChannelManager.
BUG=webrtc:4690
Review URL: https://codereview.webrtc.org/1346153002
Cr-Commit-Position: refs/heads/master@{#10042}
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| b02af18c5cb6d6c3def7f44d27a63068360f4f29 |
|
16-Jun-2015 |
Henrik Lundin <henrik.lundin@webrtc.org> |
Follow-up: Remove old DelayCorrection AEC config
This is a follow-up to r9401, where the configuration DelayCorrection
was replaced by ExtendedFilter.
This change also removes the media constraint
kExperimentalEchoCancellation which was replaced by
kExtendedFilterEchoCancellation in the same CL.
Both settings that are now being removed were kept in the code to avoid
API breakages. In https://codereview.chromium.org/1167343004,
depending code has been updated to avoid breakages.
BUG=webrtc:4696
R=bjornv@webrtc.org, tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1181413004.
Cr-Commit-Position: refs/heads/master@{#9444}
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| 70c7fe14ac322a3abac2726d29ae3264b956e3da |
|
15-Jun-2015 |
Tommi <tommi@webrtc.org> |
Add kGoogEchoCancellation to MediaConstraintsInterface.
This constraint will be equal to kEchoCancellation until we've updated Chromium to use kGoogEchoCancellation where that constraint is needed. Once that's done, I'll change kEchoCancellation to be 'echoCancellation'.
BUG=webrtc:4747
R=andrew@webrtc.org
Review URL: https://codereview.webrtc.org/1179233003.
Cr-Commit-Position: refs/heads/master@{#9433}
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| 441f6347311bcf2079435c3888d67e1fb321f9f8 |
|
09-Jun-2015 |
Henrik Lundin <henrik.lundin@webrtc.org> |
Re-land r9378 "Rename APM Config DelayCorrection to ExtendedFilter"
(This reverts commit 3fbf3f8841b5460503fb646eaedcb063620434a8.)
The original submission was reverted because it broke the Chrome build. This is fixed in patch set 2 of this change by keeping the old MediaConstraintsInterface string kExperimentalEchoCancellation. It will be removed once the Chrome code has been updated.
Original description:
"We use this Config struct for enabling/disabling Extended filter mode in AEC. This change renames it to ExtendedFilter for readability reasons. The corresponding media constraint is also renamed to kExtendedFilterEchoCancellation.
The old Config is kept in parallel with the new during a transition period. This is to avoid problems with API breakages. During this period, if any of the two Configs are enabled, the extended filter mode is engaged in APM. That is, the two Configs are combined with an "OR" operation.
This change also renames experimental_aec in AudioOptions to extended_filter_aec."
BUG=webrtc:4696
R=bjornv@webrtc.org, tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1151573021.
Cr-Commit-Position: refs/heads/master@{#9401}
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| 3fbf3f8841b5460503fb646eaedcb063620434a8 |
|
05-Jun-2015 |
Henrik Lundin <henrik.lundin@webrtc.org> |
Revert r9378 "Rename APM Config DelayCorrection to ExtendedFilter"
This reverts commit 5f4b7e2873864c61e2ad6d88679dcd5d321bfd16, since it
broke some of the build bots.
BUG=4696
TBR=bjornv@webrtc.org
Review URL: https://codereview.webrtc.org/1166463006
Cr-Commit-Position: refs/heads/master@{#9380}
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| 5f4b7e2873864c61e2ad6d88679dcd5d321bfd16 |
|
05-Jun-2015 |
Henrik Lundin <henrik.lundin@webrtc.org> |
Rename APM Config DelayCorrection to ExtendedFilter
We use this Config struct for enabling/disabling Extended filter mode
in AEC. This change renames it to ExtendedFilter for readability
reasons. The corresponding media constraint is also renamed to
kExtendedFilterEchoCancellation.
The old Config is kept in parallel with the new during a transition
period. This is to avoid problems with API breakages. During this
period, if any of the two Configs are enabled, the extended filter
mode is engaged in APM. That is, the two Configs are combined with an
"OR" operation.
This change also renames experimental_aec in AudioOptions to extended_filter_aec.
BUG=4696
R=bjornv@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/54659004
Cr-Commit-Position: refs/heads/master@{#9378}
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| 1ba344a07060bf57db649299835ec4f093d58d40 |
|
29-Apr-2015 |
Bjorn Volcker <bjornv@chromium.org> |
Adds a MediaConstraint for the AudioOption aec_dump
Alson includes
- a test verifying that the option is set
- changed the test verifying delay_agnostic_aec option is set to use non-default value
BUG=4555
TESTED=locally through AppRTCDemo on N7 and Android One
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46059004
Cr-Commit-Position: refs/heads/master@{#9109}
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| bf395c1fc0a29b54fac4b6f6e9f6c117762faa15 |
|
25-Mar-2015 |
Bjorn Volcker <bjornv@webrtc.org> |
Add WebRTC Media Constraint to force using Delay Agnostic AEC on Android
If built-in Echo Cancellation is available on a device it is automatically enabled. The reason is that it in most cases performs better than the WebRTC software echo control for mobile. The drawback is that we can not develop, test and rollout the delay agnostic AEC (DA-AEC) on Android as for desktops.
This CL includes
- adding a media constraint to enable/disable DA-AEC.
- automatically turning on echo cancellation if DA-AEC is enabled.
- a fix in the AEC that enables delay estimation when DA-AEC is enabled, but delay metrics is disabled.
- sets the Config struct ReportedDelay, which controls DA-AEC internally in the AEC.
The test code to verify that it works in AppRTCDemo can be found here:
https://webrtc-codereview.appspot.com/50479004/
BUG=4472
TESTED=locally on N7, N6, Android One
R=glaznev@webrtc.org, perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48699004
Cr-Commit-Position: refs/heads/master@{#8861}
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| 5f93d0a140515e3b8cdd1b9a4c6f5871144e5dee |
|
20-Jan-2015 |
jlmiller@webrtc.org <jlmiller@webrtc.org> |
Update libjingle license statements at top of talk files for consistency
BUG=2133
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8105 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| a09a99950ec40aef6421e4ba35eee7196b7a6e68 |
|
13-Aug-2014 |
buildbot@webrtc.org <buildbot@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
(Auto)update libjingle 73222930-> 73226398
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6891 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| 38d88816e395dfc32b355769f67a6f39c18bd511 |
|
13-Aug-2014 |
xians@webrtc.org <xians@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Fix the audio source failure due to unsupported constraints.
Some constraints, like kEchoCancellation, kMediaStreamAudioDucking are supported in Chrome but not in Libjingle, if the users set it in mandatory, LocalAudioSource::Initialize() will fail the getUserMedia call.
This patch fixes the problem by fully initializing the LocalAudioSource even though some constraints are not supported in libjingle.
BUT=crbug/398080
TEST=manual test:
var constraints = {audio: { mandatory: { googEchoCancellation: true } }};
getUserMedia(constraints, gotStream, gotStreamFailed);
verify you get a gotStream callback
R=henrika@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/21049004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6885 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| d4e598d57aed714a599444a7eab5e8fdde52a950 |
|
29-Jul-2014 |
buildbot@webrtc.org <buildbot@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
(Auto)update libjingle 72097588-> 72159069
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6799 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| 97077a3ab27259164eb121034b6e0ebe9ba592df |
|
25-Oct-2013 |
wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update libjingle to 55618622.
Update libyuv to r826.
TEST=try bots
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2889004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5038 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|
| 28e20752806a492f5a6a5d343c02f9556f39b1cd |
|
10-Jul-2013 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds trunk/talk folder of revision 359 from libjingles google code to
trunk/talk
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/talk/app/webrtc/localaudiosource_unittest.cc
|