e2976c87f7ba627fa1e1246f0ccfb34b4b9f3a73 |
|
04-Jan-2016 |
Peter Boström <pbos@webrtc.org> |
Remove DISABLED_ON_ macros. Macro incorrectly displays DISABLED_ON_ANDROID in test names for parameterized tests under --gtest_list_tests, causing tests to be disabled on all platforms since they contain the DISABLED_ prefix rather than their expanded variants. This expands the macro variants to inline if they're disabled or not, and removes building some tests under configurations where they should fail, instead of building them but disabling them by default. The change also removes gtest_disable.h as an unused include from many other files. BUG=webrtc:5387, webrtc:5400 R=kjellander@webrtc.org, phoglund@webrtc.org TBR=henrik.lundin@webrtc.org Review URL: https://codereview.webrtc.org/1547343002 . Cr-Commit-Position: refs/heads/master@{#11150}
/external/webrtc/webrtc/base/signalthread_unittest.cc
|
3c089d751ede283e21e186885eaf705c3257ccd2 |
|
16-Sep-2015 |
henrikg <henrikg@webrtc.org> |
Add RTC_ prefix to contructormagic macros. We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition. * DISALLOW_ASSIGN -> RTC_DISALLOW_ASSIGN * DISALLOW_COPY_AND_ASSIGN -> RTC_DISALLOW_COPY_AND_ASSIGN * DISALLOW_IMPLICIT_CONSTRUCTORS -> RTC_DISALLOW_IMPLICIT_CONSTRUCTORS Related CL: https://codereview.webrtc.org/1335923002/ BUG=chromium:468375 NOTRY=true Review URL: https://codereview.webrtc.org/1345433002 Cr-Commit-Position: refs/heads/master@{#9953}
/external/webrtc/webrtc/base/signalthread_unittest.cc
|
ae0f0ee79ecda30af4fc82eec4cdd07b7770336a |
|
05-Apr-2015 |
Thiago Farina <tfarina@chromium.org> |
Cleanup: Remove DISALLOW_EVIL_CONSTRUCTORS macro. Just use the less-evil version, DISALLOW_COPY_AND_ASSIGN macro. This should help with my TODO in https://chromium.googlesource.com/chromium/src/+/master/base/macros.h#33 Tested on Linux with the following command lines: $ rm -rf out/ $ gn gen //out/Debug --args='is_debug=true target_cpu="x64" build_with_chromium=false' $ ninja -C out/Debug BUG=None TEST=see above R=tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/50599004 Patch from Thiago Farina <tfarina@chromium.org>. Cr-Commit-Position: refs/heads/master@{#8927}
/external/webrtc/webrtc/base/signalthread_unittest.cc
|
c732a3e5113bd64c85eeefa7a2ed3a5076e3db87 |
|
10-Oct-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
Re-enable allmost all base tests. BUG=3836 R=marpan@google.com Review URL: https://webrtc-codereview.appspot.com/22989004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7416 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/signalthread_unittest.cc
|
fded02c164ea4cc3d28d7f30ac9ce9d94d76ef7a |
|
19-Sep-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
base: disabled several base tests on Mac so that rtc_unittests can be turned back on BUG=N/A R=kjellander@webrtc.org Review URL: https://webrtc-codereview.appspot.com/30449004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7240 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/signalthread_unittest.cc
|
e5063b173303e9ee6c2246d2aa42a1480902b867 |
|
23-May-2014 |
fischman@webrtc.org <fischman@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Thread: delete racy API (Release()) and fix racy code (started()). - Thread::Release() wrote a local variable on the calling thread but read it on another thread, with no synchronization. Happily it has no non-test callers so deleting it instead of trying to fix it (see bug for details). - Thread::started_ similarly was racily being written to; replaced with a running_ Event, and hid the accessor except for tests & legacy callers, with a note about why it's a bad idea. webrtc/base patched with: git diff origin --relative=talk/base | patch -p1 -dwebrtc/base followed by manual merge of 3 thunks that ran afoul of naming differences between talk/base and webrtc/base. BUG=3388 R=andrew@webrtc.org Review URL: https://webrtc-codereview.appspot.com/14589005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6236 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/signalthread_unittest.cc
|
f048872e915a3ee229044ec4bc541f6cbf9e4de1 |
|
13-May-2014 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/17479005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/signalthread_unittest.cc
|
e9a604accd54ab14dbf98f99ccdcf3ae1c54d27c |
|
13-May-2014 |
perkj@webrtc.org <perkj@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..." This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome. http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457 > Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. > > BUG=N/A > R=andrew@webrtc.org, wu@webrtc.org > > Review URL: https://webrtc-codereview.appspot.com/12199004 TBR=henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/14479004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/signalthread_unittest.cc
|
2c7d1b39b9374d2bc9bda4755fd4813db66a135c |
|
12-May-2014 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base. BUG=N/A R=andrew@webrtc.org, wu@webrtc.org Review URL: https://webrtc-codereview.appspot.com/12199004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/base/signalthread_unittest.cc
|