| 4376648df021fd82f25a38694e33678f802d06ea |
|
27-Aug-2015 |
Karl Wiberg <kwiberg@google.com> |
AudioDecoder: Replace Init() with Reset()
The Init() method was previously used to initialize and reset
decoders, and returned an error code. The new Reset() method is used
for reset only; the constructor is now responsible for fully
initializing the AudioDecoder.
Reset() doesn't return an error code; it turned out that none of the
functions it ended up calling could actually fail, so this CL removes
their error return codes as well.
R=henrik.lundin@webrtc.org
Review URL: https://codereview.webrtc.org/1319683002 .
Cr-Commit-Position: refs/heads/master@{#9798}
/external/webrtc/webrtc/modules/audio_coding/codecs/ilbc/ilbc.c
|
| dce40cf804019a9898b6ab8d8262466b697c56e0 |
|
24-Aug-2015 |
Peter Kasting <pkasting@google.com> |
Update a ton of audio code to use size_t more correctly and in general reduce
use of int16_t/uint16_t.
This is the upshot of a recommendation by henrik.lundin and kwiberg on an original small change ( https://webrtc-codereview.appspot.com/42569004/#ps1 ) to stop using int16_t just because values could fit in it, and is similar in nature to a previous "mass change to use size_t more" ( https://webrtc-codereview.appspot.com/23129004/ ) which also needed to be split up for review but to land all at once, since, like adding "const", such changes tend to cause a lot of transitive effects.
This was be reviewed and approved in pieces:
https://codereview.webrtc.org/1224093003
https://codereview.webrtc.org/1224123002
https://codereview.webrtc.org/1224163002
https://codereview.webrtc.org/1225133003
https://codereview.webrtc.org/1225173002
https://codereview.webrtc.org/1227163003
https://codereview.webrtc.org/1227203003
https://codereview.webrtc.org/1227213002
https://codereview.webrtc.org/1227893002
https://codereview.webrtc.org/1228793004
https://codereview.webrtc.org/1228803003
https://codereview.webrtc.org/1228823002
https://codereview.webrtc.org/1228823003
https://codereview.webrtc.org/1228843002
https://codereview.webrtc.org/1230693002
https://codereview.webrtc.org/1231713002
The change is being landed as TBR to all the folks who reviewed the above.
BUG=chromium:81439
TEST=none
R=andrew@webrtc.org, pbos@webrtc.org
TBR=aluebs, andrew, asapersson, henrika, hlundin, jan.skoglund, kwiberg, minyue, pbos, pthatcher
Review URL: https://codereview.webrtc.org/1230503003 .
Cr-Commit-Position: refs/heads/master@{#9768}
/external/webrtc/webrtc/modules/audio_coding/codecs/ilbc/ilbc.c
|
| a8b335c709b244685345cfabb3b72ce672a09d96 |
|
12-Jun-2015 |
Peter Kasting <pkasting@google.com> |
Reland "Upconvert various types to int.", ilbc portion.
This reverts portions of commit cb180976dd0e9672cde4523d87b5f4857478b5e9, which
reverted commit 83ad33a8aed1fb00e422b6abd33c3e8942821c24. Specifically, the
files in webrtc/modules/audio_coding/codecs/ilbc/ are relanded.
The original commit message is below:
Upconvert various types to int.
Per comments from HL/kwiberg on https://webrtc-codereview.appspot.com/42569004 , when there is existing usage of mixed types (int16_t, int, etc.), we'd prefer to standardize on larger types like int and phase out use of int16_t.
Specifically, "Using int16 just because we're sure all reasonable values will fit in 16 bits isn't usually meaningful in C."
This converts some existing uses of int16_t (and, in a few cases, other types such as uint16_t) to int (or, in a few places, int32_t). Other locations will be converted to size_t in a separate change.
BUG=none
TBR=kwiberg
Review URL: https://codereview.webrtc.org/1184643002
Cr-Commit-Position: refs/heads/master@{#9423}
/external/webrtc/webrtc/modules/audio_coding/codecs/ilbc/ilbc.c
|
| cb180976dd0e9672cde4523d87b5f4857478b5e9 |
|
11-Jun-2015 |
Peter Kasting <pkasting@google.com> |
Revert "Upconvert various types to int."
This reverts commit 83ad33a8aed1fb00e422b6abd33c3e8942821c24.
BUG=499241
TBR=hlundin
Review URL: https://codereview.webrtc.org/1179953003
Cr-Commit-Position: refs/heads/master@{#9418}
/external/webrtc/webrtc/modules/audio_coding/codecs/ilbc/ilbc.c
|
| 83ad33a8aed1fb00e422b6abd33c3e8942821c24 |
|
10-Jun-2015 |
Peter Kasting <pkasting@google.com> |
Upconvert various types to int.
Per comments from HL/kwiberg on https://webrtc-codereview.appspot.com/42569004 , when there is existing usage of mixed types (int16_t, int, etc.), we'd prefer to standardize on larger types like int and phase out use of int16_t.
Specifically, "Using int16 just because we're sure all reasonable values will fit in 16 bits isn't usually meaningful in C."
This converts some existing uses of int16_t (and, in a few cases, other types such as uint16_t) to int (or, in a few places, int32_t). Other locations will be converted to size_t in a separate change.
BUG=none
R=andrew@webrtc.org, kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/54629004
Cr-Commit-Position: refs/heads/master@{#9405}
/external/webrtc/webrtc/modules/audio_coding/codecs/ilbc/ilbc.c
|
| 71b35a4ce4b1fcd9fdd75485aeffb1b92322f103 |
|
17-Feb-2015 |
jmarusic@webrtc.org <jmarusic@webrtc.org> |
iLBC: Use uint8_t[] for byte arrays
BUG=909
This is the same as https://review.webrtc.org/41779004/ with the review comments addressed.
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40769004
Cr-Commit-Position: refs/heads/master@{#8394}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8394 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/codecs/ilbc/ilbc.c
|
| eb544460e47140d494dddf1217a698a1dcf4dee0 |
|
17-Dec-2014 |
pbos@webrtc.org <pbos@webrtc.org> |
Rename _t struct types in audio_coding.
_t names are reserved in POSIX.
R=henrik.lundin@webrtc.org
BUG=162
Review URL: https://webrtc-codereview.appspot.com/34509004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7933 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/codecs/ilbc/ilbc.c
|
| e728ee03ba093ddb9fa6fb803994969801a4f601 |
|
17-Dec-2014 |
pbos@webrtc.org <pbos@webrtc.org> |
Remove or rename typedefs with _t prefixes.
_t prefixes are reserved for additional typenames in POSIX.
R=henrik.lundin@webrtc.org, hta@webrtc.org, stefan@webrtc.org
BUG=162
Review URL: https://webrtc-codereview.appspot.com/36559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7931 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/codecs/ilbc/ilbc.c
|
| cb858ba3974c921627e81805e2ab4a2ae52c6619 |
|
08-Dec-2014 |
kwiberg@webrtc.org <kwiberg@webrtc.org> |
Make an AudioEncoder subclass for iLBC
BUG=3926
R=henrik.lundin@webrtc.org, kjellander@google.com
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32649005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7828 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/codecs/ilbc/ilbc.c
|
| 0946a56023d821e0deca04029bb016ae1f23aa82 |
|
09-Apr-2013 |
pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
WebRtc_Word32 => int32_t etc. in audio_coding/
BUG=314
Review URL: https://webrtc-codereview.appspot.com/1271006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3789 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/codecs/ilbc/ilbc.c
|
| 14b43beb7ce4440b30dcea31196de5b4a529cb6b |
|
22-Oct-2012 |
andrew@webrtc.org <andrew@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Move src/ -> webrtc/
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/webrtc/modules/audio_coding/codecs/ilbc/ilbc.c
|