History log of /packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
ecf356c15143ab0583c64682de16d94a57f7dd1c 20-Sep-2013 Mathew Inwood <mathewi@google.com> Remove content provider querying from the search app.

The global search API that is used for this is being deprecated, since it
has long been beset by performance problems. Remove all related code from
the search app.

Bug: 10487397

Change-Id: Ifa91b50d784cb469cb39d6008284aa44ff54e62b
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
723b496d757c34d8ea745c4f650b353f5791e1ce 24-May-2011 Mathew Inwood <mathewi@google.com> Get Search app usable on tablet & phone.

The new-style split pane UI is only used on x-large devices. Others
will use the phone style white UI.

Also tidied up unused and non-working code in SearchWidgetProvider.

Change-Id: Ic39170146426f6ba63fad4943f296f3ddd8a85dc
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
116affd19a834a2df4226a1ae37afcc1113a230e 16-Nov-2010 Mathew Inwood <mathewi@google.com> Always publish results even when none are promoted.

This fixes a bug which caused result never to be published
when a suggestions provider never returns, and there are no
shortcut matches.

Bug: 3200540
Change-Id: Ic63a69c4606f4e97d83028a9b26389b0dbd3b601
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
00efc7712fd9fce49f1c8e1a4de71784958f8a35 16-Nov-2010 Mathew Inwood <mathewi@google.com> Order corpora in right hand pane by popularity.

The ordering of the corpora in the Suggestions object is now
maintained so that the corpora appear in the order determined
by the corpus ranker.

Change-Id: I27e282af8d942de0c939748ab63a049a994bd7ad
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
3540e5a9eab6ff33e6d45f1d908bcaf4c4f49152 26-Oct-2010 Bjorn Bringert <bringert@android.com> Clear suggestions when query is cleared

Bug: 3130934
Change-Id: Idc9c2413431a6d7be67c10619cadcd2db1d32058
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
dfc1772caf35942837d83331d787eb10734c37cb 20-Oct-2010 Bjorn Bringert <bringert@android.com> Get corpora excluded from All to work in the single pane UI

Bug: 3054864
Change-Id: Ie312ffe89b173a1a8d5eff7b5eb1136957971d6c
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
8b2936607176720172aee068abc5631bdf77e843 12-Oct-2010 Bjorn Bringert <bringert@android.com> Added strawman tablet corpus selection UI

Bug: 3053103
Change-Id: Iaca9605fe88c53581ef20a79d07724fc4bfd5e8b
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
b42184f1e6a1b7bb22797ff92cae696753aca770 20-Aug-2010 Bjorn Bringert <bringert@android.com> Get shortcuts asynchronously.

Other shortcut repository queries are still done on the main thread.
I'll fix that in spearate changes.

Bug: http://b/issue?id=2706190
Bug: http://b/issue?id=2892691
Change-Id: I7a6429afa876364a8609f80b448a1df0b5a65e3c
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
b83882b9efa37ec0f20a0f1c85cf5ccc93194aee 19-Aug-2010 Bjorn Bringert <bringert@android.com> Move Promoter to SuggestionsAdapter to have a single Suggestions object

Change-Id: Ie0521f7a8427015d394c442a4b6d31b96d91d85b
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
4572856ac85bb53ea06e65d00beebdf336af9b27 16-Aug-2010 Mathew Inwood <mathewi@google.com> Filter shortcuts between the two panes, and other fixes.

Shortcuts are now split between the two panes in the same way as other
suggestions. Some problems with suggestions filtering have also been fixed,
which sometimes resulted in crashes. Other stuff:
- renames some classes for clarity
- renames some test code
- other tidying up and removal of dead code.

Change-Id: I75e22fe09340d3f31d79dfa29dc00fcf42b877ca
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
3f38435f152ab0a1164b85ffa43d024a2d05f000 12-Aug-2010 Mathew Inwood <mathewi@google.com> Merge commit '09208161' into manualmerge

Conflicts:
src/com/android/quicksearchbox/Suggestions.java

Change-Id: I3fbc3dcbd0962fda61a762889f6bfae95af4a875
9038d65a5a8ebcfada1ec3067f81a26f05622088 11-Aug-2010 Mathew Inwood <mathewi@google.com> Only refresh shortcuts that are displayed in the UI.

Change I6413d82f9051bb64487c65817bfbcdea0f0c3097 introduced a problem whereby
*all* the shortcuts were updated, as the shortcut repository did not filter them,
and it refreshed all the shortcuts it returned. Now, the refreshing is started
after the suggestion promotion stage, so that only shortcuts that are actually
displayed in the suggestions list will be refreshed. This results in far fewer
refreshes and database updates (which can be time consuming).

Change-Id: I4b4cac522d12a4e304ddebfca7466f670cc3811b
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
848fa7a19abedc372452073abaf52780c7b6d78d 26-Jul-2010 Amith Yamasani <yamasani@google.com> Two-pane UI implemented.

Show query suggestions on the left and all other results on the right.

There is one major issue with this as it stands: *all* shortcuts currently
appear in the right pane. They need to be split between the left and right
pane as web results are (presumably).

Change-Id: I4b433fb319d9911a83ccd974493de246300a1ddc
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
2fd5aa82682f077660faa8ec60c04238026a8731 28-Jun-2010 Mathew Inwood <mathewi@google.com> Make logging more consistent.

Always use Log.d, never Log.v.

Change-Id: I3d32c9005f5b2798c99d1b253c99e728e40c0cc8
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
1923b7bd8926e274d013c66d23af219c755e6060 25-Jun-2010 Bjorn Bringert <bringert@android.com> Fix code review comments

Addresses code review comments on I6e25b77e73ca7b7b6869c283e2496bfa14242248

Change-Id: I8420221cc95e33d0b0b6f070814c1cf92cbb667a
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
13b2fc952b2fe3dee4ccdd3e7f7d090e688bf655 25-Jun-2010 Mathew Inwood <mathewi@google.com> Simplified suggestion filtering when switching between corpora.

Fixes bugs 2798084, 2798081. Don't understand why it fixes the 2nd one.

Change-Id: I6e25b77e73ca7b7b6869c283e2496bfa14242248
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
ced9f76b761536341d739e9a243c98a4bf90638c 25-Jun-2010 Bjorn Bringert <bringert@android.com> Delay suggestion updates 200 ms and group them

New corpus results are now delayed for 200 ms, unless it is the
last set of results. If a new result comes in before the timeout,
the timeout is reset.

Bug: 2796507
Change-Id: I545c3bdddba9e0d94fed781660577d80d918727e
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
754cb6b769c5955fc707a6c5ab6689b64df102b3 22-Jun-2010 Mathew Inwood <mathewi@google.com> Clear suggestions immediately when swicthing between corpora.

When switching from All to a specific corpora, the suggestions are filtered so that the results are available immediately. When switching from a specific corpora to All, we leave the suggestions in place, since they are still appropriate. When switching between individual seperate corpora, all suggestions are cleared.

Bug: 2750930

Change-Id: Ie284dee7bd93ebf048d86f025b4c30111f3dd403
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
3cb8178193a41f6c74ee396c318385a50dd624e1 15-Jun-2010 Mathew Inwood <mathewi@google.com> Minor logging improvement & bugfixing.

Changed startup logging to include time takent to get the list of shortcuts. Also, changes to support bug 2758788.

Change-Id: Idd0c28910893619b9dc6e176b94f11daaba26caf
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
b5fc08b7f16a32d3865f44b7f26d8aaa5304a2ad 19-Mar-2010 Bjorn Bringert <bringert@android.com> Disable debug logging and remove unused imports and classes

Fixes http://b/issue?id=2410136

Change-Id: I2416c9b6c1b9e819ec17d7954b6b70bf106f0414
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
39bbcdc1a485ded93059de4a3f70bfda85e9f304 17-Mar-2010 Bryan Mawhinney <bryanmawhinney@google.com> Various changes to shorcut promotion logic.

- Default services are always shown before non-default
- All default sources must respond before non default are called
- The top slots above the keyboard are shared by any default source results.

Change-Id: I59c9dad0fac1f9664b5f40cc32cc38fb42507fb2
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
e6f46632869a288c82b75187af166931f82a6e12 12-Mar-2010 Bryan Mawhinney <bryanmawhinney@google.com> Show shortcuts in corpus-specific mode.

Change-Id: Ibc101f26a9aede7992a43731975d99eb96318568
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
870b826dfbc5ef7518826007f22343dc963d6d04 09-Mar-2010 Bjorn Bringert <bringert@android.com> Use @VisibleForTesting instead of proguard.flags

Change-Id: Ib6a8cceaa24da843d46ea3561c9d237a21c2b83e
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
e06b7cbf55301a24cfd7525a91107e3cd2c9f48e 04-Mar-2010 Bjorn Bringert <bringert@android.com> Only included queried corpora in qsb_click log event

Change-Id: I4ce89b02f7957a427508e58226c5b9867e819b32
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
82bcf002f2f736afcd6cb548c19aa4e8ac12b421 04-Mar-2010 Bjorn Bringert <bringert@android.com> Use actual set of promoted corpora in suggestion promoter

Fixes http://b/issue?id=2486251

Change-Id: I9de5b09eadf168377e7c7b2f11ce9ae247129f70
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
3673ad4f2b3893f15675820ab2240ec0a64b7970 03-Mar-2010 Bjorn Bringert <bringert@android.com> Don't close cursors in finalize()

This can cause lock-ups, see
https://sites.google.com/a/google.com/db_in_android/

Change-Id: I293021d3bdc7a549147afa80593fa162b135ac00
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
fde948e69f59589cf0d217ea414af7947de600bb 11-Feb-2010 Bjorn Bringert <bringert@android.com> Merge Google and Browser sources and call them Web

This required a gigantic refactoring of QuickSearchBox to work nicely.

This change also reduces the number of promoted source to 3,
since Web is now one source instead of two.

As a side effect of the recatoring, VoiceSearch now searches
the selected corpus (fixes http://b/issue?id=2438309)

Fixes http://b/issue?id=2365770

Change-Id: Ife8d40ef62ea004e8d0f20a60e9196fc589f01fc
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
27d3d4eb3b0414cf7001020d8ddcfdde81fd516b 09-Feb-2010 Bryan Mawhinney <bryanmawhinney@google.com> Order sources by total clicks, and only query numPromotedSources initially.

If after numPromotedSources complete we don't have enough results,
then query the next numPromotedSources and so on.
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
447226345392f2721d72bb1e2278b541448f3796 03-Feb-2010 Bryan Mawhinney <bryanmawhinney@google.com> Ensure that promoted results are updated when shortcuts change.

Bug: 2416313
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
94e8a2be78530170f50e7895a558bf8011bbf8e8 18-Jan-2010 Bryan Mawhinney <bryanmawhinney@google.com> Implement refreshing of shortcuts in QSB.
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
cef2c4c9d54f513babd74801dbed5cbf709b9b79 19-Jan-2010 Bjorn Bringert <bringert@android.com> Disable some QSB logspam

Change-Id: I6d75009c3273a88d80c7e3b661e70afcb3f49175
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
185bb2e3881452c084fde44d9bee657f65881b0e 04-Dec-2009 Bjorn Bringert <bringert@android.com> Make tab order stable

- Overhauls suggestions handling to make tab order stable.

- Refactors SuggestionsView to split it into some
general tab components (TabView, TabAdapter), and
QSB-specific parts (SuggestionsView, SuggestionsAdapter,
SuggestionCursorAdapter).

- Moves UI code to .ui subpackage.

- Converts some error and warning logs to exceptions to make
them easier to find during development and dogfooding.

- Recycles suggestion views.

This code is currently pretty slow.

TODO: Don't populate views that aren't visible.
TODO: Delay update until the currently visible source reports.
TODO: Batch updates.

Change-Id: If42889d20499c34d94e1dc0acdc12a3ae53a23b0
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
d7a95801d20a9405b4ab9c9b4beecd106e880166 11-Dec-2009 Bryan Mawhinney <bryanmawhinney@google.com> Delay before updating the view when we have no suggestions.

This reduces flicker a little, and moving the delay here allows us to simplify Suggestions.
Also fixes a small bug where the spinner could keep spinning indefinitely.
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java
3e44ff1f2a204db3f479698cf0b3eab3d451dec2 03-Dec-2009 Bjorn Bringert <bringert@android.com> Import QuickSearchBox package from perforce.

This moves code from
//depot/google3/java/com/google/android/apps/quicksearchbox/...
The only changes done in the move are the package names
and the license headers.

The code does not yet build, since there is no Android.mk.

Change-Id: I768b06d211f5ee6ecd6f9777ba2839c09744fbf1
/packages/apps/QuickSearchBox/src/com/android/quicksearchbox/Suggestions.java