History log of /packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
57f82d24a7f7105800eff71083e41db5b27ba183 09-Sep-2014 Andrew Sapperstein <asapperstein@google.com> Return of the message-level stars.

Fixes b/16563881 by enabling starring/unstarring via
the message header overflow. Also restores the behavior
where starred messages are expanded when you open the conversation.

Fixes b/16349888 by turning off the conversation-level stars
in CV.

Also fixes b/17432202 where the message header overflow wasn't properly
aligned with the action bar overflow.

Also noticed a super-collapsed bug where we weren't properly resetting
state on bind.

Change-Id: I39d7ef7b49f13aad62895e743effe76c707510f0
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
d8f80955c27bf4c0820169789bfa6740e4c70eaf 05-Sep-2014 Andrew Sapperstein <asapperstein@google.com> Make CV Subject selectable again. b/17376132

Change-Id: Ifaf110a765cfc5979e865feb97402fa5cc39eeaa
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
ce29380a68ee4bf6d5d8cf11d9eda7caa6482de4 13-Aug-2014 Paul Westbrook <pwestbro@google.com> prevent NPE

Bug: 16949922
Change-Id: Ic542ddf5b6946816f0e7be562a4b0238abf6bb7d
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
eb58a092961773a8da67c0e0dd5770346381d938 24-Jun-2014 Andrew Sapperstein <asapperstein@google.com> Updated conversation header for quantum CV.

b/15595931

Using a combination of breaking and non-breaking spaces
to ensure that labels start on a new line if they don't
all fit in the remaining space of the first line they can
be drawn on.

Starring works now.
Can click the labels to open change labels again.
Priority indicator is now baseline aligned.
Properly drawing the label chips.
Label chips moved up to the baseline
RTL support.
New star asset.

Change-Id: Ife32339f174bff7beafc979f9cc9761cefffed72
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
e6bf30d6e98eb6140b7a5f301efe631ff35c9f7b 14-Mar-2014 Andrew Sapperstein <asapperstein@google.com> RTL - Align conversation header with viewStart.

Fixes b/13432564.

Change-Id: I97954654b829579d481780ddd0c550d4caa58086
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
17646055214b9ab3abc2553379bf046ca3e53fb2 07-Mar-2014 Andrew Sapperstein <asapperstein@google.com> Show priority indicators (chevrons).

Fixes b/7961430. Creates a new account setting
called showChevronsEnabled that, if true, results
in the UI showing chevrons. Also properly distinguishes
showing chevrons from the show importance marker setting.

Change-Id: I767341457ed610309b5729887d121c6fb7c94eba
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
2fd167d6131482da984768b5ee75cefa32ed3e32 28-Jan-2014 Andrew Sapperstein <asapperstein@google.com> RTL - conversation view fixes.

b/12681840 - Properly align attachment details.
b/12681242 - Message header expanded details are locale aligned.
b/12681528 - Message header title and snippet are locale aligned.
b/11989230 - Set each overlay view's layout direction.

The first three bugs were fixed by adding unicode wrapping
to a bunch of fields.

The final bug was slightly more complex. In some scenarios,
the overlay views's layout direction was not properly resolved.
But it should always be the same as its parent so we forcibly
do it now when adding new views.

Change-Id: I9e065e0deaf1958ee87d098231238f6d976e9e68
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
be0cb1e421831672f49c30ecb46e6eee765cb661 16-Jan-2014 Andrew Sapperstein <asapperstein@google.com> Ad teaser redesign.

b/12243411.

Change-Id: I993b326bc36de8edf1f2f40202d8f32551de4d94
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
2c13cfa0c78263b9e3b4c6b0039dcd023a359fd6 17-Jan-2014 Andrew Sapperstein <asapperstein@google.com> Fix NoSuchMethodError crash. Fixes b/12591171.

Was calling TextUtils.getLayoutDirectionFromLocale
before API 17.

Change-Id: I14978c61f4947202990a500e8c4f711d22571af4
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
a4296c179cd4eb12e7c4912d72c22dd2ec724a7e 11-Jan-2014 Andrew Sapperstein <asapperstein@google.com> RTL the conversation list and two pane layout.

Fixes:
b/12451886
b/12452546

Change-Id: If2bd3d63c07eda3190d16fd95746c0105b251406
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
93405645e9b637c89e1d2d3be4fe507179c4a854 04-Dec-2013 Andrew Sapperstein <asapperstein@google.com> Shift label spaces to right of labels in RTL mode.

Fixes one part of b/11971620. Previously, when leaving
space before the label (so that multiple labels would
have a gap between them), we would always assume before
meant to the left of the label. Now, we check if we're in
RTL and if so, draw the space to the right of the label.
This has the noticeable effect of not having a gap between
the left edge of the header and the left edge of the first
label when in RTL mode.

There's still a bug in ConversationViewHeader where the
layout direction of the view is getting resolved to LTR
even when in RTL mode. Need to do more investigation.

Change-Id: Ic3a62a0678c905fe18aaf165bc7b1bb3d7631f4e
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
62297d85d9e8539a25d03cb4373e4c3e870b26fe 11-Oct-2013 Andrew Sapperstein <asapperstein@google.com> Show "(no subject)" in conversation view header.

Fixes b/10299458.

Change-Id: I3fe3a610e7c40cef3c0597c8458bbd21da8ccd7f
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
ca4f947523e19ef8e658ead0bf5f70b45b64e9da 19-Sep-2013 Andrew Sapperstein <asapperstein@google.com> Separate RTL margins and paddings into ldrtl.

b/10751781

Change-Id: Ibc6d795c2899802eefb199f32081adc0a0b53e68
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
e539880d39620d7e26b31c8b5b381a7e9d1a722e 30-Jul-2013 Andrew Sapperstein <asapperstein@google.com> Conversation View UI Refresh: Card Borders.

Also some tablet stuff. Top borders aren't
working. Need a new asset for them. But this'll
do for tonight.

Change-Id: I6501b39c1d89f025ff68aa3cf19b3c29365c3f92
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
b2c9f9f54cfe3b6d9014e48ffe2718381da8e41c 09-Jul-2013 Andrew Sapperstein <asapperstein@google.com> Conversation View UI Refresh: conversation header.

Changed conversation header to a linear layout since
it is simpler now that we don't realign the labels
to fit on the same line. The rest of the commit is playing
with margins/padding/text sizing/etc.

Change-Id: Id73fd3f0d8f3662aa998fc505c0131655b9fc385
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
b53fe05fb867685d0d3f2f37daf0f93bc6488ded 21-Apr-2013 Andy Huang <ath@google.com> misc contact photo optimizations

* Only invalidate the contact image region on async load.
* Calculate hash codes by hand to save autoboxing of ints.
* Don't parse Folder color strings at draw time.
* Switch ConcurrentHashMap to SynchronizedMap. No need for concurrent
write support, as we only have one writer thread. Write perf is much
better.

No-op stale photo requests more correctly now. Previously, a canvas that
was re-used and happened to have the same person in it would apply the
photo even if the dimensions didn't match. Now, PhotoManager makes a
record of the canvas's "generation" at request time, so the results can
later be rejected entirely if the canvas generation differs.

Bug: 8051779
Change-Id: I31c3fd0c3bcc10641f264b6e30eb133cc0bf77b3
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
30b17e3a157dcfd65cf51ebb788283efa79df268 08-Apr-2013 Vikram Aggarwal <viki@google.com> Remove the subject from the actionbar

Following the new UX guidelines: no subject in actionbar anymore.

Bug: 8438223 Subject of the mail disappears from the action bar on
orientation change to landscape mode

Bug: 8492928 Action bar title switches between subject and the
folder+account name

Bug: 8529168 Remove search_actionbar_view

Change-Id: I8551fdacd7843ca0b2ba0bf1025483eee2587638
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
67aa9e5162a15fb8b46b4113ac627cd20668f095 20-Mar-2013 Scott Kennedy <skennedy@google.com> Exclude all inbox labels when we're viewing an inbox

Bug: 8426563
Change-Id: Ib9256fcdb658cb3df9b67485f7768f75bb8b6539
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
d8c68c08dca0b45e7681a5756da73bced452c42d 19-Mar-2013 Vikram Aggarwal <viki@google.com> Remove Folder.newUnsafeInstance

Creating a Folder object just for populating three values is excessive.
Also, avoid creating and passing String objects when a simple integer
will be less convoluted.

Change-Id: I4b0a5ddd2da16310f5c7863dcb61d6d15d57aef4
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
8f1877832b0f3bc55e6d63ccf70dfae7dd8328c9 07-Nov-2012 Andy Huang <ath@google.com> wire up snap headers pref

Have conversation view read the initial value upon view creation
and update the value in ConversationContainer via dataset
change, which is triggered by account change (which is triggered
by settings change!).

Bug: 7217360
Change-Id: I55ac947dea692af6ad32995d0970c69dbdf5c2ef
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
0d3bbc800f05d3783f963675125060b890ec0024 16-Oct-2012 Paul Westbrook <pwestbro@google.com> Fix NPE in secure conversation mode

Change-Id: I3ea4b6a31ff183cad79e6ac88a0ea40ed97208da
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
7388dba58aecafacd91ded0f787cf01bfc7af232 26-Sep-2012 Andy Huang <ath@google.com> cleanup. fix minor logging errors.

Don't notify JS of a height change during initial render.
(it's not a height change if it's the first time.)
Don't even bother measuring the conversation header during
initial render, since the view that's being bound is temporary
and not attached yet.

Bug: 7154554
Change-Id: I8c8147123bb15173888a3ad95e1ca3703018a520
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
ab2d998506c83e82ddae25b6ba1419414e1e8122 25-Sep-2012 Mark Wei <markwei@google.com> Fixed conversation label header doesn't increase height when adding labels

Bug: 7154554
Change-Id: Iacdf4bb7466978c0da3e3985d14e42894dac2ff7
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
0c3c2058f75487713c64634c7f08025fd78ba012 21-Sep-2012 Vikram Aggarwal <viki@google.com> Explicit Intent to view Inbox

The Compose Activity was creating an intent with a folder object
populated with uninitialized values. Using this object is very
unsafe. Since the entire goal was to view the default inbox, that is
easily done by passing an intent without a folder. AAC.handleIntent()
shows the default folder when only an account is specified in the
intent.

Since using new Folder() is very unsafe, the method is made private,
and a static method with a suitably dangerous name was created to
ensure that callers are aware of the peril involved.

Fixes Bug: 7139995 Empty conversation list

Change-Id: Ic3e254630afd59a59caba10f2249e3e451005d63
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
604f7716eaac3bc0989cdb2ff129c383b6dfe4d6 18-Sep-2012 mindyp <mindyp@google.com> Make sure we properly set the subject, hide the area where folders would go

Fixes b/7178668 Unnecessary white space above email message headers

Change-Id: Id72b6e01be1663c201519e70728c5d2dd97d5af3
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
36280f3c2939bb2dacb4077bd528900346ff4bb9 10-Sep-2012 mindyp <mindyp@google.com> Update conversation folders when they change.

fixes b/6305908 After applying label in the message view, the label is not displayed
make priority indicator update as well
Change-Id: I4ea59f1eaa0bf97545d44b1ef897d5f5c98f060a
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
28b7aee7fa1f7d096d33fc823a88a64f7a3fa79d 21-Aug-2012 Andy Huang <ath@google.com> update conversation view on reply-all setting change

Use existing adapter's dataset change signal-- dump overlays
and re-render.
Begin to assume that Settings always hangs off Account.

Bug: 6245217
Change-Id: I70f98f641eee6d193f9842a578a889197f650941
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
f76bf4cf779b6eadb1cc6208a63e4558a3c0abee 01-Aug-2012 Vikram Aggarwal <viki@google.com> Priority arrow setting in conversation view

Change-Id: I33a668509e20dafd9d8de022772e21d4c522d278
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
85c4a77abd849f5f3f0236d51554bb1bb99fe8f6 30-Jul-2012 Mindy Pereira <mindyp@google.com> Cache displayable folders.

Change-Id: Ibb2766e5a197a86adb0a456dc1fb58cdd98fd610
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
53f262e1c93fc20c9c44d46ebb9fc1b5a44cd06b 27-Jul-2012 Mindy Pereira <mindyp@google.com> Use cached rawfolders.

Change-Id: I4b70c2761a699541b98a02a24f8cd017df13433f
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
1284fd6e98a1e6757742c1fcc18ab0a1cc7aacdd 13-Jul-2012 Andy Huang <ath@google.com> only mark important conversations important

Bug: 6239637
Change-Id: Ib232282aeee7ea50031ecbefeda60c1c6641bce2
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
5895f7b0e5fa921f6d46bbaf6d8c7b1a8ebc7804 02-Jun-2012 Andy Huang <ath@google.com> subject in actionbar

Mostly a port of Gmail1 code. New and noteworthy:
* when switching between ActionBar list nav vs. custom display,
toggle ActionBar.DISPLAY_SHOW_CUSTOM rather than messing with
custom view visibility
* This exposes something of a framework bug where collapsing
an action view will leave views for all inactive navigation
modes GONE, which I work around for now (b/6664203).
* ActionBar views were being inflated with system default Holo
theme due to application vs. ActionBar context (wrong theme on
the application context). Fixed that and un-inverted some
existing styles.
* SnippetTextView: save off the last measurespec rather than
inventing one as before.
* bring back an existing excellent behavior: since
PagerAdapter.setPrimaryItem reacts too slowly to nicely
change the action bar subject when paging, listen for
OnPageChangeListener.onPageSelected in addition.

Bug: 6384157
Change-Id: I45d995a472d4b3c71f1371dc7b993923423b7cf7
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
9875bb4fc00347fc76f432a6e9ec5e6987679ca9 05-Apr-2012 Andy Huang <ath@google.com> remeasure when overlay views change size

The initial measure() (for sending to WebView) is done too soon,
so after a height change, ensure that the container re-measures.
The container will only measure newly bound views, or views with
newly changed heights, so most scrolling continues to not
trigger measure().

It would be more correct to mark the overlay *view* itself
valid or invalid, not the item, but apps don't have access to
the measurement flags on View.

Also do lots of cleanup in the area of measure/layout of the
Container. Prevent children of the container from requesting
layout because they don't push on each other in the normal way.
(a followup onGeometryChange is needed to re-position properly)
But a layout triggered from elsewhere should re-measure and
re-position the container's overlays.

Bug: 6297423

Change-Id: Id9196322774e732417e926ac87ce2ec524bf425e
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
5ff63747a1b5c6e2197528972cbc3ba808b09d8d 17-Mar-2012 Andy Huang <ath@google.com> show subject and labels in conversation view

Show labels only for accounts that support multi-folder
conversations.
Move some classes into smaller 'browse' package.
Special-case subject/labels overlay for now. Full adapterization
is coming soon when super-collapsed blocks are in.

Change-Id: I458009776eb2e3840dd9e441de9e4ead3cc94d0b
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java
c03208720e5650f0acb748f82ed10ac770d6ceb4 14-Mar-2012 Andy Huang <ath@google.com> bring in classes to support conversation view's subject/labels

No functional change.

Bring in classes and refactor existing folder-display related
classes. Remove FolderValues and use plain Folder. If we need
somewhere to tuck display-only Folder properties or behavior, we
should wrap base Folders instead of duplicating fields.

Folder objects now support equality checking using the
(globally unique) URI.

Change-Id: Ic4cd9b555a6a71ed037a1e730f36f7f64c50ca36
/packages/apps/UnifiedEmail/src/com/android/mail/browse/ConversationViewHeader.java