| 78904e6625453ef4c58a6161a971cd60cf967db1 |
|
30-Sep-2015 |
Peter Qiu <zqiu@google.com> |
Perform synchronous Get before reading property value
Currently, when getting a property value, we only read the
cached value. It is possible to read the cache value before
it is initialized, since it is being initialized using
asynchronous GetAll function.
Instead, explicity perform synchronous Get to ensure the
cache value is valid before returning it. This will match
the previous behavior that we had when using dbus-c++ library.
This will fix the problem with WiMax, where we tried to
use an uninitialize property value, causing WiMax service
failed to start.
Bug: None
BUG=chromium:533423
TEST=Run network_WiMaxSmoke autotest
TEST=Run wifi_matfunc
Change-Id: I0bef30a45e5ab34ffc142e6076755f9d74107af9
/system/connectivity/shill/dbus/chromeos_wimax_manager_proxy.cc
|
| 289a5a5e18bb1a676b3dfce111af4c2c00c7776e |
|
21-Sep-2015 |
Samuel Tan <samueltan@google.com> |
shill: use different service_constants.h path for Android builds
Use the service_constants.h file from the external/cros/system_api/dbus
instead of chromeos/dbus/service_constants.h, since this header file
is installed into different directories when building shill for Android
and Chrome OS.
BUG: 22956441
Change-Id: I7e6ea46b4893588d2862792cf43aa83fdf7c30b4
TEST: shill still compiles using emerge.
/system/connectivity/shill/dbus/chromeos_wimax_manager_proxy.cc
|
| 2148dfd552b045aff8eed4c3fb8cf9ff5a3758ef |
|
22-Sep-2015 |
Peter Qiu <zqiu@google.com> |
Revert "dbus: release object proxy from the bus"
This reverts commit a9a0e8356b33ccac1f06ffb1cb8a601dca4d62f2.
The original CL causes shill crash on reboot and suspend/resume
https://code.google.com/p/chromium/issues/detail?id=534299.
Revert it for now to unblock others. Will dig deeper to find
the root cause.
Bug: None
TEST=Run ExternalUsbPeripherals autotest
Change-Id: I3a568ba09fc669a93a74fca0957c93211737134f
/system/connectivity/shill/dbus/chromeos_wimax_manager_proxy.cc
|
| a9a0e8356b33ccac1f06ffb1cb8a601dca4d62f2 |
|
17-Sep-2015 |
Peter Qiu <zqiu@google.com> |
dbus: release object proxy from the bus
Currently, the generated Chrome OS D-Bus proxies are leaking
memory/resources, since they never remove the underlying object
proxy from the bus upon destruction. This causes a problem
when we frequently create/destroy proxies (ChromeosSupplicantBSSProxy),
where the bus would permenantly fail to add match rules for
new object proxies once the limit for match rules is reached.
Without match rules, object proxies will not be able to receive
any signals from the bus.
To resolve this issue, explicitly release the object proxy from
the bus upon proxy destruction.
Note: ReleaseObjectProxy calls Bus::RemoveObjectProxy, which is
an asynchronous call. So the bus can only be destructed after the
asynchronous object proxy cleanup is completed.
Note: do not release the object proxy from the bus for cellular proxies.
It turns out that cellular initializes a lot of their proxies using
the same service name and path. And in libchrome's D-Bus library,
D-Bus objects are mapped based on service name and path. So
for proxies with same service name and path, only one D-Bus object
is actually allocated by the bus. Based to this behavior, the
resource leak from cellular proxies should be minimal, and
shouldn't have any negative impact on shill.
While there, defer the destruction for the ChromeosDBusControl
to ChromeosDaemon's destructor. Since the proxy bus can only be
deleted after the asynchronous object proxy cleanups are completed.
Bug: 23560086
TEST=Verify no "org.freedesktop.DBus.Error.LimitsExceeded" error
TEST=in /var/log/net.log after leaving a wolf device up for a day.
TEST=Verify no shill crash after restarting shill
Change-Id: Ic78eed00b448743f11738717f2b0ac7da08fc135
/system/connectivity/shill/dbus/chromeos_wimax_manager_proxy.cc
|
| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/dbus/chromeos_wimax_manager_proxy.cc
|
| ce2aeebbcf78c637deac48a4e943a86ba1415d27 |
|
29-Jul-2015 |
Peter Qiu <zqiu@chromium.org> |
shill: implement wimax manager proxies using chromeos DBus
BUG=chromium:507869
TEST=unittests
Change-Id: Ie19a76324380879d767c0cdd81969ad3606568a5
Reviewed-on: https://chromium-review.googlesource.com/289325
Tested-by: Zeping Qiu <zqiu@chromium.org>
Trybot-Ready: David James <davidjames@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Zeping Qiu <zqiu@chromium.org>
/system/connectivity/shill/dbus/chromeos_wimax_manager_proxy.cc
|