| 289a5a5e18bb1a676b3dfce111af4c2c00c7776e |
|
21-Sep-2015 |
Samuel Tan <samueltan@google.com> |
shill: use different service_constants.h path for Android builds
Use the service_constants.h file from the external/cros/system_api/dbus
instead of chromeos/dbus/service_constants.h, since this header file
is installed into different directories when building shill for Android
and Chrome OS.
BUG: 22956441
Change-Id: I7e6ea46b4893588d2862792cf43aa83fdf7c30b4
TEST: shill still compiles using emerge.
/system/connectivity/shill/ephemeral_profile.cc
|
| d48e8140b17d9f04e9848e1e638c483450a5dcfc |
|
22-Sep-2015 |
mukesh agrawal <quiche@google.com> |
shill: Profile: change ctor arg type from string to FilePath
The |user_storage_directory| argument to the Profile ctor
is stored inside the Profile object as a FilePath, and the
DefaultProfile ctor takes its path argument as a FilePath.
Both of these facts argue for |user_storage_directory| to
be passed in as a FilePath, rather than a string.
Make it so.
Bug: None
TEST=unit tests
Change-Id: I6094aeb44de96ccd0312c5311bdd195ee64cf510
/system/connectivity/shill/ephemeral_profile.cc
|
| c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2
This patch automatically replaced the license on all text files from
Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as
a reference.
The license header was added to .gyp and .gypi, the NOTICE was added with a copy
of the Apache2 license and MODULE_LICENSE_* file was added.
BUG=23587594
TEST=grep 'Chromium OS Authors' doesn't find anything.
Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/ephemeral_profile.cc
|
| a794cd60a7339d576ea2eed263a4f0a20fb255af |
|
16-Jun-2015 |
Paul Stewart <pstew@chromium.org> |
shill: Top-level files a-e: Switch pointer/ref spacing
Switch to Chrome style spacing.
BUG=chromium:501026
TEST=Unit tests
Change-Id: Idb7252202e142098999fe0672712aded7d369259
Reviewed-on: https://chromium-review.googlesource.com/278038
Reviewed-by: Rebecca Silberstein <silberst@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| c9c31d8497c3f053c2160408cc386010fc125fad |
|
22-Oct-2014 |
Rebecca Silberstein <silberst@chromium.org> |
shill: add object id to scoped log messages
Add object identifier (DBus::Path) string to scoped logging messages. If
the logging message is called from a static method, SLOG will be called
with nullptr and the log will use (anon) for the object id. Objects
without identifying information will use the (class_name) as their logged
identifier.
BUG=chromium:403996
TEST=ran unit tests and manually inspected net.log
Change-Id: Idf23911a303f5edc4b82917bf1e2cea3f8e44e60
Reviewed-on: https://chromium-review.googlesource.com/224812
Tested-by: Rebecca Silberstein <silberst@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Rebecca Silberstein <silberst@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| cc225ef3b77b5e098cc12c661a947e1737480777 |
|
30-Sep-2014 |
Ben Chan <benchan@chromium.org> |
shill: Replace NULL with nullptr.
BUG=None
TEST=`USE=wimax FEATURES=test emerge-$BOARD shill`
Change-Id: I30ab47ff32dcadad09ae7a2baf4d4123a6ef0d8e
Reviewed-on: https://chromium-review.googlesource.com/220657
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 86a22598bac564b2030aed6f862f684a96471836 |
|
25-Jul-2014 |
mukesh agrawal <quiche@chromium.org> |
shill: logging: give EphemeralProfile a friendly name
In some cases, we'd see log messages of the form "Moving service 1 to
profile from profile". This is confusing, to say the least.
Fix this, by having EphmeralProfile override GetFriendlyName.
BUG=None
TEST=unit tests
Change-Id: Ia7cf6ff28301bf3b991c606cbac3a2145a856587
Reviewed-on: https://chromium-review.googlesource.com/210048
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 5133b71eaa00535739ebbddd8a8f31cd8fcf33a8 |
|
19-Feb-2013 |
Thieu Le <thieule@chromium.org> |
shill: Add metric to track corrupted profiles
New metric Network.Shill.CorruptedProfile.
BUG=chromium-os:38669
TEST=1. Unit tests
2. Stop shill
Corrupt /var/cache/shill/default.profile by adding junk
Start shill
Verify new metric appears in chrome://histograms
Change-Id: I629ed00884ecd2d2fe90744583bd72bf2e9e6af4
Reviewed-on: https://gerrit.chromium.org/gerrit/43556
Reviewed-by: Thieu Le <thieule@chromium.org>
Tested-by: Thieu Le <thieule@chromium.org>
Commit-Queue: Thieu Le <thieule@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 457728b3eeb2d67c980e0d20675f0a0f750903e1 |
|
09-Jan-2013 |
Darin Petkov <petkov@chromium.org> |
shill: Log service's unique name rather than friendly name.
This way we consistently identify the service throughout shill's logs
as well as alleviate PII concerns due to SSIDs leaking into
logs. Renamed Service::UniqueName() to Service::unique_name(), per
style. Made Service::friendly_name() protected to limit its accidental
use.
BUG=chromium-os:37679
TEST=unit tests, tested on device and inspected logs
Change-Id: Idcdba75875a9d10cda51b714730ef633876481c6
Reviewed-on: https://gerrit.chromium.org/gerrit/40926
Tested-by: Darin Petkov <petkov@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Darin Petkov <petkov@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 7917360b71c6680de60b487b3630dc1a0f8cdca2 |
|
13-Nov-2012 |
Philipp Neubeck <pneubeck@chromium.org> |
shill: Add emits for proxy and profile properties.
Added emits for the properties:
- Service.ProxyConfig
- Service.Profile
- Manager.Profiles
These are required by Chrome to update Policies and Proxies correctly.
BUG=chromium:157642
TEST=None, adapted manager unit test to ignore emits.
Change-Id: Icba2b43804d1d69e3b93ef0b2f30606c8d6f9753
Reviewed-on: https://gerrit.chromium.org/gerrit/37935
Tested-by: Philipp Neubeck <pneubeck@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Reviewed-by: Darin Petkov <petkov@chromium.org>
Commit-Ready: Philipp Neubeck <pneubeck@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| b691efd71561246065eae3cdd73a96ca1b8a528d |
|
09-Aug-2012 |
Christopher Wiley <wiley@chromium.org> |
shill: Rename SMLOG to SLOG
Rewrite SMLOG as SLOG, thus saving many edits. Change the location of
the SLOG macro to be memory_log.h, requiring includes to be rewritten
and reordered. While we're rewriting includes, moving all assorted
logging includes into a generic shill/logging.h, thus saving future
logging changes from altering these includes ever again.
BUG=chromium-os:31145
TEST=Builds, unit tests still pass
Change-Id: Ie5129fcbdda87f3149460209a682c698b876b09a
Reviewed-on: https://gerrit.chromium.org/gerrit/29650
Commit-Ready: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Tested-by: Christopher Wiley <wiley@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| fad4a0b7e55dd82d3815ee96862b6e546727eb6e |
|
19-Apr-2012 |
Ben Chan <benchan@chromium.org> |
shill: Replace VLOG with SLOG.
This CL replaces all uses of VLOG(level) with SLOG(scope, level) with
the same verbose level and an appropriate scope for each affected
logging statement.
BUG=chromium-os:29641
TEST=Build and run unit tests. Test scope logging with ff_debug.
Change-Id: Ifdcf1faa2a309bcbd9ee369a66179ce9c7f1ad19
Reviewed-on: https://gerrit.chromium.org/gerrit/20629
Commit-Ready: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 6515aabcd1fbbb9ff2090c9675c17eeef64e7474 |
|
13-Oct-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Make profiles backed with StoreInterfaces
Rely on persistence of data in StoreInterface to maintain
Service/Device/IPConfig info for entities that are not
currently active, instead of maintaining lists in Profile
objects themselves.
BUG=chromium-os:17253
TEST=unit, run on device
Change-Id: I206f44ddf16c584354f8fcadb57032f047f33d0a
Reviewed-on: http://gerrit.chromium.org/gerrit/10024
Commit-Ready: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| b9c00597eb1f6d2560f7e88cb0d1f627228840d4 |
|
06-Oct-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Profiles need to own their own storage
We're moving to a model where we rely on the StoreInterface
implementation to maintain profile state, instead of managing
a list of Service objects manually. Thus, we need to allow
Profile to own its own StoreInterface.
BUG=chromium-os:17253
TEST=unit
Change-Id: Ie62462686ecf598efeac08a2d3180cd372430bb9
Reviewed-on: http://gerrit.chromium.org/gerrit/9916
Commit-Ready: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 1830fa1f2e8691073f4d07b0883f059a290a9cc2 |
|
26-Sep-2011 |
mukesh agrawal <quiche@chromium.org> |
shill: enable (don't disable) -Wunused
having fixed an unused parameter in the dbus-c++ headers, those
headers no longer have unused parameters. so, if we fix up unused
parameters in shill code, we can compile with -Wunused. (this is
implied by -Wall, as long as we don't override with -Wno-unused.)
BUG=chromium-os:20779
TEST=unittests
- comment out unused parameters in function definitions
- remove some unused local variables
- also: fix an old-style cast
Change-Id: Ie654a7b34d622cecb0f26bd47c17813fe8423001
Reviewed-on: http://gerrit.chromium.org/gerrit/8365
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 9d779936d8f8c2d74b30883e2a2622c4207fe797 |
|
26-Aug-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Add code for persisting profiles and services to disk.
BUG=chromium-os:17253
TEST=unit
Change-Id: Ic6dbbcb10543da3f4615cb305a77f6b9b301e8bc
Reviewed-on: http://gerrit.chromium.org/gerrit/7633
Reviewed-by: Darin Petkov <petkov@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| ac4ac00189acd22ce95098712c74e1c2c23ede53 |
|
26-Aug-2011 |
Paul Stewart <pstew@chromium.org> |
shill: Clean up protected fields
...as per style. I did omit property_store_unittest.h, which I'll
assign to cmasone instead of closing the issue.
BUG=chromium-os:19573
TEST=Rerun unit tests
Change-Id: I37874b6e71f50e91ca753d1ef4f1e25abf77032d
Reviewed-on: http://gerrit.chromium.org/gerrit/6764
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
Reviewed-by: Darin Petkov <petkov@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 2ae797d040b7261a5619c750e07037566bcb542b |
|
24-Aug-2011 |
Chris Masone <cmasone@chromium.org> |
Re-land "[shill] Provide a cmd line toggle between flimflam and shill storage dirs"
This is so that we can easily switch to (and away from) using
the flimflam profile dir (and user profile dirs) when we start shill.
BUG=chromium-os:17253
TEST=unit
Change-Id: I0264162665607bb180688428c4640e42383ae355
Reviewed-on: http://gerrit.chromium.org/gerrit/6568
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 7156c923c9a9d2240ea9c62045337ac8c8f89e57 |
|
24-Aug-2011 |
Chris Masone <cmasone@chromium.org> |
Revert "[shill] Provide a cmd line toggle between flimflam and shill storage dirs"
This reverts commit 54c93e972563b713030a15ce3c1c1824800e317f
Change-Id: Id4bf4ee1e7e62efea5d116507d8b49d76a7a9556
Reviewed-on: http://gerrit.chromium.org/gerrit/6567
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 6402e501258c9f64373dcd05271c6c7dd75e20bc |
|
23-Aug-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Provide a cmd line toggle between flimflam and shill storage dirs
This is so that we can easily switch to (and away from) using
the flimflam profile dir (and user profile dirs) when we start shill.
BUG=chromium-os:17253
TEST=unit
Change-Id: I9352cf5c40a8f77bcda8cdc0b5912782b4e342ed
Reviewed-on: http://gerrit.chromium.org/gerrit/6454
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 7df0c672458bee8f4ff33004103351d59a9f4b50 |
|
15-Jul-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Start cleaning up some of the naming confusion
We have, so far, not been tidy wrt our objects naming themselves,
for human-readable stuff, RPC-path stuff, etc.
This starts to clean up some of that confusion.
BUG=chromium-os:17744
TEST=unit tests
Change-Id: If4d7f61ba51e527984328a0ccdf4dec461b36074
Reviewed-on: http://gerrit.chromium.org/gerrit/4311
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 6791a43add38926966bd420e89541717fb2cb2b5 |
|
12-Jul-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Enable Profile objects to manage a list of Services to persist.
The Manager will hang on to a list of active services. They will be sorted,
someday, in an order that makes sense. Every service will be associated with
a Profile, though it may the an ephemeral profile that won't persist state to
disk. Profiles will maintain a map of service name to service references to
track the services whose state they persist to disk. Services may move between
Profiles, and will certainly need to be bound to one after they are registered
with the Manager, so support for this is provided as well.
BUG=chromium-os:17436
TEST=unit tests
Change-Id: Id43a0e1d97302b6f574bd2213d4f3d176bb5223f
Reviewed-on: http://gerrit.chromium.org/gerrit/4033
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| b2e326bf37654683cdc8c0cbbab29d1af7910af8 |
|
12-Jul-2011 |
Chris Masone <cmasone@chromium.org> |
Re-land "[shill] Get rid of Entry as a first-class citizen""
This reverts commit 7c1ab1cb74bf6397c67e1cdc825043a93c4bce33.
Also, fixes some compile problems that only repro with debug flags
and that cause runtime dbus errors with the new version of libdbus
BUG=chromium-os:17436
TEST=unit tests
Change-Id: I479308e684b802f167788daeaf4ec39d0b63ee17
Reviewed-on: http://gerrit.chromium.org/gerrit/3961
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Darin Petkov <petkov@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 7c1ab1cb74bf6397c67e1cdc825043a93c4bce33 |
|
12-Jul-2011 |
Chris Masone <cmasone@chromium.org> |
Revert "[shill] Get rid of Entry as a first-class citizen"
This reverts commit 7c982eade99f01cb6b8719ed4d385c0ec6b50f75
Change-Id: I554c12003c18f09ac7f736e98b9ecd63829100e9
Reviewed-on: http://gerrit.chromium.org/gerrit/3957
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 9c9e8fb31c9b39fb2832e0804d5c71b3ef685427 |
|
12-Jul-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Get rid of Entry as a first-class citizen
Entry was a bad idea. Instead, merge that stuff back into Service and
make Profile objects just have a list of Services. Live Services will
be registered with Manager; ones that exist only within a Profile will
have to be accessed by querying the Profile over DBus, just like
today.
BUG=chromium-os:17436
TEST=unit tests
Change-Id: Id07d762925b252219aa79340931e34b87f10007e
Reviewed-on: http://gerrit.chromium.org/gerrit/3951
Reviewed-by: Darin Petkov <petkov@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|
| 7aa5f90848b530999d8b6788ecb40aa30871c7ae |
|
11-Jul-2011 |
Chris Masone <cmasone@chromium.org> |
[shill] Back property storage in Service objects with Entry objects
Much of Shill Service state is persisted to disk, by creating an Entry
in a Profile. We should store this info just once, so that we don't
have to worry about keeping multiple data stores in sync. This is a
first step in that direction.
BUG=chromium-os:17436
TEST=unit tests
Change-Id: If94db2a38a7d79c56e2c746b2f069cfd7ab4bf65
Reviewed-on: http://gerrit.chromium.org/gerrit/3876
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Darin Petkov <petkov@chromium.org>
/system/connectivity/shill/ephemeral_profile.cc
|