bad1c10ffd2d4ac14f7bd9f4ef6a8982e711f566 |
|
19-Sep-2015 |
mukesh agrawal <quiche@google.com> |
shill: remove references to GLib There are a number of references to GLib (the object), even though no one uses GLib in a substantive way. Remove these obsolete references. Bug: 23386647 TEST=unit tests Change-Id: I8d574980bc8e853c8b87ef64b581d64a71491201
/system/connectivity/shill/virtual_device_unittest.cc
|
c0beca55d290fe0b1c96d78cbbcf94b05c23f5a5 |
|
03-Sep-2015 |
Peter Qiu <zqiu@google.com> |
License shill to Apache2 This patch automatically replaced the license on all text files from Chromium OS (BSD style) to AOSP (Apache2), keeping the original year as a reference. The license header was added to .gyp and .gypi, the NOTICE was added with a copy of the Apache2 license and MODULE_LICENSE_* file was added. BUG=23587594 TEST=grep 'Chromium OS Authors' doesn't find anything. Change-Id: If41ede586c2465f5831fb7fee270ff41dbfdb596
/system/connectivity/shill/virtual_device_unittest.cc
|
8d6b59704591ba9fad57751858835dc332dbdd37 |
|
28-Oct-2014 |
Peter Qiu <zqiu@chromium.org> |
shill: export a shared library for RTNL interface. Export a shared library "libshill-net-<(libbase-ver)" from shill, which currently includes the RTNL interface and other codes that it depends on (mainly ByteString, IPAddress, IOHandler, TimeStamp, and Sockets). All the library codes are moved to under "shill/net/". Upcoming changes: - Remove dependency for "shill/error.h" which depends on dbus-c++. - Add Netlink interface to the shared library. BUG=chromium:427982 TEST=unittests CQ-DEPEND=CL:226103 Change-Id: I7f5c183b8a347c02e80ffed5e3497f691dde517c Reviewed-on: https://chromium-review.googlesource.com/226110 Reviewed-by: Peter Qiu <zqiu@chromium.org> Tested-by: Peter Qiu <zqiu@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org>
/system/connectivity/shill/virtual_device_unittest.cc
|
a41ab517725d036b63420f8445550246f8f50b99 |
|
23-Jul-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
shill: Sort headers alphabetically (build/include_alpha) We are going to enable build/include_alpha linter warning soon, so in preparation for this, fixed the warnings in shill. BUG=None TEST=cpplint.py --filter=-build/include_order,+build/include_alpha shill/* Change-Id: I113ed7f9dd3f465a3f660599320cdb434e7cc214 Reviewed-on: https://chromium-review.googlesource.com/209636 Tested-by: Alex Vakulenko <avakulenko@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/connectivity/shill/virtual_device_unittest.cc
|
8a5322984f2d81bcbfd8d44c59747a11bd9b904b |
|
17-Jun-2014 |
Alex Vakulenko <avakulenko@chromium.org> |
shill: Fix most of warnings from cpplint Fix most cpplinter's warnings. On a few occasisions, the warnings produced were false-positives, so added explicit // NOLINT comment overrides. There were a few instances of disallowed non-const reference usage (reported as runtime/reference error by cpplint) for "DBus::Error &error" which should potentially be changed to pointers to comply with C++ coding style but I will let Shill owners do that since there is quite a few of those and the change isn't brain-dead simple... BUG=None TEST=platform2 still compiles and all unit tests pass. Change-Id: Ic2e31896aa13d20eeb1a85dee74f3db8cccfde2e Reviewed-on: https://chromium-review.googlesource.com/204164 Tested-by: Alex Vakulenko <avakulenko@chromium.org> Reviewed-by: mukesh agrawal <quiche@chromium.org> Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
/system/connectivity/shill/virtual_device_unittest.cc
|
4a165582f3a9d425ba1c5fde717b0b76f03dbf3f |
|
03-Aug-2013 |
mukesh agrawal <quiche@chromium.org> |
shill: add yet more unit tests for ppp dongle support This time, the lucky winner is VirtualDevice. BUG=chromium:246826 TEST=unit tests (old+new) Change-Id: I1c87afa29ba9ebed1a95c2e5132fbe90161aaced Reviewed-on: https://gerrit.chromium.org/gerrit/64401 Commit-Queue: mukesh agrawal <quiche@chromium.org> Tested-by: mukesh agrawal <quiche@chromium.org> Reviewed-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/virtual_device_unittest.cc
|
a8f7c4990e64897c070d89b599e050017555de5d |
|
14-Jun-2013 |
mukesh agrawal <quiche@chromium.org> |
shill: build virtual_device_unittest.o for shill_unittest Previously, it was a dependency of shill. That meant that a) we were wasting time compiling a unit test when we just wanted the daemon b) we never ran the test, because it was linked to shill_unittest as a library. because none of the code in shill_unittest referenced it, it was discarded. Props to @davidjames for reporting a), and to @gauravsh for helping me figure out b). BUG=chromium:249545 TEST=manual (see below) Manual test ----------- - make clean - cros_workon_make --board=link --reconf shill - find . -name virtual_device_unittest.o (no match) - cros_workon_make --board=link --test --reconf shill - find . -name virtual_device_unittest.o (matches) - GTEST_FILTER="VirtualDeviceTest.*" \ cros_workon_make --board=link --test --reconf shill (runs one unit test) Change-Id: I53ee69cf940c83ea309036d22d96ead39ecadfac Reviewed-on: https://gerrit.chromium.org/gerrit/58612 Reviewed-by: Gaurav Shah <gauravsh@chromium.org> Commit-Queue: mukesh agrawal <quiche@chromium.org> Tested-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/virtual_device_unittest.cc
|
9da07771df3dbbc99ff99114c26317d01f29f7fc |
|
15-May-2013 |
mukesh agrawal <quiche@chromium.org> |
shill: support 3G dongles with PPP interface Assuming the 3G dongle has been switched to modem mode (with usb_modeswitch or similar), and an activated SIM is present, shill will automatically connect to the cellular network. The primary change, as far as the Cellular/Modem logic goes, is that we take the absence of a link name to mean that the modem is a PPP dongle. Instead of bailing out, we create the Cellular object, and register it with the manager as any other Cellular device. When the Cellular connection is complete, CellularCapabilityUniversal checks the Bearer's IPConfig method, as indicated by modemmanager1. If the method is specified as PPP, the capability asks the Cellular device to start PPP. When PPP setup completes, Cellular passes the IP configuration information to the PPPDevice. At that point, the PPPDevice is assigned an IP address, and routing is updated appropriately. Notable changes: - Moved VPN to VirtualDevice, changed OpenVPNDriver to use it, created a new subclass PPPDevice. - Moved PPP code out of L2TPIPSecDriver, and into PPPDevice. - Changed L2TPIPSecDriver to use PPPDevice. While there: - Got rid of VPNDriver::OnDisconnected, and changed callers to use DropConnection instead. - Made Load and Save of VirtualDevices no-ops. This eliminates the confusingly named "device_" stanzas in the default profile. We lose VPN byte counts by doing this, but they weren't sensible anyway (they'd be shared across potentially different VPNs). New units will follow in another CL (TBW). BUG=chromium:240051 TEST=unit tests, manual Manual testing -------------- 1. Get 3G PPP dongle. 2. Install activated SIM. 3. Plug dongle into USB port. 4. Wait for the dongle to switch to modem mode. (I used a manually installed usb_modeswitch, but this will soon be handled by mist.) 5. Wait for the dongle to connect. With the Huawei E303, this takes about 35 seconds. Change-Id: I916bef451ee6e8dcf1af8135ecf6787251acf19b Reviewed-on: https://gerrit.chromium.org/gerrit/51356 Commit-Queue: mukesh agrawal <quiche@chromium.org> Reviewed-by: mukesh agrawal <quiche@chromium.org> Tested-by: mukesh agrawal <quiche@chromium.org>
/system/connectivity/shill/virtual_device_unittest.cc
|