| c43ea562a0447330b26eeec3c7b1fb935958e985 |
|
08-Feb-2014 |
Prathmesh Prabhu <pprabhu@chromium.org> |
pseudomodem: Some simple style fixes.
Fix where this doesn't hold:
- Two lines between top level classes, functions, class methods.
- No lines between @param/@returns/@raises in docstrings
- One blank line at the end of docstring, unless it's a one line docstring.
- Uniformity: Change to @returns and @raises.
BUG=chromium:339312
TEST=None.
Change-Id: I959aa27875531644fd0f34a54d0046a059dbf164
Reviewed-on: https://chromium-review.googlesource.com/185475
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/client.py
|
| 317eed3023be98b2d5c0a2e4040278158e213076 |
|
06-Feb-2014 |
Prathmesh Prabhu <pprabhu@chromium.org> |
pseudomodem: Ensure child process is ready before continuing from context.
After this CL, |pseudomodem_context| ensures that pseudomodem is up and ready to
serve requests before continuing on the main process. This avoids race condition
between the test continuing on the main process and pseudomodem initialization
in the child process.
BUG=chromium:337990
TEST=(1) run_pseudomodem.py
(2) Run the changed tests: network_3GScanningProperty,
network_CDMAActivate, network_SIMLocking
Change-Id: Idc17b0b6aa452f9f7d90e7a6b5be0e996ea06afa
Reviewed-on: https://chromium-review.googlesource.com/185103
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/client.py
|
| 0d75056f7bfb1c2b42d8a2c7ebbd34f69bc95db6 |
|
28-Jan-2014 |
Prathmesh Prabhu <pprabhu@chromium.org> |
pseudomodem: Run pseudomodem in a separate subprocess.
This CL cleans up the way pseudomodem is launched. The main changes are:
- |pseudomodem.py| no longer tries to fork pseudomodem in a background
process. It is now a top level package that runs pseudomodem in the current
process. This should no longer be used directly.
- |pseudomodem_context.py| should be used by tests. The companion module
|run_pseudomodem.py| should be used to run pseudomodem from the command
line. This cleanly launches pseudomodem in a separate process. It also
provides ways to customize the pseudomodem with the same flexibility as
before this CL.
- Logs from pseudomodem are now directed to syslog, and are handled in the
same way as ModemManager logs. Additionally, logs can be directed to stdout.
- pseudomodem now runs as the 'modem' user -- this is the user that
modemmanager runs as.
BUG=chromium:328257
TEST=(1) Run
/usr/local/autotest/cros/cellular/pseudomodem/pseudomodem_context.py
with and without the '--cli' option and ensure pseudomodem works as
expected in standalone mode.
(2) After fixing tests (see companion CL:184088), run network3g_pseudomodem
and network_ui test suites.
CQ-DEPEND=CL:184088
Change-Id: I0c1f275150c52a6ae882b1fc260bcbd6401754b9
Reviewed-on: https://chromium-review.googlesource.com/184059
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/client.py
|
| c569e99b922542e7ddbbc4cd465fc8328ec16214 |
|
22-Jan-2014 |
Thieu Le <thieule@chromium.org> |
cellular: Refactor pseudomodem mm1.py into constants and errors.
cros/cellular/mm1_constants.py: This module contains ModemManager
specific constants which are used by the pseudomodem and a future
ModemManager proxy.
cros/cellular/pseudomodem/pm_constants.py: Pseudomodem specific
constants (eg. testing interface, state machine names)
cros/cellular/pseudomodem/pm_errors.py: Pseudomodem specific exception
classes.
BUG=chromium:219144
TEST=network_3GDisconnectFailure/control
network_3GDisableWhileConnecting/control.pseudomodem
network_3GFailedConnect/control.pseudomodem
network_3GIdentifiers/control.pseudomodem
network_3GModemControl/control.pseudomodem
network_3GModemPresent/control.pseudomodem
network_3GSafetyDance/control.pseudomodem
network_3GScanningProperty/control
network_3GSmokeTest/control.pseudomodem
network_3GStressEnable/control.pseudomodem
network_CDMAActivate/control
network_ChromeCellularNetworkPresent/control
network_ChromeCellularNetworkProperties/control
network_ChromeCellularSmokeTest/control
network_LTEActivate/control
network_SIMLocking/control
Change-Id: I7b02cf0ee6b1b73fb1eb7fcf0f10068e7515e465
Reviewed-on: https://chromium-review.googlesource.com/183526
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Thieu Le <thieule@chromium.org>
Commit-Queue: Thieu Le <thieule@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/client.py
|
| 4b64e9ff090ace27a336d1444a120f22fba15cc9 |
|
05-Dec-2013 |
Prathmesh Prabhu <pprabhu@chromium.org> |
pseudomodem: Add interactive state machines
This CL adds an option to run pseudomodem machines in interactive mode. When a
state machine is run in this mode, it exports a new testing object on a testing
interface, and waits for an |Advance| call on this testing interface before
taking each step. This is intended to allow tests fine grained control on the
progress of the state machine.
Specifically, this CL,
(1) Extends StateMachine to support interactive mode
(2) Adds a StateMachineFactory to increase flexibility in how state machines
are instantiated by the Modem.
(3) Extends the standalone mode of pseudomodem to run with some or all state
machines in interactive mode.
(4) Extends Client to add basic functionality to allow interacting with a
machine from the cli.
BUG=chromium:326439
TEST=(1) Run pseudomodem in standalone mode and interactive mode with
interactive state machines.
(2) Run existing pseudomodem tests.
Change-Id: Ic448be4958904842a683bd441362ae0262c1c3bc
Reviewed-on: https://chromium-review.googlesource.com/179070
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/client.py
|
| 6e5f5087e263d7bf17dda8b8324c6b1648debcb9 |
|
16-Aug-2013 |
Arman Uguray <armansito@chromium.org> |
pseudomodem: Add support for 'VendorPcoInfo'.
Added support for reading and debugging the Modem3gpp VendorPcoInfo property.
BUG=chromium:273847
TEST=1. stop modemmanager; pseudomodem.py -f 3GPP -i
2. Use "set pco" to set the pco value.
3. The org.freedesktop.ModemManager1.Modem.Modem3gpp.VendorPcoInfo
property should update to the value set by "set pco". Check
using DBus-Python.
Change-Id: I9c52b4165fd909f81c4cfc71c37e9778c61b741d
Reviewed-on: https://gerrit.chromium.org/gerrit/66052
Reviewed-by: Thieu Le <thieule@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
Commit-Queue: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/client.py
|
| f4fc926ee1a10609e545b0edbc2921be93a78790 |
|
06-Aug-2013 |
Arman Uguray <armansito@chromium.org> |
pseudomodem: Added SMS support.
Pseudomodem can now simulate fake SMS reception. It doesn't yet handler
multi-part SMS.
BUG=chromium:268573
TEST=1. stop modemmanager; stop cromo; pseudomodem -f 3GPP -i
2. In the shell run 'sms 15555555555 This is a fake SMS message.'
The UI should notify the arrival of a new SMS.
Change-Id: Iceadfd77cf0bd436c6f1b781311de37d28d61395
Reviewed-on: https://gerrit.chromium.org/gerrit/65037
Commit-Queue: Arman Uguray <armansito@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/client.py
|
| e6a6e0d0b3664a9cf4359bf060517b1447e2f4ff |
|
06-Aug-2013 |
Arman Uguray <armansito@chromium.org> |
pseudomodem: Implemented an interactive shell.
PseudoModemManager can now be launch in an interactive mode via command
line. It features a set of commands that interact directly with the
PseudoModemManager through the new org.chromium.Pseudomodem.Testing
interface.
BUG=chromium:220643
TEST=Run pseudomodem.py -f 3GPP -i. You should get a command prompt.
Play with 'help', 'properties', etc. 'exit' when done.
Change-Id: Ie07f2c34b5fe7424dd28cae6bc34f203de43b7ab
Reviewed-on: https://gerrit.chromium.org/gerrit/64750
Commit-Queue: Arman Uguray <armansito@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
/external/autotest/client/cros/cellular/pseudomodem/client.py
|