| 92d8f3ca1dc7757f9234605a129399d5ebd0e539 |
|
14-Jun-2016 |
Tom Wai-Hong Tam <waihong@chromium.org> |
Chameleon: Increase the tolerance of considering good pixels
Change the constant _PIXEL_DIFF_MARGIN_FOR_DIGITAL to 3, meaning
that value +/-3 is acceptable.
BUG=chromium:618115
TEST=Ran the display_Resolution test.
Change-Id: I0afac6160c4b78388136c7773d842e77cc2e0514
Reviewed-on: https://chromium-review.googlesource.com/352642
Commit-Ready: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@google.com>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
/external/autotest/client/cros/chameleon/screen_utility_factory.py
|
| 5d6f1cd83db3c7871026254184b9d4ae531cd4e2 |
|
04-Dec-2014 |
Tom Wai-Hong Tam <waihong@chromium.org> |
Chameleon: Increase the margin of pixel-diff for digital interfaces to 2
We saw some devices get a small amount of pixels with pixel-diff=2. As it
is a minor issue that an user does not notice, increasing the margin to
2 reduces some random failures.
BUG=chromium:438007
TEST=None, trivial change.
Change-Id: I6d20bba46f3b64e7d0812cda56bd3afd359762ab
Reviewed-on: https://chromium-review.googlesource.com/233346
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
Commit-Queue: Wai-Hong Tam <waihong@chromium.org>
/external/autotest/client/cros/chameleon/screen_utility_factory.py
|
| bf17c0772b26a6fa37b1fda40cd4a18b73f0d5b3 |
|
02-Dec-2014 |
Tom Wai-Hong Tam <waihong@chromium.org> |
Chameleon: Use the connector of Chameleon to check VGA or not
The original code used the connector of CrOS to check. It does not work
if the connector is unplugged during the check. So change to use the
connector of Chameleon.
BUG=chromium:429862
TEST=Ran a Chameleon test passed.
Change-Id: I5be81150904ad55c887ce03e6e10143ee8cf4760
Reviewed-on: https://chromium-review.googlesource.com/232534
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: Hung-ying Tyan <tyanh@chromium.org>
Commit-Queue: Wai-Hong Tam <waihong@chromium.org>
/external/autotest/client/cros/chameleon/screen_utility_factory.py
|
| 5e1bfb03b52c450d64af06c0f1b2fd83c214826a |
|
13-Nov-2014 |
Tom Wai-Hong Tam <waihong@chromium.org> |
Chameleon: Abstract the screen comparison logic to the ScreenComparer class
This change abstracts the screen comparison logic to a new class, i.e.
ScreenComparer. It is created via the ScreenUtilityFactory, depending on
the connected interface is VGA or not. Proper configurations, like
pixel_diff_margin and wrong_pixels_margin, are preset.
It also abstracts the mirror comparison logic which checks all screens
on CrOS identical or not.
BUG=chromium:429931
TEST=Tested on Peppy by running Chameleon tests. Tests passed.
TEST=Tested on Parrot by running Chameleon tests. Tests passed.
Change-Id: I3c43269a517e3afd1e78f6a314fc33d9ddda9a6f
Reviewed-on: https://chromium-review.googlesource.com/229669
Reviewed-by: Hung-ying Tyan <tyanh@chromium.org>
Commit-Queue: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
/external/autotest/client/cros/chameleon/screen_utility_factory.py
|
| 45e1947cf4a46ec3c4a8a85cf644b326a7afb8bb |
|
13-Nov-2014 |
Tom Wai-Hong Tam <waihong@chromium.org> |
Chameleon: Construct ScreenCapturer classes
Serveral ScreenCapturer classes are created for capturing screens on
Chameleon, DUT external, and DUT internal. A differnet capturer is
returned if found a VGA port.
BUG=chromium:429931
TEST=Tested on Peppy by running Chameleon tests. Tests passed.
TEST=Tested on Parrot by running Chameleon tests. The size
of captured image matches with the DUT one.
Change-Id: I4ac5b0a43a74fc1f53776f5fef54347c17a79396
Reviewed-on: https://chromium-review.googlesource.com/229666
Reviewed-by: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Commit-Queue: Wai-Hong Tam <waihong@chromium.org>
/external/autotest/client/cros/chameleon/screen_utility_factory.py
|
| a435cc0a9e2feea72edb87d84dfd6ac944aef39b |
|
13-Nov-2014 |
Tom Wai-Hong Tam <waihong@chromium.org> |
Chameleon: Add construction of resolution comparer, for supporting VGA
This change supports VGA specific resolution comparison, while slimming
the ChameleonTest class.
It introduces a ScreenUtilityFactory which creates utilities according
to the properties of the CrOS. The VgaResolutionComparer is generated, in
additional to the original ExactMatchResolutionComparer, for checking
the VGA resolution. It accepts the size of the capturing image is larger
or equal to the expected size as this is a VGA behavior.
It also changes the tests not to use the resolution from Chameleon, as
it is not the true resolution on VGA interface.
BUG=chromium:429931
TEST=Tested on Peppy by running the modified tests. Tests passed.
TEST=Tested on Parrot by running the modified tests. The resolution
comparisons passed.
Change-Id: I6ebea41b239755aa9f4a2201e583749d3dc21abe
Reviewed-on: https://chromium-review.googlesource.com/229440
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@chromium.org>
Commit-Queue: Wai-Hong Tam <waihong@chromium.org>
/external/autotest/client/cros/chameleon/screen_utility_factory.py
|