33d2055e594177b27360f84e0631b26d74a55a9b |
|
22-Mar-2017 |
Mike Klein <mtklein@chromium.org> |
GM: some header cleanup gm.h includes sk_tool_utils.h but does not use it. The bulk of this CL makes each gm that uses sk_tool_utils include it. sk_tool_utils.h also provided SkRandom and SkTDArray, so a couple GMs add those headers too. Change-Id: Ieb2a7c542f0ca89c3223f744fc11b0ff37af36c1 Reviewed-on: https://skia-review.googlesource.com/10014 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
/external/skia/gm/lightingshader.cpp
|
dbfd7ab10883f173f5c1b653a233e18dc6142002 |
|
01-Sep-2016 |
mtklein <mtklein@chromium.org> |
Replace a lot of 'static const' with 'constexpr' or 'const'. 'static const' means, there must be at most one of these, and initialize it at compile time if possible or runtime if necessary. This leads to unexpected code execution, and TSAN* will complain about races on the guard variables. Generally 'constexpr' or 'const' are better choices. Neither can cause races: they're either intialized at compile time (constexpr) or intialized each time independently (const). This CL prefers constexpr where possible, and uses const where not. It even prefers constexpr over const where they don't make a difference... I want to have lots of examples of constexpr for people to see and mimic. The scoped-to-class static has nothing to do with any of this, and is not changed. * Not yet on the bots, which use an older TSAN. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300623005 Review-Url: https://codereview.chromium.org/2300623005
/external/skia/gm/lightingshader.cpp
|
a8eabc4a2a5559a1410fdbb348f967cd1554b325 |
|
29-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Moved ambient lights out of SkLight's light array BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287553002 Committed: https://skia.googlesource.com/skia/+/8f98f0aa2d3f7571a890b916c7c4b5ee831e9686 Review-Url: https://codereview.chromium.org/2287553002
/external/skia/gm/lightingshader.cpp
|
84cddf6fa7a2ee4a8163f99c9238d5fba6b49566 |
|
29-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Revert of Moved ambient lights out of SkLight's light array (patchset #7 id:120001 of https://codereview.chromium.org/2287553002/ ) Reason for revert: Made Deigo's GM miss their ambient lights Original issue's description: > Moved ambient lights out of SkLight's light array > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287553002 > > Committed: https://skia.googlesource.com/skia/+/8f98f0aa2d3f7571a890b916c7c4b5ee831e9686 TBR=robertphillips@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2291663002
/external/skia/gm/lightingshader.cpp
|
8f98f0aa2d3f7571a890b916c7c4b5ee831e9686 |
|
29-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Moved ambient lights out of SkLight's light array BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287553002 Review-Url: https://codereview.chromium.org/2287553002
/external/skia/gm/lightingshader.cpp
|
772b5ee446d7545eec4ca7d6dc9d75461e2a9c38 |
|
12-Aug-2016 |
vjiaoblack <vjiaoblack@google.com> |
Added PointLights to SkLights::Light BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237493002 Review-Url: https://codereview.chromium.org/2237493002
/external/skia/gm/lightingshader.cpp
|
1ec04d9553af68b458c8dd6bd18d8c25ebd41d7a |
|
05-Aug-2016 |
reed <reed@google.com> |
rename FoceCopyMode to SkCopyPixelMode BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2220603002 Review-Url: https://codereview.chromium.org/2220603002
/external/skia/gm/lightingshader.cpp
|
6af677ff8f549751352847ceefda4538236c8a20 |
|
11-Jul-2016 |
dvonbeck <dvonbeck@google.com> |
Changed SkLightingShader API to take in a shader as color source This CL's base is the CL for the same modification, but in the implementation side: https://codereview.chromium.org/2062703003/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2064153002 Review-Url: https://codereview.chromium.org/2064153002
/external/skia/gm/lightingshader.cpp
|
5b794fad18344e8dbb840be49d1bc66ebe754b31 |
|
06-Jul-2016 |
dvonbeck <dvonbeck@google.com> |
API change to allow for NormalSource selection at the user level. This CL's base is the CL for CPU handling: https://codereview.chromium.org/2050773002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2063793002 Review-Url: https://codereview.chromium.org/2063793002
/external/skia/gm/lightingshader.cpp
|
71e055279336096f92d63c5c855641b4b31d6a54 |
|
31-May-2016 |
robertphillips <robertphillips@google.com> |
Make use of new SkLights class GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2026763002 Review-Url: https://codereview.chromium.org/2026763002
/external/skia/gm/lightingshader.cpp
|
9d524f22bfde5dc3dc8f48e1be39bdebd3bb0304 |
|
29-Mar-2016 |
halcanary <halcanary@google.com> |
Style bikeshed - remove extraneous whitespace GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002 Review URL: https://codereview.chromium.org/1842753002
/external/skia/gm/lightingshader.cpp
|
fe63045f075165b1be5d3e7fc5c710021d85f53b |
|
25-Mar-2016 |
reed <reed@google.com> |
move setshader to sk_sp, re-using SK_SUPPORT_LEGACY_CREATESHADER_PTR BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1829303002 Review URL: https://codereview.chromium.org/1829303002
/external/skia/gm/lightingshader.cpp
|
943a462fef57832e2683894bb9f2f36ac25d98f7 |
|
03-Sep-2015 |
robertphillips <robertphillips@google.com> |
Minor code cleanup (left over from prior CL) This was requested in https://codereview.chromium.org/1309543012/ (Add new GM to directly exercise perspective bitmap drawing) Review URL: https://codereview.chromium.org/1320673011
/external/skia/gm/lightingshader.cpp
|
385fe4d4b62d7d1dd76116dd570df3290a2f487b |
|
26-Aug-2015 |
halcanary <halcanary@google.com> |
Style Change: SkNEW->new; SkDELETE->delete DOCS_PREVIEW= https://skia.org/?cl=1316123003 Review URL: https://codereview.chromium.org/1316123003
/external/skia/gm/lightingshader.cpp
|
2f0dbc761a626473c19db7de561c7072b12953c5 |
|
20-Aug-2015 |
robertphillips <robertphillips@google.com> |
Update SkLightingShader to support rotation This also: makes the SkLightingShader handle normal maps where the rects aren't aligned between the diffuse and normal maps. adds a light aggregating class (Lights) to SkLightingShader (along with a Builder nested class). Split out of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call) Committed: https://skia.googlesource.com/skia/+/45b59ed6e4e231814dbdb9f707b3d2a7ee50de84 Review URL: https://codereview.chromium.org/1291783003
/external/skia/gm/lightingshader.cpp
|
f7d602a458f156723ec1a086f0fd132b1a9cc0e8 |
|
19-Aug-2015 |
robertphillips <robertphillips@google.com> |
Revert "Update SkLightingShader to support rotation" This reverts commit 45b59ed6e4e231814dbdb9f707b3d2a7ee50de84. TBR=herb@google.com Review URL: https://codereview.chromium.org/1304673002
/external/skia/gm/lightingshader.cpp
|
45b59ed6e4e231814dbdb9f707b3d2a7ee50de84 |
|
19-Aug-2015 |
robertphillips <robertphillips@google.com> |
Update SkLightingShader to support rotation This also: makes the SkLightingShader handle normal maps where the rects aren't aligned between the diffuse and normal maps. adds a light aggregating class (Lights) to SkLightingShader (along with a Builder nested class). Split out of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call) Review URL: https://codereview.chromium.org/1291783003
/external/skia/gm/lightingshader.cpp
|
ea4529d09a6ad50582e348eee1c275a9ffb59278 |
|
18-Aug-2015 |
robertphillips <robertphillips@google.com> |
Move normal map creation methods to sk_tools Split off of https://codereview.chromium.org/1261433009/ (Add SkCanvas::drawLitAtlas call) Review URL: https://codereview.chromium.org/1298763002
/external/skia/gm/lightingshader.cpp
|
ebc1c10fe1befb4f8025e825d3fb6012c145c593 |
|
07-Aug-2015 |
bsalomon <bsalomon@google.com> |
Fix warnings on VS2015 x86_64 build TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1276133002
/external/skia/gm/lightingshader.cpp
|
a9652ac09ee45b964e0d906887e1521ee328cb6a |
|
31-Jul-2015 |
robertphillips <robertphillips@google.com> |
Address some SkLightingShader TODOs This CL: switches the light colors to be 3 scalars (SkColor3f) adds some dox Review URL: https://codereview.chromium.org/1265983003
/external/skia/gm/lightingshader.cpp
|
640898f5881df1fd56d306190608dd79b1f32044 |
|
30-Jul-2015 |
robertphillips <robertphillips@google.com> |
Update SkLightingShader to take a localMatrix W/o this we can't draw lit objects anywhere but the origin. Review URL: https://codereview.chromium.org/1253223003
/external/skia/gm/lightingshader.cpp
|
5f865b9cf11ac16e41f10d78276d6b8cf68762de |
|
29-Jul-2015 |
robertphillips <robertphillips@google.com> |
Move LightingShader to effects Additionally this CL: forces the light colors to be opaque forces the light direction to be normalized adds a raster implementation adds a gm Review URL: https://codereview.chromium.org/1245883003
/external/skia/gm/lightingshader.cpp
|